cattri 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f432670c63ac3fc653b105988804c219c7f73e0023c7fc1e11b2f56a16a9ac66
-  data.tar.gz: 4302d8ffafd8c3f0e321aea61ec5c06e42ec7c5178130768c967b25ed0bcdf43
+  metadata.gz: ba04c1c408b5ffe93591ba80633bc3b7d7950d0e651e4adf738e30fe4ba795ea
+  data.tar.gz: a4d5f788238eee82419df14b8977b018ed8b7d91169f7719171186c26e9dde7d
 SHA512:
-  metadata.gz: '08c0a0719c6699e42a40c92081700a0466ae78f3eda2ff08e34c75f76006c9a9bf915b65235893ee72ff28a0402c553b2dbca4ea596591a33cf1acd28a6fa975'
-  data.tar.gz: 99c6caeb8fd09b5c0a3de773efec82f0f63648d73ba1f2e7597351a17bea6450b7b05ec8ca952cf0f2e0e9abc7a974738807d4b67048b8ae5190cc85ef043427
+  metadata.gz: 1a923822a64d948f87bc16c14511ab2b9a6d278f3b3a9264ee4ab57515644f3f42dedaee7db4bd3b6d5a7d294daf866a00dd99b0d4d72b29faade58f6facc0e2
+  data.tar.gz: 26cc1589b802f4916b55b43312d567e7e68138a83e16780c6c5a49405b16e45a6325bfd5d5e39b7b80bbe5bdf53bbadd84b606765c156cf53183be6a49e251f9

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [0.2.3] - 2025-12-14
+
+### Added
+- New specs covering write-only exposure visibility for both instance and class attributes, ensuring readers are properly private/protected while writers remain public.
+- Strengthened Context storage resolution tests to assert descriptive errors when instance receivers are missing.
+
 ## [0.2.2] - 2025-05-04
 
 No breaking changes – the public DSL (cattri, final_cattri) remains identical to v0.2.0.

data/lib/cattri/attribute.rb

@@ -105,7 +105,7 @@ module Cattri
     def readonly?
       return false if @options.expose == :none
 
-      @options.expose == :read || final?
+      @options.expose == :read
     end
 
     # @return [Boolean] whether the attribute is marked final (write-once)

data/lib/cattri/attribute_compiler.rb

@@ -33,7 +33,7 @@ module Cattri
         return if attribute.expose == :none
 
         define_accessor!(attribute, context)
-        define_writer!(attribute, context)
+        define_writer!(attribute, context) if attribute.writable?
         define_predicate!(attribute, context) if attribute.with_predicate?
       end
 

data/lib/cattri/attribute_options.rb

@@ -20,25 +20,29 @@ module Cattri
       # Validates and normalizes the `expose` configuration.
       #
       # @param expose [Symbol, String] one of: :read, :write, :read_write, :none
+      # @param attribute_name [Symbol, nil] optional attribute name for error context
       # @return [Symbol]
       # @raise [Cattri::AttributeError] if the value is invalid
-      def validate_expose!(expose)
+      def validate_expose!(expose, attribute_name: nil)
         expose = expose.to_sym
         return expose if EXPOSE_OPTIONS.include?(expose) # steep:ignore
 
-        raise Cattri::AttributeError, "Invalid expose option `#{expose.inspect}` for :#{name}"
+        detail = attribute_name ? " for :#{attribute_name}" : ""
+        raise Cattri::AttributeError, "Invalid expose option `#{expose.inspect}`#{detail}"
       end
 
       # Validates and normalizes method visibility.
       #
       # @param visibility [Symbol, String] one of: :public, :protected, :private
+      # @param attribute_name [Symbol, nil] optional attribute name for error context
       # @return [Symbol]
       # @raise [Cattri::AttributeError] if the value is invalid
-      def validate_visibility!(visibility)
+      def validate_visibility!(visibility, attribute_name: nil)
         visibility = visibility.to_sym
         return visibility if VISIBILITIES.include?(visibility) # steep:ignore
 
-        raise Cattri::AttributeError, "Invalid visibility `#{visibility.inspect}` for :#{name}"
+        detail = attribute_name ? " for :#{attribute_name}" : ""
+        raise Cattri::AttributeError, "Invalid visibility `#{visibility.inspect}`#{detail}"
       end
     end
 
@@ -88,8 +92,8 @@ module Cattri
       @predicate = predicate
       @default = normalize_default(default)
       @transformer = normalize_transformer(transformer)
-      @expose = self.class.validate_expose!(expose)
-      @visibility = self.class.validate_visibility!(visibility)
+      @expose = self.class.validate_expose!(expose, attribute_name: @name)
+      @visibility = self.class.validate_visibility!(visibility, attribute_name: @name)
 
       freeze
     end

data/lib/cattri/introspection.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "set"
+
 module Cattri
   # Provides a read-only interface for inspecting attributes defined via the Cattri DSL.
   #
@@ -62,7 +64,9 @@ module Cattri
       #
       # @return [Hash{Symbol => Set<Symbol>}]
       def attribute_methods
-        context.defined_methods # steep:ignore
+        attribute_registry.defined_attributes(with_ancestors: true).transform_values do |attribute| # steep:ignore
+          Set.new(attribute.allowed_methods)
+        end
       end
 
       # Returns the original class or module where the given attribute was defined.

data/lib/cattri/version.rb

@@ -2,6 +2,6 @@
 
 module Cattri
   # :nocov:
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
   # :nocov:
 end

data/sig/lib/cattri/attribute_options.rbs

@@ -35,14 +35,14 @@ module Cattri
     # @param expose [Symbol, String] one of: :read, :write, :read_write, :none
     # @return [Symbol]
     # @raise [Cattri::AttributeError] if the value is invalid
-    def self.validate_expose!: (expose_types | identifier expose) -> untyped
+    def self.validate_expose!: (expose_types | identifier expose, ?attribute_name: ::Symbol?) -> untyped
 
     # Validates and normalizes method visibility.
     #
     # @param visibility [Symbol, String] one of: :public, :protected, :private
     # @return [Symbol]
     # @raise [Cattri::AttributeError] if the value is invalid
-    def self.validate_visibility!: (visibility_types | identifier visibility) -> untyped
+    def self.validate_visibility!: (visibility_types | identifier visibility, ?attribute_name: ::Symbol?) -> untyped
 
     # Valid method visibility levels.
     VISIBILITIES: ::Array[visibility_types]

data/spec/cattri/attribute_compiler_spec.rb

@@ -67,6 +67,26 @@ RSpec.describe Cattri::AttributeCompiler do
         expect(instance.enabled?).to eq(true)
       end
     end
+
+    context "when expose is :read" do
+      let(:attribute) do
+        Cattri::Attribute.new(
+          :visible,
+          defined_in: dummy_class,
+          default: -> { "shown" },
+          expose: :read
+        )
+      end
+
+      it "does not define a writer" do
+        described_class.define_accessor(attribute, context)
+        instance = dummy_class.new
+
+        expect(instance.visible).to eq("shown")
+        expect(instance.respond_to?(:visible=)).to be(false)
+        expect(instance.respond_to?(:visible=, true)).to be(false)
+      end
+    end
   end
 
   describe ".define_accessor!" do

data/spec/cattri/attribute_options_spec.rb

@@ -144,6 +144,18 @@ RSpec.describe Cattri::AttributeOptions do
         expect(instance.instance_variable_get(:@visibility)).to eq(:private)
       end
     end
+
+    it "raises a helpful error when expose is invalid" do
+      expect do
+        described_class.new(name, expose: :bogus)
+      end.to raise_error(Cattri::AttributeError, /:bogus.*for :my_attribute/)
+    end
+
+    it "raises a helpful error when visibility is invalid" do
+      expect do
+        described_class.new(name, visibility: :bogus)
+      end.to raise_error(Cattri::AttributeError, /:bogus.*for :my_attribute/)
+    end
   end
 
   describe "#[]" do

data/spec/cattri/attribute_spec.rb

@@ -112,8 +112,8 @@ RSpec.describe Cattri::Attribute do
   describe "#writable?" do
     [
       [true, :read, false],
-      [true, :write, false],
-      [true, :read_write, false],
+      [true, :write, true],
+      [true, :read_write, true],
       [true, :none, false],
       [false, :read, false],
       [false, :write, true],
@@ -134,8 +134,8 @@ RSpec.describe Cattri::Attribute do
   describe "#readonly?" do
     [
       [true, :read, true],
-      [true, :write, true],
-      [true, :read_write, true],
+      [true, :write, false],
+      [true, :read_write, false],
       [true, :none, false],
       [false, :read, true],
       [false, :write, false],

data/spec/cattri/context_registry_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Cattri::ContextRegistry do
   let(:klass) do
     Class.new do
       include Cattri::ContextRegistry
+
       public :context, :attribute_registry
     end
   end

data/spec/cattri/context_spec.rb

@@ -231,9 +231,10 @@ RSpec.describe Cattri::Context do
     end
 
     context "when a received cannot be resolved" do
-      it "raises an error" do
+      it "raises a descriptive Cattri::Error" do
         expect { context.storage_receiver_for(instance_attribute, nil) }
-          .to raise_error
+          .to raise_error(Cattri::Error,
+                          /Missing runtime instance for instance-level attribute :#{instance_attribute.name}/)
       end
     end
   end

data/spec/cattri/introspection_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Cattri::Introspection do
   let(:klass) do
     Class.new do
       include Cattri
+
       cattri :foo, 123
     end
   end
@@ -13,6 +14,7 @@ RSpec.describe Cattri::Introspection do
   let(:subclass) do
     Class.new(klass) do
       include Cattri::Introspection
+
       cattri :bar, "bar"
     end
   end
@@ -75,6 +77,12 @@ RSpec.describe Cattri::Introspection do
       expect(methods.keys).to include(:bar)
       expect(methods[:bar]).to include(:bar)
     end
+
+    it "includes methods for inherited attributes" do
+      methods = subclass.attribute_methods
+      expect(methods.keys).to include(:foo)
+      expect(methods[:foo]).to include(:foo)
+    end
   end
 
   describe ".attribute_source" do

data/spec/cattri_spec.rb

@@ -35,6 +35,7 @@ RSpec.describe Cattri do
     let(:introspective_class) do
       Class.new do
         include Cattri
+
         cattri :id, "foo"
 
         with_cattri_introspection
@@ -56,6 +57,7 @@ RSpec.describe Cattri do
     it "allows one-time assignment to final instance attribute" do
       klass = Class.new do
         include Cattri
+
         cattri :value, final: true
 
         def initialize(value)
@@ -72,6 +74,7 @@ RSpec.describe Cattri do
     it "prevents any assignment to final class attribute" do
       klass = Class.new do
         include Cattri
+
         cattri :value, -> { "init" }, final: true, scope: :class
       end
 
@@ -82,11 +85,13 @@ RSpec.describe Cattri do
     it "allows shadowing parent class attributes" do
       parent = Class.new do
         include Cattri
+
         cattri :enabled, true, final: true, scope: :class
       end
 
       child = Class.new do
         include Cattri
+
         cattri :enabled, false, final: true, scope: :class
       end
 
@@ -97,6 +102,7 @@ RSpec.describe Cattri do
     it "defines predicate method for instance attribute" do
       klass = Class.new do
         include Cattri
+
         cattri :flag, false, predicate: true
       end
 
@@ -110,6 +116,7 @@ RSpec.describe Cattri do
     it "evaluates and stores default value lazily" do
       klass = Class.new do
         include Cattri
+
         cattri :computed, -> { "value" }
       end
 
@@ -123,6 +130,7 @@ RSpec.describe Cattri do
     it "isolates instance and class attributes correctly" do
       klass = Class.new do
         include Cattri
+
         cattri :config, scope: :class
         cattri :state, scope: :instance
       end
@@ -142,6 +150,7 @@ RSpec.describe Cattri do
       mod = Module.new do
         class << self
           include Cattri
+
           cattri :version, "0.1.0", final: true, scope: :class
         end
       end
@@ -152,6 +161,7 @@ RSpec.describe Cattri do
     it "isolates class attributes across subclasses" do
       parent = Class.new do
         include Cattri
+
         cattri :level, "parent", scope: :class
       end
 
@@ -167,6 +177,7 @@ RSpec.describe Cattri do
     it "applies custom coercion via block during assignment" do
       klass = Class.new do
         include Cattri
+
         cattri :age do |value|
           Integer(value)
         end
@@ -181,6 +192,7 @@ RSpec.describe Cattri do
     it "allows inherited initialize to set final attribute once" do
       base = Class.new do
         include Cattri
+
         cattri :token, final: true
 
         def initialize(token)
@@ -195,4 +207,35 @@ RSpec.describe Cattri do
       expect { obj.token = "fail" }.to raise_error(Cattri::AttributeError)
     end
   end
+
+  describe "visibility with write-only exposure" do
+    let(:klass) do
+      Class.new do
+        include Cattri
+
+        cattri :token, expose: :write
+        cattri :level, :low, expose: :write, scope: :class
+      end
+    end
+
+    it "keeps the reader private while writer stays public on instances" do
+      instance = klass.new
+
+      expect(klass.public_instance_methods(false)).to include(:token=)
+      expect(klass.private_instance_methods(false)).to include(:token)
+      expect { instance.token }.to raise_error(NoMethodError)
+
+      instance.token = "set"
+      expect(instance.send(:token)).to eq("set")
+    end
+
+    it "marks class-level readers as protected while keeping the writer public" do
+      expect(klass.singleton_class.public_instance_methods(false)).to include(:level=)
+      expect(klass.singleton_class.protected_instance_methods(false)).to include(:level)
+      expect { klass.level }.to raise_error(NoMethodError)
+
+      klass.level = :high
+      expect(klass.send(:level)).to eq(:high)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cattri
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Nathan Lucas
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-05-04 00:00:00.000000000 Z
+date: 2025-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: debride