cats_core 1.5.18 → 1.5.21

data/app/models/cats/core/location.rb

@@ -54,8 +54,8 @@ module Cats
         Store.find_by(code: "FDP-ST-#{code}")
       end
 
-      def self.ransackable_attributes(auth_object = nil)
-        ["code", "location_type", "name"]
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[code location_type name]
       end
     end
   end

data/app/models/cats/core/receipt_authorization.rb

@@ -15,8 +15,8 @@ module Cats
         ValidationUtil.validate_quantity(self, "dispatch", authorizations, "dispatch")
       end
 
-      def self.ransackable_attributes(auth_object = nil)
-        ["authorized_by_id", "dispatch_id", "received_quantity", "quantity", "status", "store_id", "unit_id"]
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[authorized_by_id dispatch_id received_quantity quantity status store_id unit_id]
       end
     end
   end

data/app/models/cats/core/receipt_transaction.rb

@@ -46,8 +46,8 @@ module Cats
         end
       end
 
-      def self.ransackable_attributes(auth_object = nil)
-        ["destination_id", "quantity", "receipt_authorization_id", "receipt_number", "status", "transaction_date", "unit_id"]
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[destination_id quantity receipt_authorization_id receipt_number status transaction_date unit_id]
       end
     end
   end

data/app/models/cats/core/round_beneficiary.rb

@@ -12,12 +12,12 @@ module Cats
       delegate(:name, to: :commodity_category, prefix: true)
       delegate(:abbreviation, to: :unit, prefix: true)
 
-      def self.ransackable_attributes(auth_object = nil)
-        ["beneficiary_id", "commodity_category_id", "quantity", "received", "round_plan_item_id", "unit_id"]
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[beneficiary_id commodity_category_id quantity received round_plan_item_id unit_id]
       end
 
-      def self.ransackable_associations(auth_object = nil)
-        ["beneficiary", "commodity_category", "round_plan_item", "unit"]
+      def self.ransackable_associations(_auth_object = nil)
+        %w[beneficiary commodity_category round_plan_item unit]
       end
     end
   end

data/app/models/cats/core/round_plan.rb

@@ -72,8 +72,8 @@ module Cats
         errors.add(:region, "is not valid.") unless region.location_type == Location::REGION
       end
 
-      def self.ransackable_attributes(auth_object = nil)
-        ["plan_id", "reference_no", "region_id", "rounds", "status"]
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[plan_id reference_no region_id rounds status]
       end
     end
   end

data/app/models/cats/core/round_plan_item.rb

@@ -22,8 +22,8 @@ module Cats
       delegate(:name, to: :fdp, prefix: true)
       delegate(:name, to: :operator, prefix: true)
 
-      def self.ransackable_attributes(auth_object = nil)
-        ["fdp_id", "operator_id", "plan_item_id", "region_id", "round_plan_id", "woreda_id", "zone_id"]
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[fdp_id operator_id plan_item_id region_id round_plan_id woreda_id zone_id]
       end
     end
   end

data/app/models/cats/core/route.rb

@@ -44,8 +44,8 @@ module Cats
         errors.add(:base, "Source and destination cannot be the same") if source == destination
       end
 
-      def self.ransackable_attributes(auth_object = nil)
-        ["destination_id", "name", "region_id", "source_id"]
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[destination_id name region_id source_id]
       end
     end
   end

data/app/models/cats/core/stack.rb

@@ -15,16 +15,16 @@ module Cats
       has_many :receipt_transactions, foreign_key: :destination_id
 
       validates :code, :length, :width, :height, :start_x, :start_y, :commodity_status, :stack_status,
-        :quantity, presence: true
+                :quantity, presence: true
       validates :code, uniqueness: true
       validates :length, :width, :height, :start_x, :start_y, numericality: {greater_than: 0}
       validates :quantity, numericality: {greater_than_or_equal_to: 0}
       validates :commodity_status, inclusion: {in: Cats::Core::Commodity::COMMODITY_STATUSES}
       validates :stack_status, inclusion: {in: STACK_STATUSES}
       validate :validate_coordinates, :validate_dimensions, :validate_distance_from_wall, :validate_overlap,
-        :validate_space_between_stack, :validate_max_height, :validate_max_length, :validate_max_width,
-        :validate_distance_from_ceiling,
-        unless: -> { store && (store.code == "SUP-STORE" || store.code.start_with?("FDP-ST")) }
+               :validate_space_between_stack, :validate_max_height, :validate_max_length, :validate_max_width,
+               :validate_distance_from_ceiling,
+               unless: -> { store && (store.code == "SUP-STORE" || store.code.start_with?("FDP-ST")) }
 
       delegate :batch_no, to: :commodity, prefix: true
       delegate :abbreviation, to: :unit, prefix: true
@@ -66,9 +66,9 @@ module Cats
 
         rule = stacking_rules
         if start_x < rule.distance_from_wall || store.length - (start_x + length) < rule.distance_from_wall ||
-            store.width - (start_y + width) < rule.distance_from_wall || start_y < rule.distance_from_wall
+           store.width - (start_y + width) < rule.distance_from_wall || start_y < rule.distance_from_wall
           errors.add(:base,
-            message: "The stack must be placed #{rule.distance_from_wall} meter away from a store wall")
+                     message: "The stack must be placed #{rule.distance_from_wall} meter away from a store wall")
         end
       end
 
@@ -89,9 +89,9 @@ module Cats
         rule = stacking_rules
         new_stack = dup
         new_stack.assign_attributes(start_x: start_x - rule.space_between_stack,
-          start_y: start_y - rule.space_between_stack,
-          length: length + (2 * rule.space_between_stack),
-          width: width + (2 * rule.space_between_stack))
+                                    start_y: start_y - rule.space_between_stack,
+                                    length: length + (2 * rule.space_between_stack),
+                                    width: width + (2 * rule.space_between_stack))
         stacks.each do |s|
           errors.add(:base, message: "#{code} overlaps with #{s.code}") if overlaps?(new_stack, s)
         end
@@ -140,10 +140,10 @@ module Cats
         return unless length_previously_changed? || width_previously_changed? || stack_status_previously_changed?
 
         old_area = if length_previously_was.nil? && width_previously_was.nil?
-          0
-        else
-          length_previously_was * width_previously_was
-        end
+                     0
+                   else
+                     length_previously_was * width_previously_was
+                   end
 
         store.available_space += old_area
         store.available_space -= length * width unless stack_status == DESTROYED
@@ -171,27 +171,27 @@ module Cats
       end
 
       def destroy_stack
-        if stack_status == Cats::Core::Stack::RESERVED || quantity.zero?
-          self.stack_status = Cats::Core::Stack::DESTROYED
-          save!
-        else
+        unless stack_status == Cats::Core::Stack::RESERVED || quantity.zero?
           raise(StandardError, "Stack has to be either RESERVED or with zero quantity to be destroyed.")
         end
+
+        self.stack_status = Cats::Core::Stack::DESTROYED
+        save!
       end
 
-      def self.ransackable_attributes(auth_object = nil)
-        [
-          "commodity_id",
-          "commodity_status",
-          "height",
-          "length",
-          "quantity",
-          "stack_status",
-          "start_x",
-          "start_y",
-          "store_id",
-          "unit_id",
-          "width"
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[
+          commodity_id
+          commodity_status
+          height
+          length
+          quantity
+          stack_status
+          start_x
+          start_y
+          store_id
+          unit_id
+          width
         ]
       end
     end

data/app/models/cats/core/stacking_rule.rb

@@ -2,14 +2,14 @@ module Cats
   module Core
     class StackingRule < ApplicationRecord
       validates :distance_from_wall, :space_between_stack, :distance_from_ceiling, :maximum_height, :maximum_length,
-        :maximum_width, :distance_from_gangway, presence: true, numericality: {greater_than: 0}
+                :maximum_width, :distance_from_gangway, presence: true, numericality: {greater_than: 0}
       validate :validate_only_a_record_exist
 
       def validate_only_a_record_exist
         return unless StackingRule.count > 1
 
         errors.add(:base,
-          "There is already a stacking rule entry. A new rule can not be added")
+                   "There is already a stacking rule entry. A new rule can not be added")
       end
     end
   end

data/app/models/cats/core/store.rb

@@ -9,10 +9,10 @@ module Cats
       validates :length, :width, :height, numericality: {greater_than: 0}
       validates :gangway_length, :gangway_width, :gangway_corner_dist, presence: true, if: :has_gangway?
       validates :gangway_length,
-        :gangway_width,
-        :gangway_corner_dist,
-        numericality: {greater_than: 0},
-        allow_nil: true
+                :gangway_width,
+                :gangway_corner_dist,
+                numericality: {greater_than: 0},
+                allow_nil: true
       validate :validate_location
 
       before_create :update_usable_space
@@ -29,26 +29,26 @@ module Cats
         self.available_space = self.usable_space
       end
 
-      def self.ransackable_attributes(auth_object = nil)
-        [
-          "available_space",
-          "code",
-          "gangway_corner_dist",
-          "gangway_length",
-          "gangway_width",
-          "has_gangway",
-          "height",
-          "length",
-          "name",
-          "temporary",
-          "usable_space",
-          "warehouse_id",
-          "width"
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[
+          available_space
+          code
+          gangway_corner_dist
+          gangway_length
+          gangway_width
+          has_gangway
+          height
+          length
+          name
+          temporary
+          usable_space
+          warehouse_id
+          width
         ]
       end
 
-      def self.ransackable_associations(auth_object = nil)
-        ["stacks", "warehouse"]
+      def self.ransackable_associations(_auth_object = nil)
+        %w[stacks warehouse]
       end
     end
   end

data/app/models/cats/core/transporter.rb

@@ -4,8 +4,8 @@ module Cats
       validates :code, :name, :address, :contact_phone, presence: true
       validates :code, uniqueness: true
 
-      def self.ransackable_attributes(auth_object = nil)
-        ["address", "code", "contact_phone", "name"]
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[address code contact_phone name]
       end
     end
   end

data/app/models/cats/core/unit_conversion.rb

@@ -19,9 +19,7 @@ module Cats
 
         # Check if there is reverse conversion entry defined
         conversion = find_by(from: to, to: from)
-        unless conversion
-          raise(StandardError, "Conversion factor between #{from.abbreviation} and #{to.abbreviation} not found.")
-        end
+        raise(StandardError, "Conversion factor between #{from.abbreviation} and #{to.abbreviation} not found.") unless conversion
 
         (value / conversion.factor).round(2)
       end

data/app/serializers/cats/core/cash_donation_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class CashDonationSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :description, :donated_on, :donor_id, :donor_name, :amount, :currency_id,
-        :currency_code
+                 :currency_code
     end
   end
 end

data/app/serializers/cats/core/commodity_donation_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class CommodityDonationSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :donated_on, :donor_id, :donor_name, :plan_id, :plan_reference_no,
-        :quantity, :unit_id, :unit_abbreviation, :description, :commodity_category_id,
-        :commodity_category_name, :shipping_reference
+                 :quantity, :unit_id, :unit_abbreviation, :description, :commodity_category_id,
+                 :commodity_category_name, :shipping_reference
     end
   end
 end

data/app/serializers/cats/core/commodity_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class CommoditySerializer < ActiveModel::Serializer
       attributes :id, :name, :batch_no, :description, :unit_of_measure_id, :unit_abbreviation, :project_id,
-        :project_code, :quantity, :best_use_before, :volume_per_metric_ton, :arrival_status, :status,
-        :shipping_reference, :commodity_grade, :package_unit_id, :package_unit_abbreviation
+                 :project_code, :quantity, :best_use_before, :volume_per_metric_ton, :arrival_status, :status,
+                 :shipping_reference, :commodity_grade, :package_unit_id, :package_unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/dispatch_authorization_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class DispatchAuthorizationSerializer < ActiveModel::Serializer
       attributes :id, :dispatch_id, :dispatch_reference_no, :store_id, :store_name, :quantity, :authorized_by_id,
-        :authorizer_full_name, :dispatch_status, :plate_no, :driver_name, :status, :unit_id,
-        :unit_abbreviation
+                 :authorizer_full_name, :dispatch_status, :plate_no, :driver_name, :status, :unit_id,
+                 :unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/dispatch_plan_item_serializer.rb

@@ -2,9 +2,9 @@ module Cats
   module Core
     class DispatchPlanItemSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :dispatch_plan_id, :plan_reference_no, :source_id, :source_name, :destination_id,
-        :destination_name, :quantity, :source_location_type, :destination_location_type, :commodity_status,
-        :status, :commodity_id, :commodity_name, :commodity_batch_no, :unit_abbreviation,
-        :commodity_shipping_reference, :unit_id
+                 :destination_name, :quantity, :source_location_type, :destination_location_type, :commodity_status,
+                 :status, :commodity_id, :commodity_name, :commodity_batch_no, :unit_abbreviation,
+                 :commodity_shipping_reference, :unit_id
     end
   end
 end

data/app/serializers/cats/core/dispatch_plan_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class DispatchPlanSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :status, :dispatchable_id, :dispatchable_type, :request_reference,
-        :request_quantity, :upstream
+                 :request_quantity, :upstream
     end
   end
 end

data/app/serializers/cats/core/dispatch_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class DispatchSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :dispatch_plan_item_id, :transporter_id, :transporter_name, :plate_no,
-        :driver_name, :driver_phone, :quantity, :remark, :prepared_by_id, :prepared_by_email,
-        :dispatch_status, :destination, :auth_details, :unit_id, :unit_abbreviation, :commodity_status
+                 :driver_name, :driver_phone, :quantity, :remark, :prepared_by_id, :prepared_by_email,
+                 :dispatch_status, :destination, :auth_details, :unit_id, :unit_abbreviation, :commodity_status
     end
   end
 end

data/app/serializers/cats/core/dispatch_transaction_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class DispatchTransactionSerializer < ActiveModel::Serializer
       attributes :id, :source_id, :source_code, :dispatch_authorization_id, :quantity, :transaction_date, :status,
-        :unit_id, :unit_abbreviation, :reference_no
+                 :unit_id, :unit_abbreviation, :reference_no
     end
   end
 end

data/app/serializers/cats/core/loan_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class LoanSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :lender, :agreement_date, :repayment_date, :commodity_category_id,
-        :commodity_category_name, :quantity, :unit_id, :unit_abbreviation
+                 :commodity_category_name, :quantity, :unit_id, :unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/purchase_order_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class PurchaseOrderSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :order_date, :requisition_no, :supplier, :cash_donation_id, :purchase_type,
-        :commodity_category_id, :commodity_category_name, :quantity, :unit_id, :unit_name, :currency_id,
-        :currency_code, :price
+                 :commodity_category_id, :commodity_category_name, :quantity, :unit_id, :unit_name, :currency_id,
+                 :currency_code, :price
     end
   end
 end

data/app/serializers/cats/core/receipt_authorization_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class ReceiptAuthorizationSerializer < ActiveModel::Serializer
       attributes :id, :dispatch_id, :dispatch_reference_no, :store_id, :store_name, :quantity, :received_quantity,
-        :remark, :status, :authorized_by_id, :authorizer_full_name, :auth_details, :plate_no, :driver_name,
-        :dispatch_status, :unit_id, :unit_abbreviation, :driver_confirmed
+                 :remark, :status, :authorized_by_id, :authorizer_full_name, :auth_details, :plate_no, :driver_name,
+                 :dispatch_status, :unit_id, :unit_abbreviation, :driver_confirmed
     end
   end
 end

data/app/serializers/cats/core/receipt_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class ReceiptSerializer < ActiveModel::Serializer
       attributes :id, :receipt_authorization_id, :commodity_status, :commodity_grade, :quantity, :remark,
-        :unit_id, :unit_abbreviation, :reference_no
+                 :unit_id, :unit_abbreviation, :reference_no
     end
   end
 end

data/app/serializers/cats/core/receipt_transaction_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class ReceiptTransactionSerializer < ActiveModel::Serializer
       attributes :id, :receipt_authorization_id, :receipt_number,
-        :dispatch_reference_no, :destination_id, :destination_code, :quantity,
-        :transaction_date, :status, :unit_id, :unit_abbreviation
+                 :dispatch_reference_no, :destination_id, :destination_code, :quantity,
+                 :transaction_date, :status, :unit_id, :unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/round_beneficiary_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class RoundBeneficiarySerializer < ActiveModel::Serializer
       attributes :id, :beneficiary_id, :beneficiary_full_name, :round_plan_item_id, :commodity_category_id,
-        :commodity_category_name, :quantity, :unit_id, :unit_abbreviation, :received
+                 :commodity_category_name, :quantity, :unit_id, :unit_abbreviation, :received
     end
   end
 end

data/app/serializers/cats/core/round_plan_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class RoundPlanSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :status, :plan_id, :plan_reference_no, :region_id, :region_name, :rounds,
-        :program_code
+                 :program_code
     end
   end
 end

data/app/serializers/cats/core/stack_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class StackSerializer < ActiveModel::Serializer
       attributes :id, :code, :length, :width, :height, :start_x, :start_y, :commodity_id, :store_id, :commodity_status,
-        :stack_status, :quantity, :commodity_batch_no, :unit_id, :unit_abbreviation
+                 :stack_status, :quantity, :commodity_batch_no, :unit_id, :unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/store_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class StoreSerializer < ActiveModel::Serializer
       attributes :id, :code, :name, :length, :width, :height, :temporary, :has_gangway, :gangway_length,
-        :gangway_width, :gangway_corner_dist, :warehouse_id
+                 :gangway_width, :gangway_corner_dist, :warehouse_id
 
       has_many :stacks
     end

data/app/serializers/cats/core/swap_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class SwapSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :swapper, :agreement_date, :issued_commodity_id, :issued_commodity_name,
-        :issued_quantity, :received_commodity_id, :received_commodity_name, :received_quantity,
-        :issued_unit_id, :issued_unit_abbreviation, :received_unit_id, :received_unit_abbreviation
+                 :issued_quantity, :received_commodity_id, :received_commodity_name, :received_quantity,
+                 :issued_unit_id, :issued_unit_abbreviation, :received_unit_id, :received_unit_abbreviation
     end
   end
 end

data/app/services/cats/core/authorization_service.rb

@@ -3,9 +3,7 @@ module Cats
     class AuthorizationService
       def driver_confirm(authorization_id, pin, receipt_number)
         authorization = ReceiptAuthorization.find(authorization_id)
-        if authorization.status == Authorization::AUTHORIZED
-          raise(StandardError, "Authorization not confirmed by storekeeper.")
-        end
+        raise(StandardError, "Authorization not confirmed by storekeeper.") if authorization.status == Authorization::AUTHORIZED
 
         raise(StandardError, "No pin has been generated for receipt.") if authorization.auth_details.nil?
 
@@ -65,14 +63,10 @@ module Cats
 
       def stack(authorization_id)
         authorization = ReceiptAuthorization.find(authorization_id)
-        unless authorization.dispatch.dispatch_status == Dispatch::RECEIVED
-          raise(StandardError, "Dispatch is not received.")
-        end
+        raise(StandardError, "Dispatch is not received.") unless authorization.dispatch.dispatch_status == Dispatch::RECEIVED
 
         total = authorization.transactions.sum(:quantity)
-        if total != authorization.received_quantity
-          raise(StandardError, "Received quantity is not the same as quantity to be stacked.")
-        end
+        raise(StandardError, "Received quantity is not the same as quantity to be stacked.") if total != authorization.received_quantity
 
         authorization.transactions.each(&:commit)
 

data/app/services/cats/core/beneficiary_service.rb

@@ -57,7 +57,7 @@ module Cats
         end
 
         beneficiaries = RoundBeneficiary.joins(:round_plan_item)
-          .where(round_plan_item: {round_plan_id: plan_id})
+                                        .where(round_plan_item: {round_plan_id: plan_id})
         to_delete = RoundBeneficiary.where(id: ids)
         diff = to_delete - beneficiaries
         raise(StandardError, "Round plan beneficiaries should be from the same plan.") if diff.count.positive?
@@ -76,7 +76,7 @@ module Cats
         end
 
         beneficiaries = RoundBeneficiary.joins(:round_plan_item)
-          .where(round_plan_item: {round_plan_id: plan_id})
+                                        .where(round_plan_item: {round_plan_id: plan_id})
         to_confirm = RoundBeneficiary.where(id: ids)
         diff = to_confirm - beneficiaries
         raise(StandardError, "Round plan beneficiaries should be from the same plan.") if diff.count.positive?

data/app/services/cats/core/dispatch_plan_service.rb

@@ -50,7 +50,7 @@ module Cats
           recipients = users.map do |user|
             details = user.details
             if (details.key?("warehouse") && details["warehouse"] == location_id) ||
-                (details.key?("hub") && details["hub"] == location_id)
+               (details.key?("hub") && details["hub"] == location_id)
               user
             end
           end.compact

data/app/services/cats/core/dispatch_service.rb

@@ -4,33 +4,31 @@ module Cats
       def search(user, status, authorized: false)
         details = user.details
 
-        unless details["stores"] || details["warehouse"] || details["hub"]
-          raise(StandardError, "User does not have associated location.")
-        end
+        raise(StandardError, "User does not have associated location.") unless details["stores"] || details["warehouse"] || details["hub"]
 
         # Get user's hub
         hub = if details["stores"]
-          Store.find(details["stores"][0]).warehouse.parent
-        elsif details["warehouse"]
-          Location.find(details["warehouse"]).parent
-        else
-          Location.find(details["hub"])
-        end
+                Store.find(details["stores"][0]).warehouse.parent
+              elsif details["warehouse"]
+                Location.find(details["warehouse"]).parent
+              else
+                Location.find(details["hub"])
+              end
 
         if authorized
           return Dispatch.joins(:dispatch_plan_item)
-              .includes({dispatch_plan_item: :destination}, :transporter, :prepared_by, :unit)
-              .where(
-                dispatch_plan_item: {destination: hub, status: DispatchPlanItem::AUTHORIZED},
-                dispatch_status: status
-              )
+                         .includes({dispatch_plan_item: :destination}, :transporter, :prepared_by, :unit)
+                         .where(
+                           dispatch_plan_item: {destination: hub, status: DispatchPlanItem::AUTHORIZED},
+                           dispatch_status: status
+                         )
         end
         Dispatch.joins(:dispatch_plan_item)
-          .includes({dispatch_plan_item: :destination}, :transporter, :prepared_by, :unit)
-          .where(
-            dispatch_plan_item: {destination: hub},
-            dispatch_status: status
-          )
+                .includes({dispatch_plan_item: :destination}, :transporter, :prepared_by, :unit)
+                .where(
+                  dispatch_plan_item: {destination: hub},
+                  dispatch_status: status
+                )
       end
 
       def start(dispatch)
@@ -77,7 +75,7 @@ module Cats
           details = user.details
 
           if (details.key?("warehouse") && hub.child_ids.include?(details["warehouse"])) ||
-              (details.key?("hub") && details["hub"] == location_id)
+             (details.key?("hub") && details["hub"] == location_id)
             user
           end
         end.compact

data/app/services/cats/core/notification_service.rb

@@ -34,7 +34,7 @@ module Cats
         roles = rule[:recipients]
 
         users = Cats::Core::User.joins(:application_module)
-          .where(application_module: {prefix: app_code}).with_all_roles(*roles)
+                                .where(application_module: {prefix: app_code}).with_all_roles(*roles)
         notifier.deliver(users)
       end
     end