cats_core 1.5.17 → 1.5.19

data/app/models/cats/core/user.rb

@@ -2,33 +2,33 @@ module Cats
   module Core
     class User < ApplicationRecord
       has_secure_password
-      rolify role_cname: 'Cats::Core::Role'
+      rolify role_cname: "Cats::Core::Role"
 
       belongs_to :application_module
       has_many :notifications, as: :recipient
 
-      validates :password, length: { minimum: 6 }, if: proc { |u| u.password.present? }, on: :update
+      validates :password, length: {minimum: 6}, if: proc { |u| u.password.present? }, on: :update
       validates :first_name, :last_name, :email, presence: true
-      validates :password, presence: true, length: { minimum: 6 }, on: :create
-      validates :email, uniqueness: true, format: { with: URI::MailTo::EMAIL_REGEXP }
+      validates :password, presence: true, length: {minimum: 6}, on: :create
+      validates :email, uniqueness: true, format: {with: URI::MailTo::EMAIL_REGEXP}
       validate :validate_phone_number
 
       def warehouse
-        return unless details.key?('warehouse')
+        return unless details.key?("warehouse")
 
-        Cats::Core::Location.find_by(id: details['warehouse'], location_type: Cats::Core::Location::WAREHOUSE)
+        Cats::Core::Location.find_by(id: details["warehouse"], location_type: Cats::Core::Location::WAREHOUSE)
       end
 
       def stores
-        return unless details.key?('stores')
+        return unless details.key?("stores")
 
-        Cats::Core::Store.where(id: details['stores'])
+        Cats::Core::Store.where(id: details["stores"])
       end
 
       def hub
-        return unless details.key?('hub')
+        return unless details.key?("hub")
 
-        Cats::Core::Location.find_by(id: details['hub'], location_type: Cats::Core::Location::HUB)
+        Cats::Core::Location.find_by(id: details["hub"], location_type: Cats::Core::Location::HUB)
       end
 
       def add_detail(key, value)
@@ -48,7 +48,7 @@ module Cats
 
         return if phone_number.length == 12 && /251\d{9}/.match(phone_number)
 
-        errors.add(:phone_number, 'must be 10 or 12 digits and should match with local phone pattern')
+        errors.add(:phone_number, "must be 10 or 12 digits and should match with local phone pattern")
       end
 
       def full_name

data/app/models/concerns/cats/core/dispatchable.rb

@@ -7,9 +7,9 @@ module Cats
     module Dispatchable
       extend ActiveSupport::Concern
 
-      DRAFT = 'Draft'.freeze
-      APPROVED = 'Approved'.freeze
-      COMPLETED = 'Completed'.freeze
+      DRAFT = "Draft".freeze
+      APPROVED = "Approved".freeze
+      COMPLETED = "Completed".freeze
 
       # rubocop:disable Style/MutableConstant
       STATUSES = [DRAFT, APPROVED, COMPLETED]

data/app/notifications/cats/core/allocation_notification.rb

@@ -24,7 +24,7 @@ module Cats
               Quantity = #{allocation_item.quantity}
           The commodity is expected to be delivered from #{source} to #{destination}
         BODY
-        { title: title, date: date, body: body }
+        {title: title, date: date, body: body}
       end
     end
   end

data/app/notifications/cats/core/dispatch_authorization_notification.rb

@@ -8,6 +8,8 @@ module Cats
       def message
         authorization = params[:dispatch_authorization]
         dispatch = authorization.dispatch
+        plan_item_ref = dispatch.dispatch_plan_item.reference_no
+        plan_ref = dispatch.dispatch_plan_item.dispatch_plan.reference_no
         commodity = dispatch.dispatch_plan_item.commodity
         title = "Dispatch Authorization Notification - #{commodity.name}"
         date = Date.today
@@ -16,6 +18,8 @@ module Cats
           Commodity with the following details is ordered to be dispatched from your store:
               Authorization no. = #{dispatch.dispatch_plan_item.reference_no}
               Dispatch Ref. = #{dispatch.reference_no}
+              Dispatch Plan Ref. = #{plan_ref}
+              Dispatch Plan Item Ref. = #{plan_item_ref}
               Batch No. = #{commodity.batch_no}
               Commodity = #{commodity.name}
               Quantity = #{authorization.quantity}
@@ -24,7 +28,7 @@ module Cats
               Driver Name = #{dispatch.driver_name}
               Driver Phone = #{dispatch.driver_phone}
         BODY
-        { title: title, date: date, body: body }
+        {title: title, date: date, body: body}
       end
     end
   end

data/app/notifications/cats/core/dispatch_notification.rb

@@ -23,7 +23,7 @@ module Cats
               Driver Name = #{dispatch.driver_name}
               Driver Phone = #{dispatch.driver_phone}
         BODY
-        { title: title, date: date, body: body }
+        {title: title, date: date, body: body}
       end
     end
   end

data/app/notifications/cats/core/receipt_authorization_notification.rb

@@ -24,7 +24,7 @@ module Cats
               Driver Name = #{dispatch.driver_name}
               Driver Phone = #{dispatch.driver_phone}
         BODY
-        { title: title, date: date, body: body }
+        {title: title, date: date, body: body}
       end
     end
   end

data/app/notifications/cats/core/round_plan_notification.rb

@@ -20,7 +20,7 @@ module Cats
             Year = #{plan.year}
             Season = #{plan.season}
         BODY
-        { title: title, date: date, body: body }
+        {title: title, date: date, body: body}
       end
     end
   end

data/app/notifications/cats/core/simple_notification.rb

@@ -13,7 +13,7 @@ module Cats
       def message
         title = params[:title]
         body = params[:body]
-        { title: title, body: body }
+        {title: title, body: body}
       end
     end
   end

data/app/serializers/cats/core/cash_donation_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class CashDonationSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :description, :donated_on, :donor_id, :donor_name, :amount, :currency_id,
-                 :currency_code
+        :currency_code
     end
   end
 end

data/app/serializers/cats/core/commodity_donation_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class CommodityDonationSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :donated_on, :donor_id, :donor_name, :plan_id, :plan_reference_no,
-                 :quantity, :unit_id, :unit_abbreviation, :description, :commodity_category_id,
-                 :commodity_category_name, :shipping_reference
+        :quantity, :unit_id, :unit_abbreviation, :description, :commodity_category_id,
+        :commodity_category_name, :shipping_reference
     end
   end
 end

data/app/serializers/cats/core/commodity_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class CommoditySerializer < ActiveModel::Serializer
       attributes :id, :name, :batch_no, :description, :unit_of_measure_id, :unit_abbreviation, :project_id,
-                 :project_code, :quantity, :best_use_before, :volume_per_metric_ton, :arrival_status, :status,
-                 :shipping_reference, :commodity_grade, :package_unit_id, :package_unit_abbreviation
+        :project_code, :quantity, :best_use_before, :volume_per_metric_ton, :arrival_status, :status,
+        :shipping_reference, :commodity_grade, :package_unit_id, :package_unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/dispatch_authorization_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class DispatchAuthorizationSerializer < ActiveModel::Serializer
       attributes :id, :dispatch_id, :dispatch_reference_no, :store_id, :store_name, :quantity, :authorized_by_id,
-                 :authorizer_full_name, :dispatch_status, :plate_no, :driver_name, :status, :unit_id,
-                 :unit_abbreviation
+        :authorizer_full_name, :dispatch_status, :plate_no, :driver_name, :status, :unit_id,
+        :unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/dispatch_plan_item_serializer.rb

@@ -2,9 +2,9 @@ module Cats
   module Core
     class DispatchPlanItemSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :dispatch_plan_id, :plan_reference_no, :source_id, :source_name, :destination_id,
-                 :destination_name, :quantity, :source_location_type, :destination_location_type, :commodity_status,
-                 :status, :commodity_id, :commodity_name, :commodity_batch_no, :unit_abbreviation,
-                 :commodity_shipping_reference, :unit_id
+        :destination_name, :quantity, :source_location_type, :destination_location_type, :commodity_status,
+        :status, :commodity_id, :commodity_name, :commodity_batch_no, :unit_abbreviation,
+        :commodity_shipping_reference, :unit_id
     end
   end
 end

data/app/serializers/cats/core/dispatch_plan_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class DispatchPlanSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :status, :dispatchable_id, :dispatchable_type, :request_reference,
-                 :request_quantity, :upstream
+        :request_quantity, :upstream
     end
   end
 end

data/app/serializers/cats/core/dispatch_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class DispatchSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :dispatch_plan_item_id, :transporter_id, :transporter_name, :plate_no,
-                 :driver_name, :driver_phone, :quantity, :remark, :prepared_by_id, :prepared_by_email,
-                 :dispatch_status, :destination, :auth_details, :unit_id, :unit_abbreviation, :commodity_status
+        :driver_name, :driver_phone, :quantity, :remark, :prepared_by_id, :prepared_by_email,
+        :dispatch_status, :destination, :auth_details, :unit_id, :unit_abbreviation, :commodity_status
     end
   end
 end

data/app/serializers/cats/core/dispatch_transaction_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class DispatchTransactionSerializer < ActiveModel::Serializer
       attributes :id, :source_id, :source_code, :dispatch_authorization_id, :quantity, :transaction_date, :status,
-                 :unit_id, :unit_abbreviation, :reference_no
+        :unit_id, :unit_abbreviation, :reference_no
     end
   end
 end

data/app/serializers/cats/core/loan_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class LoanSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :lender, :agreement_date, :repayment_date, :commodity_category_id,
-                 :commodity_category_name, :quantity, :unit_id, :unit_abbreviation
+        :commodity_category_name, :quantity, :unit_id, :unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/purchase_order_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class PurchaseOrderSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :order_date, :requisition_no, :supplier, :cash_donation_id, :purchase_type,
-                 :commodity_category_id, :commodity_category_name, :quantity, :unit_id, :unit_name, :currency_id,
-                 :currency_code, :price
+        :commodity_category_id, :commodity_category_name, :quantity, :unit_id, :unit_name, :currency_id,
+        :currency_code, :price
     end
   end
 end

data/app/serializers/cats/core/receipt_authorization_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class ReceiptAuthorizationSerializer < ActiveModel::Serializer
       attributes :id, :dispatch_id, :dispatch_reference_no, :store_id, :store_name, :quantity, :received_quantity,
-                 :remark, :status, :authorized_by_id, :authorizer_full_name, :auth_details, :plate_no, :driver_name,
-                 :dispatch_status, :unit_id, :unit_abbreviation, :driver_confirmed
+        :remark, :status, :authorized_by_id, :authorizer_full_name, :auth_details, :plate_no, :driver_name,
+        :dispatch_status, :unit_id, :unit_abbreviation, :driver_confirmed
     end
   end
 end

data/app/serializers/cats/core/receipt_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class ReceiptSerializer < ActiveModel::Serializer
       attributes :id, :receipt_authorization_id, :commodity_status, :commodity_grade, :quantity, :remark,
-                 :unit_id, :unit_abbreviation, :reference_no
+        :unit_id, :unit_abbreviation, :reference_no
     end
   end
 end

data/app/serializers/cats/core/receipt_transaction_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class ReceiptTransactionSerializer < ActiveModel::Serializer
       attributes :id, :receipt_authorization_id, :receipt_number,
-                 :dispatch_reference_no, :destination_id, :destination_code, :quantity,
-                 :transaction_date, :status, :unit_id, :unit_abbreviation
+        :dispatch_reference_no, :destination_id, :destination_code, :quantity,
+        :transaction_date, :status, :unit_id, :unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/round_beneficiary_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class RoundBeneficiarySerializer < ActiveModel::Serializer
       attributes :id, :beneficiary_id, :beneficiary_full_name, :round_plan_item_id, :commodity_category_id,
-                 :commodity_category_name, :quantity, :unit_id, :unit_abbreviation, :received
+        :commodity_category_name, :quantity, :unit_id, :unit_abbreviation, :received
     end
   end
 end

data/app/serializers/cats/core/round_plan_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class RoundPlanSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :status, :plan_id, :plan_reference_no, :region_id, :region_name, :rounds,
-                 :program_code
+        :program_code
     end
   end
 end

data/app/serializers/cats/core/stack_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class StackSerializer < ActiveModel::Serializer
       attributes :id, :code, :length, :width, :height, :start_x, :start_y, :commodity_id, :store_id, :commodity_status,
-                 :stack_status, :quantity, :commodity_batch_no, :unit_id, :unit_abbreviation
+        :stack_status, :quantity, :commodity_batch_no, :unit_id, :unit_abbreviation
     end
   end
 end

data/app/serializers/cats/core/store_serializer.rb

@@ -2,7 +2,7 @@ module Cats
   module Core
     class StoreSerializer < ActiveModel::Serializer
       attributes :id, :code, :name, :length, :width, :height, :temporary, :has_gangway, :gangway_length,
-                 :gangway_width, :gangway_corner_dist, :warehouse_id
+        :gangway_width, :gangway_corner_dist, :warehouse_id
 
       has_many :stacks
     end

data/app/serializers/cats/core/swap_serializer.rb

@@ -2,8 +2,8 @@ module Cats
   module Core
     class SwapSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :swapper, :agreement_date, :issued_commodity_id, :issued_commodity_name,
-                 :issued_quantity, :received_commodity_id, :received_commodity_name, :received_quantity,
-                 :issued_unit_id, :issued_unit_abbreviation, :received_unit_id, :received_unit_abbreviation
+        :issued_quantity, :received_commodity_id, :received_commodity_name, :received_quantity,
+        :issued_unit_id, :issued_unit_abbreviation, :received_unit_id, :received_unit_abbreviation
     end
   end
 end

data/app/services/cats/core/authorization_service.rb

@@ -1,22 +1,22 @@
 module Cats
   module Core
     class AuthorizationService
-      def driver_confirm(authorization_id, pin)
+      def driver_confirm(authorization_id, pin, receipt_number)
         authorization = ReceiptAuthorization.find(authorization_id)
         if authorization.status == Authorization::AUTHORIZED
-          raise(StandardError, 'Authorization not confirmed by storekeeper.')
+          raise(StandardError, "Authorization not confirmed by storekeeper.")
         end
 
-        raise(StandardError, 'No pin has been generated for receipt.') if authorization.auth_details.nil?
+        raise(StandardError, "No pin has been generated for receipt.") if authorization.auth_details.nil?
 
-        raise(StandardError, 'Incorrect pin.') unless pin == authorization.auth_details['pin']
+        raise(StandardError, "Incorrect pin.") unless pin == authorization.auth_details["pin"]
 
-        raise(StandardError, 'Pin is not active.') unless authorization.auth_details['active']
+        raise(StandardError, "Pin is not active.") unless authorization.auth_details["active"]
 
-        if DateTime.now > authorization.auth_details['expires_at']
+        if DateTime.now > authorization.auth_details["expires_at"]
           authorization.auth_details[:active] = false
           authorization.save!
-          raise(StandardError, 'Pin has expired.')
+          raise(StandardError, "Pin has expired.")
         end
 
         authorization.driver_confirmed = true
@@ -27,7 +27,7 @@ module Cats
         # Create destination stack and transaction for FDP
         location = authorization.dispatch.dispatch_plan_item.destination
         if location.location_type == Location::FDP
-          create_stack(authorization_id)
+          create_stack(authorization_id, receipt_number)
           stack(authorization_id)
         end
 
@@ -35,7 +35,7 @@ module Cats
       end
 
       # A method to create stack and stack transactions for FDP
-      def create_stack(authorization_id)
+      def create_stack(authorization_id, receipt_number)
         authorization = ReceiptAuthorization.find(authorization_id)
         commodity = authorization.dispatch.dispatch_plan_item.commodity
         stack = Stack.create!(
@@ -57,7 +57,8 @@ module Cats
           quantity: authorization.received_quantity,
           unit: authorization.unit,
           status: Transaction::DRAFT,
-          transaction_date: Date.today
+          transaction_date: Date.today,
+          receipt_number: receipt_number
         )
         stack
       end
@@ -65,12 +66,12 @@ module Cats
       def stack(authorization_id)
         authorization = ReceiptAuthorization.find(authorization_id)
         unless authorization.dispatch.dispatch_status == Dispatch::RECEIVED
-          raise(StandardError, 'Dispatch is not received.')
+          raise(StandardError, "Dispatch is not received.")
         end
 
         total = authorization.transactions.sum(:quantity)
         if total != authorization.received_quantity
-          raise(StandardError, 'Received quantity is not the same as quantity to be stacked.')
+          raise(StandardError, "Received quantity is not the same as quantity to be stacked.")
         end
 
         authorization.transactions.each(&:commit)
@@ -83,7 +84,7 @@ module Cats
         item = DispatchPlanItem.find(id).includes(
           :destination,
           :unit,
-          commodity: { project: :source }
+          commodity: {project: :source}
         )
         {
           date: Date.today,
@@ -97,15 +98,15 @@ module Cats
       end
 
       def send_receipt_notification(authorization)
-        notification_rule = NotificationRule.find_by(code: 'receipt_authorization')
-        error = 'Notification rule not found for receipt authorization notification.'
+        notification_rule = NotificationRule.find_by(code: "receipt_authorization")
+        error = "Notification rule not found for receipt authorization notification."
         raise(StandardError, error) unless notification_rule
 
-        users = User.joins(:roles).where(cats_core_roles: { name: notification_rule.roles })
+        users = User.joins(:roles).where(cats_core_roles: {name: notification_rule.roles})
         recipients = users.map do |user|
           details = user.details
 
-          user if details.key?('stores') && details['stores'].include?(authorization.store_id)
+          user if details.key?("stores") && details["stores"].include?(authorization.store_id)
         end.compact
         return if recipients.empty?
 
@@ -114,15 +115,15 @@ module Cats
       end
 
       def send_dispatch_notification(authorization)
-        notification_rule = NotificationRule.find_by(code: 'dispatch_authorization')
-        error = 'Notification rule not found for dispatch authorization notification.'
+        notification_rule = NotificationRule.find_by(code: "dispatch_authorization")
+        error = "Notification rule not found for dispatch authorization notification."
         raise(StandardError, error) unless notification_rule
 
-        users = User.joins(:roles).where(cats_core_roles: { name: notification_rule.roles })
+        users = User.joins(:roles).where(cats_core_roles: {name: notification_rule.roles})
         recipients = users.map do |user|
           details = user.details
 
-          user if details.key?('stores') && details['stores'].include?(authorization.store_id)
+          user if details.key?("stores") && details["stores"].include?(authorization.store_id)
         end.compact
         return if recipients.empty?
 

data/app/services/cats/core/beneficiary_service.rb

@@ -3,9 +3,9 @@ module Cats
     class BeneficiaryService
       def clear_distribution_list(id)
         round_plan = RoundPlan.find(id)
-        raise(StandardError, 'Round plan is not in draft state.') unless round_plan.status == RoundPlan::DRAFT
+        raise(StandardError, "Round plan is not in draft state.") unless round_plan.status == RoundPlan::DRAFT
 
-        RoundBeneficiary.joins(:round_plan_item).where(round_plan_item: { round_plan_id: id }).delete_all
+        RoundBeneficiary.joins(:round_plan_item).where(round_plan_item: {round_plan_id: id}).delete_all
       end
 
       def generate_distribution_list(id)
@@ -14,7 +14,7 @@ module Cats
         plan_days = round_plan.plan.no_of_round_days
         rounds = round_plan.rounds.count
         beneficiaries = Beneficiary.joins(:beneficiary_category).where(
-          beneficiary_category: { plan_id: round_plan.plan_id }
+          beneficiary_category: {plan_id: round_plan.plan_id}
         ).group_by(&:fdp_id)
         beneficiaries.each_key do |key|
           beneficiaries[key] = beneficiaries[key].group_by(&:beneficiary_category_id)
@@ -48,38 +48,38 @@ module Cats
       end
 
       def remove_items(plan_id, ids)
-        raise(StandardError, 'No beneficiaries specified.') if ids.count.zero?
+        raise(StandardError, "No beneficiaries specified.") if ids.count.zero?
 
         begin
           plan = RoundPlan.find(plan_id)
         rescue ActiveRecord::RecordNotFound
-          raise(StandardError, 'Round plan not found.') unless plan
+          raise(StandardError, "Round plan not found.") unless plan
         end
 
         beneficiaries = RoundBeneficiary.joins(:round_plan_item)
-                                        .where(round_plan_item: { round_plan_id: plan_id })
+          .where(round_plan_item: {round_plan_id: plan_id})
         to_delete = RoundBeneficiary.where(id: ids)
         diff = to_delete - beneficiaries
-        raise(StandardError, 'Round plan beneficiaries should be from the same plan.') if diff.count.positive?
+        raise(StandardError, "Round plan beneficiaries should be from the same plan.") if diff.count.positive?
 
         to_delete.delete_all
         true
       end
 
       def confirm_receipt(plan_id, ids)
-        raise(StandardError, 'No beneficiaries specified.') if ids.count.zero?
+        raise(StandardError, "No beneficiaries specified.") if ids.count.zero?
 
         begin
           plan = RoundPlan.find(plan_id)
         rescue ActiveRecord::RecordNotFound
-          raise(StandardError, 'Round plan not found.') unless plan
+          raise(StandardError, "Round plan not found.") unless plan
         end
 
         beneficiaries = RoundBeneficiary.joins(:round_plan_item)
-                                        .where(round_plan_item: { round_plan_id: plan_id })
+          .where(round_plan_item: {round_plan_id: plan_id})
         to_confirm = RoundBeneficiary.where(id: ids)
         diff = to_confirm - beneficiaries
-        raise(StandardError, 'Round plan beneficiaries should be from the same plan.') if diff.count.positive?
+        raise(StandardError, "Round plan beneficiaries should be from the same plan.") if diff.count.positive?
 
         to_confirm.update_all(received: true)
         true

data/app/services/cats/core/dispatch_plan_service.rb

@@ -7,8 +7,8 @@ module Cats
         if plan.upstream
           # Create source hub authorizations for each item and
           # put them in a `Source Authorized` state
-          store = Store.find_by(code: 'SUP-STORE')
-          keeper = User.find_by(first_name: 'SUP-Storekeeper')
+          store = Store.find_by(code: "SUP-STORE")
+          keeper = User.find_by(first_name: "SUP-Storekeeper")
           authorizations = []
           plan.dispatch_plan_items.each do |item|
             authorizations << {
@@ -40,17 +40,17 @@ module Cats
       end
 
       def send_notification(allocation)
-        notification_rule = Cats::Core::NotificationRule.find_by(code: 'allocation')
-        raise(StandardError, 'Notification rule not found for allocation notification.') unless notification_rule
+        notification_rule = Cats::Core::NotificationRule.find_by(code: "allocation")
+        raise(StandardError, "Notification rule not found for allocation notification.") unless notification_rule
 
-        users = Cats::Core::User.joins(:roles).where(cats_core_roles: { name: notification_rule.roles })
+        users = Cats::Core::User.joins(:roles).where(cats_core_roles: {name: notification_rule.roles})
         allocation.dispatch_plan_items.each do |item|
           location_id = item.destination_id
 
           recipients = users.map do |user|
             details = user.details
-            if (details.key?('warehouse') && details['warehouse'] == location_id) ||
-               (details.key?('hub') && details['hub'] == location_id)
+            if (details.key?("warehouse") && details["warehouse"] == location_id) ||
+                (details.key?("hub") && details["hub"] == location_id)
               user
             end
           end.compact
@@ -69,9 +69,9 @@ module Cats
       #
       def generate(id)
         details = RoundPlanItemDetail.joins(
-          beneficiary_round_plan_item: { round_plan_item: :round_plan }
+          beneficiary_round_plan_item: {round_plan_item: :round_plan}
         ).where(
-          beneficiary_round_plan_item: { cats_core_round_plan_items: { round_plan_id: id } }
+          beneficiary_round_plan_item: {cats_core_round_plan_items: {round_plan_id: id}}
         ).includes(
           beneficiary_round_plan_item: {
             round_plan_item: %i[round_plan region zone woreda fdp]
@@ -99,7 +99,7 @@ module Cats
         {
           reference_no: nil,
           dispatchable_id: id,
-          dispatchable_type: 'Cats::Core::RoundPlan',
+          dispatchable_type: "Cats::Core::RoundPlan",
           items: items
         }
       end