cats_core 1.4.3 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2624794cc9a3787caefb212037b9f33f8964e9d5512fcc40a7dbb31fa129009
-  data.tar.gz: 0f2d9b94ca4dc8794fe89928449b6c26cac67a78e2ffffadfa5be8d49baef52c
+  metadata.gz: 05ec37047a728927e68df2e0a0ae34dd16cca869cfe658314ea5fb0738ae894b
+  data.tar.gz: 272f1c6cb33e96a8407cab42c3b9bd8b01540156feee9bf4d6012b5b97600b52
 SHA512:
-  metadata.gz: c0f3fc9431f4b011ca5015f9bf288627b51b547d79323e48d1f0221baae4781766b63ab521c23652feda8cd2fefb7f17a2242166ace64875cf4418138dc37c54
-  data.tar.gz: c9b0ec89851d48c0fcc9338dd749364d4a1a66e0a4291085c59f70b73605f5b47b4831cbfd03d01683f0b1ed829309247069f0878b6bc199cf2791936e416978
+  metadata.gz: 19a5247f29b37ca8dc8a0176719b22b924069166168ddcf684a84ca0bcbd45ae170a164516ffada4cb2066b428ece538f89c8daa45bfb2db15bd432fb9676dab
+  data.tar.gz: b41ed1c8028112b527cd21b01821187260ba85ab2647fe7f477422a69f40a72420aed74d6741d3525f5812d110354b85bc12cf23b54163ce921286be1d185e10

data/app/controllers/cats/core/dispatch_plan_items_controller.rb

@@ -17,7 +17,7 @@ module Cats
 
       def model_params
         params.require(:payload).permit(:dispatch_plan_id, :source_id, :destination_id, :quantity, :commodity_status,
-                                        :status)
+                                        :status, :commodity_id)
       end
     end
   end

data/app/controllers/cats/core/dispatch_plans_controller.rb

@@ -33,7 +33,7 @@ module Cats
       private
 
       def model_params
-        params.require(:payload).permit(:reference_no, :dispatchable_id, :dispatchable_type, :commodity_id)
+        params.require(:payload).permit(:reference_no, :dispatchable_id, :dispatchable_type)
       end
     end
   end

data/app/controllers/cats/core/dispatch_transactions_controller.rb

@@ -14,7 +14,7 @@ module Cats
       # user to give us a source.
       def create_allocation
         dispatch = Dispatch.find(model_params[:dispatch_id])
-        commodity = dispatch.dispatch_plan_item.dispatch_plan.commodity
+        commodity = dispatch.dispatch_plan_item.commodity
         transaction = DispatchTransaction.new(model_params)
 
         # Fetch supplier stack by commodity

data/app/controllers/cats/core/dispatches_controller.rb

@@ -49,7 +49,7 @@ module Cats
       end
 
       def commodity
-        data = @dispatch.dispatch_plan_item.dispatch_plan.commodity
+        data = @dispatch.dispatch_plan_item.commodity
         render json: { success: true, data: serialize(data) }
       end
 

data/app/controllers/cats/core/stacks_controller.rb

@@ -13,9 +13,9 @@ module Cats
         render json: { success: true, data: serialize(query.result) }
       end
 
-      def commodity_for_location
+      def items_for_location
         service = StackService.new
-        commodities = service.commodity_for_location(current_user)
+        commodities = service.items_for_location(current_user)
         render json: { success: true, data: serialize(commodities) }
       end
 

data/app/models/cats/core/commodity.rb

@@ -38,7 +38,7 @@ module Cats
       validates :arrival_status, presence: true, inclusion: { in: ARRIVAL_STATUSES }
       validates :status, presence: true, inclusion: { in: STATUSES }
 
-      delegate(:abbreviation, to: :unit_of_measure, prefix: true)
+      delegate(:abbreviation, to: :unit_of_measure, prefix: 'unit')
       delegate(:reference_no, to: :source, prefix: true)
 
       def name

data/app/models/cats/core/dispatch_plan.rb

@@ -8,7 +8,6 @@ module Cats
       belongs_to :dispatchable, polymorphic: true, optional: true
       belongs_to :prepared_by, class_name: 'Cats::Core::User'
       belongs_to :approved_by, class_name: 'Cats::Core::User', optional: true
-      belongs_to :commodity
 
       has_many :dispatch_plan_items
 
@@ -16,7 +15,6 @@ module Cats
       validates :status, inclusion: { in: STATUSES }
       validate :validate_dispatchable, on: :create
 
-      delegate(:batch_no, :name, :quantity, to: :commodity, prefix: true)
       delegate(:request_reference, to: :dispatchable, allow_nil: true)
       delegate(:request_quantity, to: :dispatchable, allow_nil: true)
 

data/app/models/cats/core/dispatch_plan_item.rb

@@ -10,6 +10,8 @@ module Cats
       belongs_to :source, class_name: 'Cats::Core::Location'
       belongs_to :destination, class_name: 'Cats::Core::Location'
       belongs_to :dispatch_plan
+      belongs_to :commodity
+
       has_many :dispatches
       has_many :hub_authorizations
 
@@ -18,7 +20,7 @@ module Cats
       validates :status, presence: true, inclusion: { in: STATUSES }
 
       delegate(:reference_no, to: :dispatch_plan, prefix: :plan, allow_nil: true)
-      delegate(:commodity_batch_no, :commodity_name, to: :dispatch_plan)
+      delegate(:batch_no, :name, to: :commodity, prefix: true)
       delegate(:name, to: :source, prefix: true)
       delegate(:name, to: :destination, prefix: true)
       delegate(:location_type, to: :source, prefix: true)

data/app/models/cats/core/transport_bid_item.rb

@@ -11,6 +11,7 @@ module Cats
       validates :transport_plan_item_id, uniqueness: true
 
       delegate(:reference_no, to: :transport_bid, prefix: true)
+      delegate(:abbreviation, to: :unit, prefix: true)
 
       def route
         transport_plan_item.route.name

data/app/notifications/cats/core/allocation_notification.rb

@@ -12,14 +12,14 @@ module Cats
 
       def message
         allocation_item = params[:allocation_item]
-        commodity = allocation_item.dispatch_plan.commodity.name
+        commodity = allocation_item.commodity.name
         source = allocation_item.source.name
         destination = allocation_item.destination.name
         title = "Allocation Notification - #{commodity}"
         date = Date.today
         body = <<~BODY
           Commodity with the following specification has been allocated to you:
-              Batch No. = #{allocation_item.dispatch_plan.commodity.batch_no}
+              Batch No. = #{allocation_item.commodity.batch_no}
               Commodity = #{commodity}
               Quantity = #{allocation_item.quantity}
           The commodity is expected to be delivered from #{source} to #{destination}

data/app/notifications/cats/core/dispatch_notification.rb

@@ -7,7 +7,7 @@ module Cats
 
       def message
         dispatch = params[:dispatch]
-        commodity = dispatch.dispatch_plan_item.dispatch_plan.commodity
+        commodity = dispatch.dispatch_plan_item.commodity
         title = "Dispatch Notification - #{commodity.name}"
         date = Date.today
         body = <<~BODY

data/app/serializers/cats/core/commodity_serializer.rb

@@ -1,7 +1,7 @@
 module Cats
   module Core
     class CommoditySerializer < ActiveModel::Serializer
-      attributes :id, :name, :batch_no, :description, :unit_of_measure_id, :unit_of_measure_abbreviation, :source_id,
+      attributes :id, :name, :batch_no, :description, :unit_of_measure_id, :unit_abbreviation, :source_id,
                  :source_type, :source_reference_no, :quantity, :best_use_before, :volume_per_metric_ton,
                  :arrival_status, :status, :shipping_reference
     end

data/app/serializers/cats/core/dispatch_plan_serializer.rb

@@ -2,8 +2,7 @@ module Cats
   module Core
     class DispatchPlanSerializer < ActiveModel::Serializer
       attributes :id, :reference_no, :status, :dispatchable_id, :dispatchable_type, :request_reference,
-                 :request_quantity, :commodity_id, :commodity_name, :commodity_batch_no, :commodity_quantity,
-                 :upstream
+                 :request_quantity, :upstream
     end
   end
 end

data/app/services/cats/core/stack_service.rb

@@ -1,7 +1,7 @@
 module Cats
   module Core
     class StackService
-      def commodity_for_location(user)
+      def items_for_location(user)
         details = user.details
 
         key_available = details.keys.any? { |key| %w[stores warehouse hub].include?(key) }
@@ -17,7 +17,7 @@ module Cats
 
         allocation_items =
           DispatchPlanItem
-          .joins(dispatch_plan: :commodity)
+          .joins(:dispatch_plan)
           .where(destination: hub, dispatch_plan: { status: DispatchPlan::APPROVED })
 
         allocation_items.map do |item|
@@ -26,10 +26,10 @@ module Cats
             source: item.source.name,
             destination: item.destination.name,
             quantity: item.quantity,
-            batch_no: item.dispatch_plan.commodity.batch_no,
-            commodity_id: item.dispatch_plan.commodity_id,
-            commodity_name: item.dispatch_plan.commodity.name,
-            unit: item.dispatch_plan.commodity.unit_of_measure.abbreviation
+            batch_no: item.commodity.batch_no,
+            commodity_id: item.commodity_id,
+            commodity_name: item.commodity.name,
+            unit: item.commodity.unit_abbreviation
           }
         end
       end
@@ -39,7 +39,7 @@ module Cats
         warehouses = location.children
         stores = Store.where(warehouse: warehouses)
 
-        commodity = receipt.dispatch.dispatch_plan_item.dispatch_plan.commodity
+        commodity = receipt.dispatch.dispatch_plan_item.commodity
         Stack.where(commodity: commodity, store: stores)
       end
 
@@ -48,7 +48,7 @@ module Cats
         warehouses = location.children
         stores = Store.where(warehouse: warehouses)
 
-        commodity = dispatch.dispatch_plan_item.dispatch_plan.commodity
+        commodity = dispatch.dispatch_plan_item.commodity
         Stack.where(commodity: commodity, store: stores)
       end
     end

data/config/routes.rb

@@ -137,7 +137,7 @@ Cats::Core::Engine.routes.draw do
 
   get '/stores/:id/stacks', controller: :stacks, action: :index, as: :stacks_store
   post '/stores/:id/stacks', controller: :stacks, action: :filter
-  get '/stacks/commodity_for_location', controller: :stacks, action: :commodity_for_location, as: :commodity_for_location
+  get '/stacks/items_for_location', controller: :stacks, action: :items_for_location, as: :items_for_location
   get '/receipts/:id/stacks', controller: :stacks, action: :receipt_stacks, as: :receipt_stacks
   get '/dispatches/:id/stacks', controller: :stacks, action: :dispatch_stacks, as: :dispatch_stacks
   resources :stacks, only: %i[show index create update]

data/db/migrate/20210718043328_create_cats_core_dispatch_plans.rb

@@ -6,11 +6,6 @@ class CreateCatsCoreDispatchPlans < ActiveRecord::Migration[6.1]
       t.string :status, null: false, default: 'Draft'
       t.references :dispatchable, polymorphic: true
       t.boolean :upstream, null: false, default: false
-      t.references :commodity,
-                   null: false,
-                   index: { name: 'commodity_on_dp_indx' },
-                   foreign_key: { to_table: :cats_core_commodities }
-
       t.references :prepared_by,
                    null: false,
                    index: { name: 'pb_on_dp_indx' },

data/db/migrate/20210718043401_create_cats_core_dispatch_plan_items.rb

@@ -13,6 +13,10 @@ class CreateCatsCoreDispatchPlanItems < ActiveRecord::Migration[6.1]
                    null: false,
                    index: { name: 'dpi_on_destination_indx'},
                    foreign_key: { to_table: :cats_core_locations }
+      t.references :commodity,
+                  null: false,
+                  index: { name: 'commodity_on_dpi_indx' },
+                  foreign_key: { to_table: :cats_core_commodities }
       t.float :quantity, null: false
       t.string :commodity_status, null: false, default: 'Good'
       t.string :status, null: false, default: 'Unauthorized'

data/lib/cats/core/version.rb

@@ -1,5 +1,5 @@
 module Cats
   module Core
-    VERSION = '1.4.3'.freeze
+    VERSION = '1.4.4'.freeze
   end
 end

data/spec/factories/cats/core/dispatch_plan_items.rb

@@ -4,6 +4,7 @@ FactoryBot.define do
     destination factory: :location
     dispatch_plan
     quantity { 100 }
+    commodity
     commodity_status { Cats::Core::Commodity::GOOD }
     status { Cats::Core::DispatchPlanItem::UNAUTHORIZED }
   end

data/spec/factories/cats/core/dispatch_plans.rb

@@ -4,7 +4,6 @@ FactoryBot.define do
     status { Cats::Core::DispatchPlan::DRAFT }
     dispatchable { nil }
     upstream { false }
-    commodity
     prepared_by factory: :user
     approved_by { nil }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cats_core
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.4.4
 platform: ruby
 authors:
 - Henock L.