cats_core 1.3.22 → 1.3.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e19b31050b332057df303229d63b57fe37df4608769e70684b9d3f7a35492ec
-  data.tar.gz: 1254bcbeb26ea89e70f710bdb4429f1e02a3cd80bb913c0ec9f7be5d1f3df42d
+  metadata.gz: 1c3f37fca9f63d54dbce888d0beaeb5e3bbd96ac1e1052011433711c2d1b126a
+  data.tar.gz: b018b4b1903cb423c01a37eefc6ec109db0757294b5179f3eb1faba0b30dd6e4
 SHA512:
-  metadata.gz: 54d98fda12c17f62461414a08f301e2f7b0b6ed5857ff9841cf12c0a03e53b0fa8bf0040bbc389bed789ea5d043fd9d5e401e50a567a9d9b88b8db19ffe3c59a
-  data.tar.gz: c25d388617ea0f3a694e7b03d5985b9d1fd87ee7a9a08394109ec9eaefd33d0854d70bdcbefbaf99d3713332d071a7be674cd8003327709d6312e923115055d2
+  metadata.gz: 047d73951d974a609d6caa7c1d76b1ce156d4c2d47e446fc16821732dfdcf0a017eff53dac8c7f64eae1cec0534e9e4cc651cf46f084fdb81892c64245c170d6
+  data.tar.gz: 6e515febfd96c18ab7876fa0ab92c511f34e96c31e3241419b2bd3a2bf5789f65894e958621a16b5a7ae1c35cd00a91640202aaf66213971ba9f0517c29f5b46

data/app/controllers/cats/core/dispatch_plans_controller.rb

@@ -15,15 +15,10 @@ module Cats
 
       def create
         service = DispatchPlanService.new
-
-        data = service.create(model_params, current_user)
-        if data[0]
-          render json: { success: true, data: serialize(data[1]) }, status: :created
-        else
-          render json: { success: false, error: data[1].errors.full_messages[0] }, status: :unprocessable_entity
-        end
+        plan = service.create(model_params, current_user)
+        render json: { success: true, data: serialize(plan) }, status: :created
       rescue StandardError => e
-        render json: { success: false, error: e.message }
+        render json: { success: false, error: e.message }, status: :unprocessable_entity
       end
 
       def approve
@@ -37,7 +32,7 @@ module Cats
       private
 
       def model_params
-        params.require(:payload).permit(:reference_no, :request_id, :commodity_id)
+        params.require(:payload).permit(:reference_no, :dispatchable_id, :dispatchable_type, :commodity_id)
       end
     end
   end

data/app/controllers/cats/core/transporters_controller.rb

@@ -0,0 +1,13 @@
+module Cats
+  module Core
+    class TransportersController < ApplicationController
+      include Cats::Core::Common
+
+      private
+
+      def model_params
+        params.require(:payload).permit(:code, :name, :address, :contact_phone)
+      end
+    end
+  end
+end

data/app/models/cats/core/dispatch_plan.rb

@@ -5,7 +5,7 @@ module Cats
       APPROVED = 'Approved'.freeze
       STATUSES = [DRAFT, APPROVED].freeze
 
-      belongs_to :request, polymorphic: true, optional: true
+      belongs_to :dispatchable, polymorphic: true, optional: true
       belongs_to :prepared_by, class_name: 'Cats::Core::User'
       belongs_to :approved_by, class_name: 'Cats::Core::User', optional: true
       belongs_to :commodity
@@ -16,8 +16,8 @@ module Cats
       validates :status, inclusion: { in: STATUSES }
 
       delegate(:batch_no, :name, :quantity, to: :commodity, prefix: true)
-      delegate(:reference_no, to: :request, prefix: true, allow_nil: true)
-      delegate(:quantity, to: :request, prefix: true, allow_nil: true)
+      delegate(:request_reference, to: :dispatchable, allow_nil: true)
+      delegate(:request_quantity, to: :dispatchable, allow_nil: true)
 
       def approve
         raise(StandardError, 'Dispatch plan already approved.') if status == APPROVED

data/app/models/cats/core/monthly_plan.rb

@@ -1,6 +1,8 @@
 module Cats
   module Core
     class MonthlyPlan < ApplicationRecord
+      include Dispatchable
+
       belongs_to :plan
       belongs_to :region, class_name: 'Cats::Core::Location'
 
@@ -16,6 +18,14 @@ module Cats
       delegate(:reference_no, to: :plan, prefix: true)
       delegate(:name, to: :region, prefix: true)
 
+      def request_reference
+        reference_no
+      end
+
+      def request_quantity
+        nil
+      end
+
       def validate_month
         return unless month
 

data/app/models/cats/core/rhn_request.rb

@@ -1,6 +1,8 @@
 module Cats
   module Core
     class RhnRequest < ApplicationRecord
+      include Dispatchable
+
       DRAFT = 'Draft'.freeze
       APPROVED = 'Approved'.freeze
       ALLOCATED = 'Allocated'.freeze
@@ -16,6 +18,14 @@ module Cats
 
       delegate(:batch_no, to: :commodity, prefix: true)
 
+      def request_reference
+        reference_no
+      end
+
+      def request_quantity
+        quantity
+      end
+
       def validate_commodity_status
         return unless commodity
 

data/app/models/concerns/cats/core/dispatchable.rb

@@ -0,0 +1,15 @@
+# A concern to represent entities that lead to dispatch plan.
+# All classes including this concern must implement `request_reference()`
+# and `request_quantity()` methods, which will be used to generate
+# reference information in dispatch plan serializer.
+module Cats
+  module Core
+    module Dispatchable
+      extend ActiveSupport::Concern
+
+      included do
+        has_many :dispatch_plans, as: :dispatchable
+      end
+    end
+  end
+end

data/app/serializers/cats/core/dispatch_plan_serializer.rb

@@ -1,8 +1,9 @@
 module Cats
   module Core
     class DispatchPlanSerializer < ActiveModel::Serializer
-      attributes :id, :reference_no, :status, :request_id, :commodity_id, :commodity_name, :commodity_batch_no,
-                 :commodity_quantity, :request_reference_no, :request_quantity, :upstream
+      attributes :id, :reference_no, :status, :dispatchable_id, :dispatchable_type, :request_reference,
+                 :request_quantity, :commodity_id, :commodity_name, :commodity_batch_no, :commodity_quantity,
+                 :upstream
     end
   end
 end

data/app/serializers/cats/core/transporter_serializer.rb

@@ -0,0 +1,3 @@
+class TransporterSerializer < ActiveModel::Serializer
+  attributes :id, :code, :name, :address, :contact_phone
+end

data/app/services/cats/core/dispatch_plan_service.rb

@@ -3,24 +3,19 @@ module Cats
     class DispatchPlanService
       def approve(plan)
         plan.approve
-        plan.request.allocate if plan.request_id
+
+        plan.dispatchable.allocate if plan.dispatchable_type == Cats::Core::RhnRequest.name
         # send_notification(plan)
         plan
       end
 
       def create(params, user)
         plan = Cats::Core::DispatchPlan.new(params)
-        raise 'Commodity is not assigned for plan.' unless plan.commodity_id || plan.request_id
-
-        unless plan.commodity_id
-          request = Cats::Core::RhnRequest.find(plan.request_id)
-          plan.commodity_id = request.commodity_id
-          plan.request_type = 'Cats::Core::RhnRequest'
-        end
         plan.prepared_by = user
-        result = plan.save
-
-        [result, plan]
+        plan.save!
+        plan
+      rescue ActiveRecord::RecordInvalid
+        raise(StandardError, plan.errors.full_messages[0])
       end
     end
   end

data/config/routes.rb

@@ -66,6 +66,7 @@ Cats::Core::Engine.routes.draw do
   end
   resources :currencies, except: %i[destroy]
   resources :unit_of_measures, except: %i[destroy]
+  resources :transporters, except: %i[destroy]
 
   post '/routes/filter', controller: :routes, action: :filter
   resources :routes, except: %i[destroy]

data/db/migrate/20210718043328_create_cats_core_dispatch_plans.rb

@@ -4,7 +4,7 @@ class CreateCatsCoreDispatchPlans < ActiveRecord::Migration[6.1]
       t.string :reference_no, unique: true
       t.string :description
       t.string :status, null: false, default: 'Draft'
-      t.references :request, polymorphic: true
+      t.references :dispatchable, polymorphic: true
       t.boolean :upstream, null: false, default: false
       t.references :commodity,
                    null: false,

data/lib/cats/core/version.rb

@@ -1,5 +1,5 @@
 module Cats
   module Core
-    VERSION = '1.3.22'.freeze
+    VERSION = '1.3.23'.freeze
   end
 end

data/spec/factories/cats/core/dispatch_plans.rb

@@ -2,7 +2,7 @@ FactoryBot.define do
   factory :dispatch_plan, class: 'Cats::Core::DispatchPlan' do
     reference_no { FFaker::Name.name }
     status { Cats::Core::DispatchPlan::DRAFT }
-    request { nil }
+    dispatchable { nil }
     upstream { false }
     commodity
     prepared_by factory: :user

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cats_core
 version: !ruby/object:Gem::Version
-  version: 1.3.22
+  version: 1.3.23
 platform: ruby
 authors:
 - Henock L.
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-18 00:00:00.000000000 Z
+date: 2022-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
@@ -246,6 +246,7 @@ files:
 - app/controllers/cats/core/roles_controller.rb
 - app/controllers/cats/core/routes_controller.rb
 - app/controllers/cats/core/spaces_controller.rb
+- app/controllers/cats/core/transporters_controller.rb
 - app/controllers/cats/core/unit_of_measures_controller.rb
 - app/controllers/cats/core/users_controller.rb
 - app/controllers/concerns/cats/core/common.rb
@@ -306,6 +307,7 @@ files:
 - app/models/cats/core/transporter.rb
 - app/models/cats/core/unit_of_measure.rb
 - app/models/cats/core/user.rb
+- app/models/concerns/cats/core/dispatchable.rb
 - app/notifications/cats/core/allocation_notification.rb
 - app/notifications/cats/core/dispatch_notification.rb
 - app/notifications/cats/core/simple_notification.rb
@@ -322,6 +324,7 @@ files:
 - app/serializers/cats/core/role_menu_serializer.rb
 - app/serializers/cats/core/role_serializer.rb
 - app/serializers/cats/core/route_serializer.rb
+- app/serializers/cats/core/transporter_serializer.rb
 - app/serializers/cats/core/unit_of_measure_serializer.rb
 - app/serializers/cats/core/user_serializer.rb
 - app/services/cats/core/dispatch_plan_service.rb
@@ -455,7 +458,7 @@ metadata:
   homepage_uri: http://cats.ndrmcapps.org
   source_code_uri: https://github.com/ndrmc/cats_core
   changelog_uri: https://github.com/ndrmc/cats_core/CHANGELOG.md
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -470,8 +473,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
-signing_key:
+rubygems_version: 3.3.3
+signing_key: 
 specification_version: 4
 summary: Core module for CATS applications
 test_files: []