cats_core 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed6937d9d787e6b9cd4861aed52c82cddec427a2607f86e6b76ee835dbf66c0b
-  data.tar.gz: 99f350b323761a10f70058b01cceda92acd6c92d2824f06d011effaad3cd4780
+  metadata.gz: bdb1adee3b96e70550ebe13e6e0c8a5fb25003bf9f3e6921547ecc597aa12a53
+  data.tar.gz: c358a310a99dfff0bf57002f81ea5e4dfccbc6937ed064908a5693d234c77568
 SHA512:
-  metadata.gz: 67d812874a6b1680fff22c83dff0ac53193585ac9136e9753ef28db9f0210cb503d9b0f73c19d73aa45b55f042e2ff4e2787af35ef713a0ed12029c982b789a9
-  data.tar.gz: bca2a928d539658137bb2b545ab0ea2f98611312e2c4cd8a0dffa3fe415b19b4771dd97a5550631ccc8689817686affdb0c074a93aeb479a78fbca98d4e758c5
+  metadata.gz: afc8027a1addee047913baa073b8ac5cdac7a5e8d42b7c1a81f303e7d8b28c51948a478f02b240760513787d28a0f583e800e2f65a8abc7a6e0e64103661a1fb
+  data.tar.gz: 0bfb44fbd9f541ea33738cd1a4f5150040cc9d69d2c3afd40ea5b198cc19b3b8361851bcfb5e6ed412cc0afe74e67d372fcf2a914163fdf672dbea96f60b7dfb

data/app/models/cats/core/dispatch_transaction.rb

@@ -6,6 +6,15 @@ module Cats
 
       delegate(:code, to: :source, prefix: true)
       delegate(:reference_no, to: :destination, prefix: true)
+
+      def commit
+        Transaction.transaction do
+          source.quantity -= quantity
+          source.save!
+          self.status = COMMITTED
+          save!
+        end
+      end
     end
   end
 end

data/app/models/cats/core/receipt_transaction.rb

@@ -10,7 +10,7 @@ module Cats
         ReceiptTransaction.transaction do
           destination.quantity += quantity
           destination.stack_status = Cats::Core::Stack::ALLOCATED
-          destination.save
+          destination.save!
           self.status = COMMITTED
           save!
         end

data/app/models/cats/core/transaction.rb

@@ -17,23 +17,16 @@ module Cats
       def validate_quantity
         return unless quantity.present? && source.present?
 
-        total = self.class.where(source: source).sum(:quantity)
+        dispatched = self.class.where(source: source, status: DRAFT).sum(:quantity)
 
-        total -= quantity_was if id
+        available = source.quantity - dispatched
+        available += quantity_was if quantity_was
 
-        diff = source.quantity - total
-        errors.add(:quantity, "total is higher than source quantity (Max = #{diff}).") if quantity > diff
+        errors.add(:quantity, "total is higher than source quantity (Max = #{available}).") if quantity > available
       end
 
       def commit
-        Transaction.transaction do
-          source.quantity -= quantity
-          destination.quantity += quantity
-          source.save
-          destination.save
-          self.status = COMMITTED
-          save!
-        end
+        raise(NotImplementedError, 'Method should be implemented in child classes.')
       end
 
       def skip_quantity_validation

data/lib/cats/core/version.rb

@@ -1,5 +1,5 @@
 module Cats
   module Core
-    VERSION = '1.2.0'.freeze
+    VERSION = '1.2.1'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cats_core
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Henock L.
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-11-01 00:00:00.000000000 Z
+date: 2021-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_model_serializers