catpm 0.6.4 → 0.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3085a527e26332fa08ecca7de2efaa10b43cedc80b0505c88edae91edd7ec66f
-  data.tar.gz: 396130a945ff87931a1abea5c9b287b2529416f95a19aee47b5d8daa4e3812ca
+  metadata.gz: 584e9923c1e96355460ab405299df1d35e2116b4ca81b07bb350ae6d8ec773cf
+  data.tar.gz: c972d35aad27e3a6da12029192fbbb25e5674fd29ab4994b5c8f6baed0995c6f
 SHA512:
-  metadata.gz: 4a043995497b5b3046cdee78037f0a89b9801d84f6d58df30a06b2380b866d7d9157c9d33f823e0a50c643b734d37339dcfab3f3a4b3d7cce70a381eb61c8432
-  data.tar.gz: 5e9be269fae7cc4dae79427c8d77284631bda64a25a10235da3755d8a9ec194eb85ff4e0fded2690aa633d1100295734081116d5484bd4be6ae6b69b1f7b21d4
+  metadata.gz: 9fc17e982f9f39197c8398db38b601860c0977bb311b48204016fed327d7cc58c95bc897d74fe0b8e7bc72f75421eb95319bf64f007485348ef4b62179dbd2e8
+  data.tar.gz: 688688d4f266af7950c70bb7377d9846ebf3377550446d0761fc20426b7081ce5006d7ef567a6a589d79bc9cb9eb29a3b0b77c314832ce17c383f355f435e1f7

data/app/views/catpm/system/index.html.erb

@@ -121,8 +121,9 @@
 
     <tr><td colspan="2" style="font-weight:600;color:var(--text-2);font-size:11px;text-transform:uppercase;letter-spacing:0.5px;padding-top:12px">Sampling</td></tr>
     <tr><td>Random Sample Rate</td><td class="mono">1 in <%= @config.random_sample_rate %></td></tr>
-    <tr><td>Max Random Samples / Endpoint</td><td class="mono"><%= @config.max_random_samples_per_endpoint %></td></tr>
-    <tr><td>Max Slow Samples / Endpoint</td><td class="mono"><%= @config.max_slow_samples_per_endpoint %></td></tr>
+    <tr><td>Max Random Samples / Endpoint</td><td class="mono"><%= @config.max_random_samples_per_endpoint || "unlimited" %></td></tr>
+    <tr><td>Max Slow Samples / Endpoint</td><td class="mono"><%= @config.max_slow_samples_per_endpoint || "unlimited" %></td></tr>
+    <tr><td>Max Error Samples / Fingerprint</td><td class="mono"><%= @config.max_error_samples_per_fingerprint || "unlimited" %></td></tr>
 
     <tr><td colspan="2" style="font-weight:600;color:var(--text-2);font-size:11px;text-transform:uppercase;letter-spacing:0.5px;padding-top:12px">Buffer & Flush</td></tr>
     <tr><td>Max Buffer Memory</td><td class="mono"><%= number_to_human_size(@config.max_buffer_memory) %></td></tr>

data/lib/catpm/configuration.rb

@@ -28,21 +28,21 @@ module Catpm
 
     # Numeric settings that must be positive numbers (nil not allowed)
     REQUIRED_NUMERIC = %i[
-      max_sql_length slow_threshold max_buffer_memory flush_interval
-      flush_jitter max_error_contexts random_sample_rate cleanup_interval
+      slow_threshold max_buffer_memory flush_interval flush_jitter
+      random_sample_rate cleanup_interval
       circuit_breaker_failure_threshold circuit_breaker_recovery_timeout
       sqlite_busy_timeout persistence_batch_size shutdown_timeout
-      events_max_samples_per_name stack_sample_interval
-      max_stack_samples_per_request max_error_detail_length
-      max_fingerprint_app_frames max_fingerprint_gem_frames
-      cleanup_batch_size caller_scan_depth segment_source_threshold
+      stack_sample_interval segment_source_threshold
     ].freeze
 
-    # Numeric settings where nil means "unlimited"
+    # Numeric settings where nil means "no limit" / "disabled"
     OPTIONAL_NUMERIC = %i[
       max_segments_per_request retention_period backtrace_lines
       max_random_samples_per_endpoint max_slow_samples_per_endpoint
-      max_error_samples_per_fingerprint
+      max_error_samples_per_fingerprint max_sql_length max_error_contexts
+      events_max_samples_per_name max_stack_samples_per_request
+      max_error_detail_length max_fingerprint_app_frames
+      max_fingerprint_gem_frames cleanup_batch_size caller_scan_depth
     ].freeze
 
     (REQUIRED_NUMERIC + OPTIONAL_NUMERIC).each do |attr|

data/lib/catpm/flusher.rb

@@ -83,8 +83,8 @@ module Catpm
             adapter.persist_buckets(buckets)
 
             bucket_map = build_bucket_map(buckets)
-            samples = rotate_samples(samples)
             adapter.persist_samples(samples, bucket_map)
+            trim_samples(samples)
             adapter.persist_errors(errors)
           end
 
@@ -227,75 +227,43 @@ module Catpm
     end
 
 
-    def rotate_samples(samples)
-      return samples if samples.empty?
+    # Trim excess samples AFTER insert. Simpler and guaranteed correct —
+    # no stale-cache issues when a single flush batch crosses the limit.
+    def trim_samples(samples)
+      return if samples.empty?
 
-      # Pre-fetch counts for all endpoints and types in bulk
       endpoint_keys = samples.map { |s| s[:bucket_key][0..2] }.uniq
-      error_fps = samples.filter_map { |s| s[:error_fingerprint] }.uniq
-
-      # Build counts cache: { [kind, target, op, type] => count }
-      counts_cache = {}
-      if endpoint_keys.any?
-        Catpm::Sample.joins(:bucket)
-          .where(catpm_buckets: { kind: endpoint_keys.map(&:first), target: endpoint_keys.map { |k| k[1] }, operation: endpoint_keys.map { |k| k[2] } })
-          .where(sample_type: %w[random slow])
-          .group('catpm_buckets.kind', 'catpm_buckets.target', 'catpm_buckets.operation', 'catpm_samples.sample_type')
-          .count
-          .each { |(kind, target, op, type), cnt| counts_cache[[kind, target, op, type]] = cnt }
-      end
 
-      error_counts = {}
-      if error_fps.any?
-        Catpm::Sample.where(sample_type: 'error', error_fingerprint: error_fps)
-          .group(:error_fingerprint).count
-          .each { |fp, cnt| error_counts[fp] = cnt }
+      endpoint_keys.each do |kind, target, operation|
+        endpoint_scope = Catpm::Sample.joins(:bucket)
+          .where(catpm_buckets: { kind: kind, target: target, operation: operation })
+
+        # Random: keep newest N
+        max_random = Catpm.config.max_random_samples_per_endpoint
+        trim_by_column(endpoint_scope.where(sample_type: 'random'), max_random, :recorded_at) if max_random
+
+        # Slow: keep highest-duration N
+        max_slow = Catpm.config.max_slow_samples_per_endpoint
+        trim_by_column(endpoint_scope.where(sample_type: 'slow'), max_slow, :duration) if max_slow
+
       end
 
-      samples.each do |sample|
-        kind, target, operation = sample[:bucket_key][0..2]
-
-        case sample[:sample_type]
-        when 'random'
-          max_random = Catpm.config.max_random_samples_per_endpoint
-          if max_random
-            cache_key = [kind, target, operation, 'random']
-            if (counts_cache[cache_key] || 0) >= max_random
-              oldest = Catpm::Sample.joins(:bucket)
-                .where(catpm_buckets: { kind: kind, target: target, operation: operation })
-                .where(sample_type: 'random').order(recorded_at: :asc).first
-              oldest&.destroy
-            end
-          end
-        when 'slow'
-          max_slow = Catpm.config.max_slow_samples_per_endpoint
-          if max_slow
-            cache_key = [kind, target, operation, 'slow']
-            if (counts_cache[cache_key] || 0) >= max_slow
-              weakest = Catpm::Sample.joins(:bucket)
-                .where(catpm_buckets: { kind: kind, target: target, operation: operation })
-                .where(sample_type: 'slow').order(duration: :asc).first
-              if weakest && sample[:duration] > weakest.duration
-                weakest.destroy
-              else
-                sample[:_skip] = true
-              end
-            end
-          end
-        when 'error'
-          max_err = Catpm.config.max_error_samples_per_fingerprint
-          if max_err
-            fp = sample[:error_fingerprint]
-            if fp && (error_counts[fp] || 0) >= max_err
-              oldest = Catpm::Sample.where(sample_type: 'error', error_fingerprint: fp)
-                .order(recorded_at: :asc).first
-              oldest&.destroy
-            end
-          end
+      # Errors: per-fingerprint cap (keep newest within each fingerprint)
+      max_err_fp = Catpm.config.max_error_samples_per_fingerprint
+      if max_err_fp
+        fps = samples.filter_map { |s| s[:error_fingerprint] }.uniq
+        fps.each do |fp|
+          trim_by_column(Catpm::Sample.where(sample_type: 'error', error_fingerprint: fp), max_err_fp, :recorded_at)
         end
       end
+    end
+
+    def trim_by_column(scope, max, keep_column)
+      count = scope.count
+      return if count <= max
 
-      samples.reject { |s| s.delete(:_skip) }
+      excess_ids = scope.order(keep_column => :asc).limit(count - max).pluck(:id)
+      Catpm::Sample.where(id: excess_ids).delete_all if excess_ids.any?
     end
 
     def build_error_context(event)

data/lib/catpm/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Catpm
-  VERSION = '0.6.4'
+  VERSION = '0.6.6'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: catpm
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.6.6
 platform: ruby
 authors:
 - ''