catarse_paypal_express 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b89329023598b1ed9e39384aa566a45f533002f5
-  data.tar.gz: 8e101b28b9165382f8da2f5af956230f195d5fbf
+  metadata.gz: 462880b88a69a04cb38588b2ef1cf645a3e5f2a5
+  data.tar.gz: d8b93811dc10e125d1de20db10d92d4afc4b2fc6
 SHA512:
-  metadata.gz: 21c800b9c57b8902797d48b075deb2e1d46759cb7db39ec70f8342014b336fedfd53a17e735697457c53b433f2334a40026800523f0307d5b6872dd6f8f40777
-  data.tar.gz: af28d53d3843797abf0f215ebba738c390676b99cd7c979790a67da68c10d0002937de6676ef0f2564ad60563ba9654c341f8a27a794b8aed1e15ac43a76aa4a
+  metadata.gz: f312249be9030a40ee51e0f8e4a4e48ce488fb45609c1a169b4a1c65284dc003fc8eaa9972710cc4ed5816471bc1ec49758c05eace37cd6afce539798ed7fd2c
+  data.tar.gz: 4a3630047639182d35448adce5da2a78cbe0d21948d60d62b98d4755b22b0a89365130856a52e227cbe56db75b891e9240c0256998ea5be3c5196dccb9cee3aa

data/app/controllers/catarse_paypal_express/paypal_express_controller.rb

@@ -1,4 +1,6 @@
 class CatarsePaypalExpress::PaypalExpressController < ApplicationController
+  include ActiveMerchant::Billing::Integrations
+
   skip_before_filter :force_http
   SCOPE = "projects.backers.checkout"
   layout :false
@@ -6,15 +8,27 @@ class CatarsePaypalExpress::PaypalExpressController < ApplicationController
   def review
   end
 
+  def refund
+    refund_request = gateway.refund(nil, backer.payment_id)
+
+    if refund_request.success?
+      flash[:notice] = I18n.t('projects.backers.refund.success')
+    else
+      flash[:alert] = I18n.t('projects.backers.refund.error')
+    end
+
+    redirect_to main_app.admin_backers_path
+  end
+
   def ipn
-    if backer
+    if backer && notification.acknowledge
       process_paypal_message params
       backer.update_attributes({
         :payment_service_fee => params['mc_fee'],
         :payer_email => params['payer_email']
       })
     else
-      return render status: 500, text: e.inspect
+      return render status: 500, nothing: true
     end
     return render status: 200, nothing: true
   rescue Exception => e
@@ -110,4 +124,10 @@ class CatarsePaypalExpress::PaypalExpressController < ApplicationController
       puts "[PayPal] An API Certificate or API Signature is required to make requests to PayPal"
     end
   end
+
+  protected
+
+  def notification
+    @notification ||= Paypal::Notification.new(request.raw_post)
+  end
 end

data/config/initializers/active_merchant.rb

@@ -1,2 +1,2 @@
-ActiveMerchant::Billing::PaypalExpressGateway.default_currency = 'BRL'
+ActiveMerchant::Billing::PaypalExpressGateway.default_currency = (PaymentEngines.configuration[:currency_charge] rescue nil) || 'BRL'
 ActiveMerchant::Billing::Base.mode = :test if (PaymentEngines.configuration[:paypal_test] == 'true' rescue nil)

data/config/initializers/register.rb

@@ -1,5 +1,14 @@
 begin
-  PaymentEngines.register({name: 'paypal', review_path: ->(backer){ CatarsePaypalExpress::Engine.routes.url_helpers.review_paypal_express_path(backer) }, locale: 'en'})
+  PaymentEngines.register({
+    name: 'paypal',
+    review_path: ->(backer) {
+      CatarsePaypalExpress::Engine.routes.url_helpers.review_paypal_express_path(backer)
+    },
+    refund_path: ->(backer) {
+      CatarsePaypalExpress::Engine.routes.url_helpers.refund_paypal_express_path(backer)
+    },
+    locale: 'en'
+  })
 rescue Exception => e
   puts "Error while registering payment engine: #{e}"
 end

data/config/locales/en.yml

@@ -1,6 +1,9 @@
 en:
   projects:
     backers:
+      refund:
+        success: 'Pedido de reembolso enviado com sucesso!'
+        error: 'OPS! Ocorreu um erro ao tentar enviar o pedido de reembolso.'
       review:
         paypal: 'PayPal'
         international:

data/config/locales/pt.yml

@@ -1,6 +1,9 @@
 pt:
   projects:
     backers:
+      refund:
+        success: 'Pedido de reembolso enviado com sucesso!'
+        error: 'OPS! Ocorreu um erro ao tentar enviar o pedido de reembolso.'
       review:
         paypal: 'Pagamento internacional - PayPal'
         international:

data/config/routes.rb

@@ -5,6 +5,7 @@ CatarsePaypalExpress::Engine.routes.draw do
     end
 
     member do
+      post :refund
       get  :review
       post :pay
       get  :success

data/lib/catarse_paypal_express/version.rb

@@ -1,3 +1,3 @@
 module CatarsePaypalExpress
-  VERSION = "2.0.0"
+  VERSION = "2.1.0"
 end

data/spec/controllers/catarse_paypal_express/paypal_express_controller_spec.rb

@@ -40,6 +40,21 @@ describe CatarsePaypalExpress::PaypalExpressController do
     address_phone_number: '123'
   }) }
 
+  describe "POST refund" do
+    before do
+      success_refund = double
+      success_refund.stub(:success?).and_return(true)
+
+      main_app.should_receive(:admin_backers_path).and_return('admin_backers_path')
+
+      gateway.should_receive(:refund).with(nil, backer.payment_id).and_return(success_refund)
+
+      post :refund, id: backer.id, use_route: 'catarse_paypal_express'
+    end
+
+    it { should redirect_to('admin_backers_path') }
+  end
+
   describe "GET review" do
     before do
       get :review, id: backer.id, use_route: 'catarse_paypal_express'
@@ -49,24 +64,63 @@ describe CatarsePaypalExpress::PaypalExpressController do
 
   describe "POST ipn" do
     let(:ipn_data){ {"mc_gross"=>"50.00", "protection_eligibility"=>"Eligible", "address_status"=>"unconfirmed", "payer_id"=>"S7Q8X88KMGX5S", "tax"=>"0.00", "address_street"=>"Rua Tatui, 40 ap 81\r\nJardins", "payment_date"=>"09:03:01 Nov 05, 2012 PST", "payment_status"=>"Completed", "charset"=>"windows-1252", "address_zip"=>"01409-010", "first_name"=>"Paula", "mc_fee"=>"3.30", "address_country_code"=>"BR", "address_name"=>"Paula Rizzo", "notify_version"=>"3.7", "custom"=>"", "payer_status"=>"verified", "address_country"=>"Brazil", "address_city"=>"Sao Paulo", "quantity"=>"1", "verify_sign"=>"ALBe4QrXe2sJhpq1rIN8JxSbK4RZA.Kfc5JlI9Jk4N1VQVTH5hPYOi2S", "payer_email"=>"paula.rizzo@gmail.com", "txn_id"=>"3R811766V4891372K", "payment_type"=>"instant", "last_name"=>"Rizzo", "address_state"=>"SP", "receiver_email"=>"financeiro@catarse.me", "payment_fee"=>"", "receiver_id"=>"BVUB4EVC7YCWL", "txn_type"=>"express_checkout", "item_name"=>"Back project", "mc_currency"=>"BRL", "item_number"=>"", "residence_country"=>"BR", "handling_amount"=>"0.00", "transaction_subject"=>"Back project", "payment_gross"=>"", "shipping"=>"0.00", "ipn_track_id"=>"5865649c8c27"} }
-
     let(:backer){ double(:backer, :payment_id => ipn_data['txn_id'] ) }
+    let(:notification) { double }
 
     before do
-      params = ipn_data.merge({ use_route: 'catarse_paypal_express' })
-      backer.should_receive(:update_attributes).with({
-        payment_service_fee: ipn_data['mc_fee'],
-        payer_email: ipn_data['payer_email']
-      })
-      controller.should_receive(:process_paypal_message).with(ipn_data.merge({
-        "controller"=>"catarse_paypal_express/paypal_express",
-        "action"=>"ipn"
-      }))
-      post :ipn, params
+      controller.stub(:notification).and_return(notification)
     end
 
-    its(:status){ should == 200 }
-    its(:body){ should == ' ' }
+    context "when is a valid ipn data" do
+      before do
+        params = ipn_data.merge({ use_route: 'catarse_paypal_express' })
+
+        notification.stub(:acknowledge).and_return(true)
+
+        backer.should_receive(:update_attributes).with({
+          payment_service_fee: ipn_data['mc_fee'],
+          payer_email: ipn_data['payer_email']
+        })
+        controller.should_receive(:process_paypal_message).with(ipn_data.merge({
+          "controller"=>"catarse_paypal_express/paypal_express",
+          "action"=>"ipn"
+        }))
+
+        notification.should_receive(:acknowledge)
+
+        post :ipn, params
+      end
+
+      its(:status){ should == 200 }
+      its(:body){ should == ' ' }
+    end
+
+    context "when is not valid ipn data" do
+      let(:ipn_data){ {"mc_gross"=>"50.00", "payment_status" => 'confirmed', "txn_id" => "3R811766V4891372K", 'payer_email' => 'fake@email.com', 'mc_fee' => '0.0'} }
+
+      before do
+        params = ipn_data.merge({ use_route: 'catarse_paypal_express' })
+
+        notification.stub(:acknowledge).and_return(false)
+
+        backer.should_receive(:update_attributes).with({
+          payment_service_fee: ipn_data['mc_fee'],
+          payer_email: ipn_data['payer_email']
+        }).never
+
+        controller.should_receive(:process_paypal_message).with(ipn_data.merge({
+          "controller"=>"catarse_paypal_express/paypal_express",
+          "action"=>"ipn"
+        })).never
+
+        notification.should_receive(:acknowledge)
+
+        post :ipn, params
+      end
+
+      its(:status){ should == 500 }
+      its(:body){ should == ' ' }
+    end
   end
 
   describe "POST pay" do

data/test/dummy/config/database.yml

@@ -9,6 +9,7 @@
 #       Choose the win32 build.
 #       Install PostgreSQL and put its /bin directory on your path.
 development:
+  host: localhost
   adapter: postgresql
   encoding: utf-8
   database: catarse_development
@@ -35,6 +36,7 @@ development:
 # re-generated from your development database when you run "rake".
 # Do not set this db to the same as development or production.
 test: &test
+  host: localhost
   adapter: postgresql
   encoding: utf-8
   database: catarse_test
@@ -43,6 +45,7 @@ test: &test
 
 
 production:
+  host: localhost
   adapter: postgresql
   encoding: utf-8
   database: catarse_production

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: catarse_paypal_express
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Antônio Roberto Silva
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-15 00:00:00.000000000 Z
+date: 2013-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -186,7 +186,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.1.10
 signing_key: 
 specification_version: 4
 summary: PaypalExpress integration with Catarse