catarse_pagarme 2.7.6 → 2.7.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f6cf63973dd886ba8c5d27c0b298f30812ffe9e9
-  data.tar.gz: 3ffbcb1761d21d21cbc5ad41015d277d6af966f9
+  metadata.gz: 8e8bbb31e0174af0ee3e4de0efaea4c10fb0384b
+  data.tar.gz: 75c632f18a64aceddbad27ce548ec4550f5bb048
 SHA512:
-  metadata.gz: ab663e3744a0c647dedf9aaf15e4be62174213a7d833b0625816871797e1c5d6235bec1c87061997d95d567ea4e347a59b613f5e60a4c055d198bf02f2fb6109
-  data.tar.gz: 02bdb171b420db9455e647dc4d522bc78f51cb8a645835540af593bc31d059e04af7ca9488845e50a10575ca33b39c4150f2a67fbc0e8f3e970ff64a1080973a
+  metadata.gz: 517aed8b6eb577a19a2d7d35d9f35c6049b0bf95b896c83da29f3e023fc73c4d15095d367faf5e2e9cb3c07b596a871250f58c813b8a4e6d20566c880a7edb90
+  data.tar.gz: b50189ff5a90b837c01f5b4db758f95b308be91c32c7f8cec04c865d71a89291ce2657c001f9e153b1492749612c300dc16df4a8f17c7e99a70e4a894524126e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    catarse_pagarme (2.7.6)
+    catarse_pagarme (2.7.7)
       pagarme (= 1.10.0)
       rails (~> 4.0)
       sidekiq

data/app/models/catarse_pagarme/fee_calculator_concern.rb

@@ -19,7 +19,7 @@ module CatarsePagarme::FeeCalculatorConcern
 
     def get_card_fee
       return nil if self.payment.gateway_data["acquirer_name"].blank? # Here we depend on the acquirer name
-      if self.payment.gateway_data["acquirer_name"] == 'stone'
+      if %w(stone pagarme).include? self.payment.gateway_data["acquirer_name"]
         get_stone_fee
       else
         get_cielo_fee

data/app/models/catarse_pagarme/payment_delegator.rb

@@ -69,12 +69,15 @@ module CatarsePagarme
     end
 
     def transaction
-      @transaction ||= ::PagarMe::Transaction.find_by_id(self.payment.gateway_id)
-      if @transaction.kind_of?(Array)
-        @transaction.last
-      else
-        @transaction
-      end
+      gateway_id = self.payment.gateway_id
+      raise "no gateway_id present" unless gateway_id.present?
+
+      @transaction ||= ::PagarMe::Transaction.find_by_id(gateway_id)
+      _transaction = @transaction.kind_of?(Array) ? @transaction.last : @transaction
+
+      raise "transaction gateway not match" unless _transaction.id == gateway_id
+
+      _transaction
     end
 
     def get_installment(installment_number)

data/lib/catarse_pagarme/version.rb

@@ -1,3 +1,3 @@
 module CatarsePagarme
-  VERSION = "2.7.6"
+  VERSION = "2.7.7"
 end

data/spec/controllers/catarse_pagarme/notifications_controller_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe CatarsePagarme::NotificationsController do
-  let(:fake_transaction) { double("fake transaction", card_brand: 'visa', acquirer_name: 'stone', tid: '404040404', installments: 2) }
+  let(:fake_transaction) { double("fake transaction", id: payment.gateway_id, card_brand: 'visa', acquirer_name: 'stone', tid: '404040404', installments: 2) }
 
   before do
     PagarMe.stub(:validate_fingerprint).and_return(true)
@@ -10,8 +10,8 @@ describe CatarsePagarme::NotificationsController do
 
   let(:project) { create(:project, goal: 10_000, state: 'online') }
   let(:contribution) { create(:contribution, value: 10, project: project) }
-  let(:payment) { 
-    p = contribution.payments.first 
+  let(:payment) {
+    p = contribution.payments.first
     p.update_attributes gateway_id: 'abcd'
     p
   }

data/spec/models/catarse_pagarme/payment_delegator_spec.rb

@@ -4,7 +4,7 @@ describe CatarsePagarme::PaymentDelegator do
   let(:contribution) { create(:contribution, value: 10) }
   let(:payment) { contribution.payments.first }
   let(:delegator) { payment.pagarme_delegator }
-  let(:fake_transaction) { double("fake transaction", card_brand: 'visa', acquirer_name: 'stone', tid: '404040404', installments: 2) }
+  let(:fake_transaction) { double("fake transaction", id: payment.gateway_id, card_brand: 'visa', acquirer_name: 'stone', tid: '404040404', installments: 2) }
 
   before do
     CatarsePagarme.configuration.stub(:slip_tax).and_return(2.00)
@@ -100,6 +100,43 @@ describe CatarsePagarme::PaymentDelegator do
     end
   end
 
+  describe "#transaction" do
+    before do
+      delegator.unstub(:transaction)#.and_return(fake_transaction)
+      allow(PagarMe::Transaction).to receive(:find_by_id).and_return(fake_transaction)
+    end
+
+    context "when payment.gateway id is null" do
+      before do
+        allow(payment).to receive(:gateway_id).and_return(nil)
+      end
+
+      it "expect to raises an error" do
+        expect {
+          delegator.transaction
+        }.to raise_error("no gateway_id present")
+      end
+    end
+
+    context "when transaction.id dont match with gateway_id" do
+      before do
+        allow(fake_transaction).to receive(:id).and_return("123")
+      end
+
+      it "expect to raises an error" do
+        expect {
+          delegator.transaction
+        }.to raise_error("transaction gateway not match")
+      end
+    end
+
+    context "when have correct transaction" do
+      it "should return the transaction object" do
+        expect(delegator.transaction).to eq(fake_transaction)
+      end
+    end
+  end
+
   describe "#transfer_funds" do
     let(:admin_user) { create(:user, admin: true) }
     let(:transfer_mock) {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: catarse_pagarme
 version: !ruby/object:Gem::Version
-  version: 2.7.6
+  version: 2.7.7
 platform: ruby
 authors:
 - Antônio Roberto Silva
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-11 00:00:00.000000000 Z
+date: 2015-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails