castle-rb 5.0.0 → 7.1.1

data/spec/lib/castle/commands/{impersonate_spec.rb → start_impersonation_spec.rb}

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-describe Castle::Commands::Impersonate do
-  subject(:instance) { described_class.new(context) }
+describe Castle::Commands::StartImpersonation do
+  subject(:instance) { described_class }
 
   let(:context) { { user_agent: 'test', ip: '127.0.0.1', client_id: 'test' } }
   let(:impersonator) { 'test@castle.io' }
-  let(:default_payload) { { user_id: '1234', sent_at: time_auto } }
+  let(:default_payload) { { user_id: '1234', sent_at: time_auto, context: context } }
 
   let(:time_now) { Time.now }
   let(:time_auto) { time_now.utc.iso8601(3) }
@@ -17,24 +17,6 @@ describe Castle::Commands::Impersonate do
   describe '.build' do
     subject(:command) { instance.build(payload) }
 
-    context 'with simple merger' do
-      let(:payload) { default_payload.merge(context: { test: { test2: '1' } }) }
-      let(:command_data) do
-        default_payload.merge(
-          context: {
-            test: { test2: '1' },
-            user_agent: 'test',
-            ip: '127.0.0.1',
-            client_id: 'test'
-          }
-        )
-      end
-
-      it { expect(command.method).to be_eql(:post) }
-      it { expect(command.path).to be_eql('impersonate') }
-      it { expect(command.data).to be_eql(command_data) }
-    end
-
     context 'with impersonator' do
       let(:payload) { default_payload.merge(properties: { impersonator: impersonator }) }
       let(:command_data) do
@@ -47,10 +29,8 @@ describe Castle::Commands::Impersonate do
     end
 
     context 'when active true' do
-      let(:payload) { default_payload.merge(context: { active: true }) }
-      let(:command_data) do
-        default_payload.merge(context: context.merge(active: true))
-      end
+      let(:payload) { default_payload.merge(context: context.merge(active: true)) }
+      let(:command_data) { default_payload.merge(context: context.merge(active: true)) }
 
       it { expect(command.method).to be_eql(:post) }
       it { expect(command.path).to be_eql('impersonate') }
@@ -58,10 +38,8 @@ describe Castle::Commands::Impersonate do
     end
 
     context 'when active false' do
-      let(:payload) { default_payload.merge(context: { active: false }) }
-      let(:command_data) do
-        default_payload.merge(context: context.merge(active: false))
-      end
+      let(:payload) { default_payload.merge(context: context.merge(active: false)) }
+      let(:command_data) { default_payload.merge(context: context.merge(active: false)) }
 
       it { expect(command.method).to be_eql(:post) }
       it { expect(command.path).to be_eql('impersonate') }
@@ -69,20 +47,13 @@ describe Castle::Commands::Impersonate do
     end
 
     context 'when active string' do
-      let(:payload) { default_payload.merge(context: { active: 'string' }) }
+      let(:payload) { default_payload.merge(context: context.merge(active: 'string')) }
       let(:command_data) { default_payload.merge(context: context) }
 
       it { expect(command.method).to be_eql(:post) }
       it { expect(command.path).to be_eql('impersonate') }
       it { expect(command.data).to be_eql(command_data) }
     end
-
-    context 'when reset' do
-      let(:payload) { default_payload.merge(reset: true) }
-
-      it { expect(command.method).to be_eql(:delete) }
-      it { expect(command.path).to be_eql('impersonate') }
-    end
   end
 
   describe '#validate!' do
@@ -92,14 +63,15 @@ describe Castle::Commands::Impersonate do
       let(:payload) { {} }
 
       it do
-        expect do
-          validate!
-        end.to raise_error(Castle::InvalidParametersError, 'user_id is missing or empty')
+        expect { validate! }.to raise_error(
+          Castle::InvalidParametersError,
+          'user_id is missing or empty'
+        )
       end
     end
 
     context 'when user_id present' do
-      let(:payload) { { user_id: '1234' } }
+      let(:payload) { { user_id: '1234', context: context } }
 
       it { expect { validate! }.not_to raise_error }
     end

data/spec/lib/castle/commands/track_spec.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
 describe Castle::Commands::Track do
-  subject(:instance) { described_class.new(context) }
+  subject(:instance) { described_class }
 
   let(:context) { { test: { test1: '1' } } }
-  let(:default_payload) { { event: '$login.track', sent_at: time_auto } }
+  let(:default_payload) { { event: '$login.track', sent_at: time_auto, context: context } }
 
   let(:time_now) { Time.now }
   let(:time_auto) { time_now.utc.iso8601(3) }
@@ -16,22 +16,9 @@ describe Castle::Commands::Track do
   describe '#build' do
     subject(:command) { instance.build(payload) }
 
-    context 'with simple merger' do
-      let(:payload) { default_payload.merge(context: { test: { test2: '1' } }) }
-      let(:command_data) do
-        default_payload.merge(context: { test: { test1: '1', test2: '1' } })
-      end
-
-      it { expect(command.method).to be_eql(:post) }
-      it { expect(command.path).to be_eql('track') }
-      it { expect(command.data).to be_eql(command_data) }
-    end
-
     context 'with user_id' do
       let(:payload) { default_payload.merge(user_id: '1234') }
-      let(:command_data) do
-        default_payload.merge(user_id: '1234', context: context)
-      end
+      let(:command_data) { default_payload.merge(user_id: '1234', context: context) }
 
       it { expect(command.method).to be_eql(:post) }
       it { expect(command.path).to be_eql('track') }
@@ -40,9 +27,7 @@ describe Castle::Commands::Track do
 
     context 'with properties' do
       let(:payload) { default_payload.merge(properties: { test: '1' }) }
-      let(:command_data) do
-        default_payload.merge(properties: { test: '1' }, context: context)
-      end
+      let(:command_data) { default_payload.merge(properties: { test: '1' }, context: context) }
 
       it { expect(command.method).to be_eql(:post) }
       it { expect(command.path).to be_eql('track') }
@@ -51,9 +36,7 @@ describe Castle::Commands::Track do
 
     context 'with user_traits' do
       let(:payload) { default_payload.merge(user_traits: { test: '1' }) }
-      let(:command_data) do
-        default_payload.merge(user_traits: { test: '1' }, context: context)
-      end
+      let(:command_data) { default_payload.merge(user_traits: { test: '1' }, context: context) }
 
       it { expect(command.method).to be_eql(:post) }
       it { expect(command.path).to be_eql('track') }
@@ -61,10 +44,8 @@ describe Castle::Commands::Track do
     end
 
     context 'when active true' do
-      let(:payload) { default_payload.merge(context: { active: true }) }
-      let(:command_data) do
-        default_payload.merge(context: context.merge(active: true))
-      end
+      let(:payload) { default_payload.merge(context: context.merge(active: true)) }
+      let(:command_data) { default_payload.merge(context: context.merge(active: true)) }
 
       it { expect(command.method).to be_eql(:post) }
       it { expect(command.path).to be_eql('track') }
@@ -72,10 +53,8 @@ describe Castle::Commands::Track do
     end
 
     context 'when active false' do
-      let(:payload) { default_payload.merge(context: { active: false }) }
-      let(:command_data) do
-        default_payload.merge(context: context.merge(active: false))
-      end
+      let(:payload) { default_payload.merge(context: context.merge(active: false)) }
+      let(:command_data) { default_payload.merge(context: context.merge(active: false)) }
 
       it { expect(command.method).to be_eql(:post) }
       it { expect(command.path).to be_eql('track') }
@@ -83,7 +62,7 @@ describe Castle::Commands::Track do
     end
 
     context 'when active string' do
-      let(:payload) { default_payload.merge(context: { active: 'string' }) }
+      let(:payload) { default_payload.merge(context: context.merge(active: 'string')) }
       let(:command_data) { default_payload.merge(context: context) }
 
       it { expect(command.method).to be_eql(:post) }
@@ -99,9 +78,10 @@ describe Castle::Commands::Track do
       let(:payload) { {} }
 
       it do
-        expect do
-          validate!
-        end.to raise_error(Castle::InvalidParametersError, 'event is missing or empty')
+        expect { validate! }.to raise_error(
+          Castle::InvalidParametersError,
+          'event is missing or empty'
+        )
       end
     end
 

data/spec/lib/castle/configuration_spec.rb

@@ -1,147 +1,14 @@
 # frozen_string_literal: true
 
 describe Castle::Configuration do
-  subject(:config) do
-    described_class.instance
-  end
+  subject(:config) { described_class.new }
 
-  describe 'host' do
-    context 'with default' do
-      it { expect(config.url.host).to be_eql('api.castle.io') }
-    end
+  it_behaves_like 'configuration_host'
+  it_behaves_like 'configuration_request_timeout'
+  it_behaves_like 'configuration_allowlisted'
+  it_behaves_like 'configuration_denylisted'
+  it_behaves_like 'configuration_failover_strategy'
+  it_behaves_like 'configuration_api_secret'
 
-    context 'with setter' do
-      before { config.url = 'http://api.castle.dev/v2' }
-
-      it { expect(config.url.host).to be_eql('api.castle.dev') }
-    end
-  end
-
-  describe 'post' do
-    context 'with default' do
-      it { expect(config.url.port).to be_eql(443) }
-    end
-
-    context 'with setter' do
-      before { config.url = 'http://api.castle.dev:3001/v2' }
-
-      it { expect(config.url.port).to be_eql(3001) }
-    end
-  end
-
-  describe 'api_secret' do
-    context 'with env' do
-      let(:secret_key_env) { 'secret_key_env' }
-      let(:secret_key) { 'secret_key' }
-
-      before do
-        allow(ENV).to receive(:fetch).with(
-          'CASTLE_API_SECRET', ''
-        ).and_return(secret_key_env)
-        config.reset
-      end
-
-      it do
-        expect(config.api_secret).to be_eql(secret_key_env)
-      end
-
-      context 'when key is overwritten' do
-        before { config.api_secret = secret_key }
-
-        it do
-          expect(config.api_secret).to be_eql(secret_key)
-        end
-      end
-    end
-
-    context 'with setter' do
-      let(:value) { 'new_secret' }
-
-      before do
-        config.api_secret = value
-      end
-
-      it do
-        expect(config.api_secret).to be_eql(value)
-      end
-    end
-
-    it do
-      expect(config.api_secret).to be_eql('secret')
-    end
-  end
-
-  describe 'request_timeout' do
-    it do
-      expect(config.request_timeout).to be_eql(500)
-    end
-
-    context 'with setter' do
-      let(:value) { 50.0 }
-
-      before do
-        config.request_timeout = value
-      end
-
-      it do
-        expect(config.request_timeout).to be_eql(value)
-      end
-    end
-  end
-
-  describe 'allowlisted' do
-    it do
-      expect(config.allowlisted.size).to be_eql(0)
-    end
-
-    context 'with setter' do
-      before do
-        config.allowlisted = ['header']
-      end
-
-      it do
-        expect(config.allowlisted).to be_eql(['Header'])
-      end
-    end
-  end
-
-  describe 'denylisted' do
-    it do
-      expect(config.denylisted.size).to be_eql(0)
-    end
-
-    context 'with setter' do
-      before do
-        config.denylisted = ['header']
-      end
-
-      it do
-        expect(config.denylisted).to be_eql(['Header'])
-      end
-    end
-  end
-
-  describe 'failover_strategy' do
-    it do
-      expect(config.failover_strategy).to be_eql(:allow)
-    end
-
-    context 'with setter' do
-      before do
-        config.failover_strategy = :deny
-      end
-
-      it do
-        expect(config.failover_strategy).to be_eql(:deny)
-      end
-    end
-
-    context 'when broken' do
-      it do
-        expect do
-          config.failover_strategy = :unicorn
-        end.to raise_error(Castle::ConfigurationError)
-      end
-    end
-  end
+  it { expect(config.api_secret).to be_eql('') }
 end

data/spec/lib/castle/context/{default_spec.rb → get_default_spec.rb}

@@ -1,17 +1,19 @@
 # frozen_string_literal: true
 
-describe Castle::Context::Default do
+describe Castle::Context::GetDefault do
   subject { described_class.new(request, nil) }
 
   let(:ip) { '1.2.3.4' }
   let(:client_id) { 'abcd' }
 
   let(:env) do
-    Rack::MockRequest.env_for('/',
-                              'HTTP_X_FORWARDED_FOR' => ip,
-                              'HTTP_ACCEPT_LANGUAGE' => 'en',
-                              'HTTP_USER_AGENT' => 'test',
-                              'HTTP_COOKIE' => "__cid=#{client_id};other=efgh")
+    Rack::MockRequest.env_for(
+      '/',
+      'HTTP_X_FORWARDED_FOR' => ip,
+      'HTTP_ACCEPT_LANGUAGE' => 'en',
+      'HTTP_USER_AGENT' => 'test',
+      'HTTP_COOKIE' => "__cid=#{client_id};other=efgh"
+    )
   end
   let(:request) { Rack::Request.new(env) }
   let(:default_context) { subject.call }
@@ -26,12 +28,9 @@ describe Castle::Context::Default do
     }
   end
 
-  before do
-    stub_const('Castle::VERSION', version)
-  end
+  before { stub_const('Castle::VERSION', version) }
 
   it { expect(default_context[:active]).to be_eql(true) }
-  it { expect(default_context[:origin]).to be_eql('web') }
   it { expect(default_context[:headers]).to be_eql(result_headers) }
   it { expect(default_context[:ip]).to be_eql(ip) }
   it { expect(default_context[:client_id]).to be_eql(client_id) }

data/spec/lib/castle/context/{merger_spec.rb → merge_spec.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Castle::Context::Merger do
+describe Castle::Context::Merge do
   let(:first) { { test: { test1: { c: '4' } } } }
 
   describe '#call' do

data/spec/lib/castle/context/prepare_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+describe Castle::Context::Prepare do
+  let(:ip) { '1.2.3.4' }
+  let(:cookie_id) { 'abcd' }
+  let(:ua) { 'Chrome' }
+  let(:env) do
+    Rack::MockRequest.env_for(
+      '/',
+      'HTTP_USER_AGENT' => ua,
+      'HTTP_X_FORWARDED_FOR' => ip,
+      'HTTP_COOKIE' => "__cid=#{cookie_id};other=efgh"
+    )
+  end
+  let(:request) { Rack::Request.new(env) }
+  let(:context) do
+    {
+      client_id: 'abcd',
+      active: true,
+      user_agent: ua,
+      headers: headers,
+      ip: ip,
+      library: {
+        name: 'castle-rb',
+        version: '6.0.0'
+      }
+    }
+  end
+
+  let(:headers) do
+    { 'Content-Length': '0', 'User-Agent': ua, 'X-Forwarded-For': ip.to_s, 'Cookie': true }
+  end
+
+  before { stub_const('Castle::VERSION', '6.0.0') }
+
+  describe '#call' do
+    subject(:generated) { described_class.call(request) }
+
+    context 'when active true' do
+      it { is_expected.to eql(context) }
+    end
+  end
+end