castle-rb 3.4.0 → 3.4.1

data/spec/lib/castle/configuration_spec.rb

@@ -6,23 +6,23 @@ describe Castle::Configuration do
   end
 
   describe 'host' do
-    context 'default' do
+    context 'with default' do
       it { expect(config.host).to be_eql('api.castle.io') }
     end
 
-    context 'setter' do
+    context 'with setter' do
       before { config.host = 'api.castle.dev' }
 
       it { expect(config.host).to be_eql('api.castle.dev') }
     end
   end
 
-  describe 'host' do
-    context 'default' do
+  describe 'post' do
+    context 'with default' do
       it { expect(config.port).to be_eql(443) }
     end
 
-    context 'setter' do
+    context 'with setter' do
       before { config.port = 3001 }
 
       it { expect(config.port).to be_eql(3001) }
@@ -30,7 +30,7 @@ describe Castle::Configuration do
   end
 
   describe 'api_secret' do
-    context 'env' do
+    context 'with env' do
       before do
         allow(ENV).to receive(:fetch).with(
           'CASTLE_API_SECRET', ''
@@ -42,7 +42,7 @@ describe Castle::Configuration do
       end
     end
 
-    context 'setter' do
+    context 'with setter' do
       let(:value) { 'new_secret' }
 
       before do
@@ -63,7 +63,7 @@ describe Castle::Configuration do
       expect(config.request_timeout).to be_eql(500)
     end
 
-    context 'setter' do
+    context 'with setter' do
       let(:value) { 50.0 }
 
       before do
@@ -80,7 +80,7 @@ describe Castle::Configuration do
       expect(config.whitelisted.size).to be_eql(13)
     end
 
-    context 'setter' do
+    context 'with setter' do
       before do
         config.whitelisted = ['header']
       end
@@ -89,7 +89,7 @@ describe Castle::Configuration do
       end
     end
 
-    context 'appending' do
+    context 'when appending' do
       before do
         config.whitelisted += ['header']
       end
@@ -103,7 +103,7 @@ describe Castle::Configuration do
       expect(config.blacklisted.size).to be_eql(1)
     end
 
-    context 'setter' do
+    context 'with setter' do
       before do
         config.blacklisted = ['header']
       end
@@ -112,7 +112,7 @@ describe Castle::Configuration do
       end
     end
 
-    context 'appending' do
+    context 'when appending' do
       before do
         config.blacklisted += ['header']
       end
@@ -126,7 +126,7 @@ describe Castle::Configuration do
       expect(config.failover_strategy).to be_eql(:allow)
     end
 
-    context 'setter' do
+    context 'with setter' do
       before do
         config.failover_strategy = :deny
       end

data/spec/lib/castle/{default_context_spec.rb → context/default_spec.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Castle::DefaultContext do
+describe Castle::Context::Default do
   subject { described_class.new(request, nil) }
 
   let(:ip) { '1.2.3.4' }

data/spec/lib/castle/{context_merger_spec.rb → context/merger_spec.rb}

@@ -1,20 +1,20 @@
 # frozen_string_literal: true
 
-describe Castle::ContextMerger do
+describe Castle::Context::Merger do
   let(:first) { { test: { test1: { c: '4' } } } }
 
-  context '#call' do
+  describe '#call' do
     subject { described_class.call(first, second) }
 
     let(:result) { { test: { test1: { c: '4', d: '5' } } } }
 
-    context 'symbol keys' do
+    context 'with symbol keys' do
       let(:second) { { test: { test1: { d: '5' } } } }
 
       it { is_expected.to eq(result) }
     end
 
-    context 'string keys' do
+    context 'with string keys' do
       let(:second) { { 'test' => { 'test1' => { 'd' => '5' } } } }
 
       it { is_expected.to eq(result) }

data/spec/lib/castle/{context_sanitizer_spec.rb → context/sanitizer_spec.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Castle::ContextSanitizer do
+describe Castle::Context::Sanitizer do
   let(:paylod) { { test: 'test' } }
 
   describe '#call' do

data/spec/lib/castle/extractors/client_id_spec.rb

@@ -36,7 +36,7 @@ describe Castle::Extractors::ClientId do
     end
   end
 
-  context 'allow cookies to be undefined' do
+  context 'when cookies undefined' do
     let(:cookies) { nil }
     let(:headers) { {} }
 

data/spec/lib/castle/request_spec.rb

@@ -7,7 +7,7 @@ describe Castle::Request do
   let(:api_secret) { Castle.config.api_secret }
 
   describe 'build' do
-    context 'get' do
+    context 'when get' do
       let(:path) { 'endpoint' }
       let(:params) { { user_id: 1 } }
       let(:request) { subject.build(path, params, :get) }
@@ -19,7 +19,7 @@ describe Castle::Request do
       it { expect(request.to_hash['authorization'][0]).to match(/Basic \w/) }
     end
 
-    context 'post' do
+    context 'when post' do
       let(:path) { 'endpoint' }
       let(:params) { { user_id: 1 } }
       let(:request) { subject.build(path, params, :post) }

data/spec/lib/castle/response_spec.rb

@@ -35,28 +35,28 @@ describe Castle::Response do
   end
 
   describe 'parse' do
-    context 'successfully' do
+    context 'when success' do
       let(:response) { OpenStruct.new(body: '{"user":1}', code: 200) }
 
       it do
         expect(castle_response.parse).to eql(user: 1)
       end
     end
-    context 'return empty object when response empty' do
+    context 'when response empty' do
       let(:response) { OpenStruct.new(body: '', code: 200) }
 
       it do
         expect(castle_response.parse).to eql({})
       end
     end
-    context 'return empty object when response nil' do
+    context 'when response nil' do
       let(:response) { OpenStruct.new(code: 200) }
 
       it do
         expect(castle_response.parse).to eql({})
       end
     end
-    context 'fail when json is malformed' do
+    context 'when json is malformed' do
       let(:response) { OpenStruct.new(body: '{a', code: 200) }
 
       it do

data/spec/lib/castle/review_spec.rb

@@ -7,7 +7,7 @@ describe Castle::Review do
     ).to_return(status: 200, body: '{}', headers: {})
   end
 
-  context '#retrieve' do
+  describe '#retrieve' do
     subject(:retrieve) { described_class.retrieve(review_id) }
 
     let(:review_id) { '1234' }

data/spec/lib/castle/utils_spec.rb

@@ -8,80 +8,80 @@ describe Castle::Utils do
   let(:symbol_array_of_hashes) { { a: [{ b: 2 }, { c: 3 }, 4] } }
   let(:mixed_array_of_hashes) { { a: [{ b: 2 }, { 'c' => 3 }, 4] } }
 
-  context '#deep_symbolize_keys' do
+  describe '#deep_symbolize_keys' do
     subject { described_class.deep_symbolize_keys(hash) }
 
-    context 'nested_symbols' do
+    context 'when nested_symbols' do
       let(:hash) { nested_symbols }
 
       it { is_expected.to eq(nested_symbols) }
     end
 
-    context 'nested_strings' do
+    context 'when nested_strings' do
       let(:hash) { nested_strings }
 
       it { is_expected.to eq(nested_symbols) }
     end
 
-    context 'nested_mixed' do
+    context 'when nested_mixed' do
       let(:hash) { nested_mixed }
 
       it { is_expected.to eq(nested_symbols) }
     end
 
-    context 'string_array_of_hashes' do
+    context 'when string_array_of_hashes' do
       let(:hash) { string_array_of_hashes }
 
       it { is_expected.to eq(symbol_array_of_hashes) }
     end
 
-    context 'symbol_array_of_hashes' do
+    context 'when symbol_array_of_hashes' do
       let(:hash) { symbol_array_of_hashes }
 
       it { is_expected.to eq(symbol_array_of_hashes) }
     end
 
-    context 'mixed_array_of_hashes' do
+    context 'when mixed_array_of_hashes' do
       let(:hash) { mixed_array_of_hashes }
 
       it { is_expected.to eq(symbol_array_of_hashes) }
     end
   end
 
-  context '#deep_symbolize_keys' do
+  describe '#deep_symbolize_keys' do
     subject { described_class.deep_symbolize_keys!(Castle::Utils::Cloner.call(hash)) }
 
-    context 'nested_symbols' do
+    context 'when nested_symbols' do
       let(:hash) { nested_symbols }
 
       it { is_expected.to eq(nested_symbols) }
     end
 
-    context 'nested_strings' do
+    context 'when nested_strings' do
       let(:hash) { nested_strings }
 
       it { is_expected.to eq(nested_symbols) }
     end
 
-    context 'nested_mixed' do
+    context 'when nested_mixed' do
       let(:hash) { nested_mixed }
 
       it { is_expected.to eq(nested_symbols) }
     end
 
-    context 'string_array_of_hashes' do
+    context 'when string_array_of_hashes' do
       let(:hash) { string_array_of_hashes }
 
       it { is_expected.to eq(symbol_array_of_hashes) }
     end
 
-    context 'symbol_array_of_hashes' do
+    context 'when symbol_array_of_hashes' do
       let(:hash) { symbol_array_of_hashes }
 
       it { is_expected.to eq(symbol_array_of_hashes) }
     end
 
-    context 'mixed_array_of_hashes' do
+    context 'when mixed_array_of_hashes' do
       let(:hash) { mixed_array_of_hashes }
 
       it { is_expected.to eq(symbol_array_of_hashes) }

data/spec/lib/castle/validators/not_supported_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+describe Castle::Validators::NotSupported do
+  describe '#call' do
+    subject(:call) { described_class.call({ first: 1 }, keys) }
+
+    context 'when keys is present' do
+      let(:keys) { %i[first second] }
+
+      it do
+        expect do
+          call
+        end.to raise_error(
+          Castle::InvalidParametersError,
+          'first is/are not supported'
+        )
+      end
+    end
+
+    context 'when key is not present' do
+      let(:keys) { %i[second third] }
+
+      it { expect { call }.not_to raise_error }
+    end
+  end
+end

data/spec/lib/castle/validators/present_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+describe Castle::Validators::Present do
+  describe '#call' do
+    subject(:call) { described_class.call({ first: 1, second: '2', invalid: '' }, keys) }
+
+    context 'when keys is not present' do
+      let(:keys) { %i[second third] }
+
+      it do
+        expect do
+          call
+        end.to raise_error(Castle::InvalidParametersError, 'third is missing or empty')
+      end
+    end
+
+    context 'when keys is empty' do
+      let(:keys) { %i[second invalid] }
+
+      it do
+        expect do
+          call
+        end.to raise_error(Castle::InvalidParametersError, 'invalid is missing or empty')
+      end
+    end
+
+    context 'when key is present' do
+      let(:keys) { %i[first second] }
+
+      it { expect { call }.not_to raise_error }
+    end
+  end
+end

data/spec/lib/castle_spec.rb

@@ -24,7 +24,7 @@ describe Castle do
       it { expect(castle.config.request_timeout).to be_eql(timeout) }
     end
 
-    context 'by block' do
+    context 'with block' do
       before do
         castle.configure do |config|
           config.api_secret = value
@@ -35,13 +35,13 @@ describe Castle do
       it_behaves_like 'config_setup'
     end
 
-    context 'by options' do
+    context 'with options' do
       before { castle.configure(request_timeout: timeout, api_secret: value) }
 
       it_behaves_like 'config_setup'
     end
 
-    context 'by block and options' do
+    context 'with block and options' do
       before do
         castle.configure(request_timeout: timeout) do |config|
           config.api_secret = value

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: castle-rb
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.4.1
 platform: ruby
 authors:
 - Johan Brissmyr
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-27 00:00:00.000000000 Z
+date: 2018-02-21 00:00:00.000000000 Z
 dependencies: []
 description: Castle protects your users from account compromise
 email: johan@castle.io
@@ -28,9 +28,9 @@ files:
 - lib/castle/commands/review.rb
 - lib/castle/commands/track.rb
 - lib/castle/configuration.rb
-- lib/castle/context_merger.rb
-- lib/castle/context_sanitizer.rb
-- lib/castle/default_context.rb
+- lib/castle/context/default.rb
+- lib/castle/context/merger.rb
+- lib/castle/context/sanitizer.rb
 - lib/castle/errors.rb
 - lib/castle/extractors/client_id.rb
 - lib/castle/extractors/headers.rb
@@ -49,6 +49,8 @@ files:
 - lib/castle/utils/cloner.rb
 - lib/castle/utils/merger.rb
 - lib/castle/utils/timestamp.rb
+- lib/castle/validators/not_supported.rb
+- lib/castle/validators/present.rb
 - lib/castle/version.rb
 - spec/lib/castle/api_spec.rb
 - spec/lib/castle/client_spec.rb
@@ -59,9 +61,9 @@ files:
 - spec/lib/castle/commands/review_spec.rb
 - spec/lib/castle/commands/track_spec.rb
 - spec/lib/castle/configuration_spec.rb
-- spec/lib/castle/context_merger_spec.rb
-- spec/lib/castle/context_sanitizer_spec.rb
-- spec/lib/castle/default_context_spec.rb
+- spec/lib/castle/context/default_spec.rb
+- spec/lib/castle/context/merger_spec.rb
+- spec/lib/castle/context/sanitizer_spec.rb
 - spec/lib/castle/extractors/client_id_spec.rb
 - spec/lib/castle/extractors/headers_spec.rb
 - spec/lib/castle/extractors/ip_spec.rb
@@ -74,6 +76,8 @@ files:
 - spec/lib/castle/utils/merger_spec.rb
 - spec/lib/castle/utils/timestamp_spec.rb
 - spec/lib/castle/utils_spec.rb
+- spec/lib/castle/validators/not_supported_spec.rb
+- spec/lib/castle/validators/present_spec.rb
 - spec/lib/castle/version_spec.rb
 - spec/lib/castle_spec.rb
 - spec/spec_helper.rb
@@ -89,7 +93,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.6
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -97,20 +101,21 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Castle
 test_files:
 - spec/spec_helper.rb
 - spec/lib/castle_spec.rb
-- spec/lib/castle/context_sanitizer_spec.rb
 - spec/lib/castle/review_spec.rb
 - spec/lib/castle/client_spec.rb
+- spec/lib/castle/context/default_spec.rb
+- spec/lib/castle/context/merger_spec.rb
+- spec/lib/castle/context/sanitizer_spec.rb
 - spec/lib/castle/api_spec.rb
 - spec/lib/castle/configuration_spec.rb
 - spec/lib/castle/version_spec.rb
-- spec/lib/castle/default_context_spec.rb
 - spec/lib/castle/header_formatter_spec.rb
 - spec/lib/castle/utils/cloner_spec.rb
 - spec/lib/castle/utils/timestamp_spec.rb
@@ -123,7 +128,8 @@ test_files:
 - spec/lib/castle/commands/track_spec.rb
 - spec/lib/castle/commands/impersonate_spec.rb
 - spec/lib/castle/commands/identify_spec.rb
-- spec/lib/castle/context_merger_spec.rb
+- spec/lib/castle/validators/not_supported_spec.rb
+- spec/lib/castle/validators/present_spec.rb
 - spec/lib/castle/extractors/ip_spec.rb
 - spec/lib/castle/extractors/headers_spec.rb
 - spec/lib/castle/extractors/client_id_spec.rb