casting 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a049ec2ac612c4ec99f2a08de7050e45242a69a
-  data.tar.gz: fd53cbfb8d14d07a077f001f6d85037e3a3a4a33
+  metadata.gz: 83a70a78a12f99c533069a99925cd2fff9e7f1f9
+  data.tar.gz: eb390d0896a0e88a266bbcc6ff7a638af357523e
 SHA512:
-  metadata.gz: b1ef3ecf6e9fe204ad27b6a5274c021df0f8d4ce7bae9543abe4a57fc7cf7dba54061f3c1bf7b296c9faf008fb75d9b188497619ad0bf3fefe0e05391e2b75e1
-  data.tar.gz: 0a8b280a22b0c34d6cae5b1774ae8c879ab35a9a1080317abf6e3abb657bd2aabf26bbd5ff80864fa8b03517631a29805906f8ccbedc6e6771e39c23946b074b
+  metadata.gz: a6169cca406169f595e33fd5fe9fd85884c7a501e4369fc0c0d665f3a6da178a98c16c7d285d06998c3ab97958fff4d8a82e740ee39e726c0e412d48e9df349e
+  data.tar.gz: 6378fe6a71115ac772e4d5b0b1d3c24924a1133d44ce778497476ff613a2784e7d994b9b2eece23c6dca9d28b8ea8a7d1b64e200f838578f7bded9a958bbff2c

data/lib/casting/client.rb

@@ -26,6 +26,7 @@ module Casting
     end
 
     def cast(delegated_method_name, attendant, *args)
+      validate_attendant(attendant)
       delegation(delegated_method_name).to(attendant).with(*args).call
     end
 
@@ -35,6 +36,12 @@ module Casting
 
     private
 
+    def validate_attendant(attendant)
+      if attendant == self
+        raise Casting::InvalidAttendant.new('client can not delegate to itself')
+      end
+    end
+
     def self.set_delegation_strategy(base, *which)
       which = [:instance] if which.empty?
       which.map!{|selection|

data/lib/casting/missing_method_client.rb

@@ -1,7 +1,10 @@
+require 'casting/method_consolidator'
+
 module Casting
   module MissingMethodClient
 
     def cast_as(attendant)
+      validate_attendant(attendant)
       __delegates__.unshift(attendant)
       self
     end
@@ -11,6 +14,30 @@ module Casting
       self
     end
 
+    def delegated_methods(all=true)
+      __delegates__.flat_map{|attendant|
+        attendant_methods(attendant, all)
+      }
+    end
+
+    def delegated_public_methods(include_super=true)
+      __delegates__.flat_map{|attendant|
+        attendant_public_methods(attendant, include_super)
+      }
+    end
+
+    def delegated_protected_methods(include_super=true)
+      __delegates__.flat_map{|attendant|
+        attendant_protected_methods(attendant, include_super)
+      }
+    end
+
+    def delegated_private_methods(include_super=true)
+      __delegates__.flat_map{|attendant|
+        attendant_private_methods(attendant, include_super)
+      }
+    end
+
     private
 
     def __delegates__
@@ -31,12 +58,38 @@ module Casting
 
     def method_delegate(meth)
       __delegates__.find{|attendant|
-        if Module === attendant
-          attendant.instance_methods
-        else
-          attendant.methods
-        end.include?(meth)
+        attendant_methods(attendant).include?(meth)
       }
     end
+
+    def attendant_methods(attendant, all=true)
+      collection = attendant_public_methods(attendant) + attendant_protected_methods(attendant)
+      collection += attendant_private_methods(attendant) if all
+      collection
+    end
+
+    def attendant_public_methods(attendant, include_super=true)
+      if Module === attendant
+        attendant.public_instance_methods(include_super)
+      else
+        attendant.public_methods(include_super)
+      end
+    end
+
+    def attendant_protected_methods(attendant, include_super=true)
+      if Module === attendant
+        attendant.protected_instance_methods(include_super)
+      else
+        attendant.protected_methods(include_super)
+      end
+    end
+
+    def attendant_private_methods(attendant, include_super=true)
+      if Module === attendant
+        attendant.private_instance_methods(include_super)
+      else
+        attendant.private_methods(include_super)
+      end
+    end
   end
 end

data/lib/casting/version.rb

@@ -1,3 +1,3 @@
 module Casting
-  VERSION = '0.6.1'
+  VERSION = '0.6.2'
 end

data/test/client_test.rb

@@ -39,4 +39,13 @@ describe Casting::Client do
 
     assert_equal client, delegation.client
   end
+
+  it 'refuses to delegate to itself' do
+    client = TestPerson.new
+    client.extend(Casting::Client)
+
+    assert_raises(Casting::InvalidAttendant){
+      client.delegate('to_s', client)
+    }
+  end
 end

data/test/missing_method_client_test.rb

@@ -1,10 +1,9 @@
 require 'test_helper'
-require 'casting/client'
 
 describe Casting::MissingMethodClient, '#cast_as' do
-  def client
-    @client ||= test_person.extend(Casting::Client, Casting::MissingMethodClient)
-  end
+  let(:client){
+    test_person.extend(Casting::Client, Casting::MissingMethodClient)
+  }
 
   it "sets the object's delegate for missing methods" do
     client.cast_as(TestPerson::Greeter)
@@ -12,13 +11,23 @@ describe Casting::MissingMethodClient, '#cast_as' do
   end
 
   it "delegates to objects of the same type" do
+    # avoid using another client
+    client = test_person
     client.extend(TestPerson::Greeter)
     attendant = client.clone
+    client.extend(Casting::Client, Casting::MissingMethodClient)
+
     client.singleton_class.send(:undef_method, :greet)
     client.cast_as(attendant)
     assert_equal 'hello', client.greet
   end
 
+  it "raises an error when given the client object" do
+    assert_raises(Casting::InvalidAttendant){
+      client.cast_as(client)
+    }
+  end
+
   it "returns the object for further operation" do
     jim = test_person.extend(Casting::Client, Casting::MissingMethodClient)
 
@@ -27,9 +36,9 @@ describe Casting::MissingMethodClient, '#cast_as' do
 end
 
 describe Casting::MissingMethodClient, '#uncast' do
-  def client
-    @client ||= test_person.extend(Casting::Client, Casting::MissingMethodClient)
-  end
+  let(:client){
+    test_person.extend(Casting::Client, Casting::MissingMethodClient)
+  }
 
   it "removes the last added delegate" do
     client.cast_as(TestPerson::Greeter)
@@ -50,4 +59,114 @@ describe Casting::MissingMethodClient, '#uncast' do
 
     assert_equal 'name from TestPerson', jim.uncast.name
   end
+end
+
+describe Casting::MissingMethodClient, '#delegated_methods' do
+  let(:client){
+    object = test_person.extend(Casting::Client, Casting::MissingMethodClient)
+    object.cast_as(TestPerson::Greeter)
+    object
+  }
+
+  it "returns all instance methods including private from the object's delegates" do
+    assert_includes(client.delegated_methods(true), :psst)
+  end
+
+  it "returns all public instance methods from the object and it's delegates" do
+    refute_includes(client.delegated_methods(false), :psst)
+  end
+
+  it "returns all protected instance methods from the object and it's delegates" do
+    assert_includes(client.delegated_methods(true), :hey)
+  end
+end
+
+describe Casting::MissingMethodClient, '#delegated_public_methods' do
+  let(:client){
+    object = test_person.extend(Casting::Client, Casting::MissingMethodClient)
+    object.cast_as(TestPerson::Greeter)
+    object
+  }
+
+  it "returns all public methods from the object's delegates" do
+    assert_includes(client.delegated_public_methods, :greet)
+  end
+
+  it "excludes all private  methods from the object's delegates" do
+    refute_includes(client.delegated_public_methods, :psst)
+  end
+
+  it "excludes all protected methods from the object's delegates" do
+    refute_includes(client.delegated_public_methods, :hey)
+  end
+
+  it "includes methods from superclasses" do
+    client.cast_as(Nested)
+    assert_includes(client.delegated_public_methods(true), :nested_deep)
+  end
+
+  it "excludes methods from superclasses" do
+    client.cast_as(Nested)
+    refute_includes(client.delegated_public_methods(false), :nested_deep)
+  end
+end
+
+describe Casting::MissingMethodClient, '#delegated_protected_methods' do
+  let(:client){
+    object = test_person.extend(Casting::Client, Casting::MissingMethodClient)
+    object.cast_as(TestPerson::Greeter)
+    object
+  }
+
+  it "excludes all public methods from the object's delegates" do
+    refute_includes(client.delegated_protected_methods, :greet)
+  end
+
+  it "excludes all private  methods from the object's delegates" do
+    refute_includes(client.delegated_protected_methods, :psst)
+  end
+
+  it "includes all protected methods from the object's delegates" do
+    assert_includes(client.delegated_protected_methods, :hey)
+  end
+
+  it "includes methods from superclasses" do
+    client.cast_as(Nested)
+    assert_includes(client.delegated_protected_methods(true), :protected_nested_deep)
+  end
+
+  it "excludes methods from superclasses" do
+    client.cast_as(Nested)
+    refute_includes(client.delegated_protected_methods(false), :protected_nested_deep)
+  end
+end
+
+describe Casting::MissingMethodClient, '#delegated_private_methods' do
+  let(:client){
+    object = test_person.extend(Casting::Client, Casting::MissingMethodClient)
+    object.cast_as(TestPerson::Greeter)
+    object
+  }
+
+  it "excludes all public methods from the object's delegates" do
+    refute_includes(client.delegated_private_methods, :greet)
+  end
+
+  it "includes all private  methods from the object's delegates" do
+    assert_includes(client.delegated_private_methods, :psst)
+  end
+
+  it "excludes all protected methods from the object's delegates" do
+    refute_includes(client.delegated_private_methods, :hey)
+  end
+
+  it "includes methods from superclasses" do
+    client.cast_as(Nested)
+    assert_includes(client.delegated_private_methods(true), :private_nested_deep)
+  end
+
+  it "excludes methods from superclasses" do
+    client.cast_as(Nested)
+    refute_includes(client.delegated_private_methods(false), :private_nested_deep)
+  end
 end

data/test/test_helper.rb

@@ -4,7 +4,9 @@ SimpleCov.start do
 end
 
 require 'coveralls'
-Coveralls.wear!
+if ENV['COVERALLS']
+  Coveralls.wear!
+end
 
 require 'minitest/autorun'
 require 'casting'
@@ -22,6 +24,14 @@ class TestPerson
     def greet
       'hello'
     end
+
+    protected
+
+    def hey; end
+
+    private
+
+    def psst; end
   end
 
   module Verbose
@@ -50,6 +60,24 @@ class Unrelated
   end
 end
 
+module Deep
+  def nested_deep; end
+  protected
+  def protected_nested_deep; end
+  private
+  def private_nested_deep; end
+end
+
+module Nested
+  include Deep
+
+  def nested; end
+  protected
+  def protected_nested; end
+  private
+  def private_nested; end
+end
+
 def test_person
   TestPerson.new
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: casting
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Jim Gay
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-05 00:00:00.000000000 Z
+date: 2013-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redcard
@@ -82,3 +82,4 @@ test_files:
 - test/client_test.rb
 - test/delegation_test.rb
 - test/missing_method_client_test.rb
+has_rdoc: