cassette 1.2.5 → 1.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c9ed73a897ba8ecc5a7f0133132d28388b9f4a90bc2d0e8a1fe3d1ec21f9b4b3
-  data.tar.gz: bdbe2968131cbddb9527ba973d68aaff7f5008be1b4fe6f662a26c7f5468edd1
+  metadata.gz: 537dfe98da3fa2ff458b4dcd7c8a4288711e8c44bc7093dd3271a2b10b2c7ceb
+  data.tar.gz: 0e61274545f74bcc569503231f9f856e2121af0e20b1843f10ac2f60fc6dc708
 SHA512:
-  metadata.gz: 259b435580d9ebe186553374624dcab25e84d33b392ea00997dbc1729b0fd1fada1b1e5de3bf129aca440146c9bf5b94544525d7868c54b11509cbfc54b0e9b5
-  data.tar.gz: 02fc9b53c0a2e873b0dde28d2757e1d23f59b62d949ace7f789466c1e37f874477d9d4489d03c2e48536bf25016eef2da358e9dbe4dcb5e99943f7dd56ac94be
+  metadata.gz: f6befb3beb94dcfdfb5c021dd144e349a3d06fbe18a6013fb90049fecd5aa9c2996c512253dbc2d5f7c08594725ba22cfad296df3491857037f13a94d4f68dc1
+  data.tar.gz: 461d20aa06ad57a0efad132883cbc005ab68160aa9bda58ec335e274d026abe298b829e179602020b375b03c222e3a743318be69af9ec500a92f32c39d489c85

data/README.md

@@ -1,6 +1,6 @@
 # Cassette::Client
 
-[![Build Status](https://travis-ci.org/locaweb/cassette.svg)](https://travis-ci.org/locaweb/cassette) 
+[![Build Status](https://travis-ci.org/locaweb/cassette.svg)](https://travis-ci.org/locaweb/cassette)
 
 [![Test Coverage](https://codeclimate.com/github/locaweb/cassette/badges/coverage.svg)](https://codeclimate.com/github/locaweb/cassette/coverage)
 

data/lib/cassette.rb

@@ -37,5 +37,21 @@ module Cassette
     @config if defined?(@config)
   end
 
+  def cache_backend
+    @cache_backend ||= begin
+      if defined?(::Rails) && ::Rails.cache
+        ::Rails.cache
+      elsif defined?(::ActiveSupport::Cache::MemoryStore)
+        ActiveSupport::Cache::MemoryStore.new
+      else
+        Cache::NullStore.new
+      end
+    end
+  end
+
+  def self.cache_backend=(cache_backend)
+    @cache_backend = cache_backend
+  end
+
   def_delegators Http::Request, :post
 end

data/lib/cassette/cache.rb

@@ -8,28 +8,6 @@ end
 
 module Cassette
   module Cache
-    def self.backend
-      @backend ||= begin
-        if defined?(::Rails) && ::Rails.cache
-          ::Rails.cache
-        elsif defined?(::ActiveSupport::Cache::MemoryStore)
-          ActiveSupport::Cache::MemoryStore.new
-        else
-          NullStore.new
-        end
-      end
-    end
-
-    def self.backend=(backend)
-      @backend = backend
-    end
-
-    def backend
-      @backend ||= Cassette::Cache.backend
-    end
-
-    attr_writer :backend
-
     def uses_key(key)
       "uses:#{key}"
     end
@@ -50,5 +28,13 @@ module Cassette
 
       backend.fetch(key, options, &block)
     end
+
+    def backend
+      Cassette.cache_backend
+    end
+
+    def self.backend=(backend)
+      ::Cassette.cache_backend = backend
+    end
   end
 end

data/lib/cassette/version.rb

@@ -2,7 +2,7 @@ module Cassette
   class Version
     MAJOR = '1'
     MINOR = '2'
-    PATCH = '5'
+    PATCH = '6'
 
     def self.version
       [MAJOR, MINOR, PATCH].join('.')

data/spec/cassette/authentication/cache_spec.rb

@@ -40,5 +40,21 @@ describe Cassette::Authentication::Cache do
         it  { expect(call_with_other_service).to eq(2) }
       end
     end
+
+    it 'uses the cache store set in configuration' do
+      # setup
+      global_cache = double('cache_store')
+      Cassette.cache_backend = global_cache
+
+      logger = Logger.new('/dev/null')
+
+      # exercise
+      auth_cache = described_class.new(logger)
+
+      expect(auth_cache.backend).to eq(global_cache)
+
+      # tear down
+      Cassette.cache_backend = nil
+    end
   end
 end

data/spec/cassette/cache_spec.rb

@@ -5,62 +5,31 @@ describe Cassette::Cache do
     cached()
   end
 
-  after do
-    described_class.instance_variable_set(:@backend, nil)
-  end
+  describe '#backend' do
+    it 'returns the global cache' do
+      # setup
+      global_cache = double('cache_store')
+      Cassette.cache_backend = global_cache
 
-  describe '.backend' do
-    it 'defaults to rails backend' do
-      rails = double('Rails')
-      cache = double('cache_backend')
-      allow(rails).to receive(:cache).and_return(cache)
-      stub_const('Rails', rails)
+      # exercise and verify
+      expect(subject.backend).to eql(global_cache)
 
-      expect(described_class.backend).to eql(cache)
+      # tear down
+      Cassette.cache_backend = nil
     end
   end
 
   describe '.backend=' do
-    it 'provides a default backend for new instances' do
-      backend = double('backend')
-      expect(subject.backend).not_to eq(backend)
-
-      described_class.backend = backend
-
-      new_instance = cached()
-      expect(new_instance.backend).to eq(backend)
-      expect(new_instance.backend).not_to eq(subject.backend)
-    end
-
-    it 'sets the default backend' do
-      backend = double('backend')
-      expect(described_class.backend).not_to eq(backend)
-
-      described_class.backend = backend
-
-      expect(described_class.backend).to eq(backend)
-    end
-  end
-
-  describe '#backend' do
-    before { subject.backend = nil }
-    after { subject.backend = nil }
-
-    it 'sets the backend' do
-      backend = double('Backend')
-
-      subject.backend = backend
-
-      expect(subject.backend).to eql(backend)
-    end
+    it 'sets the cache' do
+      # setup
+      global_cache = double('cache_store')
+      described_class.backend = global_cache
 
-    it 'defaults to rails backend' do
-      rails = double('Rails')
-      cache = double('cache_backend')
-      allow(rails).to receive(:cache).and_return(cache)
-      stub_const('Rails', rails)
+      # exercise and verify
+      expect(subject.backend).to eql(global_cache)
 
-      expect(subject.backend).to eql(cache)
+      # tear down
+      Cassette.cache_backend = nil
     end
   end
 

data/spec/cassette/client/cache_spec.rb

@@ -3,5 +3,19 @@
 
 
 describe Cassette::Client::Cache do
-  pending
+  it 'uses the cache store set in configuration' do
+      # setup
+      global_cache = double('cache_store')
+      Cassette.cache_backend = global_cache
+
+      logger = Logger.new('/dev/null')
+
+      # exercise
+      client_cache = described_class.new(logger)
+
+      expect(client_cache.backend).to eq(global_cache)
+
+      # tear down
+      Cassette.cache_backend = nil
+    end
 end

data/spec/cassette_spec.rb

@@ -33,4 +33,53 @@ describe Cassette do
       end
     end
   end
+
+  describe '.cache_backend' do
+    context 'when the cache_backend is already set' do
+      it 'returns the cache_backend set' do
+        new_cache = double('cache_backend')
+        described_class.cache_backend = new_cache
+
+        # exercise and verify
+        expect(described_class.cache_backend).to eq(new_cache)
+
+        # tear down
+        described_class.cache_backend = nil
+      end
+    end
+
+    context 'when the cache_backend is not set' do
+      it 'returns Rails.cache if set' do
+        rails_cache = double('cache')
+        rails = double('Rails')
+        allow(rails).to receive(:cache).and_return(rails_cache)
+        stub_const('Rails', rails)
+
+        # exercise and verify
+        expect(described_class.cache_backend).to eq(rails_cache)
+
+        # tear down
+        described_class.cache_backend = nil
+      end
+
+      it 'returns MemoryStore if Rails.cache not set' do
+        # exercise and verify
+        expect(described_class.cache_backend).to be_a(ActiveSupport::Cache::MemoryStore)
+
+        # tear down
+        described_class.cache_backend = nil
+      end
+
+      it 'returns NullStore if Rails.cache and MemoryStore are not set' do
+        hide_const('ActiveSupport::Cache::MemoryStore')
+        require 'cassette/cache/null_store'
+
+        # exercise and verify
+        expect(described_class.cache_backend).to be_a(Cassette::Cache::NullStore)
+
+        # tear down
+        described_class.cache_backend = nil
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -5,6 +5,9 @@ require 'yaml'
 require 'webmock/rspec'
 require 'rspec/its'
 require 'faker'
+if RUBY_VERSION >= '2.3.0'
+  require 'pry-byebug'
+end
 
 Dir['spec/support/**/*.rb'].each { |f| load f }
 
@@ -17,6 +20,9 @@ end
 RSpec.configure do |config|
   config.mock_framework = :rspec
   config.include Fixtures
+  last_execution_result_file = 'spec/support/last_execution_examples_result.txt'
+  config.example_status_persistence_file_path = last_execution_result_file
+  config.order = 'random'
 end
 
 SimpleCov.start 'gem' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cassette
 version: !ruby/object:Gem::Version
-  version: 1.2.5
+  version: 1.2.6
 platform: ruby
 authors:
 - Ricardo Hermida Ruiz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-19 00:00:00.000000000 Z
+date: 2019-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="