cashbox 0.0.28 → 0.0.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b5ee5fff97665fd2a7ac1653360cad18dd8420a9
-  data.tar.gz: c0eccb6bb6e081c1680844ec2bceffb16939c4ee
+  metadata.gz: 494c2c2038e3a5a9cd16a08e9150edb1bdb21bb3
+  data.tar.gz: b5855dcc9b3cb371522c85d7a14f50d9a6862832
 SHA512:
-  metadata.gz: bf4cd3b4749712c725474fe0215438adb6d62f37eb040e80ed581b0831e2139fe240e559f84abceea2b575f94f9c84b01d8e25b2c148c2d769af30dd25959fd2
-  data.tar.gz: ad9099c7e3f06d8a9f569d17464d10c8f8269348f6a5a1d9de335ff57950fde02ff07da3304e36ceb4c789a2b091905bca76ad21a337c21287d8310279b57521
+  metadata.gz: 80e0b9ad17debe098926bec454b55f1c21725a4394f2d6cb60f3f02a9b1fbdafb6373cb6b8cfca58b4049fef8650c6df6c29f40b51df5293e129ef9c7a88342b
+  data.tar.gz: bbc2a88cbb06761a6a2028984c9a0abfccd2aacd010668b0c396fa70fe2d78bf3b62d4952b3fb9948d7ae639695eb627b8d85c430b4abaaa81d426310a1b2fbc

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cashbox (0.0.28)
+    cashbox (0.0.29)
       activesupport
       addressable
       hashie

data/lib/cashbox/model/credit_card.rb

@@ -2,11 +2,24 @@ module Cashbox
   class CreditCard < Model
     include Concern::Objectable
 
+    MASTER_CARD = 'MasterCard'
+    VISA = 'Visa'
+
+    BIN_PREFIXES = {
+      '2' => MASTER_CARD,
+      '5' => MASTER_CARD,
+      '4' => VISA
+    }
+
     property :vid
     property :account
     property :account_length
     property :bin
     property :expiration_date
     property :last_digits
+
+    def network
+      BIN_PREFIXES[bin.to_s[0]]
+    end
   end
 end

data/lib/cashbox/model/payment_method.rb

@@ -4,6 +4,9 @@ module Cashbox
     include Rest::ReadWrite
     include Rest::Archive
 
+    CREDIT_CARD = 'CreditCard'
+    DIRECT_DEBIT = 'DirectDebit'
+
     property :id
     property :vid
     property :created, coerce: Cashbox::Type.DateTime
@@ -18,11 +21,11 @@ module Cashbox
     property :validation_status
 
     def credit_card?
-      type == "CreditCard"
+      type == CREDIT_CARD
     end
 
     def direct_debit?
-      type == "DirectDebit"
+      type == DIRECT_DEBIT
     end
 
     def last_digits
@@ -30,10 +33,7 @@ module Cashbox
     end
 
     def card_network
-      return unless type == "CreditCard"
-      bin_number = credit_card.bin.to_s
-      return "Visa" if bin_number.start_with?("4")
-      return "Master Card" if bin_number.start_with?("2", "5")
+      credit_card.network unless direct_debit?
     end
   end
 end

data/lib/cashbox/version.rb

@@ -1,3 +1,3 @@
 module Cashbox
-  VERSION = "0.0.28"
+  VERSION = "0.0.29"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cashbox
 version: !ruby/object:Gem::Version
-  version: 0.0.28
+  version: 0.0.29
 platform: ruby
 authors:
 - Jonathon Storer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-18 00:00:00.000000000 Z
+date: 2018-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler