cascading.jruby 0.0.4 → 0.0.5

data/spec/expr_spec.rb

@@ -1,10 +1,230 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
-describe Object do
+context ExprStub do
   it 'should allow expr syntax' do
     test_assembly do
       insert 'foo' => 1, 'bar' => expr('offset:int')
       check_scope :values_fields => ['offset', 'line', 'bar', 'foo']
     end
   end
+
+  it 'should compile expressions' do
+    e = ExprStub.new('x:int + y:int')
+    e.compile
+  end
+
+  it 'should throw an exception for parsing failures' do
+    e = ExprStub.new('x:int + doesnotparse y:string')
+    lambda{ e.compile }.should raise_error CascadingException
+  end
+
+  it 'should throw an exception for compile failures' do
+    e = ExprStub.new('new DoesNotExist(x:int).doesnotcompile()')
+    lambda{ e.compile }.should raise_error CascadingException
+  end
+
+  it 'should throw an exception for compile failures' do
+    e = ExprStub.new('true ? x:int : y:string')
+    lambda{ e.compile }.should raise_error CascadingException
+  end
+
+  it 'should evaluate expressions' do
+    e = ExprStub.new('x:int + y:int')
+    result = e.eval(:x => 2, :y => 3)
+    result.should == 5
+
+    e = ExprStub.new('x:int + y:string')
+    result = e.eval(:x => 2, :y => 'blah')
+    result.should == '2blah'
+
+    e = ExprStub.new('x:long + y:int')
+    result = e.eval(:x => 2, :y => 3)
+    result.should == 5
+
+    e = ExprStub.new('x:double + y:int')
+    result = e.eval(:x => 2.0, :y => 3)
+    result.should == 5.0
+
+    e = ExprStub.new('x:float + y:int')
+    result = e.eval(:x => 2.0, :y => 3)
+    result.should == 5.0
+
+    e = ExprStub.new('x:bool && y:bool')
+    result = e.eval(:x => true, :y => false)
+    result.should == false
+  end
+
+  it 'should evaluate expressions despite argument order' do
+    e = ExprStub.new('x:int + y:int')
+    result = e.eval(:y => 3, :x => 2)
+    result.should == 5
+  end
+
+  it 'should throw an exception for invalid actual arguments' do
+    e = ExprStub.new('x:int + y:int')
+    lambda{ e.eval(:x => 2, :y => 'blah') }.should raise_error CascadingException
+
+    # Janino does not coerce numeric strings to Java Integers
+    e = ExprStub.new('x:int + y:int')
+    lambda{ e.eval(:x => 2, :y => '3') }.should raise_error CascadingException
+
+    # eval should not coerce numeric strings to Java Floats
+    e = ExprStub.new('x:int + y:float')
+    lambda{ e.eval(:x => 2, :y => '3') }.should raise_error CascadingException
+
+    # eval should not coerce numeric strings to Java Longs
+    e = ExprStub.new('x:long + y:int')
+    lambda{ e.eval(:x => '2', :y => 3) }.should raise_error CascadingException
+
+    # eval should not coerce floats to Java Longs
+    e = ExprStub.new('x:long + y:int')
+    lambda{ e.eval(:x => 2.0, :y => 3) }.should raise_error CascadingException
+
+    # eval should not coerce integers to Java Floats
+    e = ExprStub.new('x:int + y:float')
+    lambda{ e.eval(:x => 2, :y => 3) }.should raise_error CascadingException
+
+    e = ExprStub.new('x:float + y:int')
+    lambda{ e.eval(:x => 'blah', :y => 3) }.should raise_error CascadingException
+
+    e = ExprStub.new('x:long + y:int')
+    lambda{ e.eval(:x => [], :y => 3) }.should raise_error CascadingException
+
+    e = ExprStub.new('x:long + y:int')
+    lambda{ e.eval(:x => nil, :y => 3) }.should raise_error CascadingException
+  end
+
+  it 'should throw an exception for missing actual arguments' do
+    e = ExprStub.new('x:int + y:int')
+    lambda{ e.eval(:x => 2) }.should raise_error ExprArgException
+  end
+
+  it 'should ignore extraneous actual arguments' do
+    e = ExprStub.new('x:int + y:int')
+    result = e.eval(:x => 2, :y => 3, :z => 'unused')
+    result.should == 5
+  end
+
+  it 'should use default actual arguments to validate' do
+    e = ExprStub.new('x:int + y:int')
+    result = e.validate
+    result.should == 0
+
+    e = ExprStub.new('x:long + y:int')
+    result = e.validate
+    result.should == 0
+
+    e = ExprStub.new('x:double + y:int')
+    result = e.validate
+    result.should == 0.0
+
+    e = ExprStub.new('x:float + y:int')
+    result = e.validate
+    result.should == 0.0
+
+    e = ExprStub.new('x:bool && y:bool')
+    result = e.validate
+    result.should == false
+
+    e = ExprStub.new('x:int + y:string')
+    result = e.validate
+    result.should == '0null'
+
+    e = ExprStub.new('x:string + y:string')
+    result = e.validate
+    result.should == 'nullnull'
+  end
+
+  it 'should fail to validate these expressions with default actual arguments' do
+    e = ExprStub.new('x:string.indexOf("R") == -1')
+    lambda { e.validate }.should raise_error CascadingException
+
+    e = ExprStub.new('x:string.substring(0, 8)')
+    lambda { e.validate }.should raise_error CascadingException
+  end
+
+  it 'should allow overriding default actual arguments for validation' do
+    e = ExprStub.new('x:string.indexOf("R") == -1')
+    result = e.validate(:x => 'nothinghere')
+    result.should == true
+
+    e = ExprStub.new('x:string.substring(0, 8)')
+    result = e.validate(:x => 'atleast8chars')
+    result.should == 'atleast8'
+  end
+
+  it 'should allow overriding default actual arguments for validation via expr' do
+    expr('x:string.indexOf("R") == -1', :validate_with => { :x => 'nothinghere' })
+    expr('x:string.substring(0, 8)', :validate_with => { :x => 'atleast8chars' })
+  end
+
+  it 'should allow overriding default actual arguments for validation via filter' do
+    test_assembly do
+      filter :expression => 'line:string.indexOf("R") == -1', :validate_with => { :line => 'nothinghere' }
+      check_scope :values_fields => ['offset', 'line']
+    end
+  end
+
+  it 'should allow overriding default actual arguments for validation via where' do
+    test_assembly do
+      where 'line:string.equals("not_set") && "0".equals(offset:string)', :validate_with => { :line => 'nulls_rejected' }
+      check_scope :values_fields => ['offset', 'line']
+    end
+  end
+
+  it 'should allow disabling validation via expr' do
+    expr('x:string.indexOf("R") == -1', :validate => false)
+    expr('x:string.substring(0, 8)', :validate => false)
+  end
+
+  it 'should allow disabling validation via filter' do
+    test_assembly do
+      filter :expression => 'line:string.indexOf("R") == -1', :validate => false
+      check_scope :values_fields => ['offset', 'line']
+    end
+  end
+
+  it 'should allow disabling validation via where' do
+    test_assembly do
+      where 'line:string.indexOf("R") == -1', :validate => false
+      check_scope :values_fields => ['offset', 'line']
+    end
+  end
+
+  it 'should only allow floating point division by zero' do
+    e = ExprStub.new('x:float / y:float')
+    result = e.validate
+    result.nan?.should == true
+
+    e = ExprStub.new('x:double / y:double')
+    result = e.validate
+    result.nan?.should == true
+
+    # From: http://download.oracle.com/javase/6/docs/api/java/lang/ArithmeticException.html
+    # Thrown when an exceptional arithmetic condition has occurred. For
+    # example, an integer "divide by zero" throws an instance of this class.
+
+    e = ExprStub.new('x:long / y:long')
+    lambda { e.validate }.should raise_error CascadingException
+
+    e = ExprStub.new('x:int / y:int')
+    lambda { e.validate }.should raise_error CascadingException
+  end
+
+  it 'should catch missing fields in filter expressions' do
+    lambda do
+      test_assembly do
+        filter :expression => 'doesnotexist:int > offset:int'
+      check_scope :values_fields => ['offset', 'line', 'bar', 'foo']
+      end
+    end.should raise_error ExprArgException
+  end
+
+  it 'should catch missing fields in insert expressions' do
+    lambda do
+      test_assembly do
+        insert 'foo' => 1, 'bar' => expr('doesnotexist:int + offset:int')
+      end
+    end.should raise_error ExprArgException
+  end
 end

data/spec/jruby_version_spec.rb

@@ -0,0 +1,72 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+context Object do
+  it 'should definitely not do this' do
+    names = ['x', 'y'].to_java(java.lang.String)
+    types = [java.lang.Integer.java_class, java.lang.Integer.java_class].to_java(java.lang.Class)
+    evaluator = Java::OrgCodehausJanino::ExpressionEvaluator.new('x + y', java.lang.Comparable.java_class, names, types)
+
+    thrown = nil
+    exception = nil
+    begin
+      evaluator.evaluate([nil, nil].to_java)
+    rescue java.lang.IllegalArgumentException => iae
+      thrown = 'IllegalArgumentException'
+      exception = iae
+    rescue java.lang.reflect.InvocationTargetException => ite
+      thrown = 'InvocationTargetException'
+      exception = ite
+    end
+
+    # How can this be?  A nil exception?
+    thrown.should == 'InvocationTargetException'
+    exception.should be_nil
+  end
+
+  case JRUBY_VERSION
+  when '1.2.0'
+    it 'should handle Fixnum -> Long for ExprStub#eval' do
+      e = ExprStub.new('x:long + y:long')
+      result = e.eval(:x => 2, :y => 3)
+      result.should == 5
+    end
+
+    it 'should handle Fixnum -> Long for ExprStub#validate' do
+      e = ExprStub.new('x:long + y:long')
+      result = e.validate
+      result.should == 0
+    end
+  when '1.4.0'
+    # This test previously failed for 1.4.0 (it's duplicated in cascading_spec)
+    it 'should handle string and integer field names' do
+      f = fields(['a', 1, 'b', 2])
+      f.to_a.should == ['a', 1, 'b', 2]
+    end
+
+    it 'should handle Fixnum -> Integer for ExprStub#eval' do
+      e = ExprStub.new('x:int + y:int')
+      result = e.eval(:x => 2, :y => 3)
+      result.should == 5
+    end
+
+    it 'should handle Fixnum -> Integer for ExprStub#validate' do
+      e = ExprStub.new('x:int + y:int')
+      result = e.validate
+      result.should == 0
+    end
+  when '1.5.3'
+    it 'should handle Fixnum -> Integer for ExprStub#eval' do
+      e = ExprStub.new('x:int + y:int')
+      result = e.eval(:x => 2, :y => 3)
+      result.should == 5
+    end
+
+    it 'should handle Fixnum -> Integer for ExprStub#validate' do
+      e = ExprStub.new('x:int + y:int')
+      result = e.validate
+      result.should == 0
+    end
+  else
+    raise "cascading.jruby has not been tested with JRuby version #{JRUBY_VERSION}"
+  end
+end

data/spec/primary_key_spec.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
-describe Cascading::Scope do
+context Cascading::Scope do
   it 'should allow override of primary key' do
     test_assembly do
       split 'line', ['x', 'y'], :pattern => /,/

data/spec/scope_spec.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
-describe Cascading::Scope do
+context Cascading::Scope do
   it 'should match Cascading fields names from source tap scheme' do
     test_assembly do
       # Pass that uses our scope instead of all_fields

data/spec/spec_util.rb

@@ -171,7 +171,7 @@ def verify_assembly_output(assembly_name, params, &block)
 end
 
 def describe_job(job_file, &block)
-  describe Object do
+  context Object do
     before(:each) do
       @properties = cascading_properties
       # Must artificially fill ARGV to prevent errors when creating multi-taps

data/tasks/spec.rake

@@ -37,7 +37,7 @@ namespace :spec do
       t.rcov_opts = PROJ.rcov.opts + ['--exclude', 'spec']
     end
 
-    RCov::VerifyTask.new(:verify) do |t| 
+    RCov::VerifyTask.new(:verify) do |t|
       t.threshold = PROJ.rcov.threshold
       t.index_html = File.join(PROJ.rcov.dir, 'index.html')
       t.require_exact_threshold = PROJ.rcov.threshold_exact

metadata

@@ -1,137 +1,128 @@
 --- !ruby/object:Gem::Specification 
-name: cascading.jruby
-version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-    - 0
-    - 0
-    - 4
-  version: 0.0.4
-platform: ruby
-authors: 
-  - Matt Walker
-  - "Gr\xC3\xA9goire Marabout"
-autorequire: 
-bindir: bin
-cert_chain: []
-
-date: 2011-04-05 00:00:00 -05:00
-default_executable: 
-dependencies: []
-
-description: cascading.jruby is a small DSL above Cascading, written in JRuby
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - '>='
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
 email: mwalker@etsy.com
-executables: 
-  - make_job
-extensions: []
+cert_chain: []
 
+summary: A JRuby DSL for Cascading
+post_install_message: 
 extra_rdoc_files: 
-  - History.txt
-  - LICENSE.txt
-  - bin/make_job
-  - samples/data/data2.txt
-  - samples/data/data_join1.txt
-  - samples/data/data_join2.txt
-  - samples/data/data_join3.txt
-  - spec/resource/join_input.txt
-  - spec/resource/test_input.txt
-  - test/data/data1.txt
-  - test/data/data2.txt
-files: 
-  - HACKING.md
-  - History.txt
-  - LICENSE.txt
-  - README.md
-  - Rakefile
-  - bin/make_job
-  - lib/cascading.rb
-  - lib/cascading/assembly.rb
-  - lib/cascading/base.rb
-  - lib/cascading/cascade.rb
-  - lib/cascading/cascading.rb
-  - lib/cascading/cascading_exception.rb
-  - lib/cascading/expr_stub.rb
-  - lib/cascading/ext/array.rb
-  - lib/cascading/flow.rb
-  - lib/cascading/operations.rb
-  - lib/cascading/scope.rb
-  - samples/branch.rb
-  - samples/cascading.rb
-  - samples/copy.rb
-  - samples/data/data2.txt
-  - samples/data/data_join1.txt
-  - samples/data/data_join2.txt
-  - samples/data/data_join3.txt
-  - samples/join.rb
-  - samples/logwordcount.rb
-  - samples/project.rb
-  - samples/rename.rb
-  - samples/scorenames.rb
-  - samples/splitter.rb
-  - samples/union.rb
-  - spec/cascading_spec.rb
-  - spec/expr_spec.rb
-  - spec/primary_key_spec.rb
-  - spec/resource/join_input.txt
-  - spec/resource/test_input.txt
-  - spec/scope_spec.rb
-  - spec/spec.opts
-  - spec/spec_helper.rb
-  - spec/spec_util.rb
-  - src/cascading/jruby/Main.java
-  - src/cascading/jruby/runner.rb
-  - tags
-  - tasks/ann.rake
-  - tasks/ant.rake
-  - tasks/bones.rake
-  - tasks/gem.rake
-  - tasks/git.rake
-  - tasks/notes.rake
-  - tasks/post_load.rake
-  - tasks/rdoc.rake
-  - tasks/rubyforge.rake
-  - tasks/samples.rake
-  - tasks/setup.rb
-  - tasks/spec.rake
-  - tasks/svn.rake
-  - tasks/test.rake
-  - test/data/data1.txt
-  - test/data/data2.txt
-  - test/test_assembly.rb
-  - test/test_cascading.rb
-  - test/test_flow.rb
-has_rdoc: true
+- History.txt
+- LICENSE.txt
+- bin/make_job
+- samples/data/data2.txt
+- samples/data/data_join1.txt
+- samples/data/data_join2.txt
+- samples/data/data_join3.txt
+- spec/resource/join_input.txt
+- spec/resource/test_input.txt
+- test/data/data1.txt
+- test/data/data2.txt
 homepage: http://github.com/etsy/cascading.jruby
-licenses: []
-
-post_install_message: 
+signing_key: 
+name: cascading.jruby
 rdoc_options: 
-  - --main
-  - README.md
-require_paths: 
-  - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-          - 0
-        version: "0"
+- --main
+- README.md
+autorequire: 
+rubyforge_project: cascading.jruby
+executables: 
+- make_job
+description: cascading.jruby is a small DSL above Cascading, written in JRuby
+specification_version: 2
+default_executable: 
+files: 
+- HACKING.md
+- History.txt
+- LICENSE.txt
+- README.md
+- Rakefile
+- bin/make_job
+- lib/cascading.rb
+- lib/cascading/assembly.rb
+- lib/cascading/base.rb
+- lib/cascading/cascade.rb
+- lib/cascading/cascading.rb
+- lib/cascading/cascading_exception.rb
+- lib/cascading/expr_stub.rb
+- lib/cascading/ext/array.rb
+- lib/cascading/flow.rb
+- lib/cascading/operations.rb
+- lib/cascading/scope.rb
+- samples/branch.rb
+- samples/cascading.rb
+- samples/copy.rb
+- samples/data/data2.txt
+- samples/data/data_join1.txt
+- samples/data/data_join2.txt
+- samples/data/data_join3.txt
+- samples/join.rb
+- samples/logwordcount.rb
+- samples/project.rb
+- samples/rename.rb
+- samples/scorenames.rb
+- samples/splitter.rb
+- samples/union.rb
+- spec/cascading_spec.rb
+- spec/expr_spec.rb
+- spec/jruby_version_spec.rb
+- spec/primary_key_spec.rb
+- spec/resource/join_input.txt
+- spec/resource/test_input.txt
+- spec/scope_spec.rb
+- spec/spec.opts
+- spec/spec_helper.rb
+- spec/spec_util.rb
+- src/cascading/jruby/Main.java
+- src/cascading/jruby/runner.rb
+- tasks/ann.rake
+- tasks/ant.rake
+- tasks/bones.rake
+- tasks/gem.rake
+- tasks/git.rake
+- tasks/notes.rake
+- tasks/post_load.rake
+- tasks/rdoc.rake
+- tasks/rubyforge.rake
+- tasks/samples.rake
+- tasks/setup.rb
+- tasks/spec.rake
+- tasks/svn.rake
+- tasks/test.rake
+- test/data/data1.txt
+- test/data/data2.txt
+- test/test_assembly.rb
+- test/test_cascading.rb
+- test/test_flow.rb
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-          - 0
-        version: "0"
+  - - '>='
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+extensions: []
+
+rubygems_version: 1.3.1
 requirements: []
 
-rubyforge_project: cascading.jruby
-rubygems_version: 1.3.6
-signing_key: 
-specification_version: 3
-summary: A JRuby DSL for Cascading
+authors: 
+- Matt Walker
+- "Gr\xc3\xa9goire Marabout"
+date: 2011-08-22 04:00:00 +00:00
+platform: ruby
 test_files: 
-  - test/test_assembly.rb
-  - test/test_cascading.rb
-  - test/test_flow.rb
+- test/test_assembly.rb
+- test/test_cascading.rb
+- test/test_flow.rb
+version: !ruby/object:Gem::Version 
+  version: 0.0.5
+require_paths: 
+- lib
+dependencies: []
+
+bindir: bin
+has_rdoc: true