cascade-rb 0.2.3 → 0.3.0

data/lib/cascade/statistics.rb

@@ -1,5 +1,7 @@
-require "singleton"
-require "cascade/statistics_stores"
+# frozen_string_literal: true
+
+require 'singleton'
+require 'cascade/statistics_stores'
 
 module Cascade
   class Statistics

data/lib/cascade/statistics_stores.rb

@@ -1,3 +1,5 @@
-require "cascade/statistics_stores/abstract_store"
-require "cascade/statistics_stores/counter_store"
-require "cascade/statistics_stores/array_store"
+# frozen_string_literal: true
+
+require 'cascade/statistics_stores/abstract_store'
+require 'cascade/statistics_stores/counter_store'
+require 'cascade/statistics_stores/array_store'

data/lib/cascade/statistics_stores/abstract_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Cascade
   module StatisticsStores
     class AbstractStore

data/lib/cascade/statistics_stores/array_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Cascade
   module StatisticsStores
     class ArrayStore < AbstractStore

data/lib/cascade/statistics_stores/counter_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Cascade
   module StatisticsStores
     class CounterStore < AbstractStore

data/lib/cascade/version.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 module Cascade
   # current gem version
-  VERSION = "0.2.3"
+  VERSION = '0.3.0'
 end

data/spec/integration_spec.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Cascade do
+  let(:date_parser) { ->(value) { Date.parse(value) } }
+  let(:int_parser) { ->(value) { Integer(value) } }
+
+  class ExampleDateSaver
+    def initialize
+      @result = []
+    end
+
+    attr_reader :result
+
+    def call(row_description, _row_number)
+      @result << row_description.values
+    end
+  end
+
+  let(:data_provider) do
+    [
+      ['2000-01-01', '1000', 'uno'],
+      ['2001-01-01', '2000', 'dos'],
+      ['2002-01-01', '3000', 'tres']
+    ]
+  end
+
+  let(:columns_matching) do
+    Cascade::ColumnsMatching.new(content: {
+                                   date: :date,
+                                   points: :integer,
+                                   spanish: :string
+                                 })
+  end
+
+  let(:row_processor) do
+    Cascade::RowProcessor.new(
+      columns_matching: columns_matching,
+      ext_presenters: { date: date_parser, integer: int_parser }
+    )
+  end
+
+  let(:data_saver) { ExampleDateSaver.new }
+
+  let(:expected_result) do
+    [
+      [Date.new(2000, 1, 1), 1000, 'uno'],
+      [Date.new(2001, 1, 1), 2000, 'dos'],
+      [Date.new(2002, 1, 1), 3000, 'tres']
+    ]
+  end
+
+  it 'works with empty example' do
+    Cascade::DataParser.new(
+      data_provider: data_provider,
+      data_saver: ->(*_any) {}
+    ).call
+  end
+
+  it 'checks main cascade work-flow' do
+    Cascade::DataParser.new(
+      data_provider: data_provider,
+      row_processor: row_processor,
+      data_saver: data_saver
+    ).call
+
+    assert_equal expected_result, data_saver.result
+  end
+end

data/spec/lib/columns_matching_spec.rb

@@ -1,49 +1,41 @@
-require "spec_helper"
-require "cascade/columns_matching"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/columns_matching'
 
 describe Cascade::ColumnsMatching do
   def described_class
     Cascade::ColumnsMatching
   end
-  subject { described_class.new }
 
-  context "on settings file parsing" do
-    subject { described_class.new(filepath: "config/columns_match.yml") }
+  context 'on settings file parsing' do
+    subject { described_class.new(filepath: 'config/columns_match.yml') }
 
-    it "raise error if columns matching file doesnt contain mapping key" do
-      mock(YAML).load_file("config/columns_match.yml") { {} }
+    it "raise error if columns matching file doesn't contain mapping key" do
+      mock(YAML).load_file('config/columns_match.yml') { {} }
       assert_raises(Cascade::WrongMappingFormat) { subject }
     end
 
-    it "raise error if columns matching file doesnt contain any info" do
-      mock(YAML).load_file("config/columns_match.yml") { nil }
+    it "raise error if columns matching file doesn't contain any info" do
+      mock(YAML).load_file('config/columns_match.yml') { nil }
       assert_raises(Cascade::WrongMappingFormat) { subject }
     end
   end
 
-  context "after file parsed" do
-    before do
-      stub(YAML).load_file do
-        {
-          "mapping" => {
-            "name"  => "string",
-            "class" => "string"
-          }
-        }
-      end
-    end
+  context 'after file parsed' do
+    subject { described_class.new(content: { name: 'string' }) }
 
-    context "#supported_keys" do
+    context '#supported_keys' do
       it { subject.must_respond_to(:supported_keys) }
-      it "return array" do
+
+      it 'return array' do
         subject.supported_keys.must_be_kind_of Array
       end
     end
 
-    context "#column_type" do
-      it "return curresponding value for passed column value" do
-        assert_equal :string,
-          described_class.new(content: { name: "string" }).column_type(:name)
+    context '#column_type' do
+      it 'return curresponding value for passed column value' do
+        assert_equal :string, subject.column_type(:name)
       end
     end
   end

data/spec/lib/complex_fields/array_processor_spec.rb

@@ -1,15 +1,17 @@
-require "spec_helper"
-require "cascade/complex_fields/array_processor"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/complex_fields/array_processor'
 
 describe Cascade::ComplexFields::ArrayProcessor do
   def described_class
     Cascade::ComplexFields::ArrayProcessor
   end
 
-  let(:processor) { -> (value) { value + 1 } }
+  let(:processor) { ->(value) { value + 1 } }
   let(:subject) { described_class.new(processor) }
 
-  it "return processed array" do
+  it 'return processed array' do
     assert_equal subject.call([1, 2, 3]), [2, 3, 4]
   end
 end

data/spec/lib/complex_fields/boolean_spec.rb

@@ -1,5 +1,7 @@
-require "spec_helper"
-require "cascade/complex_fields/boolean"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/complex_fields/boolean'
 
 describe Cascade::ComplexFields::Boolean do
   def described_class
@@ -8,14 +10,14 @@ describe Cascade::ComplexFields::Boolean do
 
   let(:subject) { described_class.new }
 
-  it "return true value for values that seems like true" do
-    ["True",  "true",  "x",  "+",  true].each do |value|
+  it 'return true value for values that seems like true' do
+    ['True', 'true', 'x', '+', true].each do |value|
       assert subject.call(value)
     end
   end
 
-  it "return false value for values that cant be true" do
-    ["false", false, nil, "", "some value"].each do |value|
+  it 'return false value for values that cant be true' do
+    ['false', false, nil, '', 'some value'].each do |value|
       refute subject.call(value)
     end
   end

data/spec/lib/complex_fields/currency_spec.rb

@@ -1,5 +1,7 @@
-require "spec_helper"
-require "cascade/complex_fields/currency"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/complex_fields/currency'
 
 describe Cascade::ComplexFields::Currency do
   def described_class
@@ -8,18 +10,18 @@ describe Cascade::ComplexFields::Currency do
 
   subject { described_class.new }
 
-  describe "parse" do
+  describe 'parse' do
     it "return nil if input string isn't number" do
-      assert_nil subject.call("0o")
+      assert_nil subject.call('0o')
     end
 
-    it "prepare string to use it as bignum" do
-      assert_kind_of BigDecimal, subject.call("1 123 123 45")
-      assert_kind_of BigDecimal, subject.call("1 123, 123 45")
+    it 'prepare string to use it as bignum' do
+      assert_kind_of BigDecimal, subject.call('1 123 123 45')
+      assert_kind_of BigDecimal, subject.call('1 123, 123 45')
     end
 
-    it "return zero if field is empty" do
-      assert_nil subject.call("")
+    it 'return zero if field is empty' do
+      assert_nil subject.call('')
       assert_nil subject.call(nil)
     end
   end

data/spec/lib/concerns/statistics_collectible_spec.rb

@@ -1,15 +1,17 @@
-require "spec_helper"
-require "cascade/concerns/statistics_collectible"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/concerns/statistics_collectible'
 
 describe Cascade::StatisticsCollectible do
   class ExtendableClass; include Cascade::StatisticsCollectible; end
   subject { ExtendableClass.new }
 
-  it "defines helper for access to statics class" do
+  it 'defines helper for access to statics class' do
     assert_instance_of Cascade::Statistics, subject.statistics
   end
 
-  it "delegates register_action method to statistics" do
+  it 'delegates register_action method to statistics' do
     assert_respond_to subject, :register_action
   end
 end

data/spec/lib/data_parser_spec.rb

@@ -1,5 +1,7 @@
-require "spec_helper"
-require "cascade/data_parser"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/data_parser'
 
 describe Cascade::DataParser do
   def described_class
@@ -7,29 +9,30 @@ describe Cascade::DataParser do
   end
 
   class FakeDataProvider
-    def self.open(_)
+    def self.open(_any)
       [
-        ["Sally Whittaker", "2018", "McCarren House", "312",
-         "3.75", "France", "+", "123.123"],
-        ["Jeff Smith", "2018", "Prescott House", "17-D", "3.20",
-         "Austria", "45.12"]
+        ['Sally Whittaker', '2018', 'McCarren House', '312',
+         '3.75', 'France', '+', '123.123'],
+        ['Jeff Smith', '2018', 'Prescott House', '17-D', '3.20',
+         'Austria', '45.12']
       ]
     end
   end
 
-  let(:filename) { "spec/examples/data_test.txt" }
+  let(:filename) { 'spec/examples/data_test.txt' }
   let(:data_provider) { FakeDataProvider.open(filename) }
 
   before do
     @processor_calls_count = 0
     @data_saves_count = 0
     row_processor =  ->(_row) { @processor_calls_count += 1 }
-    data_saver    =  ->(*)   { @data_saves_count += 1 }
+    data_saver    =  ->(*) { @data_saves_count += 1 }
     @parser = described_class.new(row_processor: row_processor,
-      data_saver: data_saver, data_provider: data_provider)
+                                  data_saver: data_saver,
+                                  data_provider: data_provider)
   end
 
-  it "calls row processor for each file line" do
+  it 'calls row processor for each file line' do
     @parser.call
     assert_equal @processor_calls_count, 2
     assert_equal @data_saves_count, 2

data/spec/lib/error_handler_spec.rb

@@ -1,5 +1,7 @@
-require "spec_helper"
-require "cascade/error_handler"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/error_handler'
 
 describe Cascade::ErrorHandler do
   def described_class
@@ -14,27 +16,31 @@ describe Cascade::ErrorHandler do
   end
   let(:row) { Struct.new(:fields) }
 
-  subject { described_class.new(error_store: error_store) }
+  context 'when raise_parse_errors setting is false' do
+    subject { described_class.new(error_store: error_store) }
+
+    it 'catches handling exceptions and send info to error store' do
+      subject.with_errors_handling(row) { raise IndexError }
+      assert_includes @errors, [row, IndexError.to_s]
+    end
+  end
 
-  Cascade::ErrorHandler::HANDLING_EXCEPTIONS.each do |exception|
-    it "catch #{exception} and send info to error store" do
-      subject.with_errors_handling(row) { raise exception }
-      assert_includes @errors, [row, exception.to_s]
+  context 'when raise_parse_errors setting is true' do
+    subject do
+      described_class.new(error_store: error_store, raise_parse_errors: true)
     end
 
-    it "raises #{exception} if raise_parse_errors setting is true" do
-      described_class.stub(:raise_parse_errors, true) do
-        assert_raises(exception) do
-          subject.with_errors_handling(row) { raise exception }
-        end
+    it 'raises for handling exceptions' do
+      assert_raises(IndexError) do
+        subject.with_errors_handling(row) { raise IndexError }
       end
     end
   end
 
-  describe "DEFAULT_ERROR_STORE" do
-    it "create new array and push row with reason" do
+  describe 'DEFAULT_ERROR_STORE' do
+    it 'create new array and push row with reason' do
       result = Cascade::ErrorHandler::DEFAULT_ERROR_STORE.call(:row, :reason)
-      assert_includes result, [:row, "reason"]
+      assert_includes result, [:row, 'reason']
     end
   end
 end

data/spec/lib/exceptions/unknown_presenter_type_spec.rb

@@ -1,9 +1,11 @@
-require "spec_helper"
-require "cascade/exceptions/unknown_presenter_type"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/exceptions/unknown_presenter_type'
 
 describe Cascade::UnknownPresenterType do
   subject { Cascade::UnknownPresenterType.new }
-  it "exception raisable" do
+  it 'exception raisable' do
     assert_respond_to subject, :exception
   end
 end

data/spec/lib/exceptions/unsupported_component_spec.rb

@@ -1,19 +1,21 @@
-require "spec_helper"
-require "cascade/exceptions/unsupported_component"
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'cascade/exceptions/unsupported_component'
 
 describe Cascade::UnsupportedComponent do
   subject { Cascade::UnsupportedComponent.new }
-  it "exception raisable" do
+  it 'exception raisable' do
     assert_respond_to subject, :exception
   end
 
-  context "#message" do
-    it "uses passed message" do
-      subject = Cascade::UnsupportedComponent.new("custom_message")
-      assert_equal subject.message, "custom_message"
+  context '#message' do
+    it 'uses passed message' do
+      subject = Cascade::UnsupportedComponent.new('custom_message')
+      assert_equal subject.message, 'custom_message'
     end
 
-    it "uses default message if not passed" do
+    it 'uses default message if not passed' do
       assert_equal subject.message, Cascade::UnsupportedComponent::MESSAGE
     end
   end