carwow_rubocop 6.9.0 → 6.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2a4da2858ed109b02d01111b35e24184159d2d0c592855a4bc57bbd8d0d2f04
-  data.tar.gz: 8bf60cd532eae6c3a401eecb64f2460ba377c7573ba67657db2f792a1ac6b212
+  metadata.gz: 81c9278bdc99387df9c9a136d4a6048cf21435c6a760351b7c1be3a82a0df801
+  data.tar.gz: df963ba3013bb0fb3196a57580f06af6136eb7f89eea4f5966982da2a39ea2da
 SHA512:
-  metadata.gz: 57c7b0a76743efcafe2da17ad73254f484e83ae6d7ccd7b855f8b3f60648ff64fb83de0a63d091153b69b07e72f8df8121e2736ac88bb1d64319a5f64b6f9a23
-  data.tar.gz: 157af413e04a76aa595103680d403d846d3d9ef9018cf4b41c123a6fff97feb73e88fc55b3ebf057bd68b5cd2cc13254ecfcb6ace01d6d06e7b40f19b1166b44
+  metadata.gz: 8546625ac8e9267800cd53cda4614787ebd99abc8aa446ba5e86cdde53b2dfb780523386172e1b16eb534289ed5f9d7d7287d9af6817878d0c2cecd867057275
+  data.tar.gz: bdb3822f28558aa5a062282b09f6ceadb327dfae8bce7fe3363d4124ff3f34f5977ff1f48657798b7732650edd77245236b5144e41f96f723f1a5f72d3e7d0bd

data/.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2.1
 
 orbs:
   buildevents: honeycombio/buildevents@0.5
-  carwow: carwow/carwow-orb@0.6.0
+  carwow: carwow/carwow-orb@0.8
 
 executors:
   ruby:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    carwow_rubocop (6.9.0)
+    carwow_rubocop (6.12.0)
       rubocop (>= 1.75)
       rubocop-factory_bot
       rubocop-performance
@@ -17,7 +17,7 @@ GEM
     language_server-protocol (3.17.0.6)
     lint_roller (1.1.0)
     method_source (1.1.0)
-    parallel (2.1.0)
+    parallel (1.28.0)
     parser (3.3.12.0)
       ast (~> 2.4.1)
       racc

data/config/rubocop-carwow.yml

@@ -32,6 +32,10 @@ Carwow/NoStubbingBusinessEvent:
     - "**/*_spec.rb"
     - "**/spec/**/*"
 
+Carwow/NoStubbingHoneycombExtraData:
+  Enabled: true
+  Include: *spec_only
+
 Carwow/AddColumnWithComment:
   Enabled: true
   Include: &migrations_only
@@ -53,3 +57,6 @@ Carwow/ProductAreaRequired:
     - "app/jobs/**/*.rb"
   Exclude:
     - "**/concerns/**/*.rb"
+
+Carwow/NoAbort:
+  Enabled: true

data/lib/rubocop/carwow/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module Carwow
-    VERSION = '6.9.0'.freeze
+    VERSION = '6.12.0'.freeze
   end
 end

data/lib/rubocop/cop/carwow/jobs_queue_name_style.rb

@@ -24,6 +24,11 @@ module RuboCop
       #     queue_as :with_symbol
       #   end
       #
+      #   # bad - literals returned from a block are checked too
+      #   class Bad < ApplicationJob
+      #     queue_as { urgent? ? :with_symbol : "with_string" }
+      #   end
+      #
       #
       class JobsQueueNameStyle < ::RuboCop::Cop::Base
         extend AutoCorrector
@@ -42,27 +47,49 @@ module RuboCop
         # optimization: don't call `on_send` unless the method name is in this list
         RESTRICT_ON_SEND = %i[queue_as].freeze
         def on_send(node)
-          _, _queue_as, queue_name = *node
+          queue_names(node).each do |queue_name|
+            next if preferred_style?(queue_name)
 
-          return if prefer_symbol? && queue_name.sym_type?
-          return if prefer_string? && queue_name.str_type?
+            add_offense(queue_name, message: (prefer_symbol? ? MSG : MSG_STRING)) do |corrector|
+              content, _other = *queue_name
+              fix = prefer_symbol? ? ":#{content}" : content.to_s.inspect
 
-          add_offense(queue_name, message: (prefer_symbol? ? MSG : MSG_STRING)) do |corrector|
-            content, _other = *queue_name
-            fix = prefer_symbol? ? ":#{content}" : content.to_s.inspect
-
-            corrector.replace(queue_name, fix)
+              corrector.replace(queue_name, fix)
+            end
           end
         end
 
         private
 
-        def prefer_symbol?
-          !cop_config.fetch('QueueNameAs', 'Symbol').casecmp('string').zero?
+        def queue_names(node)
+          return [node.first_argument].compact unless node.block_node
+
+          # The queue is computed at runtime, so only the literals the block can return are checked.
+          possible_return_values(node.block_node.body).select { |value| value&.type?(:sym, :str) }
         end
 
-        def prefer_string?
-          !prefer_symbol?
+        def possible_return_values(node)
+          return [node] unless node
+
+          case node.type
+          when :begin then possible_return_values(node.children.last)
+          when :if then [node.if_branch, node.else_branch].flat_map { |branch| possible_return_values(branch) }
+          when :case then possible_case_return_values(node)
+          else [node]
+          end
+        end
+
+        def possible_case_return_values(node)
+          branches = node.when_branches.map(&:body) + [node.else_branch]
+          branches.flat_map { |branch| possible_return_values(branch) }
+        end
+
+        def preferred_style?(queue_name)
+          prefer_symbol? ? queue_name.sym_type? : queue_name.str_type?
+        end
+
+        def prefer_symbol?
+          !cop_config.fetch('QueueNameAs', 'Symbol').casecmp('string').zero?
         end
       end
     end

data/lib/rubocop/cop/carwow/no_abort.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Carwow
+      # Don't call `abort`. It raises `SystemExit`, which RSpec does not rescue, so when it
+      # escapes an example the whole process exits. Under a parallel runner the worker dies
+      # and its remaining spec files silently never run, while the suite reports 0 failures.
+      #
+      # @example
+      #   # bad
+      #   abort 'Nothing to do' if dealers.empty?
+      #
+      #   # good - in a rake task
+      #   next puts('Nothing to do') if dealers.empty?
+      #
+      #   # good
+      #   raise ArgumentError, 'Nothing to do' if dealers.empty?
+      #
+      class NoAbort < ::RuboCop::Cop::Base
+        MSG = "Don't use `abort`. It raises `SystemExit`, which RSpec does not rescue, so a spec that " \
+              'reaches it kills the whole worker and its remaining spec files never run. Return early ' \
+              '(`next puts(...)` in a rake task) or raise an error instead.'
+
+        RESTRICT_ON_SEND = %i[abort].freeze
+
+        def_node_matcher :kernel_abort?, <<~PATTERN
+          (send {nil? (const {nil? cbase} :Kernel)} :abort ...)
+        PATTERN
+
+        def on_send(node)
+          add_offense(node) if kernel_abort?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/carwow/no_stubbing_honeycomb_extra_data.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Carwow
+      class NoStubbingHoneycombExtraData < ::RuboCop::Cop::Base
+        MSG = "Don't stub or spy on `append_extra_honeycomb_data`. Other code (ActiveSupport::Notifications " \
+              'subscribers, product area tagging, Faraday middleware) appends to the same store, so expectations ' \
+              'on individual calls break when calls are split, merged or reordered. Do the work, then assert ' \
+              "on the data instead: `expect('some.key' => value).to have_been_appended_to_honeycomb_event`, " \
+              "or `expect { perform }.to append_to_honeycomb_event('some.key' => value)` to only check what " \
+              'the block appended. Both come from `CarwowCore::Spec::HoneycombHelper` in `carwow_core/spec`.'
+
+        RESTRICT_ON_SEND = %i[receive have_received receive_messages].freeze
+
+        def_node_matcher :stubs_append?, <<~PATTERN
+          {
+            (send nil? {:receive :have_received} {(sym :append_extra_honeycomb_data) (str "append_extra_honeycomb_data")})
+            (send nil? :receive_messages (hash <(pair (sym :append_extra_honeycomb_data) _) ...>))
+          }
+        PATTERN
+
+        def on_send(node)
+          add_offense(node) if stubs_append?(node)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: carwow_rubocop
 version: !ruby/object:Gem::Version
-  version: 6.9.0
+  version: 6.12.0
 platform: ruby
 authors:
 - carwow Developers
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-08-13 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -163,8 +162,10 @@ files:
 - lib/rubocop/cop/carwow/jobs.rb
 - lib/rubocop/cop/carwow/jobs_must_define_queue.rb
 - lib/rubocop/cop/carwow/jobs_queue_name_style.rb
+- lib/rubocop/cop/carwow/no_abort.rb
 - lib/rubocop/cop/carwow/no_change_matcher_with_browser_action.rb
 - lib/rubocop/cop/carwow/no_stubbing_business_event.rb
+- lib/rubocop/cop/carwow/no_stubbing_honeycomb_extra_data.rb
 - lib/rubocop/cop/carwow/no_vehicle_brand_model_sideload.rb
 - lib/rubocop/cop/carwow/product_area_required.rb
 homepage: https://github.com/carwow/carwow_rubocop
@@ -173,7 +174,6 @@ licenses:
 metadata:
   allowed_push_host: https://rubygems.org
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -188,8 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.20
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: carwow's rubocop configuration
 test_files: []