carwow_rubocop 6.8.0 → 6.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ba532ee22497e6dad682fcd4d4c8f452faf929df1ce5284e3fb5b2a1d3e5ab8
-  data.tar.gz: b54f7cc75cf53f47012ffde9f5253c06c33cc959fe6f38c7aed526aff30f990c
+  metadata.gz: 978ba9d52dc3a0f7c586dab02666847b3e7ac2bcc62990909b4ecab964e794d8
+  data.tar.gz: 35c9f5b58b396765fef73fa76e622ce28029843a96fc25f6f434897a9333cdcd
 SHA512:
-  metadata.gz: 7f6d34e7a2768754b1b6171aa09dba55b2a3eff404bc93d6039794630f9440c04304615de5ade41d82e58dcefa8f6ff98396053b68a3dee5da6e104746f49084
-  data.tar.gz: 47a4d2cfd627a6fda855df105eb4e6ccc8b246e602badaf823f253c9ddf3952aa6deca294c90c85e9dd1dc3eb1284846291880663dbce6bead17ffb187fa518d
+  metadata.gz: 51ca0f3638fd002ef701414af166ff97f63ab65f28031e385130e3813721b534ef88e75ecb3b36988d303c040a0df710552d2e210b4b242387df97a10dae2f43
+  data.tar.gz: d4a8e1e9941469ac1a1a3f88a803ddcf38c2f8992f1aefd14a0ffdb97ceda74af045de2717c49e196c072fbedc162779014457ac14ecd0eb8374c04f575d924e

data/Gemfile.lock

@@ -1,11 +1,11 @@
 PATH
   remote: .
   specs:
-    carwow_rubocop (6.8.0)
+    carwow_rubocop (6.11.0)
       rubocop (>= 1.75)
       rubocop-factory_bot
       rubocop-performance
-      rubocop-rspec (>= 3.2, < 3.6)
+      rubocop-rspec (~> 3.2)
 
 GEM
   remote: https://rubygems.org/
@@ -13,22 +13,22 @@ GEM
     ast (2.4.3)
     coderay (1.1.3)
     diff-lcs (1.5.1)
-    json (2.10.2)
-    language_server-protocol (3.17.0.4)
+    json (2.21.2)
+    language_server-protocol (3.17.0.6)
     lint_roller (1.1.0)
     method_source (1.1.0)
-    parallel (1.26.3)
-    parser (3.3.7.4)
+    parallel (2.1.0)
+    parser (3.3.12.0)
       ast (~> 2.4.1)
       racc
-    prism (1.4.0)
+    prism (1.9.0)
     pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.2.1)
-    regexp_parser (2.10.0)
+    regexp_parser (2.12.0)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -42,20 +42,20 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.1)
-    rubocop (1.75.2)
+    rubocop (1.89.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
-      parallel (~> 1.10)
+      parallel (>= 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.44.0, < 2.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.44.0)
+    rubocop-ast (1.50.0)
       parser (>= 3.3.7.2)
-      prism (~> 1.4)
+      prism (~> 1.7)
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
@@ -63,13 +63,14 @@ GEM
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rspec (3.5.0)
+    rubocop-rspec (3.10.2)
       lint_roller (~> 1.1)
-      rubocop (~> 1.72, >= 1.72.1)
+      regexp_parser (>= 2.0)
+      rubocop (~> 1.86, >= 1.86.2)
     ruby-progressbar (1.13.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.2.0)
 
 PLATFORMS
   ruby

data/carwow_rubocop.gemspec

@@ -14,12 +14,12 @@ Gem::Specification.new do |spec|
   spec.homepage              = 'https://github.com/carwow/carwow_rubocop'
   spec.license               = 'MIT'
 
-  if spec.respond_to?(:metadata)
-    spec.metadata['allowed_push_host'] = 'https://rubygems.org'
-  else
-    raise 'RubyGems 2.0 or newer is required to protect against ' \
-          'public gem pushes.'
-  end
+  raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.' unless spec.respond_to?(:metadata)
+
+  spec.metadata = {
+    'allowed_push_host' => 'https://rubygems.org',
+    'rubygems_mfa_required' => 'true'
+  }
 
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
@@ -35,9 +35,6 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'rubocop', '>= 1.75'
   spec.add_dependency 'rubocop-performance'
-  spec.add_dependency 'rubocop-rspec', '>= 3.2', '< 3.6'
+  spec.add_dependency 'rubocop-rspec', '~> 3.2'
   spec.add_dependency 'rubocop-factory_bot'
-  spec.metadata = {
-    'rubygems_mfa_required' => 'true'
-  }
 end

data/config/rubocop-carwow.yml

@@ -32,6 +32,10 @@ Carwow/NoStubbingBusinessEvent:
     - "**/*_spec.rb"
     - "**/spec/**/*"
 
+Carwow/NoStubbingHoneycombExtraData:
+  Enabled: true
+  Include: *spec_only
+
 Carwow/AddColumnWithComment:
   Enabled: true
   Include: &migrations_only

data/lib/rubocop/carwow/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module Carwow
-    VERSION = '6.8.0'.freeze
+    VERSION = '6.11.0'.freeze
   end
 end

data/lib/rubocop/cop/carwow/jobs_queue_name_style.rb

@@ -24,6 +24,11 @@ module RuboCop
       #     queue_as :with_symbol
       #   end
       #
+      #   # bad - literals returned from a block are checked too
+      #   class Bad < ApplicationJob
+      #     queue_as { urgent? ? :with_symbol : "with_string" }
+      #   end
+      #
       #
       class JobsQueueNameStyle < ::RuboCop::Cop::Base
         extend AutoCorrector
@@ -42,27 +47,49 @@ module RuboCop
         # optimization: don't call `on_send` unless the method name is in this list
         RESTRICT_ON_SEND = %i[queue_as].freeze
         def on_send(node)
-          _, _queue_as, queue_name = *node
+          queue_names(node).each do |queue_name|
+            next if preferred_style?(queue_name)
 
-          return if prefer_symbol? && queue_name.sym_type?
-          return if prefer_string? && queue_name.str_type?
+            add_offense(queue_name, message: (prefer_symbol? ? MSG : MSG_STRING)) do |corrector|
+              content, _other = *queue_name
+              fix = prefer_symbol? ? ":#{content}" : content.to_s.inspect
 
-          add_offense(queue_name, message: (prefer_symbol? ? MSG : MSG_STRING)) do |corrector|
-            content, _other = *queue_name
-            fix = prefer_symbol? ? ":#{content}" : content.to_s.inspect
-
-            corrector.replace(queue_name, fix)
+              corrector.replace(queue_name, fix)
+            end
           end
         end
 
         private
 
-        def prefer_symbol?
-          !cop_config.fetch('QueueNameAs', 'Symbol').casecmp('string').zero?
+        def queue_names(node)
+          return [node.first_argument].compact unless node.block_node
+
+          # The queue is computed at runtime, so only the literals the block can return are checked.
+          possible_return_values(node.block_node.body).select { |value| value&.type?(:sym, :str) }
         end
 
-        def prefer_string?
-          !prefer_symbol?
+        def possible_return_values(node)
+          return [node] unless node
+
+          case node.type
+          when :begin then possible_return_values(node.children.last)
+          when :if then [node.if_branch, node.else_branch].flat_map { |branch| possible_return_values(branch) }
+          when :case then possible_case_return_values(node)
+          else [node]
+          end
+        end
+
+        def possible_case_return_values(node)
+          branches = node.when_branches.map(&:body) + [node.else_branch]
+          branches.flat_map { |branch| possible_return_values(branch) }
+        end
+
+        def preferred_style?(queue_name)
+          prefer_symbol? ? queue_name.sym_type? : queue_name.str_type?
+        end
+
+        def prefer_symbol?
+          !cop_config.fetch('QueueNameAs', 'Symbol').casecmp('string').zero?
         end
       end
     end

data/lib/rubocop/cop/carwow/no_stubbing_honeycomb_extra_data.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Carwow
+      class NoStubbingHoneycombExtraData < ::RuboCop::Cop::Base
+        MSG = "Don't stub or spy on `append_extra_honeycomb_data`. Other code (ActiveSupport::Notifications " \
+              'subscribers, product area tagging, Faraday middleware) appends to the same store, so expectations ' \
+              'on individual calls break when calls are split, merged or reordered. Do the work, then assert ' \
+              "on the data instead: `expect('some.key' => value).to have_been_appended_to_honeycomb_event`, " \
+              "or `expect { perform }.to append_to_honeycomb_event('some.key' => value)` to only check what " \
+              'the block appended. Both come from `CarwowCore::Spec::HoneycombHelper` in `carwow_core/spec`.'
+
+        RESTRICT_ON_SEND = %i[receive have_received receive_messages].freeze
+
+        def_node_matcher :stubs_append?, <<~PATTERN
+          {
+            (send nil? {:receive :have_received} {(sym :append_extra_honeycomb_data) (str "append_extra_honeycomb_data")})
+            (send nil? :receive_messages (hash <(pair (sym :append_extra_honeycomb_data) _) ...>))
+          }
+        PATTERN
+
+        def on_send(node)
+          add_offense(node) if stubs_append?(node)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: carwow_rubocop
 version: !ruby/object:Gem::Version
-  version: 6.8.0
+  version: 6.11.0
 platform: ruby
 authors:
 - carwow Developers
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-08-12 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -98,22 +97,16 @@ dependencies:
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.6'
 - !ruby/object:Gem::Dependency
   name: rubocop-factory_bot
   requirement: !ruby/object:Gem::Requirement
@@ -171,14 +164,15 @@ files:
 - lib/rubocop/cop/carwow/jobs_queue_name_style.rb
 - lib/rubocop/cop/carwow/no_change_matcher_with_browser_action.rb
 - lib/rubocop/cop/carwow/no_stubbing_business_event.rb
+- lib/rubocop/cop/carwow/no_stubbing_honeycomb_extra_data.rb
 - lib/rubocop/cop/carwow/no_vehicle_brand_model_sideload.rb
 - lib/rubocop/cop/carwow/product_area_required.rb
 homepage: https://github.com/carwow/carwow_rubocop
 licenses:
 - MIT
 metadata:
+  allowed_push_host: https://rubygems.org
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -193,8 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.20
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: carwow's rubocop configuration
 test_files: []