RubyGems - carwow_rubocop - Versions diffs - 6.4.0 → 6.7.0 - Mend

carwow_rubocop 6.4.0 → 6.7.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (8) hide show

checksums.yaml +4 -4
data/Gemfile.lock +1 -1
data/config/default.yml +1 -0
data/config/rubocop-carwow.yml +9 -0
data/lib/rubocop/carwow/version.rb +1 -1
data/lib/rubocop/cop/carwow/no_change_matcher_with_browser_action.rb +90 -0
data/lib/rubocop/cop/carwow/no_vehicle_brand_model_sideload.rb +58 -0
metadata +8 -3

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bab9089484b0743c7fd6f25a35d667677321e6041b4dd0e621dfbf880110b2b1
-  data.tar.gz: 7296b387885978bc627d7284a10872f8a777bd6420ef533e569990c8daa891e6
+  metadata.gz: e3188042457455f9b00b2eba182c978d7687a7324c02bf2df68dd72a353e5a72
+  data.tar.gz: 15b8d392add3a85e05b87a6acb705d3c1a8cd54f906d7021a5c5a854387a863a
 SHA512:
-  metadata.gz: afaaa806525c1b1d124ecaa2df2ad2c6a874ef10f44bc809b172f64f1a67a0b2980b39a6f46ded6276d3a7e8cbcc85ee2d5d939f0827794cf14a67e7a4403dd3
-  data.tar.gz: 0b315d1c176472f63c27c0c0c1f923f3a8fc03b694b869c351533bbcbd7b7f4489007b034182173a1821fda281782951444d4f037a06dc98dcafd54d6d57bd6d
+  metadata.gz: e156ae2a9536b74791994e18aa3e708c9dc083b6018613e696fb564bfb8b0b7aab64a4611b97ab7d9b8149942a975f6846e6a789c4cfa8d8debe10a2e45b8f74
+  data.tar.gz: 7853d1d241b1d1be66719736a202bfb83a68ebb7677e04b5b4775113c29225a233671cb002b98b5e13e007d50b92b9b89ee5be9eaf0acaf5c8c8e9156c50095d

data/Gemfile.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    carwow_rubocop (6.4.0)
+    carwow_rubocop (6.7.0)
       rubocop (>= 1.75)
       rubocop-factory_bot
       rubocop-performance

data/config/default.yml CHANGED Viewed

@@ -20,6 +20,7 @@ AllCops:
     - 'public/**/*'
     - 'tmp/**/*'
     - 'vendor/**/*'
+  SuggestExtensions: false
 inherit_from:
   - './rubocop-bundler.yml'

data/config/rubocop-carwow.yml CHANGED Viewed

@@ -36,3 +36,12 @@ Carwow/AddColumnWithComment:
   Enabled: true
   Include: &migrations_only
     - "**/db/migrate/**/*.rb"
+Carwow/NoVehicleBrandModelSideload:
+  Enabled: true
+Carwow/NoChangeMatcherWithBrowserAction:
+  Enabled: true
+  Include:
+    - "**/*_spec.rb"
+    - "**/spec/**/*"

data/lib/rubocop/carwow/version.rb CHANGED Viewed

@@ -1,5 +1,5 @@
 module RuboCop
   module Carwow
-    VERSION = '6.4.0'.freeze
+    VERSION = '6.7.0'.freeze
   end
 end

data/lib/rubocop/cop/carwow/no_change_matcher_with_browser_action.rb ADDED Viewed

@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+module RuboCop
+  module Cop
+    module Carwow
+      # Detects the use of `expect { browser_action }.to change { db_access }`
+      # in feature/system specs. This pattern is racy because `change{}` takes
+      # DB snapshots before and after the block with no guarantee the browser
+      # has finished processing the action.
+      #
+      # @example Bad
+      #   expect { submit }.not_to(change { listing.reload.state })
+      #   expect { click_button('Save') }.to change { User.count }.by(1)
+      #
+      # @example Good
+      #   submit
+      #   expect(page).to have_content('Success')
+      #   expect(listing.reload.state).to eq('complete')
+      #
+      #   click_button('Save')
+      #   expect(page).to have_current_path(success_path)
+      #   expect(User.count).to eq(2)
+      #
+      class NoChangeMatcherWithBrowserAction < Base
+        MSG = 'Avoid wrapping Capybara browser actions in `expect { }.to change { }`. ' \
+              'The DB snapshot races the async browser. Instead: call the action, ' \
+              'wait with `expect(page).to have_*`, then assert the DB state.'
+        CAPYBARA_ACTIONS = %i[
+          visit
+          click_button click_link click_on click
+          fill_in choose check uncheck select attach_file
+          find find_field find_button find_by_id find_link
+          within within_frame within_window
+          execute_script evaluate_script
+          scroll_to scroll_by
+          hover drag_to drop
+          dismiss_confirm accept_confirm dismiss_prompt accept_prompt
+          submit
+        ].to_set.freeze
+        # AST shape for `expect { ... }.to change { ... }`
+        # (possibly chained with .by / .by_at_least etc., which wraps the whole thing)
+        #
+        # The `.to`/`.not_to` send node:
+        #   (send
+        #     (block (send nil :expect) (args) <body>)   <- expect { body }
+        #     {:to :not_to :to_not}
+        #     {
+        #       (block (send nil :change) (args) _)      <- change { ... }
+        #       (send (block (send nil :change) ...) _)  <- change { }.by(n)
+        #     }
+        #   )
+        #
+        # We also handle the parenthesised form: .not_to(change { ... })
+        # which produces identical AST.
+        def_node_matcher :expect_to_change?, <<~PATTERN
+          (send
+            (block
+              (send nil? :expect)
+              (args)
+              ...)
+            {:to :not_to :to_not}
+            {
+              (block (send nil? :change) ...)
+              (send (block (send nil? :change) ...) ...)
+            }
+          )
+        PATTERN
+        def on_send(node)
+          return unless expect_to_change?(node)
+          expect_block = node.receiver
+          return unless block_contains_capybara_action?(expect_block)
+          add_offense(node)
+        end
+        private
+        def block_contains_capybara_action?(block_node)
+          block_node.each_descendant(:send).any? do |send_node|
+            CAPYBARA_ACTIONS.include?(send_node.method_name)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/carwow/no_vehicle_brand_model_sideload.rb ADDED Viewed

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+module RuboCop
+  module Cop
+    module Carwow
+      class NoVehicleBrandModelSideload < Base
+        MSG = 'Do not sideload vehicle brand/model with includes.' \
+              'Request brand/model via extra_fields(vehicles: ...).'
+        RESTRICT_ON_SEND = %i[includes].freeze
+        DEAL_CONST = 'DealsServiceApiClient::Deal'
+        VEHICLE_CONST = 'DealsServiceApiClient::Vehicle'
+        def_node_matcher :brand_or_model_sym?, <<~PATTERN
+          (sym {:brand :model})
+        PATTERN
+        def_node_matcher :vehicle_with_brand_or_model?, <<~PATTERN
+          (pair (sym :vehicle) (array <#brand_or_model_sym? ...>))
+        PATTERN
+        def on_send(node)
+          offending_sideloads(node).each { |sideload| add_offense(sideload) }
+        end
+        private
+        def offending_sideloads(node)
+          case root_receiver_const(node.receiver)
+          when DEAL_CONST then deal_offenses(node.arguments)
+          when VEHICLE_CONST then vehicle_offenses(node.arguments)
+          else []
+          end
+        end
+        def deal_offenses(arguments)
+          arguments.flat_map do |arg|
+            next [] unless arg.hash_type?
+            arg.pairs.filter_map { |pair| pair.value if vehicle_with_brand_or_model?(pair) }
+          end
+        end
+        def vehicle_offenses(arguments)
+          arguments.select { |arg| brand_or_model_sym?(arg) }
+        end
+        def root_receiver_const(node)
+          return unless node
+          return node.const_name if node.const_type?
+          root_receiver_const(node.receiver) if node.send_type?
+        end
+      end
+    end
+  end
+end

metadata CHANGED Viewed

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: carwow_rubocop
 version: !ruby/object:Gem::Version
-  version: 6.4.0
+  version: 6.7.0
 platform: ruby
 authors:
 - carwow Developers
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-03-16 00:00:00.000000000 Z
+date: 2026-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -168,12 +169,15 @@ files:
 - lib/rubocop/cop/carwow/jobs.rb
 - lib/rubocop/cop/carwow/jobs_must_define_queue.rb
 - lib/rubocop/cop/carwow/jobs_queue_name_style.rb
+- lib/rubocop/cop/carwow/no_change_matcher_with_browser_action.rb
 - lib/rubocop/cop/carwow/no_stubbing_business_event.rb
+- lib/rubocop/cop/carwow/no_vehicle_brand_model_sideload.rb
 homepage: https://github.com/carwow/carwow_rubocop
 licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -188,7 +192,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: carwow's rubocop configuration
 test_files: []