carwow_rubocop 6.3.0 → 6.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 155060a8f6d990d618687a7c78f42c43c9cf039f53ab41fff623a1803b2995ec
-  data.tar.gz: e4d0cf349f5d5b913ab121ec888ab42f60dc985a08f4502fcd3b0e6184b9753c
+  metadata.gz: 3e153a088c0b69fa290062f7af76614067043033ccc9dc5cad5e96253b5c85bf
+  data.tar.gz: 02bb3cb5fef08391e34a518a6722b1fc23672784be9f62a32b54bea54943c3ea
 SHA512:
-  metadata.gz: 2858d9cf05878f208ecf351e5def3ff65f06f9d4181eae139ff770848210a505b5b3b720b0412c32ffd678954fb283d4c2be2e9f67ccc53869e4a78ea339580c
-  data.tar.gz: 5ac22f55117d6b77749338a70b941e0df2f5a4da889d1a342e94086724e2d47f9aaffe40c6bb8a9427fc36fafcdaaa8023aeb99bf4dc7293fbdae305883e20dc
+  metadata.gz: 9a991a2a692417cd5833058df9de060471684ecd0a59e2700438a1c2655bbc624884ae88d200174ec4bdf8780164ec2755e28b508fe73c981abe5986824749f4
+  data.tar.gz: 9c0c9b783c7288a0ed8f6fc0e7dd70b49116ff96bca7007e38874a77e3e1667f7e587033daf2c595d550646b6c75ca0ea95592b7bf31cb213fc4e3823362c506

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    carwow_rubocop (6.3.0)
+    carwow_rubocop (6.6.0)
       rubocop (>= 1.75)
       rubocop-factory_bot
       rubocop-performance

data/config/default.yml

@@ -20,6 +20,7 @@ AllCops:
     - 'public/**/*'
     - 'tmp/**/*'
     - 'vendor/**/*'
+  SuggestExtensions: false
 
 inherit_from:
   - './rubocop-bundler.yml'

data/config/rubocop-carwow.yml

@@ -36,3 +36,6 @@ Carwow/AddColumnWithComment:
   Enabled: true
   Include: &migrations_only
     - "**/db/migrate/**/*.rb"
+
+Carwow/NoVehicleBrandModelSideload:
+  Enabled: true

data/config/rubocop-style.yml

@@ -1,6 +1,9 @@
 Style/AsciiComments:
   Enabled: false
 
+Style/HashSyntax:
+  EnforcedShorthandSyntax: always
+
 Style/Documentation:
   Enabled: false
 

data/lib/rubocop/carwow/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module Carwow
-    VERSION = '6.3.0'.freeze
+    VERSION = '6.6.0'.freeze
   end
 end

data/lib/rubocop/cop/carwow/no_vehicle_brand_model_sideload.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Carwow
+      class NoVehicleBrandModelSideload < Base
+        MSG = 'Do not sideload vehicle brand/model with includes.' \
+              'Request brand/model via extra_fields(vehicles: ...).'
+
+        RESTRICT_ON_SEND = %i[includes].freeze
+
+        DEAL_CONST = 'DealsServiceApiClient::Deal'
+        VEHICLE_CONST = 'DealsServiceApiClient::Vehicle'
+
+        def_node_matcher :brand_or_model_sym?, <<~PATTERN
+          (sym {:brand :model})
+        PATTERN
+
+        def_node_matcher :vehicle_with_brand_or_model?, <<~PATTERN
+          (pair (sym :vehicle) (array <#brand_or_model_sym? ...>))
+        PATTERN
+
+        def on_send(node)
+          offending_sideloads(node).each { |sideload| add_offense(sideload) }
+        end
+
+        private
+
+        def offending_sideloads(node)
+          case root_receiver_const(node.receiver)
+          when DEAL_CONST then deal_offenses(node.arguments)
+          when VEHICLE_CONST then vehicle_offenses(node.arguments)
+          else []
+          end
+        end
+
+        def deal_offenses(arguments)
+          arguments.flat_map do |arg|
+            next [] unless arg.hash_type?
+
+            arg.pairs.filter_map { |pair| pair.value if vehicle_with_brand_or_model?(pair) }
+          end
+        end
+
+        def vehicle_offenses(arguments)
+          arguments.select { |arg| brand_or_model_sym?(arg) }
+        end
+
+        def root_receiver_const(node)
+          return unless node
+          return node.const_name if node.const_type?
+
+          root_receiver_const(node.receiver) if node.send_type?
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: carwow_rubocop
 version: !ruby/object:Gem::Version
-  version: 6.3.0
+  version: 6.6.0
 platform: ruby
 authors:
 - carwow Developers
-autorequire: 
 bindir: exe
 cert_chain: []
-date: 2025-05-12 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -170,12 +169,12 @@ files:
 - lib/rubocop/cop/carwow/jobs_must_define_queue.rb
 - lib/rubocop/cop/carwow/jobs_queue_name_style.rb
 - lib/rubocop/cop/carwow/no_stubbing_business_event.rb
+- lib/rubocop/cop/carwow/no_vehicle_brand_model_sideload.rb
 homepage: https://github.com/carwow/carwow_rubocop
 licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -190,8 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.19
-signing_key: 
+rubygems_version: 4.0.9
 specification_version: 4
 summary: carwow's rubocop configuration
 test_files: []