carwow_rubocop 6.11.0 → 6.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 978ba9d52dc3a0f7c586dab02666847b3e7ac2bcc62990909b4ecab964e794d8
-  data.tar.gz: 35c9f5b58b396765fef73fa76e622ce28029843a96fc25f6f434897a9333cdcd
+  metadata.gz: 81c9278bdc99387df9c9a136d4a6048cf21435c6a760351b7c1be3a82a0df801
+  data.tar.gz: df963ba3013bb0fb3196a57580f06af6136eb7f89eea4f5966982da2a39ea2da
 SHA512:
-  metadata.gz: 51ca0f3638fd002ef701414af166ff97f63ab65f28031e385130e3813721b534ef88e75ecb3b36988d303c040a0df710552d2e210b4b242387df97a10dae2f43
-  data.tar.gz: d4a8e1e9941469ac1a1a3f88a803ddcf38c2f8992f1aefd14a0ffdb97ceda74af045de2717c49e196c072fbedc162779014457ac14ecd0eb8374c04f575d924e
+  metadata.gz: 8546625ac8e9267800cd53cda4614787ebd99abc8aa446ba5e86cdde53b2dfb780523386172e1b16eb534289ed5f9d7d7287d9af6817878d0c2cecd867057275
+  data.tar.gz: bdb3822f28558aa5a062282b09f6ceadb327dfae8bce7fe3363d4124ff3f34f5977ff1f48657798b7732650edd77245236b5144e41f96f723f1a5f72d3e7d0bd

data/.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2.1
 
 orbs:
   buildevents: honeycombio/buildevents@0.5
-  carwow: carwow/carwow-orb@0.6.0
+  carwow: carwow/carwow-orb@0.8
 
 executors:
   ruby:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    carwow_rubocop (6.11.0)
+    carwow_rubocop (6.12.0)
       rubocop (>= 1.75)
       rubocop-factory_bot
       rubocop-performance
@@ -17,7 +17,7 @@ GEM
     language_server-protocol (3.17.0.6)
     lint_roller (1.1.0)
     method_source (1.1.0)
-    parallel (2.1.0)
+    parallel (1.28.0)
     parser (3.3.12.0)
       ast (~> 2.4.1)
       racc

data/config/rubocop-carwow.yml

@@ -57,3 +57,6 @@ Carwow/ProductAreaRequired:
     - "app/jobs/**/*.rb"
   Exclude:
     - "**/concerns/**/*.rb"
+
+Carwow/NoAbort:
+  Enabled: true

data/lib/rubocop/carwow/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module Carwow
-    VERSION = '6.11.0'.freeze
+    VERSION = '6.12.0'.freeze
   end
 end

data/lib/rubocop/cop/carwow/no_abort.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Carwow
+      # Don't call `abort`. It raises `SystemExit`, which RSpec does not rescue, so when it
+      # escapes an example the whole process exits. Under a parallel runner the worker dies
+      # and its remaining spec files silently never run, while the suite reports 0 failures.
+      #
+      # @example
+      #   # bad
+      #   abort 'Nothing to do' if dealers.empty?
+      #
+      #   # good - in a rake task
+      #   next puts('Nothing to do') if dealers.empty?
+      #
+      #   # good
+      #   raise ArgumentError, 'Nothing to do' if dealers.empty?
+      #
+      class NoAbort < ::RuboCop::Cop::Base
+        MSG = "Don't use `abort`. It raises `SystemExit`, which RSpec does not rescue, so a spec that " \
+              'reaches it kills the whole worker and its remaining spec files never run. Return early ' \
+              '(`next puts(...)` in a rake task) or raise an error instead.'
+
+        RESTRICT_ON_SEND = %i[abort].freeze
+
+        def_node_matcher :kernel_abort?, <<~PATTERN
+          (send {nil? (const {nil? cbase} :Kernel)} :abort ...)
+        PATTERN
+
+        def on_send(node)
+          add_offense(node) if kernel_abort?(node)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: carwow_rubocop
 version: !ruby/object:Gem::Version
-  version: 6.11.0
+  version: 6.12.0
 platform: ruby
 authors:
 - carwow Developers
@@ -162,6 +162,7 @@ files:
 - lib/rubocop/cop/carwow/jobs.rb
 - lib/rubocop/cop/carwow/jobs_must_define_queue.rb
 - lib/rubocop/cop/carwow/jobs_queue_name_style.rb
+- lib/rubocop/cop/carwow/no_abort.rb
 - lib/rubocop/cop/carwow/no_change_matcher_with_browser_action.rb
 - lib/rubocop/cop/carwow/no_stubbing_business_event.rb
 - lib/rubocop/cop/carwow/no_stubbing_honeycomb_extra_data.rb