caruso 0.6.0 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 718b4ebf40d78b4314d5ba6869ccf65d4e7ba02ada56c0c9b98e5de973d538c7
-  data.tar.gz: c6fcc0b7f7e45b6cd5e9235e954ea0c1cdc5d49fd729f0c6268e135ef7ac6bce
+  metadata.gz: e38c7a5007af96bb708d286a62909f07f1c1aa3b3aa800baa4a23f36c1a35814
+  data.tar.gz: 18a217953c0ec7c87bc6d9476c89bbca442fde6b45aec4614e4f58c183a3a760
 SHA512:
-  metadata.gz: 76693951a7604897ad48efaa2e81570165e483ab20e651ff757d009a4c179f21a7738f9912229dd768205736ee076fbf2f865e1b7549385ce4c320132674c08a
-  data.tar.gz: 691886bb54d63379e80df0663b0825f89b2dd7ece512fc2e859b90c7e09cc830c63c3f6c2cad4fe2dc6f83974eec03d728cb1c150240cf424821cb6948d2b7f4
+  metadata.gz: 427385d4dca6b37150a1bcf487884db8979883d1e7e3d6caa353217b55609ad43dd97dfd1c85860379a6807c62eb37646eabe491540a54a683ec347e17edbc99
+  data.tar.gz: f04abed100aef554d47572af9507c4d7701782b6321e5f48cfdee677f5cbe5ecd82dffab4e719b2328231ea8bee1a1a041c476ee3322fbdc8653c23333d81ed5

data/AGENTS.md

@@ -273,4 +273,5 @@ Version is managed in `lib/caruso/version.rb`.
 
 # Memory
 - The goal is a clean, correct, consistent implementation. Never implement fallbacks that hide errors or engage in defensive programming.
+- **Idempotency**: Removal commands (`marketplace remove`, `plugin uninstall`) are designed to be idempotent. They exit successfully (0) if the target does not exist. This is intentional for automation friendliness and is NOT considered "hiding errors".
 - Treat the vendor directory .cursor/rules/caruso/ as a build artifact

data/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.6.2] - 2025-12-17
+
+### Fixed
+- `marketplace remove` now exits gracefully (code 0) when marketplace is not found, making it idempotent
+- Documented idempotent behavior of `marketplace remove` and `plugin uninstall` in README
+
 ## [0.6.0] - 2025-11-24
 
 ### Security
@@ -20,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `Adapter` now strictly validates file existence and raises errors instead of silently skipping invalid files
 - `Fetcher` now filters glob results to ensure they remain within trusted plugin directories
 
+
 ## [0.5.3] - 2025-11-23
 
 ### Changed

data/caruso.json

@@ -0,0 +1,5 @@
+{
+  "version": "1.0.0",
+  "marketplaces": {},
+  "plugins": {}
+}

data/lib/caruso/cli.rb

@@ -51,27 +51,30 @@ module Caruso
       end
     end
 
-    desc "remove NAME", "Remove a marketplace"
-    def remove(name)
+    desc "remove NAME_OR_URL", "Remove a marketplace"
+    def remove(name_or_url)
       config_manager = load_config
+      marketplaces = config_manager.list_marketplaces
 
-      # Remove from config
-      config_manager.remove_marketplace(name)
-
-      # Remove from registry
-      registry = Caruso::MarketplaceRegistry.new
-      marketplace = registry.get_marketplace(name)
-      if marketplace
-        cache_dir = marketplace["install_location"]
-        registry.remove_marketplace(name)
-
-        # Inform about cache directory
-        if Dir.exist?(cache_dir)
-          puts "Cache directory still exists at: #{cache_dir}"
-          puts "Run 'rm -rf #{cache_dir}' to delete it if desired."
+      # Try to find by name first
+      if marketplaces.key?(name_or_url)
+        name = name_or_url
+      else
+        # Try to find by URL
+        # We need to check exact match or maybe normalized match
+        match = marketplaces.find { |_, details| details["url"] == name_or_url || details["url"].chomp(".git") == name_or_url }
+        if match
+          name = match[0]
+        else
+          puts "Marketplace '#{name_or_url}' not found."
+          return
         end
       end
 
+      # Use Remover to handle cleanup
+      remover = Caruso::Remover.new(config_manager)
+      remover.remove_marketplace(name)
+
       puts "Removed marketplace '#{name}'"
     end
 
@@ -260,15 +263,9 @@ module Caruso
       end
 
       puts "Removing #{plugin_key}..."
-      files_to_remove = config_manager.remove_plugin(plugin_key)
 
-      files_to_remove.each do |file|
-        full_path = File.join(config_manager.project_dir, file)
-        if File.exist?(full_path)
-          File.delete(full_path)
-          puts "  Deleted #{file}"
-        end
-      end
+      remover = Caruso::Remover.new(config_manager)
+      remover.remove_plugin(plugin_key)
 
       puts "Uninstalled #{plugin_key}."
     end

data/lib/caruso/config_manager.rb

@@ -150,6 +150,23 @@ module Caruso
       save_project_config(data)
     end
 
+    def remove_marketplace_with_plugins(marketplace_name)
+      files_to_remove = []
+
+      # Find and remove all plugins associated with this marketplace
+      installed_plugins = list_plugins
+      installed_plugins.each do |plugin_key, details|
+        if details["marketplace"] == marketplace_name
+          files_to_remove.concat(remove_plugin(plugin_key))
+        end
+      end
+
+      # Remove the marketplace itself
+      remove_marketplace(marketplace_name)
+
+      files_to_remove.uniq
+    end
+
     def list_marketplaces
       load_project_config["marketplaces"] || {}
     end

data/lib/caruso/remover.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require_relative "marketplace_registry"
+
+module Caruso
+  class Remover
+    attr_reader :config_manager
+
+    def initialize(config_manager)
+      @config_manager = config_manager
+    end
+
+    def remove_marketplace(name)
+      # 1. Remove from config and get associated plugin files
+      # This updates both project config (plugins) and local config (files)
+      files_to_remove = config_manager.remove_marketplace_with_plugins(name)
+
+      # 2. Delete the actual files
+      delete_files(files_to_remove)
+
+      # 3. Clean up registry cache
+      remove_from_registry(name)
+    end
+
+    def remove_plugin(name)
+      # 1. Remove from config
+      files_to_remove = config_manager.remove_plugin(name)
+
+      # 2. Delete files
+      delete_files(files_to_remove)
+    end
+
+    private
+
+    def delete_files(files)
+      files.each do |file|
+        full_path = File.join(config_manager.project_dir, file)
+        if File.exist?(full_path)
+          File.delete(full_path)
+          puts "  Deleted #{file}"
+        end
+      end
+    end
+
+    def remove_from_registry(name)
+      registry = Caruso::MarketplaceRegistry.new
+      marketplace = registry.get_marketplace(name)
+      return unless marketplace
+
+      cache_dir = marketplace["install_location"]
+      registry.remove_marketplace(name)
+
+      # Inform about cache directory
+      return unless Dir.exist?(cache_dir)
+
+      puts "Cache directory still exists at: #{cache_dir}"
+      puts "Run 'rm -rf #{cache_dir}' to delete it if desired."
+    end
+  end
+end

data/lib/caruso/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Caruso
-  VERSION = "0.6.0"
+  VERSION = "0.6.2"
 end

data/lib/caruso.rb

@@ -7,6 +7,7 @@ require_relative "caruso/config_manager"
 require_relative "caruso/fetcher"
 require_relative "caruso/adapter"
 require_relative "caruso/marketplace_registry"
+require_relative "caruso/remover"
 
 require_relative "caruso/cli"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: caruso
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.2
 platform: ruby
 authors:
 - Philipp Comans
@@ -142,6 +142,7 @@ files:
 - SECURITY.md
 - bin/caruso
 - caruso.gemspec
+- caruso.json
 - lib/caruso.rb
 - lib/caruso/adapter.rb
 - lib/caruso/cli.rb
@@ -149,6 +150,7 @@ files:
 - lib/caruso/fetcher.rb
 - lib/caruso/marketplace_registry.rb
 - lib/caruso/path_sanitizer.rb
+- lib/caruso/remover.rb
 - lib/caruso/safe_dir.rb
 - lib/caruso/safe_file.rb
 - lib/caruso/version.rb