cartage-rack 2.2 → 2.3

data/test/test_cartage_rack.rb

@@ -1,22 +1,22 @@
 # frozen_string_literal: true
 
-require 'minitest_config'
+require "minitest_helper"
 
 describe Cartage::Rack do
   include Rack::Test::Methods
 
   let(:app) { Cartage::Rack(path) }
-  let(:path) { 'test/hillvalley' }
+  let(:path) { "test/hillvalley" }
   let(:metadata) {
     {
-      'package' => {
-        'name' => 'hillvalley',
-        'repo' => {
-          'type' => 'git',
-          'url' => 'git:doc@hillvalley.com/delorean.git'
+      "package" => {
+        "name" => "hillvalley",
+        "repo" => {
+          "type" => "git",
+          "url" => "git:doc@hillvalley.com/delorean.git"
         },
-        'hashref' => 'd0cb1ff',
-        'timestamp' => '19851027104200'
+        "hashref" => "d0cb1ff",
+        "timestamp" => "19851027104200"
       }
     }
   }
@@ -31,160 +31,160 @@ describe Cartage::Rack do
     end
   end
 
-  it 'inspects nicely for `rake routes` in Rails' do
-    assert_equal 'Cartage::Rack for hillvalley (release_metadata_json)',
+  it "inspects nicely for `rake routes` in Rails" do
+    assert_equal "Cartage::Rack for hillvalley (release_metadata_json)",
       Cartage::Rack().inspect
   end
 
-  it 'returns application/json content by default' do
-    get '/'
-    assert_equal 'application/json', last_response.header['Content-Type']
+  it "returns application/json content by default" do
+    get "/"
+    assert_equal "application/json", last_response.headers["Content-Type"]
   end
 
-  it 'returns text/plain content when requested' do
-    get '/.txt'
-    assert_equal 'text/plain', last_response.header['Content-Type']
+  it "returns text/plain content when requested" do
+    get "/.txt"
+    assert_equal "text/plain", last_response.headers["Content-Type"]
   end
 
-  context 'application environment' do
-    it 'uses $RAILS_ENV first' do
-      stub_env 'RAILS_ENV' => 'vne_sliar',
-               'APP_ENV'   => 'vne_ppa',
-               'RACK_ENV'  => 'vne_kcar' do
-        get '/'
+  describe "application environment" do
+    it "uses $RAILS_ENV first" do
+      stub_env "RAILS_ENV" => "vne_sliar",
+        "APP_ENV"   => "vne_ppa",
+        "RACK_ENV"  => "vne_kcar" do
+        get "/"
 
-        metadata['env'] = { 'name' => 'vne_sliar' }
+        metadata["env"] = {"name" => "vne_sliar"}
 
         assert last_response.ok?
         assert_equal metadata.to_json, last_response.body
-        assert_equal 'application/json', last_response.header['Content-Type']
+        assert_equal "application/json", last_response.headers["Content-Type"]
       end
     end
 
-    it 'uses $APP_ENV second' do
-      stub_env 'RAILS_ENV' => nil, 'APP_ENV' => 'vne_ppa', 'RACK_ENV' => 'vne_kcar' do
-        get '/'
+    it "uses $APP_ENV second" do
+      stub_env "RAILS_ENV" => nil, "APP_ENV" => "vne_ppa", "RACK_ENV" => "vne_kcar" do
+        get "/"
 
-        metadata['env'] = { 'name' => 'vne_ppa' }
+        metadata["env"] = {"name" => "vne_ppa"}
 
         assert last_response.ok?
         assert_equal metadata.to_json, last_response.body
-        assert_equal 'application/json', last_response.header['Content-Type']
+        assert_equal "application/json", last_response.headers["Content-Type"]
       end
     end
 
-    it 'uses $RACK_ENV third' do
-      stub_env 'RAILS_ENV' => nil, 'APP_ENV' => nil, 'RACK_ENV' => 'vne_kcar' do
-        get '/'
+    it "uses $RACK_ENV third" do
+      stub_env "RAILS_ENV" => nil, "APP_ENV" => nil, "RACK_ENV" => "vne_kcar" do
+        get "/"
 
-        metadata['env'] = { 'name' => 'vne_kcar' }
+        metadata["env"] = {"name" => "vne_kcar"}
 
         assert last_response.ok?
         assert_equal metadata.to_json, last_response.body
-        assert_equal 'application/json', last_response.header['Content-Type']
+        assert_equal "application/json", last_response.headers["Content-Type"]
       end
     end
 
-    it 'falls through to UNKNOWN without either $RAILS_ENV, $APP_ENV or $RACK_ENV' do
-      stub_env 'RAILS_ENV' => nil, 'APP_ENV' => nil, 'RACK_ENV' => nil do
-        get '/'
+    it "falls through to UNKNOWN without either $RAILS_ENV, $APP_ENV or $RACK_ENV" do
+      stub_env "RAILS_ENV" => nil, "APP_ENV" => nil, "RACK_ENV" => nil do
+        get "/"
 
-        metadata['env'] = { 'name' => 'UNKNOWN' }
+        metadata["env"] = {"name" => "UNKNOWN"}
 
         assert last_response.ok?
         assert_equal metadata.to_json, last_response.body
-        assert_equal 'application/json', last_response.header['Content-Type']
+        assert_equal "application/json", last_response.headers["Content-Type"]
       end
     end
   end
 
-  context 'timestamp' do
+  describe "timestamp" do
     around do |&block|
-      metadata['package'].delete('timestamp')
+      metadata["package"].delete("timestamp")
       super(&block)
     end
 
-    it 'is omitted if not present in the metadata' do
-      stub_env 'RAILS_ENV' => nil, 'RACK_ENV' => nil do
-        get '/'
+    it "is omitted if not present in the metadata" do
+      stub_env "RAILS_ENV" => nil, "RACK_ENV" => nil do
+        get "/"
 
-        metadata['env'] = { 'name' => 'UNKNOWN' }
+        metadata["env"] = {"name" => "UNKNOWN"}
 
         assert last_response.ok?
         assert_equal metadata.to_json, last_response.body
-        assert_equal 'application/json', last_response.header['Content-Type']
+        assert_equal "application/json", last_response.headers["Content-Type"]
       end
     end
   end
 
-  context 'text/plain' do
-    it 'returns a useful plaintext format' do
-      stub_env 'RAILS_ENV' => 'production' do
-        get '/.text'
+  describe "text/plain" do
+    it "returns a useful plaintext format" do
+      stub_env "RAILS_ENV" => "production" do
+        get "/.text"
 
         assert last_response.ok?
-        assert_equal <<-text.chomp, last_response.body
-name: hillvalley
-environment: production
-hashref: d0cb1ff
-timestamp: 19851027104200
-git: git:doc@hillvalley.com/delorean.git
-        text
-        assert_equal 'text/plain', last_response.header['Content-Type']
+        assert_equal <<~TEXT.chomp, last_response.body
+          name: hillvalley
+          environment: production
+          hashref: d0cb1ff
+          timestamp: 19851027104200
+          git: git:doc@hillvalley.com/delorean.git
+        TEXT
+        assert_equal "text/plain", last_response.headers["Content-Type"]
       end
     end
 
-    it 'skips the repo if package.repo is missing' do
-      stub_env 'RAILS_ENV' => 'production' do
-        metadata['package'].delete('repo')
+    it "skips the repo if package.repo is missing" do
+      stub_env "RAILS_ENV" => "production" do
+        metadata["package"].delete("repo")
 
-        get '/.text'
+        get "/.text"
 
         assert last_response.ok?
-        assert_equal <<-text.chomp, last_response.body
-name: hillvalley
-environment: production
-hashref: d0cb1ff
-timestamp: 19851027104200
-        text
-        assert_equal 'text/plain', last_response.header['Content-Type']
+        assert_equal <<~TEXT.chomp, last_response.body
+          name: hillvalley
+          environment: production
+          hashref: d0cb1ff
+          timestamp: 19851027104200
+        TEXT
+        assert_equal "text/plain", last_response.headers["Content-Type"]
       end
     end
 
-    it 'skips the timestamp if package.timestamp is missing' do
-      stub_env 'RAILS_ENV' => 'production' do
-        metadata['package'].delete('timestamp')
+    it "skips the timestamp if package.timestamp is missing" do
+      stub_env "RAILS_ENV" => "production" do
+        metadata["package"].delete("timestamp")
 
-        get '/.text'
+        get "/.text"
 
         assert last_response.ok?
-        assert_equal <<-text.chomp, last_response.body
-name: hillvalley
-environment: production
-hashref: d0cb1ff
-git: git:doc@hillvalley.com/delorean.git
-        text
-        assert_equal 'text/plain', last_response.header['Content-Type']
+        assert_equal <<~TEXT.chomp, last_response.body
+          name: hillvalley
+          environment: production
+          hashref: d0cb1ff
+          git: git:doc@hillvalley.com/delorean.git
+        TEXT
+        assert_equal "text/plain", last_response.headers["Content-Type"]
       end
     end
   end
 
-  context 'filter' do
+  describe "filter" do
     let(:app) {
       Cartage::Rack(path) { |content|
-        content['env']['name'] = content['env']['name'].reverse
+        content["env"]["name"] = content["env"]["name"].reverse
       }
     }
 
-    it 'applies the filter before returning' do
-      stub_env 'RAILS_ENV' => 'vne_sliar' do
-        get '/'
+    it "applies the filter before returning" do
+      stub_env "RAILS_ENV" => "vne_sliar" do
+        get "/"
 
-        metadata['env'] = { 'name' => 'rails_env' }
+        metadata["env"] = {"name" => "rails_env"}
 
         assert last_response.ok?
         assert_equal metadata.to_json, last_response.body
-        assert_equal 'application/json', last_response.header['Content-Type']
+        assert_equal "application/json", last_response.headers["Content-Type"]
       end
     end
   end

data/test/test_cartage_rack_metadata.rb

@@ -1,31 +1,31 @@
 # frozen_string_literal: true
 
-require 'minitest_config'
+require "minitest_helper"
 
 describe Cartage::Rack::Metadata do
   let(:described_class) { Cartage::Rack::Metadata }
-  let(:path) { 'test/hillvalley' }
-  let(:env) { { 'RAILS_ENV' => 'production' } }
+  let(:path) { "test/hillvalley" }
+  let(:env) { {"RAILS_ENV" => "production"} }
 
-  context 'with release-metadata.json' do
+  describe "with release-metadata.json" do
     let(:expected) {
       {
-        'env' => { 'name' => 'production' },
-        'package' => {
-          'name' => 'hillvalley',
-          'repo' => {
-            'type' => 'git',
-            'url' => 'git:doc@hillvalley.com/delorean.git'
+        "env" => {"name" => "production"},
+        "package" => {
+          "name" => "hillvalley",
+          "repo" => {
+            "type" => "git",
+            "url" => "git:doc@hillvalley.com/delorean.git"
           },
-          'hashref' => 'd0cb1ff',
-          'timestamp' => '19851027104200'
+          "hashref" => "d0cb1ff",
+          "timestamp" => "19851027104200"
         }
       }
     }
 
-    it '#inspect uses the source (release_metadata_json) for inspection' do
-      stub_pathname_exist? ->(v) { v.basename.to_s == 'release-metadata.json' } do
-        instance_stub Pathname, :read, '{}' do
+    it "#inspect uses the source (release_metadata_json) for inspection" do
+      stub_pathname_exist? ->(v) { v.basename.to_s == "release-metadata.json" } do
+        instance_stub Pathname, :read, "{}" do
           assert_match(
             /\Ahillvalley \(release_metadata_json\)\z/,
             described_class.new(path, required: false).inspect
@@ -34,9 +34,9 @@ describe Cartage::Rack::Metadata do
       end
     end
 
-    it '#resolve returns the content as provided' do
+    it "#resolve returns the content as provided" do
       stub_env(env) do
-        stub_pathname_exist? ->(v) { v.basename.to_s == 'release-metadata.json' } do
+        stub_pathname_exist? ->(v) { v.basename.to_s == "release-metadata.json" } do
           instance_stub Pathname, :read, expected.to_json do
             assert_equal expected, described_class.new(path).resolve
           end
@@ -44,25 +44,25 @@ describe Cartage::Rack::Metadata do
       end
     end
 
-    it '#resolve returns filtered content' do
+    it "#resolve returns filtered content" do
       filter = ->(content) {
-        content['env']['capacitor'] = 'flux'
+        content["env"]["capacitor"] = "flux"
       }
 
       stub_env(env) do
-        stub_pathname_exist? ->(v) { v.basename.to_s == 'release-metadata.json' } do
+        stub_pathname_exist? ->(v) { v.basename.to_s == "release-metadata.json" } do
           instance_stub Pathname, :read, expected.to_json do
-            expected['env']['capacitor'] = 'flux'
+            expected["env"]["capacitor"] = "flux"
             assert_equal expected, described_class.new(path, filter: filter).resolve
           end
         end
       end
     end
 
-    it '.new throws an exception with a non-JSON file' do
+    it ".new throws an exception with a non-JSON file" do
       stub_env(env) do
-        stub_pathname_exist? ->(v) { v.basename.to_s == 'release-metadata.json' } do
-          instance_stub Pathname, :read, 'supercalafragalisticexpealadocious' do
+        stub_pathname_exist? ->(v) { v.basename.to_s == "release-metadata.json" } do
+          instance_stub Pathname, :read, "supercalafragalisticexpealadocious" do
             ex = assert_raises(JSON::ParserError) do
               described_class.new(path)
             end
@@ -74,31 +74,31 @@ describe Cartage::Rack::Metadata do
     end
   end
 
-  context 'with release_hashref' do
-    let(:one_line) { 'd0cb1ff' }
+  describe "with release_hashref" do
+    let(:one_line) { "d0cb1ff" }
     let(:two_line) { "d0cb1ff\n19851027104200\n" }
     let(:two_line_empty) { "d0cb1ff\n\n" }
     let(:three_line) { "d0cb1ff\n19851027104200\nsomethingelse\n" }
     let(:expected_notimestamp) {
       {
-        'env' => {
-          'name' => 'production'
+        "env" => {
+          "name" => "production"
         },
-        'package' => {
-          'name' => 'hillvalley',
-          'hashref' => 'd0cb1ff'
+        "package" => {
+          "name" => "hillvalley",
+          "hashref" => "d0cb1ff"
         }
       }
     }
     let(:expected_timestamp) {
       expected_notimestamp.dup.tap do |en|
-        en['package'] = en['package'].merge('timestamp' => '19851027104200')
+        en["package"] = en["package"].merge("timestamp" => "19851027104200")
       end
     }
 
-    it 'uses the source (release_hashref) for inspection' do
-      stub_pathname_exist? ->(v) { v.basename.to_s == 'release_hashref' } do
-        instance_stub Pathname, :read, '' do
+    it "uses the source (release_hashref) for inspection" do
+      stub_pathname_exist? ->(v) { v.basename.to_s == "release_hashref" } do
+        instance_stub Pathname, :read, "" do
           assert_match(
             /\Ahillvalley \(release_hashref\)\z/,
             described_class.new(path, required: false).inspect
@@ -107,10 +107,10 @@ describe Cartage::Rack::Metadata do
       end
     end
 
-    context '#resolve' do
-      it 'returns the hashref from a one line release_hashref' do
+    describe "#resolve" do
+      it "returns the hashref from a one line release_hashref" do
         stub_env(env) do
-          stub_pathname_exist? ->(v) { v.basename.to_s == 'release_hashref' } do
+          stub_pathname_exist? ->(v) { v.basename.to_s == "release_hashref" } do
             instance_stub Pathname, :read, one_line do
               assert_equal expected_notimestamp, described_class.new(path).resolve
             end
@@ -118,9 +118,9 @@ describe Cartage::Rack::Metadata do
         end
       end
 
-      it 'returns hashref and timestamp from a two line release_hashref' do
+      it "returns hashref and timestamp from a two line release_hashref" do
         stub_env(env) do
-          stub_pathname_exist? ->(v) { v.basename.to_s == 'release_hashref' } do
+          stub_pathname_exist? ->(v) { v.basename.to_s == "release_hashref" } do
             instance_stub Pathname, :read, two_line do
               assert_equal expected_timestamp, described_class.new(path).resolve
             end
@@ -128,9 +128,9 @@ describe Cartage::Rack::Metadata do
         end
       end
 
-      it 'returns hashref from a two line release_hashref (with empty timestamp line)' do
+      it "returns hashref from a two line release_hashref (with empty timestamp line)" do
         stub_env(env) do
-          stub_pathname_exist? ->(v) { v.basename.to_s == 'release_hashref' } do
+          stub_pathname_exist? ->(v) { v.basename.to_s == "release_hashref" } do
             instance_stub Pathname, :read, two_line_empty do
               assert_equal expected_notimestamp, described_class.new(path).resolve
             end
@@ -138,9 +138,9 @@ describe Cartage::Rack::Metadata do
         end
       end
 
-      it 'ignores anything larger than two lines in release_hashref' do
+      it "ignores anything larger than two lines in release_hashref" do
         stub_env(env) do
-          stub_pathname_exist? ->(v) { v.basename.to_s == 'release_hashref' } do
+          stub_pathname_exist? ->(v) { v.basename.to_s == "release_hashref" } do
             instance_stub Pathname, :read, three_line do
               assert_equal expected_timestamp, described_class.new(path).resolve
             end
@@ -150,8 +150,8 @@ describe Cartage::Rack::Metadata do
     end
   end
 
-  context 'with live data' do
-    it 'uses the source (live) for inspection' do
+  describe "with live data" do
+    it "uses the source (live) for inspection" do
       instance_stub Pathname, :exist?, false do
         assert_match(
           /\(live\)\z/,
@@ -162,44 +162,44 @@ describe Cartage::Rack::Metadata do
 
     let(:expected_nogit) {
       {
-        'env' => {
-          'name' => 'production'
+        "env" => {
+          "name" => "production"
         },
-        'package' => {
-          'name' => 'hillvalley',
-          'hashref' => 'UNKNOWN - no .git directory',
-          'timestamp' => '19851027104200'
+        "package" => {
+          "name" => "hillvalley",
+          "hashref" => "UNKNOWN - no .git directory",
+          "timestamp" => "19851027104200"
         }
       }
     }
     let(:expected_git) {
       expected_nogit.dup.tap { |en|
-        en['package'] = en['package'].merge(
-          'repo' => {
-            'type' => 'git',
-            'url' => 'git:doc@hillvalley.com/delorean.git'
+        en["package"] = en["package"].merge(
+          "repo" => {
+            "type" => "git",
+            "url" => "git:doc@hillvalley.com/delorean.git"
           },
-          'hashref' => '(git) verne'
+          "hashref" => "(git) verne"
         )
       }
     }
 
-    it 'fails if required is true' do
+    it "fails if required is true" do
       ex = assert_raises(RuntimeError) do
         described_class.new(path, required: true)
       end
 
-      assert_equal 'Cannot find release-metadata.json or release_hashref', ex.message
+      assert_equal "Cannot find release-metadata.json or release_hashref", ex.message
     end
 
-    context '#resolve' do
+    describe "#resolve" do
       around do |&block|
-        Timecop.freeze(Time.new(1985, 10, 27, 2, 42, 0, '-08:00')) do
+        Timecop.freeze(Time.new(1985, 10, 27, 2, 42, 0, "-08:00")) do
           super(&block)
         end
       end
 
-      it 'excludes package.repo when no .git directory' do
+      it "excludes package.repo when no .git directory" do
         stub_env(env) do
           instance_stub Pathname, :exist?, false do
             instance_stub Pathname, :directory?, false do
@@ -210,13 +210,13 @@ describe Cartage::Rack::Metadata do
         end
       end
 
-      it 'includes package.repo when a .git directory exists' do
+      it "includes package.repo when a .git directory exists" do
         backticks = ->(v) {
           case v
           when /remote show/
             "\n  Fetch URL: git:doc@hillvalley.com/delorean.git"
           when /rev-parse/
-            'verne'
+            "verne"
           else
             __stub_backticks__(v)
           end