carson 3.23.1 → 3.23.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74175b83073b45d8ffdf3ee6aa1af6ebe02f4e8c7eacbc315d5cb7fb42d89578
-  data.tar.gz: 9f7eae79be834f3a7b78f9caa5b415946a1205a3d5e09029b88b5f9234a962bc
+  metadata.gz: b22f115d99fffc1ed689ceb214523b8a33da08fc84a955fcc766d778be21e40c
+  data.tar.gz: 6a270c175cb8affabba0d6d747e08701a50c61124a4c5486525113ff350cedbf
 SHA512:
-  metadata.gz: dfc053ce86819ec64133a52a436a52c5719f2f2af60aebbe85ee0316f1173bc706b6c9e9158254319ff3d3c5cd457bd5583d86c818bbc3b4c866a5b90f53c427
-  data.tar.gz: 608c6af987bc8351db9febdb9c5d5ef7f181f4b19b0991c20e4033b98f788ba227c9da1bde01f3b40b92299110e91c0bee0f7a23acc95d25f26f44c0ccaddee9
+  metadata.gz: 00ac0ad1897f1d04520f4653aec941e6d9c0dfeb7d13656a4ecb1eff6a3cffe24af0b839447f1324ac11c6eb6c40e00b01e1cba6c3fa86a5d21871576b4bb2d2
+  data.tar.gz: fad5645c4a8befb085b4617db5542117bf593f1475cc5a65ccbf29b207e4c5ea9fd938bb503d2fa35e66b652ecc01fae269d68c5c60f2e895055cd8c3b0190b3

data/RELEASE.md

@@ -5,6 +5,19 @@ Release-note scope rule:
 - `RELEASE.md` records only version deltas, breaking changes, and migration actions.
 - Operational usage guides live in `MANUAL.md` and `API.md`.
 
+## 3.23.2
+
+### What changed
+
+- **Fix: onboard audit exception silently swallowed** — `onboard_run_audit!` referenced an undefined variable `e` instead of `exception` in its rescue clause. When `audit!` raised during `carson onboard`, the NameError was caught by the ensure block's return, giving the user no diagnostic. Now correctly captures the exception and reports "Audit skipped."
+- **Fix: `sync_after_merge!` always reported success** — `Open3.capture3` returns a `Process::Status` object which is always truthy. The sync-failure branch was unreachable. Now correctly calls `.success?` on the status object.
+- **Test coverage: Ledger revision recording** — unit tests for `record_revision` (numbering, `finished_at`, counter bump), `revisions_for_delivery` ordering, and behavioural verification that `active_deliveries` returns exactly the states `Delivery` considers active.
+- **Test coverage: govern reconciliation** — tests for PR MERGED (integrated), PR CLOSED (failed), head-advanced (superseded), and no-agent-provider (escalated) state transitions that were previously stubbed out.
+- **Test coverage: deliver error paths** — push failure and PR creation failure tests exercising actual error handling at the adapter boundary.
+- **Housekeeping** — `Ledger::ACTIVE_DELIVERY_STATES` now references `Delivery::ACTIVE_STATES` instead of maintaining a duplicate. Fixed indentation in `upsert_delivery` and `supersede_branch!`. Corrected "deliver/delivers" to "delivery/deliveries" in govern output.
+
+### No migration required
+
 ## 3.23.1
 
 ### What changed

data/VERSION

@@ -1 +1 @@
-3.23.1
+3.23.2

data/lib/carson/ledger.rb

@@ -6,7 +6,7 @@ require "time"
 module Carson
 	class Ledger
 		UNSET = Object.new
-		ACTIVE_DELIVERY_STATES = %w[preparing gated queued integrating escalated].freeze
+		ACTIVE_DELIVERY_STATES = Delivery::ACTIVE_STATES
 
 		def initialize( path: )
 			@path = File.expand_path( path )
@@ -75,16 +75,16 @@ module Carson
 					[ repository.path, branch_name, head ]
 				)
 
-					if row
-						database.execute(
-							<<~SQL,
-							UPDATE deliveries
-							SET worktree_path = ?, authority = ?, status = ?, pr_number = ?, pr_url = ?,
-							cause = ?, summary = ?, updated_at = ?
-							WHERE id = ?
-							SQL
-							[ worktree_path, authority, status, pr_number, pr_url, cause, summary, timestamp, row.fetch( "id" ) ]
-						)
+				if row
+					database.execute(
+						<<~SQL,
+						UPDATE deliveries
+						SET worktree_path = ?, authority = ?, status = ?, pr_number = ?, pr_url = ?,
+						cause = ?, summary = ?, updated_at = ?
+						WHERE id = ?
+						SQL
+						[ worktree_path, authority, status, pr_number, pr_url, cause, summary, timestamp, row.fetch( "id" ) ]
+					)
 					return fetch_delivery( database: database, id: row.fetch( "id" ), repository: repository )
 				end
 
@@ -283,15 +283,15 @@ module Carson
 			)
 		end
 
-			def supersede_branch!( database:, repository:, branch_name:, timestamp: )
-				database.execute(
-					<<~SQL,
-					UPDATE deliveries
-					SET status = ?, superseded_at = ?, updated_at = ?
-					WHERE repo_path = ? AND branch_name = ? AND status IN ( #{active_state_placeholders} )
-					SQL
-					[ "superseded", timestamp, timestamp, repository.path, branch_name, *ACTIVE_DELIVERY_STATES ]
-				)
+		def supersede_branch!( database:, repository:, branch_name:, timestamp: )
+			database.execute(
+				<<~SQL,
+				UPDATE deliveries
+				SET status = ?, superseded_at = ?, updated_at = ?
+				WHERE repo_path = ? AND branch_name = ? AND status IN ( #{active_state_placeholders} )
+				SQL
+				[ "superseded", timestamp, timestamp, repository.path, branch_name, *ACTIVE_DELIVERY_STATES ]
+			)
 		end
 
 		def active_state_placeholders

data/lib/carson/runtime/deliver.rb

@@ -311,10 +311,10 @@ module Carson
 			# Syncs main after a successful merge.
 			def sync_after_merge!( remote:, main:, result: )
 				main_root = main_worktree_root
-				_, pull_stderr, pull_success, = Open3.capture3(
+				_, pull_stderr, pull_status, = Open3.capture3(
 					"git", "-C", main_root, "pull", "--ff-only", remote, main
 				)
-				if pull_success
+				if pull_status.success?
 					result[ :synced ] = true
 					puts_verbose "synced #{main} in #{main_root} from #{remote}"
 				else

data/lib/carson/runtime/govern.rb

@@ -81,7 +81,7 @@ module Carson
 					return repo_report
 				end
 
-				puts_line "#{repository.name}: #{deliveries.length} active deliver#{plural_suffix( count: deliveries.length )}"
+				puts_line "#{repository.name}: #{deliveries.length} active deliver#{deliveries.length == 1 ? 'y' : 'ies'}"
 
 				reconciled = deliveries.map { |item| scoped_runtime.send( :reconcile_delivery!, delivery: item ) }
 				next_integration_id = reconciled.find( &:ready? )&.id

data/lib/carson/runtime/local/onboard.rb

@@ -295,7 +295,7 @@ module Carson
 				audit_error = nil
 				audit_status = with_captured_output { audit! }
 			rescue StandardError => exception
-				audit_error = e
+				audit_error = exception
 				audit_status = EXIT_OK
 			ensure
 				return onboard_print_audit_result( status: audit_status, error: audit_error )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: carson
 version: !ruby/object:Gem::Version
-  version: 3.23.1
+  version: 3.23.2
 platform: ruby
 authors:
 - Hailei Wang