carson 3.19.0 → 3.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36c68c06630159e0dca3560f62993befe8b50dd324fac5a6f8232895b2a667bd
-  data.tar.gz: 1a4462a8b56b6b7fe505705c30ded47e24a279f4fa775baf56b05ae2e48f450a
+  metadata.gz: 0e7fdc44d330fd415b8f6d9ee479d5256d6fc860e5d63c7c9287f28ebbdb2ba4
+  data.tar.gz: 19056bd376bcab3b7077e38ba4e42f2b9f5a3ffbf2c8027f0aa6626bb70587fb
 SHA512:
-  metadata.gz: 3f644435f5ca88527edc597a7b19134b701bc970748b5ef075f9b1e3c600b3be60724d80c8567bb919cf378a9a5da2dc54fcc27f29b0da811c0f3880c990f016
-  data.tar.gz: 12e3651de47f5f741115c58308c2fe344d542bcc94c3f1234e08990b506b6ffa2c518e5f782ea9cb0a86a699111926c6df1f6571724b5ef3d318666889f2a13f
+  metadata.gz: 13f0d5ac83272711329d435a935dd940afc461c5c3b10e20d23842492e8e53f7032cf34a8b027d70db80563af148cda5f99c2c8e7ec4025b94f4d72609ea9d1d
+  data.tar.gz: b1903c6a8f8682adc7b942e49b553579d014d56c0bb65587465568119d41583a14e0cb4a7b00bc61b9165fac79094567395dbf2b39191e3c9d673dc0750dc4f5

data/RELEASE.md

@@ -5,6 +5,17 @@ Release-note scope rule:
 - `RELEASE.md` records only version deltas, breaking changes, and migration actions.
 - Operational usage guides live in `MANUAL.md` and `API.md`.
 
+## 3.20.0
+
+### What changed
+
+- **Cross-process CWD guard for worktree removal** — `worktree_remove!` and `sweep_stale_worktrees!` now detect when another process (e.g. an agent session) has its working directory inside a worktree before attempting removal. Uses `lsof -d cwd` to scan for cross-process CWD holds. Blocks removal with a clear recovery message instead of silently destroying the directory and crashing the other session's shell.
+- **Code quality sweep** — fixed indentation errors in `deliver.rb` (`check_pr_ci` method). Converted single-parameter blocks to Ruby 3.4 `it` implicit parameter across `deliver.rb`, `govern.rb`, `setup.rb`, and all review submodules (`gate_support.rb`, `sweep_support.rb`, `utility.rb`). Added file-level purpose comments to review submodules (`gate_support.rb`, `sweep_support.rb`, `utility.rb`, `data_access.rb`, `query_text.rb`).
+
+### UX improvement
+
+- Worktree removal is now safe across process boundaries. Previously, Carson only checked if the *current* process's CWD was inside the worktree. A separate cleanup process (hook, batch sweep, or another agent) could still remove a worktree while another session's shell was inside it, permanently crashing that shell. The new guard detects this scenario and refuses removal with actionable recovery advice. Fails safe: if `lsof` is unavailable, removal proceeds as before.
+
 ## 3.19.0
 
 ### What changed

data/VERSION

@@ -1 +1 @@
-3.19.0
+3.20.0

data/lib/carson/runtime/audit.rb

@@ -212,20 +212,20 @@ module Carson
 		private
 			def pr_and_check_report
 				report = {
-				generated_at: Time.now.utc.iso8601,
-				branch: current_branch,
-				status: "ok",
-				skip_reason: nil,
-				pr: nil,
-				checks: {
-				status: "unknown",
-				skip_reason: nil,
-				required_total: 0,
-				failing_count: 0,
-				pending_count: 0,
-				failing: [],
-				pending: []
-				}
+					generated_at: Time.now.utc.iso8601,
+					branch: current_branch,
+					status: "ok",
+					skip_reason: nil,
+					pr: nil,
+					checks: {
+						status: "unknown",
+						skip_reason: nil,
+						required_total: 0,
+						failing_count: 0,
+						pending_count: 0,
+						failing: [],
+						pending: []
+					}
 				}
 				unless gh_available?
 					report[ :status ] = "skipped"
@@ -243,11 +243,11 @@ module Carson
 				end
 				pr_data = JSON.parse( pr_stdout )
 				report[ :pr ] = {
-				number: pr_data[ "number" ],
-				title: pr_data[ "title" ].to_s,
-				url: pr_data[ "url" ].to_s,
-				state: pr_data[ "state" ].to_s,
-				review_decision: blank_to( value: pr_data[ "reviewDecision" ], default: "NONE" )
+					number: pr_data[ "number" ],
+					title: pr_data[ "title" ].to_s,
+					url: pr_data[ "url" ].to_s,
+					state: pr_data[ "state" ].to_s,
+					review_decision: blank_to( value: pr_data[ "reviewDecision" ], default: "NONE" )
 				}
 				puts_verbose "pr: ##{report.dig( :pr, :number )} #{report.dig( :pr, :title )}"
 				puts_verbose "url: #{report.dig( :pr, :url )}"
@@ -287,22 +287,22 @@ module Carson
 			# Evaluates default-branch CI health so stale workflow drift blocks before merge.
 			def default_branch_ci_baseline_report
 				report = {
-				status: "ok",
-				skip_reason: nil,
-				repository: nil,
-				default_branch: nil,
-				head_sha: nil,
-				workflows_total: 0,
-				check_runs_total: 0,
-				failing_count: 0,
-				pending_count: 0,
-				advisory_failing_count: 0,
-				advisory_pending_count: 0,
-				no_check_evidence: false,
-				failing: [],
-				pending: [],
-				advisory_failing: [],
-				advisory_pending: []
+					status: "ok",
+					skip_reason: nil,
+					repository: nil,
+					default_branch: nil,
+					head_sha: nil,
+					workflows_total: 0,
+					check_runs_total: 0,
+					failing_count: 0,
+					pending_count: 0,
+					advisory_failing_count: 0,
+					advisory_pending_count: 0,
+					no_check_evidence: false,
+					failing: [],
+					pending: [],
+					advisory_failing: [],
+					advisory_pending: []
 				}
 				unless gh_available?
 					report[ :status ] = "skipped"
@@ -313,30 +313,30 @@ module Carson
 				owner, repo = repository_coordinates
 				report[ :repository ] = "#{owner}/#{repo}"
 				repository_data = gh_json_payload!(
-				"api", "repos/#{owner}/#{repo}",
-				"--method", "GET",
-				fallback: "unable to read repository metadata for #{owner}/#{repo}"
+					"api", "repos/#{owner}/#{repo}",
+					"--method", "GET",
+					fallback: "unable to read repository metadata for #{owner}/#{repo}"
 				)
 				default_branch = blank_to( value: repository_data[ "default_branch" ], default: config.main_branch )
 				report[ :default_branch ] = default_branch
 				branch_data = gh_json_payload!(
-				"api", "repos/#{owner}/#{repo}/branches/#{CGI.escape( default_branch )}",
-				"--method", "GET",
-				fallback: "unable to read default branch #{default_branch}"
+					"api", "repos/#{owner}/#{repo}/branches/#{CGI.escape( default_branch )}",
+					"--method", "GET",
+					fallback: "unable to read default branch #{default_branch}"
 				)
 				head_sha = branch_data.dig( "commit", "sha" ).to_s.strip
 				raise "default branch #{default_branch} has no commit SHA" if head_sha.empty?
 				report[ :head_sha ] = head_sha
 				workflow_entries = default_branch_workflow_entries(
-				owner: owner,
-				repo: repo,
-				default_branch: default_branch
+					owner: owner,
+					repo: repo,
+					default_branch: default_branch
 				)
 				report[ :workflows_total ] = workflow_entries.count
 				check_runs_payload = gh_json_payload!(
-				"api", "repos/#{owner}/#{repo}/commits/#{head_sha}/check-runs",
-				"--method", "GET",
-				fallback: "unable to read check-runs for #{default_branch}@#{head_sha}"
+					"api", "repos/#{owner}/#{repo}/commits/#{head_sha}/check-runs",
+					"--method", "GET",
+					fallback: "unable to read check-runs for #{default_branch}@#{head_sha}"
 				)
 				check_runs = Array( check_runs_payload[ "check_runs" ] )
 				failing, pending = partition_default_branch_check_runs( check_runs: check_runs )
@@ -399,15 +399,15 @@ module Carson
 			# Reads workflow files from default branch; missing workflow directory is valid and returns none.
 			def default_branch_workflow_entries( owner:, repo:, default_branch: )
 				stdout_text, stderr_text, success, = gh_run(
-				"api", "repos/#{owner}/#{repo}/contents/.github/workflows",
-				"--method", "GET",
-				"-f", "ref=#{default_branch}"
+					"api", "repos/#{owner}/#{repo}/contents/.github/workflows",
+					"--method", "GET",
+					"-f", "ref=#{default_branch}"
 				)
 				unless success
 					error_text = gh_error_text(
-					stdout_text: stdout_text,
-					stderr_text: stderr_text,
-					fallback: "unable to read workflow files for #{default_branch}"
+						stdout_text: stdout_text,
+						stderr_text: stderr_text,
+						fallback: "unable to read workflow files for #{default_branch}"
 					)
 					return [] if error_text.match?( /\b404\b/ )
 					raise error_text
@@ -474,10 +474,10 @@ module Carson
 						blank_to( value: entry[ "status" ], default: "UNKNOWN" )
 					end
 					{
-					workflow: blank_to( value: entry.dig( "app", "name" ), default: "workflow" ),
-					name: blank_to( value: entry[ "name" ], default: "check" ),
-					state: state.upcase,
-					link: entry[ "html_url" ].to_s
+						workflow: blank_to( value: entry.dig( "app", "name" ), default: "workflow" ),
+						name: blank_to( value: entry[ "name" ], default: "check" ),
+						state: state.upcase,
+						link: entry[ "html_url" ].to_s
 					}
 				end
 			end

data/lib/carson/runtime/deliver.rb

@@ -210,27 +210,27 @@ module Carson
 
 			# Generates a default PR title from the branch name.
 			def default_pr_title( branch: )
-				branch.tr( "-", " " ).gsub( "/", ": " ).sub( /\A\w/ ) { |c| c.upcase }
+				branch.tr( "-", " " ).gsub( "/", ": " ).sub( /\A\w/ ) { it.upcase }
 			end
 
 			# Checks CI status on a PR. Returns :pass, :fail, :pending, or :none.
-# Uses the `bucket` field (pass/fail/pending) from `gh pr checks --json`.
-def check_pr_ci( number: )
-	stdout, _, success, = gh_run(
-		"pr", "checks", number.to_s,
-		"--json", "name,bucket"
-	)
-	return :none unless success
-
-	checks = JSON.parse( stdout ) rescue []
-	return :none if checks.empty?
-
-	buckets = checks.map { |c| c[ "bucket" ].to_s.downcase }
-	return :fail if buckets.include?( "fail" )
-	return :pending if buckets.include?( "pending" )
-
-	:pass
-end
+			# Uses the `bucket` field (pass/fail/pending) from `gh pr checks --json`.
+			def check_pr_ci( number: )
+				stdout, _, success, = gh_run(
+					"pr", "checks", number.to_s,
+					"--json", "name,bucket"
+				)
+				return :none unless success
+
+				checks = JSON.parse( stdout ) rescue []
+				return :none if checks.empty?
+
+				buckets = checks.map { it[ "bucket" ].to_s.downcase }
+				return :fail if buckets.include?( "fail" )
+				return :pending if buckets.include?( "pending" )
+
+				:pass
+			end
 
 			# Checks review decision on a PR. Returns :approved, :changes_requested, :review_required, or :none.
 			def check_pr_review( number: )
@@ -298,8 +298,8 @@ end
 			def compute_post_merge_next_step!( result: )
 				main_root = main_worktree_root
 				cwd = realpath_safe( Dir.pwd )
-				current_wt = worktree_list.select { |wt| wt.fetch( :path ) != realpath_safe( main_root ) }
-					.find { |wt| cwd == wt.fetch( :path ) || cwd.start_with?( File.join( wt.fetch( :path ), "" ) ) }
+				current_wt = worktree_list.select { it.fetch( :path ) != realpath_safe( main_root ) }
+					.find { cwd == it.fetch( :path ) || cwd.start_with?( File.join( it.fetch( :path ), "" ) ) }
 
 				if current_wt
 					wt_name = File.basename( current_wt.fetch( :path ) )

data/lib/carson/runtime/govern.rb

@@ -208,10 +208,10 @@ module Carson
 				checks = Array( pr[ "statusCheckRollup" ] )
 				return :green if checks.empty?
 
-				has_failure = checks.any? { |c| check_state_failing?( state: c[ "state" ].to_s ) || check_conclusion_failing?( conclusion: c[ "conclusion" ].to_s ) }
+				has_failure = checks.any? { check_state_failing?( state: it[ "state" ].to_s ) || check_conclusion_failing?( conclusion: it[ "conclusion" ].to_s ) }
 				return :red if has_failure
 
-				has_pending = checks.any? { |c| check_state_pending?( state: c[ "state" ].to_s ) }
+				has_pending = checks.any? { check_state_pending?( state: it[ "state" ].to_s ) }
 				return :pending if has_pending
 
 				:green

data/lib/carson/runtime/local/worktree.rb

@@ -1,7 +1,8 @@
 # Safe worktree lifecycle management for coding agents.
 # Two operations: create and remove. Create auto-syncs main before branching.
-# Remove is safe by default — guards against CWD-inside-worktree and unpushed
-# commits. Content-aware: allows removal after squash/rebase merge without --force.
+# Remove is safe by default — guards against CWD-inside-worktree, cross-process
+# CWD holds, and unpushed commits. Content-aware: allows removal after
+# squash/rebase merge without --force.
 # Supports --json for machine-readable structured output with recovery commands.
 module Carson
 	class Runtime
@@ -78,12 +79,12 @@ module Carson
 				resolved_path = resolve_worktree_path( worktree_path: worktree_path )
 
 				# Missing directory: worktree was destroyed externally (e.g. gh pr merge
-			# --delete-branch). Clean up the stale git registration and delete the branch.
-			if !Dir.exist?( resolved_path ) && worktree_registered?( path: resolved_path )
-				return worktree_remove_missing!( resolved_path: resolved_path, json_output: json_output )
-			end
+				# --delete-branch). Clean up the stale git registration and delete the branch.
+				if !Dir.exist?( resolved_path ) && worktree_registered?( path: resolved_path )
+					return worktree_remove_missing!( resolved_path: resolved_path, json_output: json_output )
+				end
 
-			unless worktree_registered?( path: resolved_path )
+				unless worktree_registered?( path: resolved_path )
 					return worktree_finish(
 						result: { command: "worktree remove", status: "error", name: File.basename( resolved_path ),
 							error: "#{resolved_path} is not a registered worktree",
@@ -104,6 +105,18 @@ module Carson
 					)
 				end
 
+				# Safety: refuse if another process has its CWD inside the worktree.
+				# Protects against cross-process CWD crashes (e.g. an agent session
+				# removed by a separate cleanup process while the agent's shell is inside).
+				if worktree_held_by_other_process?( worktree_path: resolved_path )
+					return worktree_finish(
+						result: { command: "worktree remove", status: "block", name: File.basename( resolved_path ),
+							error: "another process has its working directory inside this worktree",
+							recovery: "wait for the other session to finish, then retry" },
+						exit_code: EXIT_BLOCK, json_output: json_output
+					)
+				end
+
 				branch = worktree_branch( path: resolved_path )
 				puts_verbose "worktree_remove: path=#{resolved_path} branch=#{branch} force=#{force}"
 
@@ -195,6 +208,7 @@ module Carson
 					next unless branch
 					next unless agent_prefixes.any? { |prefix| path.start_with?( prefix ) }
 					next if cwd_inside_worktree?( worktree_path: path )
+					next if worktree_held_by_other_process?( worktree_path: path )
 					next unless branch_absorbed_into_main?( branch: branch )
 
 					# Remove the worktree (no --force: refuses if dirty working tree).
@@ -303,6 +317,35 @@ module Carson
 				false
 			end
 
+			# Checks whether any other process has its working directory inside the worktree.
+			# Uses lsof to query CWD file descriptors system-wide, then matches against
+			# the worktree path. Catches the cross-process CWD crash scenario: a cleanup
+			# process removing a worktree while another session's shell is still inside it.
+			# Fails safe: returns false if lsof is unavailable or any error occurs.
+			def worktree_held_by_other_process?( worktree_path: )
+				canonical = realpath_safe( worktree_path )
+				return false if canonical.nil? || canonical.empty?
+				return false unless Dir.exist?( canonical )
+
+				stdout, _, status = Open3.capture3( "lsof", "-d", "cwd" )
+				return false unless status.success?
+
+				normalised = File.join( canonical, "" )
+				my_pid = Process.pid
+				stdout.lines.drop( 1 ).any? do |line|
+					fields = line.strip.split( /\s+/ )
+					next false unless fields.length >= 9
+					next false if fields[ 1 ].to_i == my_pid
+					name = fields[ 8.. ].join( " " )
+					name == canonical || name.start_with?( normalised )
+				end
+			rescue Errno::ENOENT
+				# lsof not installed.
+				false
+			rescue StandardError
+				false
+			end
+
 			# Checks whether a branch has unpushed commits that would be lost on removal.
 			# Content-aware: after squash/rebase merge, SHAs differ but tree content may match main. Compares content, not SHAs.
 			# Returns nil if safe, or { error:, recovery: } hash if unpushed work exists.

data/lib/carson/runtime/review/data_access.rb

@@ -1,3 +1,4 @@
+# GraphQL data access: PR details, pagination, and normalisation for review gate and sweep.
 module Carson
 	class Runtime
 		module Review

data/lib/carson/runtime/review/gate_support.rb

@@ -1,3 +1,4 @@
+# Review gate logic: snapshot convergence, disposition acknowledgements, and merge-readiness checks.
 module Carson
 	class Runtime
 		module Review
@@ -30,7 +31,7 @@ module Carson
 					unresolved_threads = unresolved_thread_entries( details: details )
 					actionable_top_level = actionable_top_level_items( details: details, pr_author: pr_author )
 					acknowledgements = disposition_acknowledgements( details: details, pr_author: pr_author )
-					unacknowledged_actionable = actionable_top_level.reject { |item| acknowledged_by_disposition?( item: item, acknowledgements: acknowledgements ) }
+					unacknowledged_actionable = actionable_top_level.reject { acknowledged_by_disposition?( item: it, acknowledgements: acknowledgements ) }
 					{
 						latest_activity: latest_review_activity( details: details ),
 						unresolved_threads: unresolved_threads,
@@ -44,8 +45,8 @@ module Carson
 				def review_gate_signature( snapshot: )
 					{
 						latest_activity: snapshot.fetch( :latest_activity ).to_s,
-						unresolved_urls: snapshot.fetch( :unresolved_threads ).map { |entry| entry.fetch( :url ) }.sort,
-						unacknowledged_urls: snapshot.fetch( :unacknowledged_actionable ).map { |entry| entry.fetch( :url ) }.sort
+						unresolved_urls: snapshot.fetch( :unresolved_threads ).map { it.fetch( :url ) }.sort,
+						unacknowledged_urls: snapshot.fetch( :unacknowledged_actionable ).map { it.fetch( :url ) }.sort
 					}
 				end
 
@@ -67,7 +68,7 @@ module Carson
 				end
 
 				def bot_username?( author: )
-					config.review_bot_usernames.any? { |bot| bot.downcase == author.to_s.downcase }
+					config.review_bot_usernames.any? { it.downcase == author.to_s.downcase }
 				end
 
 				def unresolved_thread_entries( details: )
@@ -78,7 +79,7 @@ module Carson
 						comments = thread.fetch( :comments )
 						first_comment = comments.first || {}
 						next if bot_username?( author: first_comment.fetch( :author, "" ) )
-						latest_time = comments.map { |entry| entry.fetch( :created_at ) }.max.to_s
+						latest_time = comments.map { it.fetch( :created_at ) }.max.to_s
 						{
 							url: blank_to( value: first_comment.fetch( :url, "" ), default: "#{details.fetch( :url )}#thread-#{index + 1}" ),
 							author: first_comment.fetch( :author, "" ),
@@ -130,7 +131,7 @@ module Carson
 					sources = []
 					sources.concat( Array( details.fetch( :comments ) ) )
 					sources.concat( Array( details.fetch( :reviews ) ) )
-					sources.concat( Array( details.fetch( :review_threads ) ).flat_map { |thread| thread.fetch( :comments ) } )
+					sources.concat( Array( details.fetch( :review_threads ) ).flat_map { it.fetch( :comments ) } )
 					sources.map do |entry|
 						next unless entry.fetch( :author, "" ) == pr_author
 						body = entry.fetch( :body, "" ).to_s
@@ -151,7 +152,7 @@ module Carson
 				# True when any disposition acknowledgement references the specific finding URL.
 				def acknowledged_by_disposition?( item:, acknowledgements: )
 					acknowledgements.any? do |ack|
-						Array( ack.fetch( :target_urls ) ).any? { |url| url == item.fetch( :url ) }
+						Array( ack.fetch( :target_urls ) ).any? { it == item.fetch( :url ) }
 					end
 				end
 
@@ -159,10 +160,10 @@ module Carson
 				def latest_review_activity( details: )
 					timestamps = []
 					timestamps << details.fetch( :updated_at )
-					timestamps.concat( Array( details.fetch( :comments ) ).map { |entry| entry.fetch( :created_at ) } )
-					timestamps.concat( Array( details.fetch( :reviews ) ).map { |entry| entry.fetch( :created_at ) } )
-					timestamps.concat( Array( details.fetch( :review_threads ) ).flat_map { |thread| thread.fetch( :comments ) }.map { |entry| entry.fetch( :created_at ) } )
-					timestamps.map { |text| parse_time_or_nil( text: text ) }.compact.max&.utc&.iso8601
+					timestamps.concat( Array( details.fetch( :comments ) ).map { it.fetch( :created_at ) } )
+					timestamps.concat( Array( details.fetch( :reviews ) ).map { it.fetch( :created_at ) } )
+					timestamps.concat( Array( details.fetch( :review_threads ) ).flat_map { it.fetch( :comments ) }.map { it.fetch( :created_at ) } )
+					timestamps.map { parse_time_or_nil( text: it ) }.compact.max&.utc&.iso8601
 				end
 
 				# Writes review gate artefacts using fixed report names in global report output.
@@ -208,7 +209,7 @@ module Carson
 					if report.fetch( :block_reasons ).empty?
 						lines << "- none"
 					else
-						report.fetch( :block_reasons ).each { |reason| lines << "- #{reason}" }
+						report.fetch( :block_reasons ).each { lines << "- #{it}" }
 					end
 					lines << ""
 					lines << "## Unresolved Threads"

data/lib/carson/runtime/review/query_text.rb

@@ -1,3 +1,4 @@
+# GraphQL query templates for pull request review data retrieval.
 module Carson
 	class Runtime
 		module Review

data/lib/carson/runtime/review/sweep_support.rb

@@ -1,3 +1,4 @@
+# Review sweep: late-event detection, tracking issue management, and sweep reporting.
 module Carson
 	class Runtime
 		module Review
@@ -59,7 +60,7 @@ module Carson
 						)
 					end
 
-					Array( details.fetch( :review_threads ) ).flat_map { |thread| thread.fetch( :comments ) }.each do |comment|
+					Array( details.fetch( :review_threads ) ).flat_map { it.fetch( :comments ) }.each do |comment|
 						next if comment.fetch( :author ) == pr_author
 						next if bot_username?( author: comment.fetch( :author ) )
 						hits = matched_risk_keywords( text: comment.fetch( :body ) )
@@ -152,7 +153,7 @@ module Carson
 					stdout_text, stderr_text, success, = gh_run( "issue", "list", "--repo", repo_slug, "--state", "all", "--limit", "100", "--json", "number,title,state,url,labels" )
 					raise gh_error_text( stdout_text: stdout_text, stderr_text: stderr_text, fallback: "unable to list issues for review sweep" ) unless success
 					issues = Array( JSON.parse( stdout_text ) )
-					node = issues.find { |entry| entry[ "title" ].to_s == config.review_tracking_issue_title }
+					node = issues.find { it[ "title" ].to_s == config.review_tracking_issue_title }
 					return nil if node.nil?
 					{
 						number: node[ "number" ],

data/lib/carson/runtime/review/utility.rb

@@ -1,3 +1,4 @@
+# Review utilities: risk keyword matching, disposition parsing, URL extraction, and deduplication.
 module Carson
 	class Runtime
 		module Review
@@ -24,7 +25,7 @@ module Carson
 
 				# GitHub URL extraction for mapping disposition acknowledgements to finding URLs.
 				def extract_github_urls( text: )
-					text.to_s.scan( %r{https://github\.com/[^\s\)\]]+} ).map { |value| value.sub( /[.,;:]+$/, "" ) }.uniq
+					text.to_s.scan( %r{https://github\.com/[^\s\)\]]+} ).map { it.sub( /[.,;:]+$/, "" ) }.uniq
 				end
 
 				# Parse RFC3339 timestamps and return nil on blank/invalid values.

data/lib/carson/runtime/setup.rb

@@ -137,7 +137,7 @@ module Carson
 					{ label: "branch — enforce PR-only merges (default)", value: "branch" },
 					{ label: "trunk — commit directly to main", value: "trunk" }
 				]
-				default_index = options.index { |o| o.fetch( :value ) == current } || 0
+				default_index = options.index { it.fetch( :value ) == current } || 0
 				prompt_choice( options: options, default: default_index )
 			end
 
@@ -151,7 +151,7 @@ module Carson
 					{ label: "rebase — linear history, individual commits", value: "rebase" },
 					{ label: "merge — merge commits", value: "merge" }
 				]
-				default_index = options.index { |o| o.fetch( :value ) == current } || 0
+				default_index = options.index { it.fetch( :value ) == current } || 0
 				prompt_choice( options: options, default: default_index )
 			end
 
@@ -219,7 +219,7 @@ module Carson
 						others << entry
 					end
 				end
-				well_known.sort_by { |e| WELL_KNOWN_REMOTES.index( e.fetch( :name ) ) || 999 } + others.sort_by { |e| e.fetch( :name ) }
+				well_known.sort_by { WELL_KNOWN_REMOTES.index( it.fetch( :name ) ) || 999 } + others.sort_by { it.fetch( :name ) }
 			end
 
 			# Normalises a remote URL so SSH and HTTPS variants of the same host/path compare equal.
@@ -295,7 +295,7 @@ module Carson
 
 			def detect_git_remote
 				remotes = list_git_remotes
-				remote_names = remotes.map { |entry| entry.fetch( :name ) }
+				remote_names = remotes.map { it.fetch( :name ) }
 				return nil if remote_names.empty?
 
 				return config.git_remote if remote_names.include?( config.git_remote )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: carson
 version: !ruby/object:Gem::Version
-  version: 3.19.0
+  version: 3.20.0
 platform: ruby
 authors:
 - Hailei Wang