carson 1.0.0 → 2.6.0

data/lib/carson/runtime/audit.rb

@@ -48,7 +48,6 @@ module Carson
 				audit_state = "block" if default_branch_baseline.fetch( :status ) == "block"
 				audit_state = "attention" if audit_state == "ok" && default_branch_baseline.fetch( :status ) != "ok"
 				scope_guard = print_scope_integrity_guard
-				audit_state = "block" if scope_guard.fetch( :split_required )
 				audit_state = "attention" if audit_state == "ok" && scope_guard.fetch( :status ) == "attention"
 					write_and_print_pr_monitor_report(
 						report: monitor_report.merge(
@@ -279,7 +278,7 @@ module Carson
 					local_rubocop_path = File.join( repo_root, ".rubocop.yml" )
 					if File.file?( local_rubocop_path )
 						report[ :status ] = "block"
-						report[ :reason ] = "repo-local RuboCop config is forbidden: #{relative_path( local_rubocop_path )}; remove it and use ~/AI/CODING/rubocop.yml."
+						report[ :reason ] = "repo-local RuboCop config is forbidden: #{relative_path( local_rubocop_path )}; remove it and use ~/.carson/lint/rubocop.yml."
 						report[ :exit_code ] = EXIT_BLOCK
 						puts_line "lint_#{language}_status: block"
 						puts_line "lint_#{language}_reason: #{report.fetch( :reason )}"
@@ -297,7 +296,7 @@ module Carson
 					report[ :exit_code ] = EXIT_BLOCK
 					puts_line "lint_#{language}_status: block"
 					puts_line "lint_#{language}_reason: #{report.fetch( :reason )}"
-					puts_line "ACTION: run carson lint setup --source <path-or-git-url> to prepare ~/AI/CODING policy files."
+					puts_line "ACTION: run carson lint setup --source <path-or-git-url> to prepare ~/.carson/lint policy files."
 					return report
 				end
 
@@ -403,9 +402,13 @@ module Carson
 				check_runs_total: 0,
 				failing_count: 0,
 				pending_count: 0,
+				advisory_failing_count: 0,
+				advisory_pending_count: 0,
 				no_check_evidence: false,
 				failing: [],
-				pending: []
+				pending: [],
+				advisory_failing: [],
+				advisory_pending: []
 				}
 				unless gh_available?
 					report[ :status ] = "skipped"
@@ -443,15 +446,23 @@ module Carson
 				)
 				check_runs = Array( check_runs_payload[ "check_runs" ] )
 				failing, pending = partition_default_branch_check_runs( check_runs: check_runs )
+				advisory_names = config.audit_advisory_check_names
+				critical_failing, advisory_failing = separate_advisory_check_entries( entries: failing, advisory_names: advisory_names )
+				critical_pending, advisory_pending = separate_advisory_check_entries( entries: pending, advisory_names: advisory_names )
 				report[ :check_runs_total ] = check_runs.count
-				report[ :failing ] = normalise_default_branch_check_entries( entries: failing )
-				report[ :pending ] = normalise_default_branch_check_entries( entries: pending )
+				report[ :failing ] = normalise_default_branch_check_entries( entries: critical_failing )
+				report[ :pending ] = normalise_default_branch_check_entries( entries: critical_pending )
+				report[ :advisory_failing ] = normalise_default_branch_check_entries( entries: advisory_failing )
+				report[ :advisory_pending ] = normalise_default_branch_check_entries( entries: advisory_pending )
 				report[ :failing_count ] = report.fetch( :failing ).count
 				report[ :pending_count ] = report.fetch( :pending ).count
+				report[ :advisory_failing_count ] = report.fetch( :advisory_failing ).count
+				report[ :advisory_pending_count ] = report.fetch( :advisory_pending ).count
 				report[ :no_check_evidence ] = report.fetch( :workflows_total ).positive? && report.fetch( :check_runs_total ).zero?
 				report[ :status ] = "block" if report.fetch( :failing_count ).positive?
 				report[ :status ] = "block" if report.fetch( :pending_count ).positive?
 				report[ :status ] = "block" if report.fetch( :no_check_evidence )
+				report[ :status ] = "attention" if report.fetch( :status ) == "ok" && ( report.fetch( :advisory_failing_count ).positive? || report.fetch( :advisory_pending_count ).positive? )
 				puts_line "default_branch_repository: #{report.fetch( :repository )}"
 				puts_line "default_branch_name: #{report.fetch( :default_branch )}"
 				puts_line "default_branch_head_sha: #{report.fetch( :head_sha )}"
@@ -459,8 +470,12 @@ module Carson
 				puts_line "default_branch_check_runs_total: #{report.fetch( :check_runs_total )}"
 				puts_line "default_branch_failing: #{report.fetch( :failing_count )}"
 				puts_line "default_branch_pending: #{report.fetch( :pending_count )}"
+				puts_line "default_branch_advisory_failing: #{report.fetch( :advisory_failing_count )}"
+				puts_line "default_branch_advisory_pending: #{report.fetch( :advisory_pending_count )}"
 				report.fetch( :failing ).each { |entry| puts_line "default_branch_check_fail: #{entry.fetch( :workflow )} / #{entry.fetch( :name )} #{entry.fetch( :link )}".strip }
 				report.fetch( :pending ).each { |entry| puts_line "default_branch_check_pending: #{entry.fetch( :workflow )} / #{entry.fetch( :name )} #{entry.fetch( :link )}".strip }
+				report.fetch( :advisory_failing ).each { |entry| puts_line "default_branch_check_advisory_fail: #{entry.fetch( :workflow )} / #{entry.fetch( :name )} (advisory) #{entry.fetch( :link )}".strip }
+				report.fetch( :advisory_pending ).each { |entry| puts_line "default_branch_check_advisory_pending: #{entry.fetch( :workflow )} / #{entry.fetch( :name )} (advisory) #{entry.fetch( :link )}".strip }
 				if report.fetch( :no_check_evidence )
 					puts_line "ACTION: default branch has workflow files but no check-runs; align workflow triggers and branch protection check names."
 				end
@@ -525,6 +540,14 @@ module Carson
 				[ failing, pending ]
 			end
 
+			# Separates check-run entries into critical and advisory buckets based on configured advisory names.
+			def separate_advisory_check_entries( entries:, advisory_names: )
+				advisory, critical = Array( entries ).partition do |entry|
+					advisory_names.include?( entry[ "name" ].to_s.strip )
+				end
+				[ critical, advisory ]
+			end
+
 			# Failing means completed with a non-successful conclusion.
 			def default_branch_check_run_failing?( entry: )
 				status = entry[ "status" ].to_s.strip.downcase
@@ -701,11 +724,11 @@ module Carson
 				scope.fetch( :unmatched_paths ).each { |path| puts_line "unmatched_path: #{path}" }
 				puts_line "violating_files_count: #{scope.fetch( :violating_files ).count}"
 				scope.fetch( :violating_files ).each { |path| puts_line "violating_file: #{path} (group=#{scope.fetch( :grouped_paths ).fetch( path )})" }
-				puts_line "checklist_single_business_intent: #{scope.fetch( :split_required ) ? 'needs_review' : 'pass'}"
-				puts_line "checklist_single_scope_group: #{scope.fetch( :split_required ) ? 'needs_split' : 'pass'}"
-				puts_line "checklist_cross_boundary_changes_justified: #{( scope.fetch( :split_required ) || scope.fetch( :misc_present ) ) ? 'needs_explanation' : 'pass'}"
+				puts_line "checklist_single_business_intent: pass"
+				puts_line "checklist_single_scope_group: #{scope.fetch( :split_required ) ? 'advisory' : 'pass'}"
+				puts_line "checklist_cross_boundary_changes_justified: #{( scope.fetch( :split_required ) || scope.fetch( :misc_present ) ) ? 'advisory' : 'pass'}"
 				if scope.fetch( :split_required )
-					puts_line "ACTION: split/re-branch is required before commit; multiple module groups detected."
+					puts_line "ACTION: multiple module groups detected (informational only)."
 				elsif scope.fetch( :misc_present )
 					puts_line "ACTION: unmatched paths detected; classify via scope.path_groups for stricter module checks."
 				else