carrierwave_backgrounder 1.0.0 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a99c578fbe6a6a70dc4139f3d09573f21eedd63745ca9f1020639a0b11866b1
-  data.tar.gz: 4ca00a0ca9da687600ecbd15422a6cd205592cb4f65e98a91b021ce41e352e81
+  metadata.gz: 9db3ebd17e2fba8538ee90f3f451f6d37738a9d833bc5ac9f6f8123a3f7a214a
+  data.tar.gz: 3ef48ab1f8ac80b9ea3e374fd4806b769927baec00cc8c6d7a19b9340cebe906
 SHA512:
-  metadata.gz: d6ef9643b504bff575e97ef7cce7e8d3609efa1315fe77f46f3b6581602e69df8a55696ed3bef03b67cccc9701b55d9e8f74f1cfdec06f3acf6327b6d5670c3d
-  data.tar.gz: b30c5829139120d51681bf9d36503f365e6c273c1c0af73bca63b885fffbbe61bfdc2c777a147b541e3d73d5e45dcb704dd7f3dd4e758c68891022a7acc0e486
+  metadata.gz: 67965fc212f3fa08aa5936815b63a63215550780e2150759d6dc8d87683ca7be2d5614f8d7ba9b93a22e4c1537e6db9fcffb938649708e2e42508bb868835062
+  data.tar.gz: 20c1a3d50441f061701e8ada2af4b2b26706794496f71fa707ff865338358c834ede9de39369e2448b39c149a9cfb6f8528f8a7daa126c3f51a4e7bc1767fe81

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 1.0.2
+
+### bugfixes
+  * [#317] Fixed an issue where #process_in_backfground would copy files but not create versions [Qqwy]
+## 1.0.1
+
+### bugfixes
+  * [#315] Fix an issue where the expectation was a string key for config [fero46]
+
+## 1.0.0
+  * No Changes
 ## 1.0.0-beta.2
 
 ### enhancements

data/lib/backgrounder/version.rb

@@ -1,5 +1,5 @@
 module CarrierWave
   module Backgrounder
-    VERSION = "1.0.0"
+    VERSION = "1.0.2"
   end
 end

data/lib/backgrounder/workers/process_asset_mixin.rb

@@ -11,6 +11,7 @@ module CarrierWave
 
       def perform(*args)
         record = super(*args)
+        record.send(:"process_#{column}_upload=", true)
         asset = record.send(:"#{column}")
 
         return unless record && asset_present?(asset)

data/lib/carrierwave_backgrounder.rb

@@ -17,13 +17,13 @@ module CarrierWave
 
       case backend
       when :active_job
-        @worker_klass = "CarrierWave::Workers::ActiveJob"
+        @worker_klass = 'CarrierWave::Workers::ActiveJob'
 
         require 'active_job'
         require 'backgrounder/workers/active_job/process_asset'
         require 'backgrounder/workers/active_job/store_asset'
 
-        queue_name = queue_options['queue'] || 'carrierwave'
+        queue_name = queue_options[:queue] || 'carrierwave'
 
         ::CarrierWave::Workers::ActiveJob::ProcessAsset.class_eval do
           queue_as queue_name
@@ -32,7 +32,7 @@ module CarrierWave
           queue_as queue_name
         end
       when :sidekiq
-        @worker_klass = "CarrierWave::Workers"
+        @worker_klass = 'CarrierWave::Workers'
 
         require 'sidekiq'
         ::CarrierWave::Workers::ProcessAsset.class_eval do

data/spec/backgrounder/workers/process_asset_spec.rb

@@ -24,6 +24,7 @@ RSpec.describe CarrierWave::Workers::ProcessAsset do
       allow(user).to receive(:find).with('22').and_return(user).once
       allow(user).to receive(:image).thrice.and_return(image)
 
+      expect(user).to receive(:process_image_upload=).with(true).once
       expect(image).to receive(:recreate_versions!).once.and_return(true)
       expect(image).to receive(:file).and_return(image)
     end
@@ -51,6 +52,7 @@ RSpec.describe CarrierWave::Workers::ProcessAsset do
       allow(admin).to receive(:avatar).twice.and_return(avatar)
 
       expect(admin).to receive(:respond_to?).with(:avatar_processing).once.and_return(false)
+      expect(admin).to receive(:process_avatar_upload=).with(true).once
       expect(avatar).to receive(:recreate_versions!).once.and_return(true)
       expect(avatar).to receive(:file).and_return(avatar)
 

data/spec/integrations/process_in_background_multi_upload_spec.rb

@@ -32,7 +32,9 @@ RSpec.describe '::process_in_background multi-upload support', clear_images: tru
 
     it 'creates the versions' do
       version_paths = AvatarUploader.versions.keys.map { |key| admin.images.map { |i| i.send(key).current_path } }.flatten
-      version_paths.each { |path| expect(File.exist? path).to be(true) }
+      version_paths.each { |path| expect(File.exist?(path)).to be(true) }
+      file_sizes = version_paths.map { |path| File.size(path) }
+      expect(file_sizes.uniq.count).to be(4)
     end
 
     it 'removes the files tmp directory' do
@@ -78,4 +80,4 @@ RSpec.describe '::process_in_background multi-upload support', clear_images: tru
       expect(Sidekiq::Queues["carrierwave"].size).to be(0)
     end
   end
-end
+end

data/spec/integrations/process_in_background_spec.rb

@@ -32,7 +32,9 @@ RSpec.describe '::process_in_background', clear_images: true do
 
     it 'creates the versions' do
       version_paths = admin.avatar.versions.keys.map { |key| admin.avatar.send(key).current_path }
-      version_paths.each { |path| expect(File.exist? path).to be(true) }
+      version_paths.each { |path| expect(File.exist?(path)).to be(true) }
+      file_sizes = version_paths.map { |path| File.size(path) }
+      expect(file_sizes.uniq.count).to be(4)
     end
 
     it 'removes the files tmp directory' do
@@ -72,4 +74,4 @@ RSpec.describe '::process_in_background', clear_images: true do
       expect(admin.avatar.file.nil?).to be(true)
     end
   end
-end
+end

data/spec/integrations/store_in_background_multi_upload_spec.rb

@@ -33,7 +33,9 @@ RSpec.describe '::store_in_background multi-upload support', clear_images: true
 
     it 'creates the versions' do
       version_paths = AvatarUploader.versions.keys.map { |key| user.images.map { |i| i.send(key).current_path } }.flatten
-      version_paths.each { |path| expect(File.exist? path).to be(true) }
+      version_paths.each { |path| expect(File.exist?(path)).to be(true) }
+      file_sizes = version_paths.map { |path| File.size(path) }
+      expect(file_sizes.uniq.count).to be(4)
     end
 
     it 'sets the <column>_tmp to nil' do
@@ -84,4 +86,4 @@ RSpec.describe '::store_in_background multi-upload support', clear_images: true
     end
 
   end
-end
+end

data/spec/integrations/store_in_background_spec.rb

@@ -33,7 +33,9 @@ RSpec.describe '::store_in_background', clear_images: true do
 
     it 'creates the versions' do
       version_paths = user.avatar.versions.keys.map { |key| user.avatar.send(key).current_path }
-      version_paths.each { |path| expect(File.exist? path).to be(true) }
+      version_paths.each { |path| expect(File.exist?(path)).to be(true) }
+      file_sizes = version_paths.map { |path| File.size(path) }
+      expect(file_sizes.uniq.count).to be(4)
     end
 
     it 'sets the <column>_tmp to nil' do
@@ -83,4 +85,4 @@ RSpec.describe '::store_in_background', clear_images: true do
       expect(Sidekiq::Queues["carrierwave"].size).to be(0)
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: carrierwave_backgrounder
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.2
 platform: ruby
 authors:
 - Larry Sprock
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-25 00:00:00.000000000 Z
+date: 2023-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: carrierwave