carrierwave 3.0.1 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93ce71b0513b78b021bb85c121625135145ea8b78fc21bb64542e9114220d6cf
-  data.tar.gz: cfa74c58a128998a51b9d50d1f1f5d44ca95aeeb1847ff860fc9e55aedc33f61
+  metadata.gz: e7d9ca1331d473162430928f5819d657e9c601b5663965a75f37c2eacb5bd344
+  data.tar.gz: a78745cfdebaa9b1d3cf49cfc513ac248d83690a6f1bafd6384dab81acd3e150
 SHA512:
-  metadata.gz: 320adb08f7b9e280f43daa2663acd22bbe7bfc26a03461210a888e593136fd65c641f2aae3d332091ab4c59704cec6b9293864f85e7eb676ebebd06648c1b943
-  data.tar.gz: 140d651ba46ecda9e0e9209e01731e02782d3e4dc113e6e0b042faa64b3277aace8ac1f69a9f626bf0e083f4b60b5b9665612ae66b481c1f96b0ef074961d7cc
+  metadata.gz: 51207e993ab7aaed4e68d338c7fdbfeee7f1334d914a403890c9364ad3d5aeadbd94206cc3b5fbb07bec7d7372abd346239e979a4d6c6f3c5278e92b4a823c94
+  data.tar.gz: fcc86123d64aabeb6de357cf81f632c3343b3951915d21f1b69e04c8bacb2e7e4c14c8efab9e4b0be33fac28efb228a0e7795615d19d913c33806eccb8adaedc

data/lib/carrierwave/mounter.rb

@@ -139,20 +139,22 @@ module CarrierWave
     end
 
     def store!
-      additions, remains = uploaders.partition(&:cached?)
-      existing_paths = (@removed_uploaders + remains).map(&:store_path)
-      additions.each do |uploader|
-        uploader.deduplicate(existing_paths)
-        uploader.store!
-        existing_paths << uploader.store_path
-      end
-      @added_uploaders += additions
+      uploaders.each(&:store!)
     end
 
     def write_identifier
       return if record.frozen?
 
       clear! if remove?
+
+      additions, remains = uploaders.partition(&:cached?)
+      existing_identifiers = (@removed_uploaders + remains).map(&:identifier)
+      additions.each do |uploader|
+        uploader.deduplicate(existing_identifiers)
+        existing_identifiers << uploader.identifier
+      end
+      @added_uploaders += additions
+
       record.write_uploader(serialization_column, identifier)
     end
 

data/lib/carrierwave/orm/activerecord.rb

@@ -44,9 +44,9 @@ module CarrierWave
         def initialize_dup(other)
           old_uploaders = _mounter(:"#{column}").uploaders
           @_mounters[:"#{column}"] = nil
+          super
           # The attribute needs to be cleared to prevent it from picked up as identifier
           write_attribute(:"#{column}", nil)
-          super
           _mounter(:"#{column}").cache(old_uploaders)
         end
 

data/lib/carrierwave/uploader/store.rb

@@ -108,22 +108,22 @@ module CarrierWave
       end
 
       ##
-      # Look for a store path which doesn't collide with the given already-stored paths.
+      # Look for an identifier which doesn't collide with the given already-stored identifiers.
       # It is done by adding a index number as the suffix.
       # For example, if there's 'image.jpg' and the @deduplication_index is set to 2,
       # The stored file will be named as 'image(2).jpg'.
       #
       # === Parameters
       #
-      # [current_paths (Array[String])] List of paths for already-stored files
+      # [current_identifiers (Array[String])] List of identifiers for already-stored files
       #
-      def deduplicate(current_paths)
+      def deduplicate(current_identifiers)
         @deduplication_index = nil
-        return unless current_paths.include?(store_path)
+        return unless current_identifiers.include?(identifier)
 
-        (1..current_paths.size + 1).each do |i|
+        (1..current_identifiers.size + 1).each do |i|
           @deduplication_index = i
-          break unless current_paths.include?(store_path)
+          break unless current_identifiers.include?(identifier)
         end
       end
 

data/lib/carrierwave/version.rb

@@ -1,3 +1,3 @@
 module CarrierWave
-  VERSION = "3.0.1".freeze
+  VERSION = "3.0.3".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: carrierwave
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.0.3
 platform: ruby
 authors:
 - Jonas Nicklas
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-22 00:00:00.000000000 Z
+date: 2023-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport