carrierwave 0.11.2 → 1.0.0.beta

data/lib/carrierwave/uploader/default_url.rb

@@ -1,19 +1,17 @@
-# encoding: utf-8
-
 module CarrierWave
   module Uploader
     module DefaultUrl
 
       def url(*args)
-        super || default_url
+        super || default_url(*args)
       end
 
       ##
       # Override this method in your uploader to provide a default url
       # in case no file has been cached/stored yet.
       #
-      def default_url; end
+      def default_url(*args); end
 
     end # DefaultPath
   end # Uploader
-end # CarrierWave
+end # CarrierWave

data/lib/carrierwave/uploader/download.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'open-uri'
 
 module CarrierWave
@@ -37,12 +35,12 @@ module CarrierWave
 
         def file
           if @file.blank?
-            @file = Kernel.open(@uri.to_s)
+            @file = Kernel.open(@uri.to_s, "User-Agent" => "CarrierWave/#{CarrierWave::VERSION}")
             @file = @file.is_a?(String) ? StringIO.new(@file) : @file
           end
           @file
 
-        rescue Exception => e
+        rescue StandardError => e
           raise CarrierWave::DownloadError, "could not download file: #{e.message}"
         end
 

data/lib/carrierwave/uploader/extension_blacklist.rb

@@ -4,7 +4,7 @@ module CarrierWave
       extend ActiveSupport::Concern
 
       included do
-        before :cache, :check_blacklist!
+        before :cache, :check_extension_blacklist!
       end
 
       ##
@@ -16,32 +16,36 @@ module CarrierWave
       # the Regexp expression, also case insensitive.
       #
       # === Returns
-      
-      # [NilClass, Array[String,Regexp]] a black list of extensions which are prohibited to be uploaded
+
+      # [NilClass, String, Regexp, Array[String, Regexp]] a black list of extensions which are prohibited to be uploaded
       #
       # === Examples
       #
-      #     def extension_black_list
+      #     def extension_blacklist
       #       %w(swf tiff)
       #     end
       #
       # Basically the same, but using a Regexp:
       #
-      #     def extension_black_list
+      #     def extension_blacklist
       #       [/swf/, 'tiff']
       #     end
       #
- 
-      def extension_black_list; end
+
+      def extension_blacklist; end
 
     private
 
-      def check_blacklist!(new_file)
+      def check_extension_blacklist!(new_file)
         extension = new_file.extension.to_s
-        if extension_black_list and extension_black_list.detect { |item| extension =~ /\A#{item}\z/i }
-          raise CarrierWave::IntegrityError, I18n.translate(:"errors.messages.extension_black_list_error", :extension => new_file.extension.inspect, :prohibited_types => extension_black_list.join(", "))
+        if extension_blacklist && blacklisted_extension?(extension)
+          raise CarrierWave::IntegrityError, I18n.translate(:"errors.messages.extension_blacklist_error", extension: new_file.extension.inspect, prohibited_types: Array(extension_blacklist).join(", "))
         end
       end
+
+      def blacklisted_extension?(extension)
+        Array(extension_blacklist).any? { |item| extension =~ /\A#{item}\z/i }
+      end
     end
   end
 end

data/lib/carrierwave/uploader/extension_whitelist.rb

@@ -1,12 +1,10 @@
-# encoding: utf-8
-
 module CarrierWave
   module Uploader
     module ExtensionWhitelist
       extend ActiveSupport::Concern
 
       included do
-        before :cache, :check_whitelist!
+        before :cache, :check_extension_whitelist!
       end
 
       ##
@@ -19,31 +17,35 @@ module CarrierWave
       #
       # === Returns
       #
-      # [NilClass, Array[String,Regexp]] a white list of extensions which are allowed to be uploaded
+      # [NilClass, String, Regexp, Array[String, Regexp]] a white list of extensions which are allowed to be uploaded
       #
       # === Examples
       #
-      #     def extension_white_list
+      #     def extension_whitelist
       #       %w(jpg jpeg gif png)
       #     end
       #
       # Basically the same, but using a Regexp:
       #
-      #     def extension_white_list
+      #     def extension_whitelist
       #       [/jpe?g/, 'gif', 'png']
       #     end
       #
-      def extension_white_list; end
+      def extension_whitelist; end
 
     private
 
-      def check_whitelist!(new_file)
+      def check_extension_whitelist!(new_file)
         extension = new_file.extension.to_s
-        if extension_white_list and not extension_white_list.detect { |item| extension =~ /\A#{item}\z/i }
-          raise CarrierWave::IntegrityError, I18n.translate(:"errors.messages.extension_white_list_error", :extension => new_file.extension.inspect, :allowed_types => extension_white_list.join(", "))
+        if extension_whitelist && !whitelisted_extension?(extension)
+          raise CarrierWave::IntegrityError, I18n.translate(:"errors.messages.extension_whitelist_error", extension: new_file.extension.inspect, allowed_types: Array(extension_whitelist).join(", "))
         end
       end
 
+      def whitelisted_extension?(extension)
+        Array(extension_whitelist).any? { |item| extension =~ /\A#{item}\z/i }
+      end
+
     end # ExtensionWhitelist
   end # Uploader
 end # CarrierWave

data/lib/carrierwave/uploader/file_size.rb

@@ -0,0 +1,41 @@
+module CarrierWave
+  module Uploader
+    module FileSize
+      extend ActiveSupport::Concern
+
+      included do
+        before :cache, :check_size!
+      end
+
+      ##
+      # Override this method in your uploader to provide a Range of Size which
+      # are allowed to be uploaded.
+      # === Returns
+      #
+      # [NilClass, Range] a size range which are permitted to be uploaded
+      #
+      # === Examples
+      #
+      #     def size_range
+      #       3256...5748
+      #     end
+      #
+      def size_range; end
+
+      private
+
+      def check_size!(new_file)
+        size = new_file.size
+        expected_size_range = size_range
+        if expected_size_range.is_a?(::Range)
+          if size < expected_size_range.min
+            raise CarrierWave::IntegrityError, I18n.translate(:"errors.messages.min_size_error", :min_size => expected_size_range.min)
+          elsif size > expected_size_range.max
+            raise CarrierWave::IntegrityError, I18n.translate(:"errors.messages.max_size_error", :max_size => expected_size_range.max)
+          end
+        end
+      end
+
+    end # FileSize
+  end # Uploader
+end # CarrierWave

data/lib/carrierwave/uploader/magic_mime_blacklist.rb

@@ -0,0 +1,94 @@
+module CarrierWave
+  module Uploader
+
+    ##
+    # This modules validates the content type of a file with the use of
+    # ruby-filemagic gem and a blacklist regular expression. If you want
+    # to use this, you'll need to require this file:
+    #
+    #   require 'carrierwave/uploader/magic_mime_blacklist'
+    #
+    # And then include it in your uploader:
+    #
+    #   class MyUploader < CarrierWave::Uploader::Base
+    #     include CarrierWave::Uploader::MagicMimeBlacklist
+    #
+    #     def blacklist_mime_type_pattern
+    #       /image\//
+    #     end
+    #   end
+    #
+    module MagicMimeBlacklist
+      extend ActiveSupport::Concern
+
+      included do
+        begin
+          require "filemagic"
+        rescue LoadError => e
+          e.message << " (You may need to install the ruby-filemagic gem)"
+          raise e
+        end
+
+        before :cache, :check_blacklist_pattern!
+      end
+
+      ##
+      # Override this method in your uploader to provide a black list pattern (regexp)
+      # of content-types which are prohibited to be uploaded.
+      # Compares the file's content-type.
+      #
+      # === Returns
+      #
+      # [Regexp] a black list regexp to match the content_type
+      #
+      # === Examples
+      #
+      #     def blacklist_mime_type_pattern
+      #       /(text|application)\/json/
+      #     end
+      #
+      def blacklist_mime_type_pattern; end
+
+    private
+
+      def check_blacklist_pattern!(new_file)
+        return if blacklist_mime_type_pattern.nil?
+
+        content_type = extract_content_type(new_file)
+
+        if content_type.match(blacklist_mime_type_pattern)
+          raise CarrierWave::IntegrityError,
+            I18n.translate(:"errors.messages.mime_type_pattern_black_list_error",
+                           :content_type => content_type)
+        end
+      end
+
+      ##
+      # Extracts the content type of the given file
+      #
+      # === Returns
+      #
+      # [String] the extracted content type
+      #
+      def extract_content_type(new_file)
+        content_type = nil
+
+        File.open(new_file.path) do |fd|
+          data = fd.read(1024) || ""
+          content_type = filemagic.buffer(data)
+        end
+
+        content_type
+      end
+
+    ##
+    # FileMagic object with the MAGIC_MIME_TYPE flag set
+    #
+    # @return [FileMagic] a filemagic object
+      def filemagic
+        @filemagic ||= FileMagic.new(FileMagic::MAGIC_MIME_TYPE)
+      end
+
+    end # MagicMimeblackList
+  end # Uploader
+end # CarrierWave

data/lib/carrierwave/uploader/magic_mime_whitelist.rb

@@ -0,0 +1,94 @@
+module CarrierWave
+  module Uploader
+
+    ##
+    # This modules validates the content type of a file with the use of
+    # ruby-filemagic gem and a whitelist regular expression. If you want
+    # to use this, you'll need to require this file:
+    #
+    #   require 'carrierwave/uploader/magic_mime_whitelist'
+    #
+    # And then include it in your uploader:
+    #
+    #   class MyUploader < CarrierWave::Uploader::Base
+    #     include CarrierWave::Uploader::MagicMimeWhitelist
+    #
+    #     def whitelist_mime_type_pattern
+    #       /image\//
+    #     end
+    #   end
+    #
+    module MagicMimeWhitelist
+      extend ActiveSupport::Concern
+
+      included do
+        begin
+          require "filemagic"
+        rescue LoadError => e
+          e.message << " (You may need to install the ruby-filemagic gem)"
+          raise e
+        end
+
+        before :cache, :check_whitelist_pattern!
+      end
+
+      ##
+      # Override this method in your uploader to provide a white list pattern (regexp)
+      # of content-types which are allowed to be uploaded.
+      # Compares the file's content-type.
+      #
+      # === Returns
+      #
+      # [Regexp] a white list regexp to match the content_type
+      #
+      # === Examples
+      #
+      #     def whitelist_mime_type_pattern
+      #       /(text|application)\/json/
+      #     end
+      #
+      def whitelist_mime_type_pattern; end
+
+    private
+
+      def check_whitelist_pattern!(new_file)
+        return if whitelist_mime_type_pattern.nil?
+
+        content_type = extract_content_type(new_file)
+
+        if !content_type.match(whitelist_mime_type_pattern)
+          raise CarrierWave::IntegrityError,
+            I18n.translate(:"errors.messages.mime_type_pattern_white_list_error",
+                           :content_type => content_type)
+        end
+      end
+
+      ##
+      # Extracts the content type of the given file
+      #
+      # === Returns
+      #
+      # [String] the extracted content type
+      #
+      def extract_content_type(new_file)
+        content_type = nil
+
+        File.open(new_file.path) do |fd|
+          data = fd.read(1024) || ""
+          content_type = filemagic.buffer(data)
+        end
+
+        content_type
+      end
+
+    ##
+    # FileMagic object with the MAGIC_MIME_TYPE flag set
+    #
+    # @return [FileMagic] a filemagic object
+      def filemagic
+        @filemagic ||= FileMagic.new(FileMagic::MAGIC_MIME_TYPE)
+      end
+
+    end # MagicMimeWhiteList
+  end # Uploader
+end # CarrierWave

data/lib/carrierwave/uploader/mountable.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 module CarrierWave
   module Uploader
     module Mountable
@@ -7,13 +5,14 @@ module CarrierWave
       attr_reader :model, :mounted_as
 
       ##
-      # If a model is given as the first parameter, it will be stored in the uploader, and
-      # available throught +#model+. Likewise, mounted_as stores the name of the column
-      # where this instance of the uploader is mounted. These values can then be used inside
-      # your uploader.
+      # If a model is given as the first parameter, it will be stored in the
+      # uploader, and available through +#model+. Likewise, mounted_as stores
+      # the name of the column where this instance of the uploader is mounted.
+      # These values can then be used inside your uploader.
       #
-      # If you do not wish to mount your uploaders with the ORM extensions in -more then you
-      # can override this method inside your uploader. Just be sure to call +super+
+      # If you do not wish to mount your uploaders with the ORM extensions in
+      # -more then you can override this method inside your uploader. Just be
+      # sure to call +super+
       #
       # === Parameters
       #

data/lib/carrierwave/uploader/processing.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 module CarrierWave
   module Uploader
     module Processing
@@ -11,7 +9,7 @@ module CarrierWave
         class_attribute :processors, :instance_writer => false
         self.processors = []
 
-        after :cache, :process!
+        before :cache, :process!
       end
 
       module ClassMethods

data/lib/carrierwave/uploader/proxy.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 module CarrierWave
   module Uploader
     module Proxy
@@ -19,7 +17,7 @@ module CarrierWave
       # [String] the path where the file is currently located.
       #
       def current_path
-        file.path if file.respond_to?(:path)
+        file.try(:path)
       end
 
       alias_method :path, :current_path
@@ -32,7 +30,7 @@ module CarrierWave
       # [String] uniquely identifies a file
       #
       def identifier
-        storage.identifier if storage.respond_to?(:identifier)
+        storage.try(:identifier)
       end
 
       ##
@@ -43,7 +41,7 @@ module CarrierWave
       # [String] contents of the file
       #
       def read
-        file.read if file.respond_to?(:read)
+        file.try(:read)
       end
 
       ##
@@ -54,7 +52,7 @@ module CarrierWave
       # [Integer] size of the file
       #
       def size
-        file.respond_to?(:size) ? file.size : 0
+        file.try(:size) || 0
       end
 
       ##
@@ -80,7 +78,7 @@ module CarrierWave
       # [String] content type of the file
       #
       def content_type
-        file.respond_to?(:content_type) ? file.content_type : nil
+        file.try(:content_type)
       end
 
     end # Proxy