carrierwave-aliyun 1.1.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f6d5d5c0acc30b46d90292f4a90c05e90667bdbf40ec97b279342aa215a4f2ff
-  data.tar.gz: f3b67cdf10f5800c250dafce535a6df95951c6c967e825f18fc3a656fa35268f
+  metadata.gz: 03a96d213f40d85c4e9cb135f1e32490fd3dcd2c38e1fe4c5fb866a0c06f8813
+  data.tar.gz: 372720e762645aed633542bce67a177b1718a1282ddf0012ca8d52eab554718d
 SHA512:
-  metadata.gz: 4d0ba7b297d56905fdb8d24697e02e7ba56f89c0ea91ea7f73784746f404d2a7de2d0161c1a9b9b70c6e66050247ecc0828ce2396bccfa25ab24bd49ba11499c
-  data.tar.gz: 9a6ee10ee4fb3299e9ef3170f1b4e41bc32d5137ee601295b2fed394cc060148f371835519db6af16bc5e6bf0f3be6164b4462b7fba202929505fe0d21562bf6
+  metadata.gz: a4957fb8b0998385cd932c142688cfd6dd8a2d9a971822a0fbf345e26382f2b44055e9a68e59a6ebc9c2ffae64a225eac6e30b97e43c4499ba177684982d38c0
+  data.tar.gz: 808b8d986b14cf9fcc25fd551c752a81e55bf59cd42db1b08b3c124a0de920254ea1f79fa5ca91a6c45ace1078716c097579f15f824edfa1117f5229a1b0c6db

data/CHANGELOG.md

@@ -1,3 +1,25 @@
+## 1.2.1
+
+- 实现 `size` 方法，修正更新图片数组时，新上传的图片会取代旧图片的问题。(#73)
+
+## 1.2.0
+
+- 整理修复 OSS 文件访问 URL 的生成方式，去掉 img host，保持和最新 OSS API 一样的逻辑。
+- 生成 URL 的时候，不再强制替换为 https，保持 `aliyun_host` 的配置；
+
+## 1.1.2
+
+- 修正 aliyun-sdk 0.7.0 以上 Thumb URL 生成的支持；
+- Requirement aliyun-sdk >= 0.7.0;
+
+## 1.1.2
+
+- 修正废弃调用方式，避免在 Ruby 2.7 里面出现 warning.
+
+## 1.1.1
+
+- 对于 CarrierWave 的 cache 机制正确支持；
+
 ## 1.1.0
 
 - 支持 CarrierWave 2.0;

data/lib/carrierwave/aliyun/bucket.rb

@@ -3,12 +3,12 @@
 module CarrierWave
   module Aliyun
     class Bucket
-      PATH_PREFIX = %r{^/}
+      PATH_PREFIX = %r{^/}.freeze
       CHUNK_SIZE = 1024 * 1024
 
       attr_reader :access_key_id, :access_key_secret, :bucket, :region, :mode, :host
 
-      attr_reader :endpoint, :img_endpoint, :upload_endpoint
+      attr_reader :endpoint, :upload_endpoint, :get_endpoint
 
       def initialize(uploader)
         if uploader.aliyun_area.present?
@@ -16,7 +16,7 @@ module CarrierWave
           uploader.aliyun_region ||= uploader.aliyun_area
         end
 
-        if uploader.aliyun_private_read != nil
+        unless uploader.aliyun_private_read.nil?
           ActiveSupport::Deprecation.warn(%(config.aliyun_private_read will deprecation in carrierwave-aliyun 1.1.0, please use `aliyun_mode = :private` instead.))
           uploader.aliyun_mode ||= uploader.aliyun_private_read ? :private : :public
         end
@@ -38,15 +38,15 @@ module CarrierWave
         @mode              = (uploader.aliyun_mode || :public).to_sym
 
         # Host for get request
-        @host = uploader.aliyun_host || "https://#{self.bucket}.oss-#{self.region}.aliyuncs.com"
+        @endpoint = "https://#{bucket}.oss-#{region}.aliyuncs.com"
+        @host = uploader.aliyun_host || @endpoint
 
         unless @host.include?("//")
-          raise "config.aliyun_host requirement include // http:// or https://, but you give: #{self.host}"
+          raise "config.aliyun_host requirement include // http:// or https://, but you give: #{host}"
         end
 
-        @endpoint = "https://oss-#{self.region}.aliyuncs.com"
-        @upload_endpoint = uploader.aliyun_internal == true ? "https://oss-#{self.region}-internal.aliyuncs.com" : @endpoint
-        @img_endpoint = "https://img-#{self.region}.aliyuncs.com"
+        @get_endpoint = "https://oss-#{region}.aliyuncs.com"
+        @upload_endpoint = uploader.aliyun_internal == true ? "https://oss-#{region}-internal.aliyuncs.com" : "https://oss-#{region}.aliyuncs.com"
       end
 
       # 上传文件
@@ -70,11 +70,18 @@ module CarrierWave
             stream << file.read(CHUNK_SIZE) until file.eof?
           end
           path_to_url(path)
-        rescue => e
+        rescue StandardError => e
           raise "Put file failed: #{e}"
         end
       end
 
+      def copy_object(source, dest)
+        source = source.sub(PATH_PREFIX, "")
+        dest = dest.sub(PATH_PREFIX, "")
+
+        oss_upload_client.copy_object(source, dest)
+      end
+
       # 读取文件
       # params:
       # - path - remote 存储路径
@@ -88,7 +95,7 @@ module CarrierWave
         end
 
         [obj, chunk_buff.join("")]
-      rescue => e
+      rescue StandardError => e
         raise "Get content faild: #{e}"
       end
 
@@ -103,62 +110,60 @@ module CarrierWave
         path = path.sub(PATH_PREFIX, "")
         oss_upload_client.delete_object(path)
         path_to_url(path)
-      rescue => e
+      rescue StandardError => e
         raise "Delete failed: #{e}"
       end
 
       ##
       # 根据配置返回完整的上传文件的访问地址
       def path_to_url(path, thumb: nil)
-        path = path.sub(PATH_PREFIX, "")
-
-        if thumb
-          [self.host, [path, thumb].join("")].join("/")
-        else
-          [self.host, path].join("/")
-        end
+        get_url(path, thumb: thumb)
       end
 
       # 私有空间访问地址，会带上实时算出的 token 信息
       # 有效期 15 minutes
       def private_get_url(path, thumb: nil)
+        get_url(path, private: true, thumb: thumb)
+      end
+
+      def get_url(path, private: false, thumb: nil)
         path = path.sub(PATH_PREFIX, "")
 
-        url = if thumb
-                img_client.object_url([path, thumb].join(""), expiry: 15.minutes)
+        url = if thumb&.start_with?("?")
+                # foo.jpg?x-oss-process=image/resize,h_100
+                parameters = { "x-oss-process" => thumb.split("=").last }
+                oss_client.object_url(path, private, 15.minutes, parameters)
               else
-                oss_client.object_url(path, expiry: 15.minutes)
+                oss_client.object_url(path, private, 15.minutes)
               end
 
-        url.sub("http://", "https://")
+        unless private
+          url = [url, thumb].join("") unless thumb&.start_with?("?")
+        end
+
+        url.sub(endpoint, host)
       end
 
       def head(path)
-        oss_client.get_object_meta(path)
+        path = path.sub(PATH_PREFIX, "")
+        oss_upload_client.get_object(path)
       end
 
       private
 
-        def oss_client
-          return @oss_client if defined?(@oss_client)
-          client = ::Aliyun::OSS::Client.new(endpoint: self.endpoint,
-            access_key_id: self.access_key_id, access_key_secret: self.access_key_secret)
-          @oss_client = client.get_bucket(self.bucket)
-        end
+      def oss_client
+        return @oss_client if defined?(@oss_client)
 
-        def img_client
-          return @img_client if defined?(@img_client)
-          client = ::Aliyun::OSS::Client.new(endpoint: self.img_endpoint,
-            access_key_id: self.access_key_id, access_key_secret: self.access_key_secret)
-          @img_client = client.get_bucket(self.bucket)
-        end
+        client = ::Aliyun::OSS::Client.new(endpoint: get_endpoint, access_key_id: access_key_id, access_key_secret: access_key_secret)
+        @oss_client = client.get_bucket(bucket)
+      end
 
-        def oss_upload_client
-          return @oss_upload_client if defined?(@oss_upload_client)
-          client = ::Aliyun::OSS::Client.new(endpoint: self.upload_endpoint,
-            access_key_id: self.access_key_id, access_key_secret: self.access_key_secret)
-          @oss_upload_client = client.get_bucket(self.bucket)
-        end
+      def oss_upload_client
+        return @oss_upload_client if defined?(@oss_upload_client)
+
+        client = ::Aliyun::OSS::Client.new(endpoint: upload_endpoint, access_key_id: access_key_id, access_key_secret: access_key_secret)
+        @oss_upload_client = client.get_bucket(bucket)
+      end
     end
   end
 end

data/lib/carrierwave/aliyun/version.rb

@@ -2,6 +2,6 @@
 
 module CarrierWave
   module Aliyun
-    VERSION = "1.1.0"
+    VERSION = "1.2.1"
   end
 end

data/lib/carrierwave/storage/aliyun.rb

@@ -3,14 +3,14 @@
 module CarrierWave
   module Storage
     class Aliyun < Abstract
-      def store!(file)
+      def store!(new_file)
         f = AliyunFile.new(uploader, self, uploader.store_path)
         headers = {
-          content_type: file.content_type,
+          content_type: new_file.content_type,
           content_disposition: uploader.try(:content_disposition)
         }
 
-        f.store(::File.open(file.file), headers)
+        f.store(new_file, headers)
         f
       end
 
@@ -18,19 +18,19 @@ module CarrierWave
         AliyunFile.new(uploader, self, uploader.store_path(identifier))
       end
 
-      def cache!(file)
-        f = AliyunFile.new(uploader, self, uploader.store_path)
+      def cache!(new_file)
+        f = AliyunFile.new(uploader, self, uploader.cache_path)
         headers = {
-          content_type: file.content_type,
+          content_type: new_file.content_type,
           content_disposition: uploader.try(:content_disposition)
         }
 
-        f.store(::File.open(file.file), headers)
+        f.store(new_file, headers)
         f
       end
 
       def retrieve_from_cache!(identifier)
-        AliyunFile.new(uploader, self, uploader.store_path(identifier))
+        AliyunFile.new(uploader, self, uploader.cache_path(identifier))
       end
 
       def delete_dir!(path)
@@ -38,8 +38,21 @@ module CarrierWave
       end
 
       def clean_cache!(_seconds)
-        raise 'use Object Lifecycle Management to clean the cache'
+        will_remove_keys = []
+        bucket.list_objects(prefix: uploader.cache_path).each do |file|
+          next unless file.is_a?(Object)
+          time = file.key.scan(/(\d+)-\d+-\d+(?:-\d+)?/).first.map { |t| t.to_i }
+          time = Time.at(*time)
+          will_remove_keys << item.key if time < (Time.now.utc - seconds)
+        end
+        bucket.batch_delete_objects(will_remove_keys)
       end
+
+      private
+
+        def bucket
+          @bucket ||= CarrierWave::Aliyun::Bucket.new(uploader)
+        end
     end
   end
 end

data/lib/carrierwave/storage/aliyun_file.rb

@@ -2,23 +2,37 @@
 
 module CarrierWave
   module Storage
-    class AliyunFile < CarrierWave::SanitizedFile
-      attr_reader :path
+    class AliyunFile
+      attr_writer :file
+      attr_reader :uploader, :path
+
+      alias_method :filename, :path
+      alias_method :identifier, :filename
 
       def initialize(uploader, base, path)
-        @uploader = uploader
-        @path     = URI.encode(path)
-        @base     = base
+        @uploader, @path, @base = uploader, escape(path), base
+      end
+
+      def file
+        @file ||= bucket.get(path).try(:first)
+      end
+
+      def size
+        file.headers[:content_length].to_i rescue nil
+      end
+
+      def escape(path)
+        CGI.escape(path).gsub("%2F", "/")
       end
 
       def read
-        object, body = bucket.get(@path)
+        object, body = bucket.get(path)
         @headers = object.headers
         body
       end
 
       def delete
-        bucket.delete(@path)
+        bucket.delete(path)
         true
       rescue => e
         # If the file's not there, don't panic
@@ -33,9 +47,9 @@ module CarrierWave
       #
       def url(opts = {})
         if bucket.mode == :private
-          bucket.private_get_url(@path, opts)
+          bucket.private_get_url(path, **opts)
         else
-          bucket.path_to_url(@path, opts)
+          bucket.path_to_url(path, **opts)
         end
       end
 
@@ -49,22 +63,49 @@ module CarrierWave
 
       def store(new_file, headers = {})
         if new_file.is_a?(self.class)
-          new_file.move_to(path)
+          new_file.copy_to(path)
         else
-          bucket.put(@path, new_file, headers)
+          fog_file = new_file.to_file
+          bucket.put(path, fog_file, **headers)
+          fog_file.close if fog_file && !fog_file.closed?
         end
+        true
       end
 
       def headers
-        @headers ||= {}
+        @headers ||= begin
+          obj = bucket.head(path)
+          obj.headers
+        end
+      end
+
+      def exists?
+        !!headers
+      end
+
+      def copy_to(new_path)
+        bucket.copy_object(path, new_path)
+        self.class.new(uploader, @base, new_path)
+      end
+
+      def extension
+        path_elements = path.split(".")
+        path_elements.last if path_elements.size > 1
+      end
+
+      def original_filename
+        return @original_filename if @original_filename
+        if @file && @file.respond_to?(:original_filename)
+          @file.original_filename
+        elsif path
+          ::File.basename(path)
+        end
       end
 
       private
 
         def bucket
-          return @bucket if defined? @bucket
-
-          @bucket = CarrierWave::Aliyun::Bucket.new(@uploader)
+          @bucket ||= CarrierWave::Aliyun::Bucket.new(uploader)
         end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: carrierwave-aliyun
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Jason Lee
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-08-20 00:00:00.000000000 Z
+date: 2021-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: carrierwave
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.7.0
 description: Aliyun OSS support for Carrierwave
 email:
 - huacnlee@gmail.com
@@ -57,7 +57,7 @@ homepage: https://github.com/huacnlee/carrierwave-aliyun
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -72,8 +72,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Aliyun OSS support for Carrierwave
 test_files: []