carioca 2.1.3 → 2.1.5

data/lib/carioca/services/sanitycheck.rb

@@ -1,143 +1,127 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 # base Carioca namespace
 module Carioca
-    
-    module Services
-        
-        # Exiter namespace
-        class Sanitycheck
+  module Services
+    # Exiter namespace
+    class Sanitycheck
+      def initialize
+        registry = Carioca::Registry.get
+        @output = registry.get_service name: :output
+        @i18n = registry.get_service name: :i18n
+        @toolbox = registry.get_service name: :toolbox
+        @configuration = registry.get_service name: :configuration
+        @finisher = registry.get_service name: :finisher
+        @schema = {}
+        if @configuration.settings.include? :sanitycheck
+          @schema = @configuration.settings.sanitycheck.include?(:rules) ? @configuration.settings.sanitycheck.rules : {}
+        end
+      end
 
-            def initialize
-                registry = Carioca::Registry.get
-                @output = registry.get_service name: :output
-                @i18n = registry.get_service name: :i18n
-                @toolbox = registry.get_service name: :toolbox
-                @configuration = registry.get_service name: :configuration
-                @finisher = registry.get_service name: :finisher
-                @schema = {}
-                if @configuration.settings.include? :sanitycheck then
-                    @schema = (@configuration.settings.sanitycheck.include? :rules)? @configuration.settings.sanitycheck.rules : {}
-                end
+      def run
+        unless @schema.empty?
+          begin
+            @output.info @i18n.t('sanitycheck.run.start')
+            error_number = 0
+            @schema.each do |item|
+              testcase = item[:test]
+              item.delete(:test)
+              res = send(testcase, **item)
+              if  res.empty?
+                @output.ok @i18n.t('sanitycheck.run.ok', testcase:, name: item[:name].to_s)
+              else
+                pbm = res.map(&:to_s).join(',')
+                @output.ko @i18n.t('sanitycheck.run.ko', testcase:, name: item[:name].to_s, pbm:)
+                error_number = + 1
+              end
             end
-
-            def run
-              begin
-                result = []
-                  @output.info @i18n.t('sanitycheck.run.start')
-                  error_number = 0
-                  @schema.each do |item|
-                    testcase = item[:test] ; item.delete(:test)
-                    res = self.send(testcase, **item) 
-                    if  res.empty? then
-                        @output.ok @i18n.t('sanitycheck.run.ok', testcase: testcase, name: item[:name].to_s)
-                      else
-                        pbm = res.map {|p| p.to_s}.join(',')
-                        @output.ko @i18n.t('sanitycheck.run.ko', testcase: testcase, name: item[:name].to_s, pbm: pbm)
-                        error_number =+ 1
-                      end
-                  end
-                 if error_number>0 then
-                    @output.error @i18n.t('sanitycheck.failure')
-                 else
-                    @output.success @i18n.t('sanitycheck.success') 
-                end
-              rescue Exception
-                  @finisher.secure_raise message: @i18n.t('sanitychek.error'), error_case: :status_ko
-              end unless @schema.empty?
-
+            if error_number.positive?
+              @output.error @i18n.t('sanitycheck.failure')
+            else
+              @output.success @i18n.t('sanitycheck.success')
+            end
+          rescue StandardError
+            @finisher.secure_raise message: @i18n.t('sanitychek.error'), error_case: :status_ko
           end
+        end
+      end
 
+      # @!group  Verifiers for application : FS and TCP/IP services
 
+      # check folder
+      # @return [Array] of Symbol with error type : [:inexistant,:mode,:owner,:group]
+      # @option [String] :name folder path (relative or absolute)
+      # @option [String] :mode String for OCTAL rights like "644", default 755
+      # @option [String] :owner file owner for folder, optionnal
+      # @option [String] :group  file group for folder, optionnal
+      def verify_folder(name:, mode: '755', owner: nil, group: nil)
+        full_name = File.expand_path(name)
+        res = []
+        return [:inexistant] unless File.directory?(full_name)
 
-#@!group  Verifiers for application : FS and TCP/IP services
-
-    # check folder
-    # @return [Array] of Symbol with error type : [:inexistant,:mode,:owner,:group]
-    # @option [String] :name folder path (relative or absolute)
-    # @option [String] :mode String for OCTAL rights like "644", default 755
-    # @option [String] :owner file owner for folder, optionnal
-    # @option [String] :group  file group for folder, optionnal
-    def verify_folder(name:, mode: "755", owner: nil, group: nil)
-        full_name = File.expand_path(name)     
-        res = Array::new
-        return  [:inexistant] unless File.directory?(full_name)
         stat = File.stat(full_name)
-        if mode then
-          tested_mode = "%o" % stat.mode
-          res << :mode if tested_mode[-3..-1] != mode
+        if mode
+          tested_mode = format('%o', stat.mode)
+          res << :mode if tested_mode[-3..] != mode
         end
-        if owner then
-          res << :owner if Etc.getpwuid(stat.uid).name != owner
-        end
-        if group then
-          res << :group if Etc.getgrgid(stat.gid).name != group
-        end
-        return res
+        res << :owner if owner && (Etc.getpwuid(stat.uid).name != owner)
+        res << :group if group && (Etc.getgrgid(stat.gid).name != group)
+        res
       end
-  
+
       # check symlink
       # @return [Boolean]
       # @option [String] :name path of the link
-      def verify_link(name: )
-        full_name = File.expand_path(name)  
-        res = Array::new
+      def verify_link(name:)
+        full_name = File.expand_path(name)
+        res = []
         res.push :inexistant unless File.file?(full_name)
-        return res
+        res
       end
-  
+
       # check file
       # @return [Array] of Symbol with error type : [:inexistant,:mode,:owner,:group]
       # @option [String] :name path of file
       # @option [String] :mode String for OCTAL rights like "644", optionnal
       # @option [String] :owner file owner for file, optionnal
       # @option [String] :group  file group for file, optionnal
-      def verify_file(name: , mode: '644', owner: nil, group: nil)
+      def verify_file(name:, mode: '644', owner: nil, group: nil)
         full_name = File.expand_path(name)
-        res = Array::new
-        return  [:inexistant] unless File.file?(full_name)
+        res = []
+        return [:inexistant] unless File.file?(full_name)
+
         stat = File.stat(full_name)
-        if mode then
-          tested_mode = "%o" % stat.mode
-          res << :mode if tested_mode[-3..-1] != mode
+        if mode
+          tested_mode = format('%o', stat.mode)
+          res << :mode if tested_mode[-3..] != mode
         end
-        if owner then
-          res << :owner if Etc.getpwuid(stat.uid).name != owner
-        end
-        if group then
-          res << :group if Etc.getgrgid(stat.gid).name != group
-        end
-        return res
+        res << :owner if owner && (Etc.getpwuid(stat.uid).name != owner)
+        res << :group if group && (Etc.getgrgid(stat.gid).name != group)
+        res
       end
-  
+
       # TCP/IP service checker
       # @return [Bool] status
-      # @option [String] :name display name
       # @option [String] :host hostname
       # @option [String] :port TCP port
       # @option [String] :url full URL, priority on :host and :port
-      def verify_service(name: nil, url: nil, host: nil, port: nil)
-        begin
-          if url then
-            uri = URI.parse(url)
-            host = uri.host
-            port = uri.port
-          end
-          Timeout::timeout(1) do
-            begin
-              s = TCPSocket.new(host, port)
-              s.close
-              return true
-            rescue Errno::ECONNREFUSED, Errno::EHOSTUNREACH
-              return false
-            end
-          end
-        rescue Timeout::Error
+      def verify_service(url: nil, host: nil, port: nil)
+        if url
+          uri = URI.parse(url)
+          host = uri.host
+          port = uri.port
+        end
+        Timeout.timeout(1) do
+          s = TCPSocket.new(host, port)
+          s.close
+          return true
+        rescue Errno::ECONNREFUSED, Errno::EHOSTUNREACH
           return false
         end
+      rescue Timeout::Error
+        false
       end
-      #!@endgroup
-
-        end
+      # !@endgroup
     end
+  end
 end

data/lib/carioca/services/securestore.rb

@@ -1,81 +1,80 @@
+# frozen_string_literal: true
 
 module Carioca
-    module Services
-        
-        class SecureStore
-            attr_accessor :data
-            
-            extend Carioca::Injector
-            inject service: :logger
-            inject service: :setup
-            inject service: :sanitycheck
+  module Services
+    class SecureStore
+      attr_accessor :data
 
-            def initialize(storefile: Carioca::Registry.config.secure_store_file, keyfile: Carioca::Registry.config.master_key_file)
-                [storefile, keyfile].map {|file| File.dirname(file) }.each do |path|
-                    setup.make_folder path:  File.expand_path(path), mode: "400" unless sanitycheck.verify_folder name: path
-                end
-                @storefile = File.expand_path(storefile)
-                @keyfile = File.expand_path(keyfile)
-                init! unless initialized?
-                @data = decrypt
-            end
-            
-            def initialized?
-                File.exist?(@storefile) && File.exist?(@keyfile)
-            end
-            
-            def save!
-                encrypt(@data)
-            end
-            
-            def init!
-                path = File.dirname(@storefile)
-                FileUtils.mkdir_p path
-                generate_key
-                init_data = {}
-                encrypt(init_data)
-                logger.warn(to_s) { 'Secure Store initialized' }
-            end
-            
-            private
-            
-            def generate_key
-                cipher = OpenSSL::Cipher.new('aes-256-cbc')
-                cipher.encrypt
-                key = cipher.random_key
-                iv = cipher.random_iv
-                encoded_key = Base64.encode64("#{key}|#{iv}")
-                unless File.exist? @keyfile
-                    File.write(@keyfile, encoded_key)
-                    FileUtils.chmod 0o400, @keyfile
-                end
-            end
-            
-            def decrypt
-                decipher = OpenSSL::Cipher.new('aes-256-cbc')
-                decipher.decrypt
-                encoded_key = File.read(@keyfile)
-                key, iv = Base64.decode64(encoded_key).split('|')
-                decipher.key = key
-                decipher.iv = iv
-                encoded = File.read(@storefile)
-                encrypted = Base64.decode64(encoded)
-                plain = decipher.update(encrypted) + decipher.final
-                YAML.load(plain)
-            end
-            
-            def encrypt(data)
-                encoded_key = File.read(@keyfile)
-                key, iv = Base64.decode64(encoded_key).split('|')
-                cipher = OpenSSL::Cipher.new('aes-256-cbc')
-                cipher.encrypt
-                cipher.key = key
-                cipher.iv = iv
-                encrypted = cipher.update(data.to_yaml) + cipher.final
-                encoded = Base64.encode64(encrypted)
-                File.write(@storefile, encoded)
-            end
+      extend Carioca::Injector
+      inject service: :logger
+      inject service: :setup
+      inject service: :sanitycheck
+
+      def initialize(storefile: Carioca::Registry.config.secure_store_file, keyfile: Carioca::Registry.config.master_key_file)
+        [storefile, keyfile].map { |file| File.dirname(file) }.each do |path|
+          setup.make_folder path: File.expand_path(path), mode: '400' unless sanitycheck.verify_folder name: path
+        end
+        @storefile = File.expand_path(storefile)
+        @keyfile = File.expand_path(keyfile)
+        init! unless initialized?
+        @data = decrypt
+      end
+
+      def initialized?
+        File.exist?(@storefile) && File.exist?(@keyfile)
+      end
+
+      def save!
+        encrypt(@data)
+      end
+
+      def init!
+        path = File.dirname(@storefile)
+        FileUtils.mkdir_p path
+        generate_key
+        init_data = {}
+        encrypt(init_data)
+        logger.warn(to_s) { 'Secure Store initialized' }
+      end
+
+      private
+
+      def generate_key
+        cipher = OpenSSL::Cipher.new('aes-256-cbc')
+        cipher.encrypt
+        key = cipher.random_key
+        iv = cipher.random_iv
+        encoded_key = Base64.encode64("#{key}|#{iv}")
+        unless File.exist? @keyfile
+          File.write(@keyfile, encoded_key)
+          FileUtils.chmod 0o400, @keyfile
         end
+      end
+
+      def decrypt
+        decipher = OpenSSL::Cipher.new('aes-256-cbc')
+        decipher.decrypt
+        encoded_key = File.read(@keyfile)
+        key, iv = Base64.decode64(encoded_key).split('|')
+        decipher.key = key
+        decipher.iv = iv
+        encoded = File.read(@storefile)
+        encrypted = Base64.decode64(encoded)
+        plain = decipher.update(encrypted) + decipher.final
+        YAML.safe_load(plain)
+      end
+
+      def encrypt(data)
+        encoded_key = File.read(@keyfile)
+        key, iv = Base64.decode64(encoded_key).split('|')
+        cipher = OpenSSL::Cipher.new('aes-256-cbc')
+        cipher.encrypt
+        cipher.key = key
+        cipher.iv = iv
+        encrypted = cipher.update(data.to_yaml) + cipher.final
+        encoded = Base64.encode64(encrypted)
+        File.write(@storefile, encoded)
+      end
     end
+  end
 end
-

data/lib/carioca/services/setup.rb

@@ -1,87 +1,82 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 # base Carioca namespace
 module Carioca
-    
-    module Services
-        
-        # Exiter namespace
-        class Setup
-
-            def initialize
-                registry = Carioca::Registry.get
-                @output = registry.get_service name: :output
-                @i18n = registry.get_service name: :i18n
-                @toolbox = registry.get_service name: :toolbox
-                @configuration = registry.get_service name: :configuration
-                @finisher = registry.get_service name: :finisher
-                @schema = {}
-                if @configuration.settings.include? :setup then
-                    @schema = (@configuration.settings.setup.include? :rules)? @configuration.settings.setup.rules : {}
-                end
-            end
-
+  module Services
+    # Exiter namespace
+    class Setup
+      def initialize
+        registry = Carioca::Registry.get
+        @output = registry.get_service name: :output
+        @i18n = registry.get_service name: :i18n
+        @toolbox = registry.get_service name: :toolbox
+        @configuration = registry.get_service name: :configuration
+        @finisher = registry.get_service name: :finisher
+        @schema = {}
+        if @configuration.settings.include? :setup
+          @schema = @configuration.settings.setup.include?(:rules) ? @configuration.settings.setup.rules : {}
+        end
+      end
 
-            def execute!
-                begin
-                    @output.info @i18n.t('setup.execute.start')
-                    @schema.each do |item|
-                      action = item[:action] ; item.delete(:action)
-                      self.send action, **item
-                    end
-                rescue Exception
-                    @finisher.secure_raise message: @i18n.t('setup.error'), error_case: :status_ko
-                end unless @schema.empty?
+      def execute!
+        unless @schema.empty?
+          begin
+            @output.info @i18n.t('setup.execute.start')
+            @schema.each do |item|
+              action = item[:action]
+              item.delete(:action)
+              send action, **item
             end
+          rescue StandardError
+            @finisher.secure_raise message: @i18n.t('setup.error'), error_case: :status_ko
+          end
+        end
+      end
 
+      # @!group facilities for file system commands
 
-
-
-               # @!group facilities for file system commands
-
-    # facility for file installation
-    # @option [String] :source file source path
-    # @option [String] :target file target path
-    # @option [String] :mode String for OCTAL rights (default "644")
-    # @option [String] :owner file owner for target (optional)
-    # @option [String] :group  file group for target (optional)
-    # @option [Bool] :force to copy file in force (default true)
-    # @option [Bool] :gem resolve file in gem root (default true)
-    # @option [String] :gem_name name of the gem where to search (default "carioca")
-    def install_file(source:, target:, mode: "644", owner: nil, group: nil, force: true, gem: true, gem_name: "carioca" )
-      @output.item @i18n.t('setup.install', file: target)
+      # facility for file installation
+      # @option [String] :source file source path
+      # @option [String] :target file target path
+      # @option [String] :mode String for OCTAL rights (default "644")
+      # @option [String] :owner file owner for target (optional)
+      # @option [String] :group  file group for target (optional)
+      # @option [Bool] :force to copy file in force (default true)
+      # @option [Bool] :gem resolve file in gem root (default true)
+      # @option [String] :gem_name name of the gem where to search (default "carioca")
+      def install_file(source:, target:, mode: '644', owner: nil, group: nil, force: true, gem: true, gem_name: 'carioca')
+        @output.item @i18n.t('setup.install', file: target)
         full_target = File.expand_path(target)
-        source = (gem)? @toolbox.search_file_in_gem(gem_name,source) : source
-        FileUtils::copy source, full_target if force
+        source = @toolbox.search_file_in_gem(gem: gem_name, file: source) if gem
+        FileUtils.copy source, full_target if force
         FileUtils.chmod mode.to_i(8), full_target
-        FileUtils.chown owner, group, full_target if owner and group
+        FileUtils.chown owner, group, full_target if owner && group
       end
-  
+
       # facility for folder creation
       # @option [String] :path folder path (relative or absolute)
       # @option [String] :mode String for OCTAL rights like "644"
       # @option [String] :owner file owner for folder
       # @option [String] :group  file group for folder
-    def make_folder(path:, mode: "644", owner: nil, group: nil )
+      def make_folder(path:, mode: '644', owner: nil, group: nil)
         full_path = File.expand_path(path)
         @output.item @i18n.t('setup.mkdir', path: full_path)
-        FileUtils::mkdir_p path unless File::exist? full_path
+        FileUtils.mkdir_p path unless File.exist? full_path
         FileUtils.chmod mode.to_i(8), full_path
-        FileUtils.chown owner, group, full_path if owner and group
+        FileUtils.chown owner, group, full_path if owner && group
       end
-  
+
       # facility for Symbolic link
       # @option [String] :source path of the file
       # @option [String] :link path of the symlink
       def make_link(source:, link:)
-        full_source = File.expand_path(source)
-        full_link = File.expand_path(link)
-        @output.item @i18n.t('setup.ln', target: link, source: source)
-        FileUtils::rm link if (File::symlink? link and not File::exist? link)
-        FileUtils::ln_s source, link unless File::exist? link
+        File.expand_path(source)
+        File.expand_path(link)
+        @output.item @i18n.t('setup.ln', target: link, source:)
+        FileUtils.rm link if File.symlink?(link) && !File.exist?(link)
+        FileUtils.ln_s source, link unless File.exist? link
       end
       # @!endgroup
-
-        end
     end
+  end
 end