cardconnect 2.2.0 → 2.4.0

data/test/cardconnect/connection_test.rb

@@ -11,25 +11,25 @@ describe CardConnect::Connection do
 
   describe '#connection' do
     it 'must have user agent in the headers' do
-      @connection.headers['User-Agent'].must_equal "CardConnectRubyGem/#{CardConnect::VERSION}"
+        _(@connection.headers['User-Agent']).must_equal "CardConnectRubyGem/#{CardConnect::VERSION}"
     end
 
     it 'must have a URL that matches the configured endpoint' do
-      @connection.url_prefix.host.must_equal URI.parse(CardConnect.configuration.endpoint).host
-      @connection.url_prefix.scheme.must_equal 'https'
+      _(@connection.url_prefix.host).must_equal URI.parse(CardConnect.configuration.endpoint).host
+      _(@connection.url_prefix.scheme).must_equal 'https'
     end
 
     describe 'Faraday handlers' do
       it 'must have a handler for basic authentication first' do
-        @connection.builder.handlers.first.must_be :===, Faraday::Request::BasicAuthentication
+        _(@connection.builder.handlers.first).must_be :===, Faraday::Request::Authorization
       end
 
       it 'must have a handler for encoding the request as json second' do
-        @connection.builder.handlers[1].must_be :===, FaradayMiddleware::EncodeJson
+        _(@connection.builder.handlers[1]).must_be :===, Faraday::Request::Json
       end
 
       it 'must have a handler for parsing the json response third' do
-        @connection.builder.handlers[2].must_be :===, FaradayMiddleware::ParseJson
+        _(@connection.builder.handlers[2]).must_be :===, Faraday::Response::Json
       end
 
       it 'has ssl verification on by default' do

data/test/cardconnect/services/authorization/authorization_request_test.rb

@@ -11,133 +11,133 @@ describe CardConnect::Service::AuthorizationRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal '000000927996'
+      _(@request.merchid).must_equal '000000927996'
     end
 
     it 'should have account' do
-      @request.account.must_equal '4111111111111111'
+      _(@request.account).must_equal '4111111111111111'
     end
 
     it 'should have expiry' do
-      @request.expiry.must_equal '1212'
+      _(@request.expiry).must_equal '1212'
     end
 
     it 'should have amount' do
-      @request.amount.must_equal '0'
+      _(@request.amount).must_equal '0'
     end
 
     it 'should have currency' do
-      @request.currency.must_equal 'USD'
+      _(@request.currency).must_equal 'USD'
     end
 
     it 'should have account type' do
-      @request.accttype.must_equal 'VISA'
+      _(@request.accttype).must_equal 'VISA'
     end
 
     it 'should have name' do
-      @request.name.must_equal 'TOM JONES'
+      _(@request.name).must_equal 'TOM JONES'
     end
 
     it 'should have address' do
-      @request.address.must_equal '123 MAIN STREET'
+      _(@request.address).must_equal '123 MAIN STREET'
     end
 
     it 'should have city' do
-      @request.city.must_equal 'anytown'
+      _(@request.city).must_equal 'anytown'
     end
 
     it 'should have country' do
-      @request.country.must_equal 'US'
+      _(@request.country).must_equal 'US'
     end
 
     it 'should have phone' do
-      @request.phone.must_equal '3334445555'
+      _(@request.phone).must_equal '3334445555'
     end
 
     it 'should have postal' do
-      @request.postal.must_equal '55555'
+      _(@request.postal).must_equal '55555'
     end
 
     it 'should have email' do
-      @request.email.must_equal 'tom@jones.com'
+      _(@request.email).must_equal 'tom@jones.com'
     end
 
     it 'should have ecomind' do
-      @request.ecomind.must_equal 'E'
+      _(@request.ecomind).must_equal 'E'
     end
 
     it 'should have cvv2' do
-      @request.cvv2.must_equal '123'
+      _(@request.cvv2).must_equal '123'
     end
 
     it 'should have order id' do
-      @request.orderid.must_equal 'AB-11-9876'
+      _(@request.orderid).must_equal 'AB-11-9876'
     end
 
     it 'should have track' do
-      @request.track.must_equal 'Y'
+      _(@request.track).must_equal 'Y'
     end
 
     it 'should have bankaba' do
-      @request.bankaba.must_equal '1010101'
+      _(@request.bankaba).must_equal '1010101'
     end
 
     it 'should have tokenize' do
-      @request.tokenize.must_equal 'Y'
+      _(@request.tokenize).must_equal 'Y'
     end
 
     it 'should have termid' do
-      @request.termid.must_equal '12345'
+      _(@request.termid).must_equal '12345'
     end
 
     it 'should have capture' do
-      @request.capture.must_equal 'Y'
+      _(@request.capture).must_equal 'Y'
     end
 
     it 'should have ssnl4 field' do
-      @request.ssnl4.must_equal '1234'
+      _(@request.ssnl4).must_equal '1234'
     end
 
     it 'should have license field' do
-      @request.license.must_equal 'CO:1231231234'
+      _(@request.license).must_equal 'CO:1231231234'
     end
 
     it 'should have profile field' do
-      @request.profile.must_equal 'Y'
+      _(@request.profile).must_equal 'Y'
     end
 
     it 'should have ponumber field' do
-      @request.ponumber.must_equal '1234'
+      _(@request.ponumber).must_equal '1234'
     end
 
     it 'should have authcode field' do
-      @request.authcode.must_equal '123456'
+      _(@request.authcode).must_equal '123456'
     end
 
     it 'should have invoiceid field' do
-      @request.invoiceid.must_equal '000000000001'
+      _(@request.invoiceid).must_equal '000000000001'
     end
 
     it 'should have taxamnt field' do
-      @request.taxamnt.must_equal '0'
+      _(@request.taxamnt).must_equal '0'
     end
 
     describe 'userfields' do
       it 'should be an array of name-value pairs' do
-        @request.userfields.must_be_kind_of Array
-        @request.userfields.first.must_be_kind_of Hash
-        @request.userfields.first['name0'].must_equal 'value0'
+        _(@request.userfields).must_be_kind_of Array
+        _(@request.userfields.first).must_be_kind_of Hash
+        _(@request.userfields.first['name0']).must_equal 'value0'
       end
     end
   end
 
   describe '#valid?' do
     it 'should not be valid if no attributes are passed in' do
-      CardConnect::Service::AuthorizationRequest.new.valid?.must_equal false
+      _(CardConnect::Service::AuthorizationRequest.new.valid?).must_equal false
     end
 
     it 'should be valid if valid attributes are passed in' do
-      CardConnect::Service::AuthorizationRequest.new(valid_auth_request).valid?.must_equal true
+      _(CardConnect::Service::AuthorizationRequest.new(valid_auth_request).valid?).must_equal true
     end
   end
 
@@ -145,14 +145,14 @@ describe CardConnect::Service::AuthorizationRequest do
     CardConnect::Service::AuthorizationRequest::REQUIRED_FIELDS.each do |field|
       field_name = field.to_s.capitalize
       it "should have an error message if #{field_name} is missing" do
-        CardConnect::Service::AuthorizationRequest.new.errors.must_include "#{field_name} is missing"
+        _(CardConnect::Service::AuthorizationRequest.new.errors).must_include "#{field_name} is missing"
       end
     end
   end
 
   describe '#payload' do
     it 'should generate hash with all the right values' do
-      @request.payload.must_equal symbolize_keys(valid_auth_request)
+      _(@request.payload).must_equal symbolize_keys(valid_auth_request)
     end
   end
 end

data/test/cardconnect/services/authorization/authorization_response_test.rb

@@ -11,89 +11,89 @@ describe CardConnect::Service::AuthorizationResponse do
 
   describe 'FIELDS' do
     it 'should have the merchant id' do
-      @response.merchid.must_equal '020594000000'
+      _(@response.merchid).must_equal '020594000000'
     end
 
     it 'should have the status' do
-      @response.respstat.must_equal 'A'
+      _(@response.respstat).must_equal 'A'
     end
 
     it 'should have the Retrieval Reference Number' do
-      @response.retref.must_equal '343005123105'
+      _(@response.retref).must_equal '343005123105'
     end
 
     it 'should have the Account Number' do
-      @response.account.must_equal '41XXXXXXXXXX1111'
+      _(@response.account).must_equal '41XXXXXXXXXX1111'
     end
 
     it 'should have the Token' do
-      @response.token.must_equal '9419786452781111'
+      _(@response.token).must_equal '9419786452781111'
     end
 
     it 'should have the Amount' do
-      @response.amount.must_equal '111'
+      _(@response.amount).must_equal '111'
     end
 
     it 'should have the Response Code' do
-      @response.respcode.must_equal '00'
+      _(@response.respcode).must_equal '00'
     end
 
     it 'should have the Response text' do
-      @response.resptext.must_equal 'Approved'
+      _(@response.resptext).must_equal 'Approved'
     end
 
     it 'should have the Response Processor' do
-      @response.respproc.must_equal 'FNOR'
+      _(@response.respproc).must_equal 'FNOR'
     end
 
     it 'should have the AVS response code' do
-      @response.avsresp.must_equal '9'
+      _(@response.avsresp).must_equal '9'
     end
 
     it 'should have the CVV response code' do
-      @response.cvvresp.must_equal 'M'
+      _(@response.cvvresp).must_equal 'M'
     end
 
     it 'should have the Authorization code' do
-      @response.authcode.must_equal '046221'
+      _(@response.authcode).must_equal '046221'
     end
 
     it 'should have the Commercial Card Flag' do
-      @response.commcard.must_equal 'N'
+      _(@response.commcard).must_equal 'N'
     end
 
     it 'should have the profile id' do
-      @response.profileid.must_equal '12345678'
+      _(@response.profileid).must_equal '12345678'
     end
   end
 
   describe '#success?' do
     it 'should be true when there are no errors' do
-      @response.success?.must_equal true
+      _(@response.success?).must_equal true
     end
 
     it 'should be false when there are errors' do
       auth_response = valid_auth_response.merge!('respstat' => 'B', 'resptext' => 'this is an error')
       response = CardConnect::Service::AuthorizationResponse.new(auth_response)
-      response.success?.must_equal false
+      _(response.success?).must_equal false
     end
   end
 
   describe '#errors' do
     it 'should be empty when there are no errors' do
-      @response.errors.must_be_empty
+      _(@response.errors).must_be_empty
     end
 
     it 'should be an array of error messages when there are errors' do
       auth_response = valid_auth_response.merge!('respstat' => 'B', 'resptext' => 'this is an error')
       response = CardConnect::Service::AuthorizationResponse.new(auth_response)
-      response.errors.must_equal ['this is an error']
+      _(response.errors).must_equal ['this is an error']
     end
   end
 
   describe '#body' do
     it 'should generate hash with all the right values' do
-      @response.body.must_equal symbolize_keys(valid_auth_response)
+      _(@response.body).must_equal symbolize_keys(valid_auth_response)
     end
   end
 end

data/test/cardconnect/services/authorization/authorization_test.rb

@@ -13,7 +13,7 @@ describe CardConnect::Service::Authorization do
   end
 
   it 'must have the right path' do
-    @service.path.must_equal '/cardconnect/rest/auth'
+    _(@service.path).must_equal '/cardconnect/rest/auth'
   end
 
   describe '#build_request' do
@@ -27,30 +27,30 @@ describe CardConnect::Service::Authorization do
 
     it 'uses the default merchant id if it is not passed in' do
       @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
-      @service.request.merchid.must_equal 'merchant123'
+      _(@service.request.merchid).must_equal 'merchant123'
     end
 
     it 'creates an Authorization request object with the right params' do
       @service.build_request(@valid_params)
-      @service.request.must_be_kind_of CardConnect::Service::AuthorizationRequest
-      @service.request.merchid.must_equal '000000927996'
-      @service.request.account.must_equal '4111111111111111'
-      @service.request.expiry.must_equal '1212'
-      @service.request.amount.must_equal '0'
-      @service.request.currency.must_equal 'USD'
+      _(@service.request).must_be_kind_of CardConnect::Service::AuthorizationRequest
+      _(@service.request.merchid).must_equal '000000927996'
+      _(@service.request.account).must_equal '4111111111111111'
+      _(@service.request.expiry).must_equal '1212'
+      _(@service.request.amount).must_equal '0'
+      _(@service.request.currency).must_equal 'USD'
     end
   end
 
   describe '#submit' do
     it 'raises an error when there is no request' do
-      @service.request.nil?.must_equal true
-      proc { @service.submit }.must_raise CardConnect::Error
+      _(@service.request.nil?).must_equal true
+      _(-> { @service.submit }).must_raise CardConnect::Error
     end
 
     it 'creates a response when a valid request is processed' do
       @service.build_request(valid_auth_request)
       @service.submit
-      @service.response.must_be_kind_of CardConnect::Service::AuthorizationResponse
+      _(@service.response).must_be_kind_of CardConnect::Service::AuthorizationResponse
     end
   end
 end

data/test/cardconnect/services/bin/bin_request_test.rb

@@ -0,0 +1,45 @@
+require 'test_helper'
+
+describe CardConnect::Service::BinRequest do
+  before do
+    @request = CardConnect::Service::BinRequest.new(valid_bin_request)
+  end
+
+  after do
+    @request = nil
+  end
+
+  describe 'FIELDS' do
+    it 'should have merchant id' do
+      _(@request.merchid).must_equal '000000927996'
+    end
+
+    it 'should have token' do
+      _(@request.token).must_equal '9477709629051443'
+    end
+  end
+
+  describe '#valid?' do
+    it 'should not be valid if no attributes are passed in' do
+      _(CardConnect::Service::BinRequest.new.valid?).must_equal false
+    end
+
+    it 'should be valid if valid attributes are passed in' do
+      _(CardConnect::Service::BinRequest.new(valid_bin_request).valid?).must_equal true
+    end
+  end
+
+  describe '#errors' do
+    CardConnect::Service::BinRequest::REQUIRED_FIELDS.each do |field|
+      it "should have an error message if #{field} is missing" do
+        _(CardConnect::Service::BinRequest.new.errors).must_include "#{field.to_s.capitalize} is missing"
+      end
+    end
+  end
+
+  describe '#payload' do
+    it 'should generate the correct path params' do
+      _(@request.payload).must_equal '/000000927996/9477709629051443'
+    end
+  end
+end

data/test/cardconnect/services/bin/bin_response_test.rb

@@ -0,0 +1,67 @@
+require 'test_helper'
+
+describe CardConnect::Service::BinResponse do
+  before do
+    @response = CardConnect::Service::BinResponse.new(valid_bin_response)
+  end
+
+  after do
+    @response = nil
+  end
+
+  describe 'FIELDS' do
+    it 'should have country' do
+      _(@response.country).must_equal 'USA'
+    end
+
+    it 'should have product' do
+      _(@response.product).must_equal 'V'
+    end
+
+    it 'should have cardusestring' do
+      _(@response.cardusestring).must_equal 'True credit'
+    end
+
+    it 'should have gsa' do
+      _(@response.gsa).must_equal false
+    end
+
+    it 'should have corporate' do
+      _(@response.corporate).must_equal true
+    end
+
+    it 'should have fsa' do
+      _(@response.fsa).must_equal false
+    end
+
+    it 'should have subtype' do
+      _(@response.subtype).must_equal 'Visa Corporate T&E'
+    end
+
+    it 'should have purchase' do
+      _(@response.purchase).must_equal false
+    end
+
+    it 'should have prepaid' do
+      _(@response.prepaid).must_equal false
+    end
+
+    it 'should have binlo' do
+      _(@response.binlo).must_equal '478823XXX'
+    end
+
+    it 'should have issuer' do
+      _(@response.issuer).must_equal "JPMorgan Chase Bank N.A. - Commercial"
+    end
+
+    it 'should have binhi' do
+      _(@response.binhi).must_equal "478825XXX"
+    end
+  end
+
+  describe '#body' do
+    it 'should generate hash with all the right values' do
+      _(@response.body).must_equal symbolize_keys(valid_bin_response)
+    end
+  end
+end

data/test/cardconnect/services/bin/bin_test.rb

@@ -0,0 +1,56 @@
+require 'test_helper'
+
+describe CardConnect::Service::Bin do
+  before do
+    @connection = CardConnect::Connection.new.connection do |stubs|
+      path = "#{@service.path}/#{valid_bin_request['merchid']}/#{valid_bin_request['token']}"
+      stubs.get(path) { [200, {}, valid_bin_response] }
+    end
+    @service = CardConnect::Service::Bin.new(@connection)
+  end
+
+  after do
+    @service = nil
+  end
+
+  it 'must have the right path' do
+    _(@service.path).must_equal '/cardconnect/rest/bin'
+  end
+
+  describe '#build_request' do
+    before do
+      @valid_params = valid_bin_request
+    end
+
+    after do
+      @valid_params = nil
+    end
+
+    it 'creates a bin request object with the passed in params' do
+      @service.build_request(@valid_params)
+
+      _(@service.request).must_be_kind_of CardConnect::Service::BinRequest
+      _(@service.request.token).must_equal '9477709629051443'
+      _(@service.request.merchid).must_equal '000000927996'
+    end
+
+    it 'uses default merchant ID if merchid is not passed in' do
+      @service.build_request(@valid_params.reject! { |k, _| k == 'merchid' })
+      _(@service.request).must_be_kind_of CardConnect::Service::BinRequest
+      _(@service.request.merchid).must_equal 'merchant123'
+    end
+  end
+
+  describe '#submit' do
+    it 'raises an error when there is no request' do
+      _(@service.request.nil?).must_equal true
+      _(-> { @service.submit }).must_raise CardConnect::Error
+    end
+
+    it 'creates a response when a valid request is processed' do
+      @service.build_request(valid_bin_request)
+      @service.submit
+      _(@service.response).must_be_kind_of CardConnect::Service::BinResponse
+    end
+  end
+end

data/test/cardconnect/services/capture/capture_request_test.rb

@@ -11,55 +11,55 @@ describe CardConnect::Service::CaptureRequest do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @request.merchid.must_equal '000000927996'
+      _(@request.merchid).must_equal '000000927996'
     end
 
     it 'should have retrieval reference number' do
-      @request.retref.must_equal '288002073633'
+      _(@request.retref).must_equal '288002073633'
     end
 
     it 'should have authorization code' do
-      @request.authcode.must_equal '046221'
+      _(@request.authcode).must_equal '046221'
     end
 
     it 'should have amount' do
-      @request.amount.must_equal '596.00'
+      _(@request.amount).must_equal '596.00'
     end
 
     it 'should have invoice id' do
-      @request.invoiceid.must_equal '7890'
+      _(@request.invoiceid).must_equal '7890'
     end
 
     it 'should have PO number' do
-      @request.ponumber.must_equal 'PO-0736332'
+      _(@request.ponumber).must_equal 'PO-0736332'
     end
 
     it 'should have tax amount' do
-      @request.taxamnt.must_equal '40.00'
+      _(@request.taxamnt).must_equal '40.00'
     end
   end
 
   describe '#valid?' do
     it 'should not be valid if no attributes are passed in' do
-      CardConnect::Service::CaptureRequest.new.valid?.must_equal false
+      _(CardConnect::Service::CaptureRequest.new.valid?).must_equal false
     end
 
     it 'should be valid if valid attributes are passed in' do
-      CardConnect::Service::CaptureRequest.new(valid_capture_request).valid?.must_equal true
+      _(CardConnect::Service::CaptureRequest.new(valid_capture_request).valid?).must_equal true
     end
   end
 
   describe '#errors' do
     CardConnect::Service::CaptureRequest::REQUIRED_FIELDS.each do |field|
       it "should have an error message if #{field} is missing" do
-        CardConnect::Service::CaptureRequest.new.errors.must_include "#{field.to_s.capitalize} is missing"
+        _(CardConnect::Service::CaptureRequest.new.errors).must_include "#{field.to_s.capitalize} is missing"
       end
     end
   end
 
   describe '#payload' do
     it 'should generate hash with all the right values' do
-      @request.payload.must_equal symbolize_keys(valid_capture_request)
+      _(@request.payload).must_equal symbolize_keys(valid_capture_request)
     end
   end
 end

data/test/cardconnect/services/capture/capture_response_test.rb

@@ -11,29 +11,29 @@ describe CardConnect::Service::CaptureResponse do
 
   describe 'FIELDS' do
     it 'should have merchant id' do
-      @response.merchid.must_equal '000000927996'
+      _(@response.merchid).must_equal '000000927996'
     end
 
     it 'should have account' do
-      @response.account.must_equal '41XXXXXXXXXX4113'
+      _(@response.account).must_equal '41XXXXXXXXXX4113'
     end
 
     it 'should have amount' do
-      @response.amount.must_equal '596.00'
+      _(@response.amount).must_equal '596.00'
     end
 
     it 'should have retrieval reference number' do
-      @response.retref.must_equal '288002073633'
+      _(@response.retref).must_equal '288002073633'
     end
 
     it 'should have settlement status' do
-      @response.setlstat.must_equal 'Pending'
+      _(@response.setlstat).must_equal 'Pending'
     end
   end
 
   describe '#body' do
     it 'should generate hash with all the right values' do
-      @response.body.must_equal symbolize_keys(valid_capture_response)
+      _(@response.body).must_equal symbolize_keys(valid_capture_response)
     end
   end
 end