cardconnect 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1424e5c7c8b8b7da969afddb41d96b38251e6c7f
-  data.tar.gz: 4d108dc528103808b4c9688c4afab51c4b833bb0
+  metadata.gz: 0d6ec54a93e96b0853646453b4279a2f4940f944
+  data.tar.gz: 4fdb897d65793526a08198bffd4f7b0e1533dbb6
 SHA512:
-  metadata.gz: db20abb8bd3a1125ead42db2e54d03b1864a530139d2fd669be621510851bf5537b86f5a5289a5fa98cc8855acf6ee7b84e5051f54ceb128635bb1b512ce8fea
-  data.tar.gz: 5a524dd23a749c7232831d8d75a3f72fe34b0e1f890d378a985b408b2f3312340b6c6cf06a31b12d08f69ee509a5a49e19224fe58e2fd738fa01617e28a70c84
+  metadata.gz: 7c9363231dcd9e016e566bf9bee06c6d58f08c9bf17c8e5b873a5ccb6e5192b42859bfb5517b75c565b220ba7f62a5442251eaf317fb042d5ac9d343bb103d4c
+  data.tar.gz: ecc1e1b60110560499449a41b3f615d1506ec0ce2bde957a719ac95cf7d7ebedd243eb3d9da2431e51c237399fea5c7eb2ad6febef6145f76bfd7c82555804c4

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v2.2.0
+
+* Add `token` field to Profile Service for create/update responses since this field can potentially be included in the response if a token hadn't already been created for that particular profile. (@mauriciozaffari)
+
 ## v2.1.0
 
 * Add ability to pass connection options to the Faraday connection (@jhanggi)

data/README.md

@@ -122,7 +122,6 @@ response = service.submit
 ```
 
 ### Profile Service
-Thanks to [@AndreiBujenitsa](https://github.com/AndreiBujenitsa) for implementing Profile Service!
 
 CardConnect documentation for this service can be found here: https://developer.cardconnect.com/cardconnect-api/#profile-service
 

data/lib/cardconnect/services/profile/profile_put_response.rb

@@ -5,7 +5,7 @@ module CardConnect
 
       FIELDS = [:profileid, :acctid, :respstat, :account, :respcode, :resptext, :respproc, :accttype,
                 :expiry, :name, :address, :city, :region, :country, :phone, :postal, :ssnl4, :email,
-                :defaultacct, :license, :gsacard, :auoptout]
+                :defaultacct, :license, :gsacard, :auoptout, :token]
 
       attr_accessor(*FIELDS)
       attr_reader :errors

data/lib/cardconnect/version.rb

@@ -1,3 +1,3 @@
 module CardConnect
-  VERSION = '2.1.0'.freeze
+  VERSION = '2.2.0'.freeze
 end

data/test/api_response_stubs.rb

@@ -125,23 +125,28 @@ end
 
 def valid_profile_put_response #rubocop:disable Metrics/MethodLength
   {
-    "region" => "AK",
-    "phone" => "7778789999",
-    "accttype" => "VISA",
-    "postal" => "19090",
-    "ssnl4" => "3655",
-    "respproc" => "PPS",
-    "expiry" => "0214",
-    "city" => "ANYTOWN",
     "country" => "US",
+    "address" => "123 MAIN STREET",
     "resptext" => "Profile Saved",
-    "token" => "9440670166031111",
+    "city" => "ANYTOWN",
+    "acctid" => "1",
     "respcode" => "09",
-    "address" => "123 MAIN STREET",
-    "name" => "TOM JONES",
+    "defaultacct" => "Y",
+    "accttype" => "VISA",
+    "token" => "9441149619831111",
+    "account" => "41XXXXXXXXXX1111",
+    "email" => "test@test.com",
     "license" => "123451254",
+    "respproc" => "PPS",
+    "phone" => "7778789999",
+    "profileid" => "12305454023615201322",
+    "name" => "TOM JONES",
+    "auoptout" => "N",
+    "postal" => "19090",
+    "expiry" => "0214",
+    "region" => "AK",
+    "ssnl4" => "3655",
     "respstat" => "A",
-    "profileid" => "12345678901234567890",
-    "acctid" => "1"
+    "gsacard" => "N"
   }
 end

data/test/cardconnect/services/profile/profile_put_response_test.rb

@@ -0,0 +1,135 @@
+require 'test_helper'
+
+describe CardConnect::Service::ProfilePutResponse do
+  before do
+    @response = CardConnect::Service::ProfilePutResponse.new(valid_profile_put_response)
+  end
+
+  after do
+    @response = nil
+  end
+
+  describe 'FIELDS' do
+    it 'should have profile id' do
+      @response.profileid.must_equal '12305454023615201322'
+    end
+
+    it 'should have account id' do
+      @response.acctid.must_equal '1'
+    end
+
+    it 'should have response status' do
+      @response.respstat.must_equal 'A'
+    end
+
+    it 'should have account' do
+      @response.account.must_equal '41XXXXXXXXXX1111'
+    end
+
+    it 'should have response code' do
+      @response.respcode.must_equal '09'
+    end
+
+    it 'should have response text' do
+      @response.resptext.must_equal 'Profile Saved'
+    end
+
+    it 'should have respproc' do
+      @response.respproc.must_equal 'PPS'
+    end
+
+    it 'should have accttype' do
+      @response.accttype.must_equal 'VISA'
+    end
+
+    it 'should have expiry' do
+      @response.expiry.must_equal '0214'
+    end
+
+    it 'should have name' do
+      @response.name.must_equal 'TOM JONES'
+    end
+
+    it 'should have address' do
+      @response.address.must_equal '123 MAIN STREET'
+    end
+
+    it 'should have city' do
+      @response.city.must_equal 'ANYTOWN'
+    end
+
+    it 'should have region' do
+      @response.region.must_equal 'AK'
+    end
+
+    it 'should have country' do
+      @response.country.must_equal 'US'
+    end
+
+    it 'should have phone' do
+      @response.phone.must_equal '7778789999'
+    end
+
+    it 'should have postal' do
+      @response.postal.must_equal '19090'
+    end
+
+    it 'should have ssnl4' do
+      @response.ssnl4.must_equal '3655'
+    end
+
+    it 'should have email' do
+      @response.email.must_equal 'test@test.com'
+    end
+
+    it 'should have defaultacct' do
+      @response.defaultacct.must_equal 'Y'
+    end
+
+    it 'should have license' do
+      @response.license.must_equal '123451254'
+    end
+
+    it 'should have token' do
+      @response.token.must_equal '9441149619831111'
+    end
+
+    it 'should have gsacard' do
+      @response.gsacard.must_equal 'N'
+    end
+
+    it 'should have auoptout' do
+      @response.auoptout.must_equal 'N'
+    end
+  end
+
+  describe '#success?' do
+    it 'should be true when there are no errors' do
+      @response.success?.must_equal true
+    end
+
+    it 'should be false when there are errors' do
+      prof_response = valid_profile_put_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
+      response = CardConnect::Service::ProfilePutResponse.new(prof_response)
+      response.success?.must_equal false
+    end
+  end
+
+  describe '#errors' do
+    it 'should be empty when there are no errors' do
+      @response.errors.must_be_empty
+    end
+
+    it 'should be an array of error messages when there are errors' do
+      prof_response = valid_profile_put_response.merge!('respstat' => 'C', 'resptext' => 'this is an error')
+      response = CardConnect::Service::ProfilePutResponse.new(prof_response)
+      response.errors.must_equal ['this is an error']
+    end
+  end
+
+  describe '#body' do
+    it 'should generate hash with all the right values' do
+      @response.body.must_equal symbolize_keys(valid_profile_put_response)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cardconnect
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Tim McKenzie
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-13 00:00:00.000000000 Z
+date: 2018-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -123,6 +123,7 @@ files:
 - test/cardconnect/services/profile/profile_get_request_test.rb
 - test/cardconnect/services/profile/profile_get_response_test.rb
 - test/cardconnect/services/profile/profile_put_request_test.rb
+- test/cardconnect/services/profile/profile_put_response_test.rb
 - test/cardconnect/services/profile/profile_test.rb
 - test/cardconnect/services/refund/refund_request_test.rb
 - test/cardconnect/services/refund/refund_response_test.rb
@@ -178,6 +179,7 @@ test_files:
 - test/cardconnect/services/profile/profile_get_request_test.rb
 - test/cardconnect/services/profile/profile_get_response_test.rb
 - test/cardconnect/services/profile/profile_put_request_test.rb
+- test/cardconnect/services/profile/profile_put_response_test.rb
 - test/cardconnect/services/profile/profile_test.rb
 - test/cardconnect/services/refund/refund_request_test.rb
 - test/cardconnect/services/refund/refund_response_test.rb