card 1.98.0 → 1.99.1

data/mod/pointer/lib/javascript/script_pointer_config.js.coffee

@@ -7,6 +7,8 @@ $.extend decko.editorContentFunctionMap,
       pointerContent @find('input:checked').val()
     '.pointer-list-ul': ->
       pointerContent @find('input').map( -> $(this).val() )
+    '.pointer-link-list-ul': ->
+      decko.linkListContent @find('.input-group')
     '.pointer-checkbox-list': ->
       pointerContent @find('input:checked').map( -> $(this).val() )
     '.pointer-select-list': ->
@@ -44,6 +46,17 @@ $.extend decko,
     list = $.map $.makeArray(vals), (v) -> if v then '[[' + v + ']]'
     $.makeArray(list).join "\n"
 
+  linkListContent: (input_groups) ->
+      vals = input_groups.map( ->
+        v = $(this).find('input._reference').val()
+        title = $(this).find('input._title').val()
+        v += "|#{title}" if title.length > 0
+        v
+      )
+      list = $.map $.makeArray(vals), (v) -> if v then '[[' + v + ']]'
+      $.makeArray(list).join "\n"
+
+
 pointerContent = (vals) ->
   decko.pointerContent vals
   # deprecated. backwards compatibility

data/mod/pointer/lib/javascript/script_pointer_list_editor.js.coffee

@@ -1,6 +1,6 @@
 $(window).ready ->
   # add pointer item when clicking on "add another" button
-  $('body').on 'click', '.pointer-item-add', (event)->
+  $('body').on 'click', '._pointer-item-add', (event)->
     decko.addPointerItem this
     event.preventDefault() # Prevent link from following its href
 
@@ -10,6 +10,7 @@ $(window).ready ->
       decko.addPointerItem this
       event.preventDefault() # was triggering extra item in unrelated pointer
 
+  # enable/disable add
   $('body').on 'keyup', '.pointer-item-text', (_event)->
     decko.updateAddItemButton this
 
@@ -26,8 +27,12 @@ decko.slotReady (slot) ->
 
 $.extend decko,
   addPointerItem: (el) ->
+    slot = $(el).slot()
+    slot.trigger "slotDestroy"
     newInput = decko.nextPointerInput decko.lastPointerItem(el)
     newInput.val ''
+
+    slot.trigger "slotReady"
     newInput.focus()
     decko.updateAddItemButton el
     decko.initPointerList newInput
@@ -43,6 +48,6 @@ $.extend decko,
     $(el).closest('.content-editor').find '.pointer-li:last'
 
   updateAddItemButton: (el)->
-    button = $(el).closest('.content-editor').find '.pointer-item-add'
+    button = $(el).closest('.content-editor').find '._pointer-item-add'
     disabled = decko.lastPointerItem(el).find('input').val() == ''
     button.prop 'disabled', disabled

data/mod/pointer/set/abstract/02_pointer/html_views.rb

@@ -21,7 +21,7 @@ format :html do
     pointer_items(paging_args.extract!(:limit, :offset)).join(voo.separator || "\n")
   end
 
-  view :closed_content do
+  view :one_line_content do
     item_view = implicit_item_view
     item_view = item_view == "name" ? "name" : "link"
     wrap_with :div, class: "pointer-list" do
@@ -34,11 +34,11 @@ format :html do
     %(<div class="pointer-item item-#{item_view}">#{rendered}</div>)
   end
 
-  view :editor do
+  view :input do
     _render_hidden_content_field + super()
   end
 
-  def default_editor
+  def default_input_type
     :list
   end
 
@@ -54,7 +54,8 @@ format :html do
     items = items_for_input args[:item_list]
     extra_class = "pointer-list-ul"
     ul_classes = classy "pointer-list-editor", extra_class
-    haml :list_input, items: items, ul_classes: ul_classes
+    haml :list_input, items: items, ul_classes: ul_classes,
+                      options_card: options_card_name
   end
 
   %i[autocomplete checkbox radio select multiselect].each do |editor_view|
@@ -67,11 +68,11 @@ format :html do
   end
 
   def checkbox_input
-    haml :checkbox_input
+    haml :checkbox_input, submit_on_change: @submit_on_change
   end
 
   def radio_input
-    haml :radio_input
+    haml :radio_input, submit_on_change: @submit_on_change
   end
 
   def select_input
@@ -90,7 +91,7 @@ format :html do
   def add_item_modal_link
     modal_link "Add Item",
                size: :large,
-               class: "btn btn-sm btn-primary _add-item-link",
+               class: "btn btn-sm btn-outline-secondary _add-item-link",
                path: { view: :filter_items_modal,
                        item: implicit_item_view,
                        filter_card: filter_card.name,
@@ -102,6 +103,14 @@ format :html do
 
   def add_item_overlay_link; end
 
+  def one_line_content
+    if count == 1
+      card.item_names.first
+    else
+      short_content
+    end
+  end
+
   private
 
   # currently only used by :list and :autocomplete. could be generalized?

data/mod/pointer/set/abstract/02_pointer/html_views/checkbox_input.haml

@@ -4,6 +4,5 @@
     - checked = card.item_names.include? option_name
     .pointer-checkbox
       = check_box_tag "pointer_checkbox-#{unique_id}", option_name, checked,
-                      id: id, class: "pointer-checkbox-button"
+                      id: id, class: "pointer-checkbox-button #{'_submit-on-change' if submit_on_change}"
       = option_label option_label, id
-      = option_description "checkbox", option_name

data/mod/pointer/set/abstract/02_pointer/html_views/list_input.haml

@@ -1,5 +1,4 @@
 %ul{class: ul_classes}
-  - options_card = options_card_name
   - items.each do |item|
     %li.pointer-li.mb-1
       %span.input-group
@@ -12,6 +11,6 @@
           %button.pointer-item-delete.btn.btn-secondary{ type: "button"}
             = icon_tag :remove
 %span.input-group
-  %button.pointer-item-add.btn.btn-secondary{ type: "submit" }
+  %button._pointer-item-add.btn.btn-secondary{ type: "submit" }
     = icon_tag "add"
     add another

data/mod/pointer/set/abstract/02_pointer/html_views/list_item.haml

@@ -1,3 +1,5 @@
+// TODO: delete me?  Is this file in use?
+
 %li.pointer-li.mb-1
   %span.input-group
     .input-group-prepend.handle

data/mod/pointer/set/abstract/02_pointer/html_views/radio_input.haml

@@ -9,6 +9,5 @@
       - id = "pointer-radio-#{option_name.to_name.key}"
       %li.pointer-radio.radio
         = radio_button_tag input_name, option_name, checked,
-                           id: id, class: "pointer-radio-button"
+                           id: id, class: "pointer-radio-button #{'_submit-on-change' if submit_on_change}"
         = option_label option_label, id
-        = option_description "radio", option_name

data/mod/pointer/set/abstract/02_pointer/options_api.rb

@@ -29,7 +29,7 @@ def option_cards
 end
 
 def options_rule_card
-  rule_card :options
+  rule_card :content_options
 end
 
 def standard_option_names
@@ -65,20 +65,13 @@ format :html do
     %(<label for="#{id}">#{option_label_text option_name}</label>)
   end
 
-  def option_label_text option_name
-    Card.fetch(option_name)&.label || option_name
+  def option_view
+    @option_view ||= card.rule(:content_option_view) || :smart_label
   end
 
-  # @param option_type [String] "checkbox" or "radio"
-  def option_description option_type, option_name
-    return "" unless (description = option_description_core(option_name))
-    %(<div class="#{option_type}-option-description">#{description}</div>)
-  end
+  def option_label_text option_name
+    return option_name unless (option_card = Card.fetch option_name)
 
-  def option_description_core option
-    # DISCUSS: "options label" is an obscure rule. still support?
-    desc_name = card.rule(:options_label) || "description"
-    return unless (desc_card = Card[option, desc_name])
-    nest desc_card, { view: :core }, nest_mode: :normal
+    nest option_card, view: option_view
   end
 end

data/mod/pointer/set/type/link_list.rb

@@ -1,12 +1,12 @@
 include_set Abstract::Pointer
 
-def item_names
-  reference_chunks.map(&:referee_name)
+def all_raw_item_strings content=nil
+  reference_chunks(content).map(&:referee_name)
 end
 
-def item_titles
+def item_titles default_to_name=true
   reference_chunks.map do |chunk|
-    chunk.options[:title] || chunk.referee_name
+    chunk.options[:title] || (default_to_name ? chunk.referee_name : nil)
   end
 end
 
@@ -17,7 +17,24 @@ format do
 end
 
 format :html do
-  def editor
-    :ace_editor
+  def input_type
+    :link_list
+  end
+
+  view :link_list_input, cache: :never do
+    link_list_input
+  end
+
+  def items_for_input items=nil
+    items ||= card.item_names context: :raw
+    items.empty? ? [["", ""]] : items.zip(card.item_titles(false))
+  end
+
+  def link_list_input args={}
+    items = items_for_input args[:item_list]
+    extra_class = "pointer-link-list-ul"
+    ul_classes = classy "pointer-list-editor", extra_class
+    haml :link_list_input, items: items, ul_classes: ul_classes,
+                           options_card: options_card_name
   end
 end

data/mod/pointer/set/type/link_list/link_list_input.haml

@@ -0,0 +1,24 @@
+%ul{class: ul_classes}
+  - items.each do |reference, title|
+    %li.pointer-li.mb-1
+      %span.input-group
+        .input-group-prepend.handle
+          %span.input-group-text
+            = icon_tag :reorder
+        %span.input-group-text.text-muted.group-text-left
+          [[
+        = text_field_tag "pointer_item", reference, class: "_reference pointer-item-text form-control group-text-middle",
+                                               "data-options-card": options_card
+        %span.input-group-text.text-muted.group-text-middle
+          |
+        = text_field_tag "pointer_item_title", title, class: "_title pointer-item-text form-control group-text-middle"
+        %span.input-group-text.text-muted.group-text-right
+          ]]
+        .input-group-append
+          %span.input-group-text.p-0
+            %button.pointer-item-delete.btn.btn-secondary{ type: "button"}
+              = icon_tag :remove
+%span.input-group
+  %button._pointer-item-add.btn.btn-secondary{ type: "submit" }
+    = icon_tag "add"
+    add another

data/mod/pointer/set/type/mirrored_list.rb

@@ -1,7 +1,7 @@
 include_set Abstract::Pointer
 
 event :validate_list_name, :validate, on: :save, changed: :name do
-  errors.add :name, tr(:cardtype_right) if !junction? || !right || right.type_id != CardtypeID
+  errors.add :name, tr(:cardtype_right) unless right&.type_id == CardtypeID
 end
 
 event :validate_list_item_type_change, :validate,

data/mod/pointer/spec/set/abstract/pointer/html_views_spec.rb

@@ -8,7 +8,7 @@ describe Card::Set::Abstract::Pointer do
       pointer
     end
 
-    check_views_for_errors :core, :closed_content, :editor,
+    check_views_for_errors :core, :one_line_content, :input,
                            :list, :autocomplete, :checkbox,
                            :radio, :select, :multiselect
   end
@@ -37,25 +37,27 @@ describe Card::Set::Abstract::Pointer do
     end
 
     it "includes nonexisting card in radio options" do
-      common_html = 'input[class="pointer-radio-button"]' \
-                    '[checked="checked"]' \
-                    '[type="radio"]' \
-                    '[value="nonexistingcardmustnotexistthisistherule"]' \
-                    '[id="pointer-radio-nonexistingcardmustnotexistthisistherule"]'
-      option_html = common_html + '[name="pointer_radio_button-tp"]'
-      assert_view_select pointer.format.render_radio, option_html
-      option_html = common_html + '[name="pointer_radio_button-ip"]'
-      assert_view_select inherit_pointer.format.render_radio, option_html
+      common_with = { type: "radio",
+                      value: "nonexistingcardmustnotexistthisistherule",
+                      id: "pointer-radio-nonexistingcardmustnotexistthisistherule",
+                      checked: "checked" }
+      expect(pointer.format.render_radio)
+        .to have_tag "input.pointer-radio-button",
+                     with: common_with.merge(name: "pointer_radio_button-tp")
+      expect(inherit_pointer.format.render_radio)
+        .to have_tag "input.pointer-radio-button",
+                     with: common_with.merge(name: "pointer_radio_button-ip")
     end
 
     it "includes nonexisting card in checkbox options" do
-      option_html = 'input[class="pointer-checkbox-button"]' \
-                    '[checked="checked"]' \
-                    '[type="checkbox"]' \
-                    '[value="nonexistingcardmustnotexistthisistherule"]' \
-                    '[id="pointer-checkbox-nonexistingcardmustnotexistthisistherule"]'
-      # debug_assert_view_select @pointer.format.render_checkbox, option_html
-      assert_view_select inherit_pointer.format.render_checkbox, option_html
+      expect(inherit_pointer.format.render_checkbox)
+        .to have_tag "input.pointer-checkbox-button",
+                     with: {
+                       type: "checkbox",
+                       value: "nonexistingcardmustnotexistthisistherule",
+                       id: "pointer-checkbox-nonexistingcardmustnotexistthisistherule",
+                       checked: "checked"
+                     }
     end
 
     it "includes nonexisting card in select options" do
@@ -77,7 +79,7 @@ describe Card::Set::Abstract::Pointer do
   describe "list_input" do
     subject do
       pointer = Card.new name: "tp", type: "pointer", content: pointer_content
-      pointer.format._render :editor
+      pointer.format._render :input
     end
 
     let(:pointer_content) { "[[Jane]]\n[[John]]" }

data/mod/pointer/spec/set/abstract/pointer/options_api_spec.rb

@@ -1,6 +1,7 @@
 RSpec.describe Card::Set::Abstract::Pointer::OptionsApi do
   def define_options_rule type_id, content
-    Card.create! name: %i[pointer type options], type_id: type_id, content: content
+    Card.create! name: %i[pointer type content_options],
+                 type_id: type_id, content: content
   end
 
   let :sample_pointer do

data/mod/pointer/spec/set/self/input_options_spec.rb

@@ -1,6 +1,6 @@
 describe Card::Set::Self::InputOptions do
   it "loads the self set" do
-    expect(Card[:input, :right, :options].item_names).to contain_exactly(
+    expect(Card[:input_type, :right, :content_options].item_names).to contain_exactly(
       "radio", "checkbox", "select", "multiselect", "list", "ace editor", "filtered list",
       "prosemirror editor", "tinymce editor", "text area", "text field", "calendar"
     )

data/mod/rules/set/right/self.rb

@@ -0,0 +1,3 @@
+def prototype_default_card
+  left
+end

data/mod/rules/set/rule/bar_view.rb

@@ -0,0 +1,88 @@
+format :html do
+  bar_cols 6, 6
+  info_bar_cols 5, 4, 3
+
+  def existing_rule_card
+    @existing_rule_card ||= find_existing_rule_card
+  end
+
+  view :bar, unknown: true do
+    voo.hide :bar_nav unless existing_rule_card
+    super()
+  end
+
+  view :expanded_bar, unknown: true do
+    super()
+  end
+
+  view :one_line_content,
+       wrap: { div: { class: "text-muted one-line" } }, unknown: true do
+    return render_mini_unknown unless existing_rule_card
+
+    with_nest_mode :compact do
+      one_line_content
+    end
+  end
+
+  view :raw_one_line_content,
+       wrap: { div: { class: "text-muted one-line" } }, unknown: true do
+    return render_mini_unknown unless existing_rule_card
+
+    raw_one_line_content
+  end
+
+  view :bar_bottom, unknown: true do
+    if nest_mode == :edit
+      current_rule_form
+    else
+      nest existing_rule_card, view: :core
+    end
+  end
+
+  view :bar_middle, unknown: true do
+    rule_info
+  end
+
+  view :bar_left, unknown: true do
+    super()
+  end
+
+  view :bar_right, unknown: true do
+    voo.show?(:bar_bottom) ? rule_info : rule_short_content
+  end
+
+  def rule_short_content
+    return "" unless existing_rule_card
+
+    nest existing_rule_card, { view: :one_line_content },
+         set_context: card.name.trunk_name
+  end
+
+  def bar_title
+    return super() if voo.show? :full_name
+
+    if existing_rule_card && voo.show?(:toggle)
+      link_to_view bar_title_toggle_view, card.rule_setting_title
+    else
+      card.rule_setting_title
+    end
+  end
+
+  # LOCALIZE
+  def rule_info
+    return wrap_with(:em, "no existing #{setting_link} rule") unless existing_rule_card
+
+    wrap_with :span,
+              "#{rule_setting_link} rule that applies to "\
+              "#{rule_set_link existing_rule_card}"
+  end
+
+  def rule_setting_link
+    link_to_card card.rule_setting, card.rule_setting_name
+  end
+
+  def rule_set_link existing_rule
+    count = link_to_card [card.rule_set, :by_name], card.rule_set.count
+    "#{link_to_card card.rule_set, existing_rule.trunk&.label&.downcase} (#{count})"
+  end
+end