card 1.91 → 1.92

data/spec/models/card_spec.rb

@@ -1,9 +1,9 @@
-# -*- encoding : utf-8 -*-
+   # -*- encoding : utf-8 -*-
 
 describe Card do
   describe "test data" do
     it "is findable by name" do
-      expect(Card["Wagn Bot"].class).to eq(Card)
+      expect(Card["Wagn Bot"]).to be_a Card
     end
   end
 
@@ -15,7 +15,7 @@ describe Card do
       end
     end
 
-    it "does not have errors"        do expect(@b.errors.size).to eq(0)        end
+    it "does not have errors"  do expect(@b.errors.size).to eq(0)        end
     it "has the right class"   do expect(@c.class).to    eq(Card)        end
     it "has the right key"     do expect(@c.key).to      eq("new_card")  end
     it "has the right name"    do expect(@c.name).to     eq("New Card")  end
@@ -48,10 +48,8 @@ describe Card do
     end
   end
 
-  describe "created a virtual card when missing and has a template" do
-    it "is flagged as virtual" do
-      expect(Card.new(name: "A+*last edited").virtual?).to be_truthy
-    end
+  example "creates a virtual card when missing" do
+    expect(Card.new(name: "A+*last edited")).to be_virtual
   end
 end
 
@@ -76,37 +74,6 @@ describe "basic card tests" do
     assert_equal card1.right, card2.right
   end
 
-  it "removes cards" do
-    forba = Card.create! name: "Forba"
-    torga = Card.create! name: "TorgA"
-    torgb = Card.create! name: "TorgB"
-    torgc = Card.create! name: "TorgC"
-
-    forba_torga = Card.create! name: "Forba+TorgA"
-    torgb_forba = Card.create! name: "TorgB+Forba"
-    forba_torga_torgc = Card.create! name: "Forba+TorgA+TorgC"
-
-    Card["Forba"].delete!
-
-    expect(Card["Forba"]).to be_nil
-    expect(Card["Forba+TorgA"]).to be_nil
-    expect(Card["TorgB+Forba"]).to be_nil
-    expect(Card["Forba+TorgA+TorgC"]).to be_nil
-
-    # FIXME: this is a pretty dumb test and it takes a loooooooong time
-    # while card = Card.find(:first,conditions: ["type not in (?,?,?) and trash=?", 'AccountRequest','User','Cardtype',false] )
-    #  card.delete!
-    # end
-    # assert_equal 0, Card.find_all_by_trash(false).size
-  end
-
-  # test test_attribute_card
-  #  alpha, beta = Card.create(name: 'alpha'), Card.create(name: 'beta')
-  #  assert_nil alpha.attribute_card('beta')
-  #  Card.create name: 'alpha+beta'
-  #   alpha.attribute_card('beta').should be_instance_of(Card)
-  # end
-
   it "creates cards" do
     alpha = Card.new name: "alpha", content: "alpha"
     expect(alpha.content).to eq("alpha")
@@ -143,18 +110,21 @@ describe "basic card tests" do
     expect(peel.creator_id).to eq(Card::AnonymousID)
   end
 
-  it "update_should_not_create_subcards_if_missing_main_card_permissions" do
-    b = Card.create!(name: "Banana")
-    Card::Auth.as Card::AnonymousID do
-      b.update_attributes subcards: { "+peel" => { content: "yellow" } }
-      expect(b.errors[:permission_denied]).not_to be_empty
+  context "missing main card permissions" do
+    it "update doesn't create subcards" do
+      b = create! "Banana"
+      Card::Auth.as Card::AnonymousID do
+        b.update_attributes subcards: { "+peel" => { content: "yellow" } }
+        expect(b.errors[:permission_denied]).not_to be_empty
 
-      c = Card.update(b.id, subcards: { "+peel" => { content: "yellow" } })
-      expect(c.errors[:permission_denied]).not_to be_empty
-      expect(Card["Banana+peel"]).to be_nil
+        c = Card.update(b.id, subcards: { "+peel" => { content: "yellow" } })
+        expect(c.errors[:permission_denied]).not_to be_empty
+        expect(Card["Banana+peel"]).to be_nil
+      end
     end
   end
 
+
   it "create_without_read_permission" do
     c = Card.create!(name: "Banana", type: "Fruit", content: "mush")
     Card::Auth.as Card::AnonymousID do

data/spec/spec_helper.rb

@@ -5,9 +5,6 @@ CardSpecLoader.init
 
 require "rr"
 
-# used for SharedData::Users - required here so code won't show up in coverage
-require File.expand_path("../../db/seed/test/seed.rb", __FILE__)
-
 CardSpecLoader.prefork do
   FIXTURES_PATH = File.expand_path("../../db/seed/test/fixtures", __FILE__)
 
@@ -45,3 +42,4 @@ class ActiveSupport::Logger
     end
   end
 end
+

data/spec/support/card_spec_helper.rb

@@ -1,5 +1,8 @@
-helper_path = File.expand_path "../helper/*.rb", __FILE__
-Dir[helper_path].each { |f| require f }
+%w[helper matchers].each do |load_dir|
+  load_path = File.expand_path "../#{load_dir}/*.rb", __FILE__
+  Dir[load_path].each { |f| require f }
+end
+
 
 class Card
   # to be included in  RSpec::Core::ExampleGroup

data/spec/support/card_spec_loader.rb

@@ -14,12 +14,13 @@ class CardSpecLoader
         require File.join ENV["RAILS_ROOT"], "config/environment"
         load_shared_examples
         require File.expand_path("../simplecov_helper.rb", __FILE__)
+        require File.expand_path("../../../db/seed/test/seed.rb", __FILE__)
 
         # Requires supporting ruby files with custom matchers and macros, etc,
         # in spec/support/ and its subdirectories.
-        #  Dir[File.join(Cardio.gem_root, "spec/support/**/*.rb")].each do |f|
-        #    require f
-        #  end
+        Dir[File.join(Cardio.gem_root, "spec/support/matchers/*.rb")].each do |f|
+          require f
+        end
         yield if block_given?
       end
     end
@@ -53,17 +54,44 @@ class CardSpecLoader
         config.use_transactional_fixtures = true
         config.use_instantiated_fixtures  = false
 
-        config.before(:each) do
+        config.before(:each) do |example|
           Delayed::Worker.delay_jobs = false
-          Card::Auth.current_id = @@joe_user_id
+          unless example.metadata[:as_bot]
+            user_id =
+              case example.metadata[:with_user]
+              when String
+                Card.fetch_id example.metadata[:with_user]
+              when Card
+                Card.id
+              when Integer
+                example.metadata[:with_user]
+              else
+                @@joe_user_id
+              end
+            Card::Auth.current_id = user_id
+          end
           Card::Cache.restore
           Card::Env.reset
         end
 
+        config.around(:example, :as_bot) do |example|
+          Card::Auth.current_id = @@joe_user_id
+          Card::Auth.as_bot do
+            example.run
+          end
+        end
+
         config.after(:each) do
           Timecop.return
         end
         yield config if block_given?
+
+        # # only needed for < 3.5.0
+        # [:controller, :view, :request].each do |type|
+        #   config.include ::Rails::Controller::Testing::TestProcess, :type => type
+        #   config.include ::Rails::Controller::Testing::TemplateAssertions, :type => type
+        #   config.include ::Rails::Controller::Testing::Integration, :type => type
+        # end
       end
     end
 
@@ -76,7 +104,7 @@ class CardSpecLoader
     end
 
     def load_shared_examples
-      Card::Mod::Loader.mod_dirs.each "spec/shared_examples" do |shared_ex_dir|
+      Card::Mod.dirs.each "spec/shared_examples" do |shared_ex_dir|
         Dir["#{shared_ex_dir}/**/*.rb"].sort.each { |f| require f }
       end
     end

data/spec/support/helper/event_helper.rb

@@ -61,7 +61,7 @@ class Card
       def add_test_event stage, name, opts={}, &event_block
         # use random set module that is always included so that the
         # event applies to all cards
-        opts[:set] ||= Card::Set::All::Event
+        opts[:set] ||= Card::Set::All::Fetch
         if (only_for_card = opts.delete(:for))
           opts[:when] = proc { |c| c.name == only_for_card }
         end

data/spec/support/helper/save_helper.rb

@@ -18,6 +18,10 @@ class Card
         Card::Auth.as_bot { super }
       end
 
+      def update! name_or_args, content_or_args={}
+        update_card name_or_args, content_or_args
+      end
+
       def delete name
         Card::Auth.as_bot { Card[name].delete! }
       end

data/spec/support/helper/set_helper.rb

@@ -7,7 +7,7 @@ class Card
       # @return format object
       # @example add a view to a card's html format
       # format =
-      #   Card["A"].attach_to_format(:html) do
+      #   Card["A"].format_with(:html) do
       #     view :my_test_view do
       #       card.name
       #     end

data/spec/support/matchers/card_matchers.rb

@@ -0,0 +1,136 @@
+#TODO: is this global namespace? module?
+def expect_card *marks
+  expect Card.cardish(marks)
+end
+
+RSpec::Matchers.define :exist do
+  match do |card|
+    should_be_true =
+      case card
+      when String
+        Card.exists? card
+      when Card
+        card.real?
+      else
+        card.present?
+      end
+    values_match? true, should_be_true
+  end
+
+  failure_message do |actual|
+    case actual
+    when String
+      "card '#{actual}' doesn't exist"
+    when Card
+      "#{actual.name} doesn't exist"
+    else
+      "#{actual} doesn't exist"
+    end
+  end
+end
+
+RSpec::Matchers.define :be_valid do
+  match do |card|
+    values_match?(true, card.errors.empty?)
+  end
+end
+
+[:name, :codename, :db_content, :content, :type_id].each do |field|
+  RSpec::Matchers.define "have_#{field}".to_sym do |name|
+    match do |card|
+      values_match?(name, card.send(field))
+    end
+  end
+end
+
+# RSpec::Matchers.define :have_codename do |codename|
+#   match do |card|
+#     values_match?(codename, card.codename)
+#   end
+# end
+#
+# RSpec::Matchers.define :have_content do |content|
+#   match do |card|
+#     binding.pry
+#     puts card
+#     values_match?(content, card.content)
+#   end
+# end
+
+RSpec::Matchers.define :have_type do |type|
+  match do |card|
+    case type
+    when Symbol
+      values_match?(type, card.type_code)
+    when Integer
+      values_match?(type, card.type_id)
+    when String
+      values_match?(type, card.type_name)
+    end
+  end
+end
+
+RSpec::Matchers.define :have_raw_content do |content|
+  match do |card|
+    values_match?(content, card.raw_content)
+  end
+end
+
+RSpec::Matchers.define :increase_card_count do
+  chain(:by) do |diff|
+    @diff = diff
+  end
+
+  match do |card_creation|
+    count = Card.count
+    card_creation.call
+    if @diff
+      values_match?(count + @diff, Card.count)
+    else
+      Card.count > count
+    end
+  end
+
+  supports_block_expectations
+end
+
+RSpec::Matchers.define :be_a_new_card do
+  match do |card|
+    card.is_a?(Card) && card.new_record?
+  end
+end
+
+RSpec::Matchers.define :be_invalid do
+  match do |card|
+    # valid? clears errors
+    # For a new card we have to call valid? to create the errors.
+    # For a updated card we have to check errors because with valid? we would
+    # loose the errors.
+    @valid = card.errors.empty? && card.valid?
+    # card.errors returns an array, hence we need an extra include matcher
+    values_match?(false, @valid) &&
+      values_match?(include(@error_msg), card.errors[@error_key])
+  end
+
+  description do
+    "be invalid #{"because of #{@error_key} #{@error_msg}" if @error_key}"
+  end
+
+  chain(:because_of) do |reason|
+    @error_key, @error_msg = reason.to_a.first
+  end
+
+  failure_message do |actual|
+    super() + fail_reason(actual)
+  end
+
+  def fail_reason actual
+    if @valid
+      "but file is valid"
+    else
+      "but it is invalid because of #{actual.errors.messages}"
+    end
+  end
+end
+
+

data/spec/support/matchers/expectations.rb

@@ -0,0 +1,5 @@
+module CardExpectations
+  def expect_content_of name
+    expect(Card.fetch(name).content)
+  end
+end

data/spec/support/matchers/file_matchers.rb

@@ -0,0 +1,71 @@
+RSpec::Matchers.define :have_file do |trait|
+  match do |card|
+    (@file = card.file) && file_size_matches
+  end
+
+  description do
+    "have a file attached #{"of size #{@size}" if @size}"
+  end
+
+  chain(:of_size) { |size| @size = size }
+
+  failure_message do |_actual|
+    if @size
+      "#{super()} but file size is #{@file.size}"
+    else
+      "#{super()} but found no file"
+    end
+  end
+
+  failure_message_when_negated do |_actual|
+    if @size
+      "#{super()} but file size is #{@file.size}"
+    else
+      "#{super()} but found a file"
+    end
+  end
+
+  private
+
+  def file_size_matches
+    return true unless @size
+    @size === @file.size
+  end
+end
+
+# TODO: use :have_file for this
+RSpec::Matchers.define :have_file_trait do |trait|
+  match do |card|
+    trait ||= :file
+    (@file = card.fetch(trait: trait)) && file_size_matches
+  end
+
+  description do
+    "have a file attached #{"of size #{@size}" if @size}"
+  end
+
+  chain(:of_size) { |size| @size = size }
+
+  failure_message do |_actual|
+    if @size
+      "#{super()} but file size is #{@file.file.size}"
+    else
+      "#{super()} but found no file"
+    end
+  end
+
+  failure_message_when_negated do |_actual|
+    if @size
+      "#{super()} but file size is #{@file.file.size}"
+    else
+      "#{super()} but found a file"
+    end
+  end
+
+  private
+
+  def file_size_matches
+    return true unless @size
+    @size === @file.file.size
+  end
+end

data/spec/support/matchers/negated_matchers.rb

@@ -0,0 +1,2 @@
+RSpec::Matchers.define_negated_matcher :not_include, :include
+RSpec::Matchers.define_negated_matcher :be_not_virtual, :be_virtual