card 1.19.6 → 1.20.0

data/mod/core/spec/set/all/content_spec.rb

@@ -2,7 +2,7 @@
 
 describe Card::Set::All::Content do
   describe "save_content_draft" do
-    it "should store a draft revision" do
+    it "stores a draft revision" do
       @card = Card.create! name: "mango", content: "foo"
       @card.save_content_draft("bar")
       expect(@card.drafts.length).to eq 1

data/mod/core/spec/set/all/export_spec.rb

@@ -12,7 +12,7 @@ describe Card::Set::All::Export do
       big_blind.format(:json).render_export
     end
     context "pointer card" do
-      it "should contain cards in the pointer card and its children" do
+      it "contains cards in the pointer card and its children" do
         small_blind = Card.create! name: "Elbert Hubbard",
                                    type_id: Card::BasicID,
                                    content: "Do not take life too seriously."
@@ -76,7 +76,7 @@ describe Card::Set::All::Export do
       end
     end
     context "Skin card" do
-      it "should contain cards in the pointer card and its children" do
+      it "contains cards in the pointer card and its children" do
         Card::Auth.as_bot do
           small_blind =
             Card.create! name: "Elbert Hubbard",
@@ -99,7 +99,7 @@ describe Card::Set::All::Export do
       end
     end
     context "search card" do
-      it "should contain cards from search card and its children" do
+      it "contains cards from search card and its children" do
         Card.create!(
           name: "Elbert Hubbard",
           type_id: Card::BasicID,

data/mod/core/spec/set/all/fetch_spec.rb

@@ -167,7 +167,7 @@ describe Card::Set::All::Fetch do
         expect(card.raw_content).to eq("Formatted Content")
       end
 
-      it "should recognize pattern overrides" do
+      it "recognizes pattern overrides" do
         # ~~~ create right rule
         Card.create!(name: "y+*right+*structure", content: "Right Content")
         card = Card.fetch("a+y")
@@ -188,7 +188,7 @@ describe Card::Set::All::Fetch do
         expect(card.raw_content).to eq("Right Content")
       end
 
-      it "should not hit the database for every fetch_virtual lookup" do
+      it "does not hit the database for every fetch_virtual lookup" do
         card_double = class_double("Card")
         Card.create!(name: "y+*right+*structure", content: "Formatted Content")
         Card.fetch("a+y")
@@ -196,7 +196,7 @@ describe Card::Set::All::Fetch do
         Card.fetch("a+y")
       end
 
-      it "should not be a new_record after being saved" do
+      it "does not be a new_record after being saved" do
         Card.create!(name: "growing up")
         card = Card.fetch("growing up")
         expect(card.new_record?).to be_falsey
@@ -252,14 +252,14 @@ describe Card::Set::All::Fetch do
                      content: '{"plus":"_self"}', type: "Search"
       end
     end
-    it "should find cards with *right+*structure specified" do
+    it "finds cards with *right+*structure specified" do
       c = Card.fetch("A+testsearch".to_name)
       assert c.virtual?
       expect(c.type_code).to eq(:search_type)
       expect(c.raw_content).to eq('{"plus":"_self"}')
     end
     context "fetched virtual card with new args" do
-      it "should fetch the virtual card with type set in patterns" do
+      it "fetchs the virtual card with type set in patterns" do
         Card.fetch "+testsearch", new: { name: "+testsearch",
                                          supercard: Card["home"] }
 

data/mod/core/spec/set/all/initialize_spec.rb

@@ -59,19 +59,19 @@ describe Card::Set::All::Initialize do
       end
 
       it "happens after new" do
-        expect(@c.respond_to?(:get_query)).to be_truthy
+        expect(@c.respond_to?(:query)).to be_truthy
       end
 
       it "happens after save" do
-        expect(@c.respond_to?(:get_query)).to be_truthy
+        expect(@c.respond_to?(:query)).to be_truthy
         @c.save!
-        expect(@c.respond_to?(:get_query)).to be_truthy
+        expect(@c.respond_to?(:query)).to be_truthy
       end
 
       it "happens after fetch" do
         @c.save!
         c = Card.fetch(@c.name)
-        expect(c.respond_to?(:get_query)).to be_truthy
+        expect(c.respond_to?(:query)).to be_truthy
       end
     end
 

data/mod/core/spec/set/all/name_spec.rb

@@ -8,18 +8,18 @@ describe Card::Set::All::Name do
       end
     end
 
-    it "should handle cards without names" do
+    it "handles cards without names" do
       c = Card.create! type: "Book"
       expect(c.name).to eq("b1")
     end
 
-    it "should increment again if name already exists" do
+    it "increments again if name already exists" do
       _b1 = Card.create! type: "Book"
       b2 = Card.create! type: "Book"
       expect(b2.name).to eq("b2")
     end
 
-    it "should handle trashed names" do
+    it "handles trashed names" do
       b1 = Card.create! type: "Book"
       Card::Auth.as_bot { b1.delete }
       b1 = Card.create! type: "Book"
@@ -32,12 +32,12 @@ describe Card::Set::All::Name do
       @card = Card["a"]
     end
 
-    it "should require admin permission" do
+    it "requires admin permission" do
       @card.update_attributes codename: "structure"
       expect(@card.errors[:codename].first).to match(/only admins/)
     end
 
-    it "should check uniqueness" do
+    it "checks uniqueness" do
       Card::Auth.as_bot do
         @card.update_attributes codename: "structure"
         expect(@card.errors[:codename].first).to match(/already in use/)
@@ -46,7 +46,7 @@ describe Card::Set::All::Name do
   end
 
   describe "repair_key" do
-    it "should fix broken keys" do
+    it "fixes broken keys" do
       a = Card["a"]
       a.update_column "key", "broken_a"
       a.expire

data/mod/core/spec/set/all/permissions_spec.rb

@@ -176,7 +176,7 @@ describe Card::Set::All::Permissions do
       expect(c.read_rule_id).to eq(@perm_card.id)
     end
 
-    it "should get updated when relative settings change" do
+    it "gets updated when relative settings change" do
       Card::Auth.as_bot do
         all_plus = Card.fetch "*all plus+*read", new: { content: "_left" }
         all_plus.save
@@ -202,7 +202,7 @@ describe Card::Set::All::Permissions do
       )
     end
 
-    it "should insure that class overrides work with relative settings" do
+    it "insures that class overrides work with relative settings" do
       Card::Auth.as_bot do
         all_plus = Card.fetch "*all plus+*read", new: { content: "_left" }
         all_plus.save
@@ -215,7 +215,7 @@ describe Card::Set::All::Permissions do
       end
     end
 
-    it "should work on virtual+virtual cards" do
+    it "works on virtual+virtual cards" do
       c = Card.fetch("Number+*type+by name")
       expect(c.ok?(:read)).to be_truthy
     end
@@ -251,7 +251,7 @@ describe Card::Set::All::Permissions do
       end
     end
 
-    it "should be granted to admin if to anybody" do
+    it "is granted to admin if to anybody" do
       Card::Auth.as_bot do
         c1 = Card["c1"]
         Card.create! name: "c1+*self+*comment", type: "Pointer",
@@ -454,7 +454,7 @@ describe Card::Set::All::Permissions do
     end
   end
 
-  it "should let joe view new cards" do
+  it "lets joe view new cards" do
     expect(Card.new.ok?(:read)).to be_truthy
   end
 
@@ -463,24 +463,24 @@ describe Card::Set::All::Permissions do
       @c = Card.create! name: "sky blue"
     end
 
-    it "should let anonymous users view basic cards" do
+    it "lets anonymous users view basic cards" do
       Card::Auth.as :anonymous do
         expect(@c.ok?(:read)).to be_truthy
       end
     end
 
-    it "should let joe user basic cards" do
+    it "lets joe user basic cards" do
       Card::Auth.as "joe_user" do
         expect(@c.ok?(:read)).to be_truthy
       end
     end
   end
 
-  it "should allow anyone signed in to create Basic Cards" do
+  it "allows anyone signed in to create Basic Cards" do
     expect(Card.new.ok?(:create)).to be_truthy
   end
 
-  it "should not allow someone not signed in to create Basic Cards" do
+  it "does not allow someone not signed in to create Basic Cards" do
     Card::Auth.as :anonymous do
       expect(Card.new.ok?(:create)).not_to be_truthy
     end
@@ -496,7 +496,7 @@ describe Card::Set::All::Permissions do
       end
     end
 
-    it "should handle delete as a setting" do
+    it "handles delete as a setting" do
       c = Card.new name: "whatever"
       expect(c.who_can(:delete)).to eq([Card["joe_user"].id])
       Card::Auth.as("joe_user") do

data/mod/core/spec/set/all/references_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::All::References do
-  it "should replace references should work on nests inside links" do
+  it "replaces references should work on nests inside links" do
     card = Card.create! name: "ref test", content: "[[test_card|test{{test}}]]"
     assert_equal "[[test_card|test{{best}}]]",
                  card.replace_reference_syntax("test", "best")

data/mod/core/spec/set/all/rules2_spec.rb

@@ -18,20 +18,20 @@ describe Card do
     end
 
     describe ".rule" do
-      it "should have a value of 2" do
+      it "has a value of 2" do
         expect(@rule_card.content).to eq("2")
         expect(@c1.rule(:table_of_contents)).to eq("2")
       end
     end
 
     describe "renders with/without toc" do
-      it "should not render for 'Onne Heading'" do
+      it "does not render for 'Onne Heading'" do
         expect(@c1.format.render_open_content).not_to match(/Table of Contents/)
       end
-      it "should render for 'Twwo Heading'" do
+      it "renders for 'Twwo Heading'" do
         expect(@c2.format.render_open_content).to match(/Table of Contents/)
       end
-      it "should render for 'Three Heading'" do
+      it "renders for 'Three Heading'" do
         expect(@c3.format.render_open_content).to match(/Table of Contents/)
       end
     end
@@ -51,14 +51,14 @@ describe Card do
         sets = Card["Cardtype A"].related_sets.map { |s| s[0] }
         expect(sets).to eq(["Cardtype A+*type", "Cardtype A+*right"])
       end
-      # it "should show type plus right sets when they exist" do
+      # it "shows type plus right sets when they exist" do
       #   Card::Auth.as_bot do
       #     Card.create name: 'Basic+A+*type plus right', content: ''
       #   end
       #   sets = Card['A'].related_sets
       #   sets.should == ['A+*self', 'A+*right', 'Basic+A+*type plus right']
       # end
-      # it "should show type plus right sets when they exist, and type" do
+      # it "shows type plus right sets when they exist, and type" do
       #   Card::Auth.as_bot do
       #     Card.create name: 'Basic+Cardtype A+*type plus right', content: ''
       #   end
@@ -73,7 +73,7 @@ describe Card do
     end
     #     # class methods
     #     describe ".default_rule" do
-    #       it 'should have default rule' do
+    #       it 'has default rule' do
     #         Card.default_rule(:table_of_contents).should == '0'
     #       end
     #     end
@@ -89,20 +89,20 @@ describe Card do
     end
 
     describe ".rule" do
-      it "should have a value of 1" do
+      it "has a value of 1" do
         expect(@rule_card.content).to eq("1")
         expect(@c1.rule(:table_of_contents)).to eq("1")
       end
     end
 
     describe "renders with/without toc" do
-      it "should not render toc for 'Onne Heading'" do
+      it "does not render toc for 'Onne Heading'" do
         expect(@c1.format.render_open_content).to match(/Table of Contents/)
       end
-      it "should render toc for 'Twwo Heading'" do
+      it "renders toc for 'Twwo Heading'" do
         expect(@c2.format.render_open_content).to match(/Table of Contents/)
       end
-      it "should not render for 'Twwo Heading' when changed to 3" do
+      it "does not render for 'Twwo Heading' when changed to 3" do
         @rule_card.content = "3"
         expect(@c2.rule(:table_of_contents)).to eq("3")
         expect(@c2.format.render_open_content).not_to match(/Table of Contents/)
@@ -130,20 +130,20 @@ describe Card do
     end
 
     describe ".rule" do
-      it "should have a value of 0" do
+      it "has a value of 0" do
         expect(@c1.rule(:table_of_contents)).to eq("0")
         expect(@rule_card.content).to eq("0")
       end
     end
 
     describe "renders without toc" do
-      it "should not render for 'Onne Heading'" do
+      it "does not render for 'Onne Heading'" do
         expect(@c1.format.render_open_content).not_to match(/Table of Contents/)
       end
-      it "should render for 'Twwo Heading'" do
+      it "renders for 'Twwo Heading'" do
         expect(@c2.format.render_open_content).not_to match(/Table of Contents/)
       end
-      it "should render for 'Three Heading'" do
+      it "renders for 'Three Heading'" do
         expect(@c3.format.render_open_content).not_to match(/Table of Contents/)
       end
     end
@@ -161,7 +161,7 @@ describe Card do
 
     #     # class methods
     #     describe ".default_rule" do
-    #       it 'should have default rule' do
+    #       it 'has default rule' do
     #         Card.default_rule(:table_of_contents).should == '0'
     #       end
     #     end
@@ -190,7 +190,7 @@ describe Card do
         end
       end
     end
-    it "should take on new setting value" do
+    it "takes on new setting value" do
       c = Card["toc1"]
       expect(c.rule_card(:table_of_contents).name)
         .to eq("CardtypeE+*type+*table of content")
@@ -198,14 +198,14 @@ describe Card do
     end
 
     describe "renders with/without toc" do
-      it "should not render for 'Onne Heading'" do
+      it "does not render for 'Onne Heading'" do
         expect(@c1.format.render_open_content).not_to match(/Table of Contents/)
       end
-      it "should render for 'Twwo Heading'" do
+      it "renders for 'Twwo Heading'" do
         expect(@c2.rule(:table_of_contents)).to eq("2")
         expect(@c2.format.render_open_content).to match(/Table of Contents/)
       end
-      it "should render for 'Three Heading'" do
+      it "renders for 'Three Heading'" do
         expect(@c3.format.render_open_content).to match(/Table of Contents/)
       end
     end
@@ -225,20 +225,20 @@ describe Card do
     end
 
     describe ".rule" do
-      it "should have a value of 1" do
+      it "has a value of 1" do
         expect(@rule_card.content).to eq("1")
         expect(@c1.rule(:table_of_contents)).to eq("1")
       end
     end
 
     describe "renders with/without toc" do
-      it "should not render toc for 'Onne Heading'" do
+      it "does not render toc for 'Onne Heading'" do
         expect(@c1.format.render_open_content).to match(/Table of Contents/)
       end
-      it "should render toc for 'Twwo Heading'" do
+      it "renders toc for 'Twwo Heading'" do
         expect(@c2.format.render_open_content).to match(/Table of Contents/)
       end
-      it "should not render for 'Twwo Heading' when changed to 3" do
+      it "does not render for 'Twwo Heading' when changed to 3" do
         @rule_card.content = "3"
         expect(@c2.format.render_open_content).not_to match(/Table of Contents/)
       end

data/mod/core/spec/set/all/rules_spec.rb

@@ -6,7 +6,7 @@ describe Card::Set::All::Rules do
   end
 
   describe "setting data setup" do
-    it "should make Set of +*type" do
+    it "makes Set of +*type" do
       Card.create! name: "SpeciForm", type: "Cardtype"
       expect(Card.create!(name: "SpeciForm+*type").type_code).to eq(:set)
     end

data/mod/core/spec/set/all/templating_spec.rb

@@ -26,11 +26,11 @@ describe Card::Set::All::Templating do
       @jb = Card.create! name: "Jim+birthday"
     end
 
-    it "should have default content" do
+    it "has default content" do
       expect(@jb.format._render_raw).to eq("Today!")
     end
 
-    it "should change type and content with template" do
+    it "changes type and content with template" do
       Card::Auth.as_bot do
         @bt.content = "Tomorrow"
         @bt.type = "Phrase"
@@ -41,7 +41,7 @@ describe Card::Set::All::Templating do
       expect(jb.type_id).to eq(Card::PhraseID)
     end
 
-    it "should have type and content overridden by (new) type_plus_right set" do
+    it "has type and content overridden by (new) type_plus_right set" do
       Card::Auth.as_bot do
         Card.create! name: "Basic+birthday+*type plus right+*structure",
                      type: "PlainText",
@@ -64,15 +64,15 @@ describe Card::Set::All::Templating do
       @jb = Card.create! name: "Jim+birthday"
     end
 
-    it "should have default cardtype" do
+    it "has default cardtype" do
       expect(@jb.type_code).to eq(:date)
     end
 
-    it "should have default content" do
+    it "has default content" do
       expect(Card["Jim+birthday"].content).to eq("Today!")
     end
 
-    it "should apply to new cards" do
+    it "applies to new cards" do
       pb = Card.new name: "Pete+birthday"
       expect(pb.raw_content).to eq("Today!")
       expect(pb.content).to eq("Today!")
@@ -88,7 +88,7 @@ describe Card::Set::All::Templating do
       end
     end
 
-    it "should return templated content even if content is passed in" do
+    it "returns templated content even if content is passed in" do
       new_date_card = Card.new type: "Date", content: ""
       expect(new_date_card.format._render(:raw)).to eq("Tomorrow")
     end
@@ -107,7 +107,7 @@ describe Card::Set::All::Templating do
         expect(Card["Jim+birthday"].raw_content).to eq("Today")
       end
 
-      it "should defer to normal content " \
+      it "defers to normal content " \
          "when *structure rule's content is (exactly) '_self'" do
         Card::Auth.as_bot do
           Card.create! name: "Jim+birthday+*self+*structure", content: "_self"