card 1.18.6 → 1.19.0

data/spec/lib/card/set_spec.rb

@@ -1,6 +1,7 @@
 # -*- encoding : utf-8 -*-
 
-# module Card::Set::Right::Account # won't this conflict with a real set (and fail to provide controlled test?)
+# module Card::Set::Right::Account
+# won't this conflict with a real set (and fail to provide controlled test?)
 #   extend Card::Set
 #
 #   card_accessor :role,   default: "request", type: :phrase
@@ -48,8 +49,8 @@
 #   let(:card_double) { Card }
 #   let(:format_double) { object_double(Card.new(name: 'card+*right').format) }
 #
-#   #let(:html_format_double) { Card::HtmlFormat }
-#   let(:html_format_double) { double("Card::HtmlFormat") }
+#   #let(:html_format_double) { Card::Format::HtmlFormat }
+#   let(:html_format_double) { double("Card::Format::HtmlFormat") }
 #
 #   it "should define Formatter methods from modules" do
 #     expect(format_double).to respond_to(:render_navbox_self_core)

data/spec/lib/card/stage_director_spec.rb

@@ -1,9 +1,13 @@
 describe Card::StageDirector do
-  describe 'abortion' do
-    let(:create_card) { Card.create name: 'a card' }
-    subject { Card.fetch 'a card' }
-    context 'when error added' do
-      it 'stops act in validation phase' do
+  describe "abortion" do
+    let(:create_card) { Card.create name: "a card" }
+    let(:create_card_with_subcard) do
+      Card.create name: "a card",
+                  subcards: { "a subcard" => "content" }
+    end
+    subject { Card.fetch "a card" }
+    context "when error added" do
+      it "stops act in validation phase" do
         in_stage :validate,
                  on: :save,
                  trigger: -> { create_card } do
@@ -12,7 +16,7 @@ describe Card::StageDirector do
         is_expected.to be_falsey
       end
 
-      it 'does not stop act in storage phase' do
+      it "does not stop act in storage phase" do
         in_stage :store, on: :save,
                          trigger: -> { create_card } do
           errors.add :stop, "don't do this"
@@ -21,13 +25,13 @@ describe Card::StageDirector do
       end
     end
 
-    context 'when exception raised' do
-      it 'rollbacks in finalize stage' do
+    context "when exception raised" do
+      it "rollbacks in finalize stage" do
         begin
           in_stage :finalize,
                    on: :save,
                    trigger: -> { create_card } do
-            raise Card::Error, 'rollback'
+            raise Card::Error, "rollback"
           end
         rescue Card::Error => e
         ensure
@@ -35,13 +39,13 @@ describe Card::StageDirector do
         end
       end
 
-      it 'does not rollback in integrate stage' do
+      it "does not rollback in integrate stage" do
         begin
           Card::Auth.as_bot do
             in_stage :integrate,
                      on: :save,
                      trigger: -> { create_card } do
-              raise Card::Abort, 'rollback'
+              raise Card::Abort, "rollback"
             end
           end
         rescue Card::Abort => e
@@ -51,8 +55,8 @@ describe Card::StageDirector do
       end
     end
 
-    context 'when abort :success called' do
-      it 'aborts storage in validation stage' do
+    context "when abort :success called" do
+      it "aborts storage in validation stage" do
         in_stage :validate,
                  on: :create,
                  trigger: -> { create_card } do
@@ -61,7 +65,71 @@ describe Card::StageDirector do
         is_expected.to be_falsey
       end
 
-      it 'aborts storage in store stage' do
+      it "does not execute subcard stages on create" do
+        @called_events = []
+        def event_called ev
+          @called_events << ev
+        end
+        with_test_events do
+          test_event :validate,
+                     on: :create,
+                     for: "a card" do
+            abort :success
+          end
+          test_event :prepare_to_validate,
+                     on: :create, for: "a subcard" do
+            event_called "ptv"
+          end
+          test_event :validate,
+                     on: :create, for: "a subcard" do
+            event_called "v"
+          end
+          test_event :prepare_to_store,
+                     on: :create, for: "a subcard" do
+            event_called "pts"
+          end
+          test_event :integrate,
+                     on: :create, for: "a subcard" do
+            event_called "i"
+          end
+          create_card_with_subcard
+          expect(@called_events).to eq ["ptv"]
+        end
+      end
+
+      it "does not delete children" do
+        @called_events = []
+        def event_called ev
+          @called_events << ev
+        end
+        with_test_events do
+          test_event :validate,
+                     on: :delete,
+                     for: "A" do
+            abort :success
+          end
+          test_event :prepare_to_validate,
+                     on: :delete, for: "A+B" do
+            event_called "ptv"
+          end
+          test_event :validate,
+                     on: :delete, for: "A+B" do
+            event_called "v"
+          end
+          test_event :prepare_to_store,
+                     on: :delete, for: "A+B" do
+            event_called "pts"
+          end
+          test_event :integrate,
+                     on: :delete, for: "A+B" do
+            event_called "i"
+          end
+          Card["A"].delete!
+          expect(@called_events).to eq ["ptv"]
+        end
+      end
+
+      it "aborts storage in store stage" do
         in_stage :store,
                  on: :create,
                  trigger: -> { create_card } do
@@ -70,7 +138,7 @@ describe Card::StageDirector do
         is_expected.to be_falsey
       end
 
-      it 'aborts storage in finalize stage' do
+      it "aborts storage in finalize stage" do
         in_stage :store,
                  on: :create,
                  trigger: -> { create_card } do
@@ -79,7 +147,7 @@ describe Card::StageDirector do
         is_expected.to be_falsey
       end
 
-      it 'does not abort storage in integrate stage' do
+      it "does not abort storage in integrate stage" do
         in_stage :integrate,
                  on: :create,
                  trigger: -> { create_card } do
@@ -90,22 +158,22 @@ describe Card::StageDirector do
     end
   end
 
-  describe 'stage order' do
+  describe "stage order" do
     let(:create_card_with_subcards) do
-      Card.create name: '1',
+      Card.create name: "1",
                   subcards: {
-                    '11' => { subcards: { '111' => 'A' } },
-                    '12' => { subcards: { '121' => 'A' } }
+                    "11" => { subcards: { "111" => "A" } },
+                    "12" => { subcards: { "121" => "A" } }
                   }
     end
     let(:create_card_with_junction) do
-      Card.create name: '1+2',
-                  subcards: { '11' => 'A' }
+      Card.create name: "1+2",
+                  subcards: { "11" => "A" }
     end
     let(:preorder) { %w(1 11 111 12 121) }
     let(:postorder) { %w(111 11 121 12 1) }
-    describe 'validate' do
-      it 'is pre-order depth-first' do
+    describe "validate" do
+      it "is pre-order depth-first" do
         order = []
         in_stage :validate, on: :create,
                             trigger: -> { create_card_with_subcards } do
@@ -114,7 +182,7 @@ describe Card::StageDirector do
         expect(order).to eq(preorder)
       end
 
-      it 'executes all validate stages before next stage' do
+      it "executes all validate stages before next stage" do
         order = []
         with_test_events do
           test_event :validate, on: :create do
@@ -131,8 +199,8 @@ describe Card::StageDirector do
       end
     end
 
-    describe 'finalize' do
-      it 'is post-order depth-first' do
+    describe "finalize" do
+      it "is post-order depth-first" do
         order = []
         in_stage :finalize, on: :create,
                             trigger: -> { create_card_with_subcards } do
@@ -142,8 +210,8 @@ describe Card::StageDirector do
       end
     end
 
-    describe 'store' do
-      it 'is pre-order depth-first' do
+    describe "store" do
+      it "is pre-order depth-first" do
         order = []
         in_stage :store, on: :create,
                          trigger: -> { create_card_with_subcards } do
@@ -153,8 +221,8 @@ describe Card::StageDirector do
       end
     end
 
-    describe 'store and finalize' do
-      it 'executes finalize when all subcards are stored and finalized' do
+    describe "store and finalize" do
+      it "executes finalize when all subcards are stored and finalized" do
         order = []
         with_test_events do
           test_event :store, on: :create do
@@ -172,8 +240,8 @@ describe Card::StageDirector do
       end
     end
 
-    describe 'complete run' do
-      it 'is in correct order' do
+    describe "complete run" do
+      it "is in correct order" do
         order = []
         with_test_events do
           test_event :initialize, on: :create do
@@ -184,7 +252,7 @@ describe Card::StageDirector do
           end
           test_event :validate, on: :create do
             order << "v:#{name}"
-            add_subcard '112v' if name == '11'
+            add_subcard "112v" if name == "11"
           end
           test_event :prepare_to_store, on: :create do
             order << "pts:#{name}"
@@ -203,6 +271,7 @@ describe Card::StageDirector do
           end
           create_card_with_subcards
         end
+        # Delayed::Worker.new.work_off
         expect(order).to eq(
           %w(
             i:1 i:11 i:111 i:12 i:121
@@ -212,13 +281,13 @@ describe Card::StageDirector do
             v:12 v:121
             pts:1 pts:11 pts:111 pts:112v pts:12 pts:121
             s:1
-              s:11
-                s:111 f:111
-                s:112v f:112v
-              f:11
-              s:12
-                s:121 f:121
-              f:12
+            s:11
+            s:111 f:111
+            s:112v f:112v
+            f:11
+            s:12
+            s:121 f:121
+            f:12
             f:1
             ig:1 ig:11 ig:111 ig:112v ig:12 ig:121
             igwd:1 igwd:11 igwd:111 igwd:112v igwd:12 igwd:121
@@ -226,7 +295,7 @@ describe Card::StageDirector do
         )
       end
 
-      it 'with junction' do
+      it "with junction" do
         order = []
         with_test_events do
           test_event :initialize, on: :create do
@@ -255,6 +324,7 @@ describe Card::StageDirector do
           end
           create_card_with_junction
         end
+        # Delayed::Worker.new.work_off
         expect(order).to eq(
           %w(
             i:1+2 i:11
@@ -262,9 +332,9 @@ describe Card::StageDirector do
             v:1+2 v:11
             pts:1+2 pts:11
             s:1+2
-              i:1 ptv:1 v:1 pts:1 s:1 f:1
-              i:2 ptv:2 v:2 pts:2 s:2 f:2
-              s:11 f:11
+            i:1 ptv:1 v:1 pts:1 s:1 f:1
+            i:2 ptv:2 v:2 pts:2 s:2 f:2
+            s:11 f:11
             f:1+2
             ig:1+2 ig:11 ig:1 ig:2
             igwd:1+2 igwd:11 igwd:1 igwd:2
@@ -274,11 +344,11 @@ describe Card::StageDirector do
     end
   end
 
-  describe 'subcards' do
+  describe "subcards" do
     def create_subcards
-      Card.create! name: '', subcards: {
-        '+sub1' => 'some content',
-        '+sub2' => { '+sub3' => 'content' }
+      Card.create! name: "", subcards: {
+        "+sub1" => "some content",
+        "+sub2" => { "+sub3" => "content" }
       }
     end
 
@@ -288,10 +358,10 @@ describe Card::StageDirector do
         in_stage :prepare_to_validate,
                  on: :create,
                  trigger: :create_subcards do
-          self.name = 'main' if name.empty? && !changed
+          self.name = "main" if name.empty? && !changed
         end
-        expect(Card['main+sub1'].class).to eq(Card)
-        expect(Card['main+sub2+sub3'].class).to eq(Card)
+        expect(Card["main+sub1"].class).to eq(Card)
+        expect(Card["main+sub2+sub3"].class).to eq(Card)
       end
     end
     it "has correct name if supercard's name get changed to a junction card" do
@@ -301,35 +371,35 @@ describe Card::StageDirector do
                  on: :create,
                  trigger: :create_subcards do
           if name.empty? && !changed
-            self.name = 'main1+main2'
-            expect(subfield('sub1')).to be
-            expect(subfield('sub1').content).to eq('some content')
+            self.name = "main1+main2"
+            expect(subfield("sub1")).to be
+            expect(subfield("sub1").content).to eq("some content")
           end
         end
-        expect(Card['main1+main2+sub1'].class).to eq(Card)
-        expect(Card['main1+main2+sub1'].content).to eq('some content')
-        expect(Card['main1+main2+sub2+sub3'].class).to eq(Card)
-        expect(Card['main1+main2+sub2+sub3'].content).to eq('content')
+        expect(Card["main1+main2+sub1"].class).to eq(Card)
+        expect(Card["main1+main2+sub1"].content).to eq("some content")
+        expect(Card["main1+main2+sub2+sub3"].class).to eq(Card)
+        expect(Card["main1+main2+sub2+sub3"].content).to eq("content")
       end
     end
 
-    it 'adds subsubcard to correct subdirector' do
+    it "adds subsubcard to correct subdirector" do
       Card::Auth.as_bot do
         in_stage :prepare_to_store,
                  on: :create,
-                 trigger: -> { Card.create! name: 'main' } do
+                 trigger: -> { Card.create! name: "main" } do
           case  name
-          when 'main'
-            add_subcard 'subby', '+sub2' => {
-              subcards: { 'AARGH' => { '+sub4' => 'more content' } }
+          when "main"
+            add_subcard "subby", "+sub2" => {
+              subcards: { "AARGH" => { "+sub4" => "more content" } }
             }
             in_subdirectors = director.subdirectors.any? do |subdir|
-              subdir.card.name == 'AARGH'
+              subdir.card.name == "AARGH"
             end
             expect(in_subdirectors).to be_falsey
-          when 'subby+sub2'
+          when "subby+sub2"
             in_subsubdirectors = director.subdirectors.any? do |subdir|
-              subdir.card.name == 'AARGH'
+              subdir.card.name == "AARGH"
             end
             expect(in_subsubdirectors).to be_truthy
           end
@@ -338,19 +408,19 @@ describe Card::StageDirector do
     end
   end
 
-  describe 'creating and updating cards in stages' do
-    it 'update_attributes works integrate stage' do
-      act_cnt = Card['A'].acts.size
+  describe "creating and updating cards in stages" do
+    it "update_attributes works integrate stage" do
+      act_cnt = Card["A"].acts.size
       in_stage :integrate,
                on: :create,
-               trigger: -> { Card.create! name: 'act card' } do
-        Card['A'].update_attributes content: 'changed content'
+               trigger: -> { Card.create! name: "act card" } do
+        Card["A"].update_attributes content: "changed content"
       end
-      expect(Card['A'].content).to eq 'changed content'
+      expect(Card["A"].content).to eq "changed content"
       # no act added to A
-      expect(Card['A'].acts.size).to eq act_cnt
+      expect(Card["A"].acts.size).to eq act_cnt
       # new act for 'act card'
-      expect(Card['act card'].acts.size).to eq 1
+      expect(Card["act card"].acts.size).to eq 1
     end
   end
 end

data/spec/lib/card/subcards_spec.rb

@@ -1,77 +1,77 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Subcards do
-  describe 'creating card with subcards' do
-    it 'works with subcard hash' do
+  describe "creating card with subcards" do
+    it "works with subcard hash" do
       Card::Auth.as_bot do
         @card = Card.create!(
-          name: 'card with subs',
-          subcards: { '+sub1' => { content: 'this is sub1' } }
+          name: "card with subs",
+          subcards: { "+sub1" => { content: "this is sub1" } }
         )
       end
-      expect(Card['card with subs+sub1'].content).to eq 'this is sub1'
+      expect(Card["card with subs+sub1"].content).to eq "this is sub1"
     end
 
-    it 'works with content string' do
+    it "works with content string" do
       Card::Auth.as_bot do
         @card = Card.create!(
-          name: 'card with subs', subcards: { '+sub1' => 'this is sub1' }
+          name: "card with subs", subcards: { "+sub1" => "this is sub1" }
         )
       end
-      expect(Card['card with subs+sub1'].content).to eq 'this is sub1'
+      expect(Card["card with subs+sub1"].content).to eq "this is sub1"
     end
 
-    it 'works with +name key in args' do
+    it "works with +name key in args" do
       Card::Auth.as_bot do
         @card = Card.create!(
-          name: 'card with subs', '+sub1' => { content: 'this is sub1' }
+          name: "card with subs", "+sub1" => { content: "this is sub1" }
         )
       end
-      expect(Card['card with subs+sub1'].content).to eq 'this is sub1'
+      expect(Card["card with subs+sub1"].content).to eq "this is sub1"
     end
 
-    it 'handles more than one level' do
+    it "handles more than one level" do
       Card::Auth.as_bot do
         @card = Card.create!(
-          name: 'card with subs', '+sub1' => { '+sub2' => 'this is sub2' }
+          name: "card with subs", "+sub1" => { "+sub2" => "this is sub2" }
         )
       end
-      expect(Card['card with subs+sub1+sub2'].content).to eq 'this is sub2'
+      expect(Card["card with subs+sub1+sub2"].content).to eq "this is sub2"
     end
 
-    it 'handles compound names' do
+    it "handles compound names" do
       Card::Auth.as_bot do
-        @card = Card.create! name: 'superman', '+sub1+sub2' => 'this is sub2'
+        @card = Card.create! name: "superman", "+sub1+sub2" => "this is sub2"
       end
-      expect(Card['superman+sub1']).to be_truthy
-      expect(Card['superman+sub1+sub2'].content).to eq 'this is sub2'
+      expect(Card["superman+sub1"]).to be_truthy
+      expect(Card["superman+sub1+sub2"].content).to eq "this is sub2"
     end
 
-    it 'keeps plural of left part' do
+    it "keeps plural of left part" do
       Card::Auth.as_bot do
         @card = Card.create!(
-          name: 'supermen', content: 'something',
-          subcards: { '+pseudonym' => 'clark' }
+          name: "supermen", content: "something",
+          subcards: { "+pseudonym" => "clark" }
         )
       end
-      expect(Card['supermen+pseudonym'].name).to eq 'supermen+pseudonym'
+      expect(Card["supermen+pseudonym"].name).to eq "supermen+pseudonym"
     end
 
-    it 'cleans the cache for autonaming case' do
+    it "cleans the cache for autonaming case" do
       Card::Auth.as_bot do
         Card.create!(
-          name: 'Book+*type+*autoname', content: 'Book_1',
+          name: "Book+*type+*autoname", content: "Book_1",
           type_id: Card::PhraseID
         )
         card = Card.create!(
-          type: 'Book',
-          subcards: { '+editable' => 'yes' }
+          type: "Book",
+          subcards: { "+editable" => "yes" }
         )
         expect(card.errors).to be_empty
         expect(Card["#{card.name}+editable"]).to be_truthy
         @card = Card.create!(
-          type: 'Book',
-          subcards: { '+editable' => 'sure' }
+          type: "Book",
+          subcards: { "+editable" => "sure" }
         )
       end
 
@@ -80,80 +80,84 @@ describe Card::Subcards do
     end
   end
 
-  describe '#add_subfield' do
+  describe "#add_subfield" do
     before do
-      @card = Card['A']
+      @card = Card["A"]
     end
-    subject { Card.fetch("#{@card.name}+sub", new: {}, local_only: true).content }
-    it 'works with string' do
-      @card.add_subfield 'sub', content: 'this is a sub'
-      is_expected.to eq 'this is a sub'
+    subject do
+      Card.fetch("#{@card.name}+sub", new: {}, local_only: true).content
     end
-    it 'works with codename' do
-      @card.add_subfield :phrase, content: 'this is a sub'
-      subcard = Card.fetch('A+phrase', new: {}, local_only: true)
-      expect(subcard.content).to eq 'this is a sub'
+    it "works with string" do
+      @card.add_subfield "sub", content: "this is a sub"
+      is_expected.to eq "this is a sub"
+    end
+    it "works with codename" do
+      @card.add_subfield :phrase, content: "this is a sub"
+      subcard = Card.fetch("A+phrase", new: {}, local_only: true)
+      expect(subcard.content).to eq "this is a sub"
     end
   end
 
-  describe '#subfield' do
+  describe "#subfield" do
     before do
-      @card = Card['A']
+      @card = Card["A"]
+    end
+    subject do
+      Card.fetch("#{@card.name}+sub", new: {}, local_only: true).content
     end
-    subject { Card.fetch("#{@card.name}+sub", new: {}, local_only: true).content }
-    it 'works with string' do
-      @card.add_subfield 'sub', content: 'this is a sub'
-      expect(@card.subfield('sub').content).to eq 'this is a sub'
+    it "works with string" do
+      @card.add_subfield "sub", content: "this is a sub"
+      expect(@card.subfield("sub").content).to eq "this is a sub"
     end
 
-    it 'works with codename' do
-      @card.add_subfield :phrase, content: 'this is a sub'
-      expect(@card.subfield(':phrase').content).to eq 'this is a sub'
+    it "works with codename" do
+      @card.add_subfield :phrase, content: "this is a sub"
+      expect(@card.subfield(":phrase").content).to eq "this is a sub"
     end
 
-    it 'works together with type change' do
+    it "works together with type change" do
       Card::Auth.as_bot do
         @card = Card.create!(
-          name: 'card with subs', '+sub1' => 'first'
+          name: "card with subs", "+sub1" => "first"
         )
-        @card.update_attributes! type_id: Card::PhraseID, '+sub1' => 'second'
+        @card.update_attributes! type_id: Card::PhraseID, "+sub1" => "second"
       end
-      expect(Card['card with subs+sub1'].content).to eq 'second'
+      expect(Card["card with subs+sub1"].content).to eq "second"
     end
   end
 
-  describe '#add' do
+  describe "#add" do
     before do
-      @card = Card['A']
+      @card = Card["A"]
     end
-    it 'adds a subcard' do
-      @card.add_subcard 'sub', content: 'sub content'
+    it "adds a subcard" do
+      @card.add_subcard "sub", content: "sub content"
       @card.save!
-      expect(Card['sub'].content).to eq 'sub content'
+      expect(Card["sub"].content).to eq "sub content"
     end
   end
-  describe 'two levels of subcards' do
-    it 'creates cards with subcards with subcards' do
+  describe "two levels of subcards" do
+    it "creates cards with subcards with subcards" do
       Card::Auth.as_bot do
-        in_stage :validate, trigger: -> { Card.create!(name: 'test') } do
-          if name == 'test'
-            add_subfield('first-level')
-            subfield('first-level').add_subfield 'second-level', content: 'yeah'
+        in_stage :validate, trigger: -> { Card.create!(name: "test") } do
+          if name == "test"
+            add_subfield("first-level")
+            subfield("first-level").add_subfield "second-level", content: "yeah"
           end
         end
       end
-      expect(Card.fetch('test+first-level+second-level').content).to eq 'yeah'
+      expect(Card.fetch("test+first-level+second-level").content).to eq "yeah"
     end
-    it 'creates cards with subcards with subcards using codenames' do
+    it "creates cards with subcards with subcards using codenames" do
       Card::Auth.as_bot do
-        in_stage :validate, trigger: -> { Card.create!(name: 'test') } do
-          if name == 'test'
+        in_stage :validate, trigger: -> { Card.create!(name: "test") } do
+          if name == "test"
             add_subfield :children
-            subfield(:children).add_subfield :title, content: 'yeah'
+            subfield(:children).add_subfield :title, content: "yeah"
           end
         end
       end
-      expect(Card.fetch('test+*child+*title').content).to eq 'yeah'
+      expect(Card.fetch("test+*child+*title").content).to eq "yeah"
     end
   end
 end