card 1.15.7 → 1.16.0

data/mod/05_standard/spec/set/all/event_viz_spec.rb

@@ -1,9 +1,9 @@
 # -*- encoding : utf-8 -*-
 
-describe Card::Set::All::EventViz do
-  describe '#events' do
-    it "should have at least twenty events" do
-      expect(Card['A'].events( :update ).split("\n").length).to be > 20
-    end
-  end
-end
+# describe Card::Set::All::EventViz do
+#   describe '#events' do
+#     it "should have at least twenty events" do
+#       expect(Card['A'].events( :update ).split("\n").length).to be > 20
+#     end
+#   end
+# end

data/mod/05_standard/spec/set/all/history_spec.rb

@@ -8,34 +8,34 @@ describe Card::Set::All::History do
       history = render_card :history, :name=>"A"
       assert_view_select history, 'div[class~="card-frame"]'
     end
-    
-    
+
+
     describe '#action_summary' do
-      subject do 
+      subject do
         first = Card.fetch('First')
         first.format.render_action_summary
       end
       it 'should have a summary' do
-        assert_view_select subject, 'del[class="diffdel diff-red"]', :text=>'chicken' 
-        assert_view_select subject, 'ins[class="diffins diff-green"]', :text=>'chick'         
+        assert_view_select subject, 'del[class="diffdel diff-red"]', :text=>'chicken'
+        assert_view_select subject, 'ins[class="diffins diff-green"]', :text=>'chick'
       end
     end
   end
-  
-  
+
+
   describe '#create_act_and_action' do
     let!(:act_start_cnt) {Card::Act.count}
     let(:content)        {"Nobody expects the Spanish inquisition"}
     let(:act)            {@card.acts.last}
     let(:action)         {act.actions.last}
-    
+
     context 'for single card' do
       before do
         @card = Card::Auth.as_bot do
           Card.create :name=>"single card", :content=>content
         end
       end
-        
+
       context 'when created' do
         it 'adds new act' do
           expect(Card::Act.count).to eq(act_start_cnt+1)
@@ -45,7 +45,7 @@ describe Card::Set::All::History do
           expect(action.action_type).to eq(:create)
         end
       end
-      
+
       context 'when updated' do
         it 'adds no act if nothing changed' do
           @card.update_attributes  :name=>"single card", :content=>content
@@ -56,7 +56,7 @@ describe Card::Set::All::History do
           expect(Card::Act.count).to eq(act_start_cnt+2)
         end
       end
-      
+
       context 'when deleted' do
         before do
           Card::Auth.as_bot do
@@ -68,11 +68,41 @@ describe Card::Set::All::History do
         end
         it 'adds delete action' do
           expect(action.action_type).to eq(:delete)
-        end  
-        it 'adds trash change' do  
-          expect(action.changes.last.field).to eq('trash')
-          expect(action.changes.last.value).to be_truthy
         end
+        it 'adds trash change' do
+          expect(action.card_changes.last.field).to eq('trash')
+          expect(action.card_changes.last.value).to be_truthy
+        end
+      end
+
+      context 'when creation fails' do
+        it "doesn't create an act" do
+          Card::Auth.as(:anonymous) do
+            act_count = Card::Act.count
+            Card.create :name=>"create fail"
+            expect(Card::Act.count).to eq act_count
+          end
+        end
+
+        it "doesn't create an action" do
+          Card::Auth.as(:anonymous) do
+            action_count = Card::Action.count
+            Card.create :name=>"create fail"
+            expect(Card::Action.count).to eq action_count
+          end
+        end
+
+        it "doesn't create act and actions if subcard fails" do
+          Card::Auth.as(:joe_user) do
+            act_count    = Card::Act.count
+            action_count = Card::Action.count
+            Card.create :name=>"crete fail", :subcards=>{'*all+*create'=>''}
+            expect(Card::Action.count).to eq action_count
+            expect(Card::Act.count).to eq act_count
+          end
+        end
+
+
       end
     end
 
@@ -85,13 +115,13 @@ describe Card::Set::All::History do
           @plus_action = act.actions[1]
         end
       end
-    
+
       context 'when created' do
         it 'adds only a act for left card' do
           expect(Card::Act.count).to eq(act_start_cnt+1)
           expect(act.card).to eq(@card)
         end
-    
+
         it 'adds three actions' do
           expect(act.actions.size).to eq(3)
         end
@@ -108,13 +138,13 @@ describe Card::Set::All::History do
           expect(@plus_action.action_type).to eq(:create)
         end
         it 'adds content change' do
-          expect(@plus_action.changes.find_by_field(:db_content).value).to eq(content)
+          expect(@plus_action.card_changes.find_by_field_name(:db_content).value).to eq(content)
         end
         it 'adds superaction for plus card' do
           expect(@plus_action.super_action_id).to eq(@left_action.id)
         end
       end
-      
+
       context 'when updated' do
         it 'adds act for left card' do
           @card.update_attributes :subcards=>{"+right"=>{:content=>"New content", :db_content=>"New Content"}}
@@ -130,7 +160,7 @@ describe Card::Set::All::History do
         end
       end
     end
-    
+
     context 'for plus card' do
       before do
         Card::Auth.as_bot do
@@ -140,7 +170,7 @@ describe Card::Set::All::History do
           @right_action = act.actions[2]
         end
       end
-      
+
       context 'adds' do
         it 'only a act for plus card' do
           expect(Card::Act.count).to eq(act_start_cnt+1)
@@ -148,7 +178,7 @@ describe Card::Set::All::History do
         end
         it 'three actions' do
           expect(act.actions.size).to eq(3)
-        end            
+        end
         it 'action for left part of type create' do
           expect(@left_action.card.name).to eq("left")
           expect(@left_action.action_type).to eq(:create)
@@ -163,9 +193,9 @@ describe Card::Set::All::History do
         it 'action for plus card of type create' do
           expect(@plus_action.card.name).to eq("left+right")
           expect(@plus_action.action_type).to eq(:create)
-        end   
+        end
         it 'content change' do
-          expect(@plus_action.changes.find_by_field(:db_content).value).to eq(content)
+          expect(@plus_action.card_changes(true).find_by_field_name(:db_content).value).to eq(content)
         end
       end
     end

data/mod/05_standard/spec/set/all/rich_html/editing_spec.rb

@@ -17,44 +17,46 @@ describe Card::Set::All::RichHtml::Editing do
     end
   end
 
-  describe "edit view" do
-    it "has toolbar with active 'content' pill" do
-      assert_active_toolbar_pill :edit, 'content'
-    end
-  end
-
-  describe 'edit_type view' do
-    it "has toolbar with active 'type' pill" do
-      assert_active_toolbar_pill :edit_type, 'type'
-    end
-  end
-
-  describe 'edit_name view' do
-    it "has toolbar with active 'name' pill" do
-      assert_active_toolbar_pill :edit_name, 'name'
-    end
-  end
-
-  describe 'edit_structure view' do
-    before do
-      @mycard = Card["Iliad"].format
-    end
-    it "has toolbar with active 'rules' pill" do
-      Card::Auth.as_bot do
-        assert_active_toolbar_pill :edit_structure, 'rules', true
-      end
-    end
-  end
-
-  describe 'edit_nests view' do
-    before do
-      Card::Auth.as_bot do
-        Card.create! :name=>'Iliad+author', :content=>'Homer'
-      end
-      @mycard = Card["Iliad"].format
-    end
-    it "has toolbar with active 'nests' pill" do
-      assert_active_toolbar_pill :edit_nests, 'nests'
-    end
-  end
+  # outdated
+  # TODO: write tests for new toolbar
+  # describe "edit view" do
+  #   it "has toolbar with active 'content' pill" do
+  #     assert_active_toolbar_pill :edit, 'content'
+  #   end
+  # end
+  #
+  # describe 'edit_type view' do
+  #   it "has toolbar with active 'type' pill" do
+  #     assert_active_toolbar_pill :edit_type, 'type'
+  #   end
+  # end
+  #
+  # describe 'edit_name view' do
+  #   it "has toolbar with active 'name' pill" do
+  #     assert_active_toolbar_pill :edit_name, 'name'
+  #   end
+  # end
+  #
+  # describe 'edit_structure view' do
+  #   before do
+  #     @mycard = Card["Iliad"].format
+  #   end
+  #   it "has toolbar with active 'rules' pill" do
+  #     Card::Auth.as_bot do
+  #       assert_active_toolbar_pill :edit_structure, 'rules', true
+  #     end
+  #   end
+  # end
+  #
+  # describe 'edit_nests view' do
+  #   before do
+  #     Card::Auth.as_bot do
+  #       Card.create! :name=>'Iliad+author', :content=>'Homer'
+  #     end
+  #     @mycard = Card["Iliad"].format
+  #   end
+  #   it "has toolbar with active 'nests' pill" do
+  #     assert_active_toolbar_pill :edit_nests, 'nests'
+  #   end
+  # end
 end

data/mod/05_standard/spec/set/rstar/rules_spec.rb

@@ -7,7 +7,7 @@ describe Card::Set::Rstar::Rules do
      expect(r).not_to match('No Card!')
      #warn "r = #{r}"
      assert_view_select r, 'table[class="set-rules table"]' do
-       assert_select 'a[href~="/*read+*right+*input?view=open_rule"]', :text => 'input'
+       assert_select 'a[href~="/*read+*right+*read?view=open_rule"]', :text => 'read'
      end
   end
 

data/mod/05_standard/spec/set/type/search_type_spec.rb

@@ -25,5 +25,13 @@ describe Card::Set::Type::SearchType do
     expect(r.scan('item-closed').size).to eq(2) #there are two of each
   end
 
-  it ''
+  it 'handles type update from pointer' do
+    pointer_card = Card.create!(
+        :name=>"PointerToSearches",
+        :type_id=>Card::PointerID,
+    )
+    
+    pointer_card.update_attributes! :type_id=>Card::SearchTypeID,:content=>%{{"type":"User"}}
+    expect(pointer_card.content).to eq(%{{"type":"User"}})
+  end
 end

data/mod/05_standard/spec/set/type/signup_spec.rb

@@ -1,27 +1,27 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::Signup do
-  
+
   before do
     Card::Auth.current_id = Card::AnonymousID
   end
-  
-  
+
+
   context 'signup form form' do
     before do
       card = Card.new :type_id=>Card::SignupID
       @form = card.format.render_new
     end
-    
+
     it 'should prompt to signup' do
       Card::Auth.as :anonymous do
         expect(@form.match( /Sign up/ )).to be_truthy
       end
     end
   end
-  
 
-   
+
+
   context 'signup (without approval)' do
     before do
       ActionMailer::Base.deliveries = [] #needed?
@@ -29,15 +29,15 @@ describe Card::Set::Type::Signup do
       Card::Auth.as_bot do
         Card.create! :name=>'User+*type+*create', :content=>'[[Anyone]]'
       end
-      
+
       Card::Auth.current_id = Card::AnonymousID
-      @signup = Card.create! :name=>'Big Bad Wolf', :type_id=>Card::SignupID, 
-        '+*account'=>{'+*email'=>'wolf@wagn.org', '+*password'=>'wolf'}     
-        
+      @signup = Card.create! :name=>'Big Bad Wolf', :type_id=>Card::SignupID,
+        '+*account'=>{'+*email'=>'wolf@wagn.org', '+*password'=>'wolf'}
+
       @account = @signup.account
       @token = @account.token
     end
-    
+
     it 'should create all the necessary cards' do
       expect(@signup.type_id).to eq(Card::SignupID)
       expect(@account.email).to eq('wolf@wagn.org')
@@ -46,22 +46,22 @@ describe Card::Set::Type::Signup do
       expect(@account.password.length).to be > 10 #encrypted
       expect(@account.token).to be_present
     end
-  
+
     it 'should send email with an appropriate link' do
       @mail = ActionMailer::Base.deliveries.last
       expect( @mail.parts[0].body.raw_source ).to match(Card.setting( :title ))
     end
-    
+
     it 'should create an authenticable token' do
       expect(@account.token).to eq(@token)
       expect(@account.authenticate_by_token(@token)).to eq(@signup.id)
       expect(@account.fetch(:trait=> :token)).not_to be_present
     end
-    
+
     it 'should notify someone' do
       expect(ActionMailer::Base.deliveries.last.to).to eq(['signups@wagn.org'])
     end
-    
+
     it 'should be activated by an update' do
       Card::Env.params[:token] = @token
       @signup.update_attributes({})
@@ -71,12 +71,12 @@ describe Card::Set::Type::Signup do
       expect(@account.status).to eq('active')
       expect(Card[ @account.name ].active?).to be_truthy
     end
-    
+
     it 'should reject expired token and create new token' do
       @account.token_card.update_column :updated_at, 8.days.ago.strftime("%F %T")
       @account.token_card.expire
       Card::Env.params[:token] = @token
-      
+
       result = @signup.update_attributes!({})
       expect(result).to eq(true)                 # successfully completes save
       @account.reload
@@ -96,8 +96,8 @@ describe Card::Set::Type::Signup do
         '+*account'=>{ '+*email'=>'wolf@wagn.org', '+*password'=>'wolf' }
       @account = @signup.account
     end
-    
-    
+
+
     it 'should create all the necessary cards, but no token' do
       expect(@signup.type_id).to eq(Card::SignupID)
       expect(@account.email).to eq('wolf@wagn.org')
@@ -105,11 +105,11 @@ describe Card::Set::Type::Signup do
       expect(@account.salt).not_to eq('')
       expect(@account.password.length).to be > 10 #encrypted
     end
-    
+
     it 'should not create a token' do
       expect(@account.token).not_to be_present
     end
-        
+
     it 'sends signup alert email' do
       signup_alert = ActionMailer::Base.deliveries.last
       expect(signup_alert.to).to eq(['signups@wagn.org'])
@@ -118,33 +118,33 @@ describe Card::Set::Type::Signup do
         expect(body).to include(@signup.name)
         expect(body).to include('wolf@wagn.org')
       end
-      
+
     end
-    
+
     it 'does not send verification email' do
       expect(Mail::TestMailer.deliveries[-2]).to be_nil
     end
-    
-    
+
+
     context 'approval with token' do
-      
+
       it 'should create token' do
         Card::Env.params[:approve_with_token] = true
         Card::Auth.as :joe_admin
-        
+
         @signup = Card.fetch @signup.id
         @signup.save!
         expect(@signup.account.token).to be_present
       end
-      
+
     end
-    
+
     context 'approval without token' do
-      
+
       it 'should create token' do
         Card::Env.params[:approve_without_token] = true
         Card::Auth.as :joe_admin
-        
+
         @signup = Card.fetch @signup.id
         @signup.save!
         expect(@signup.account.token).not_to be_present
@@ -154,36 +154,36 @@ describe Card::Set::Type::Signup do
     end
 
   end
-  
+
   context 'a welcome email card exists' do
     before do
-      Card::Auth.as_bot do 
-        Card.create! :name=>'welcome email', :subcards=>{'+*subject'=>'welcome', 
+      Card::Auth.as_bot do
+        Card.create! :name=>'welcome email', :subcards=>{'+*subject'=>'welcome',
                      '+*html_message'=>'Welcome {{_self|name}}'}, :type_id=>Card::EmailTemplateID
       end
       Mail::TestMailer.deliveries.clear
-      @signup = Card.create! :name=>'Big Bad Sheep', :type_id=>Card::SignupID, 
-        '+*account'=>{'+*email'=>'sheep@wagn.org', '+*password'=>'sheep'}     
-      
+      @signup = Card.create! :name=>'Big Bad Sheep', :type_id=>Card::SignupID,
+        '+*account'=>{'+*email'=>'sheep@wagn.org', '+*password'=>'sheep'}
+
     end
     it 'sends welcome email when account is activated' do
       @signup.activate_account
       @mail = ActionMailer::Base.deliveries.find{ |a| a.subject == 'welcome' }
       Mail::TestMailer.deliveries.clear
-      
+
       expect(@mail).to be_truthy
       expect(@mail.body.raw_source ).to include('Welcome Big Bad Sheep')
     end
   end
-  
+
   context 'invitation' do
     before do
       # NOTE: by default Anonymous does not have permission to create User cards.
-      Card::Auth.current_id = Card::WagnBotID 
+      Card::Auth.current_id = Card::WagnBotID
       @signup = Card.create! :name=>'Big Bad Wolf', :type_id=>Card::SignupID, '+*account'=>{ '+*email'=>'wolf@wagn.org'}
       @account = @signup.account
     end
-    
+
     it 'should create all the necessary cards, but no password' do
       expect(@signup.type_id).to eq(Card::SignupID)
       expect(@account.email).to eq('wolf@wagn.org')
@@ -192,7 +192,7 @@ describe Card::Set::Type::Signup do
       expect(@account.token).to be_present
       expect(@account.password).not_to be_present
     end
-    
+
   end
 
   # describe '#signup_notifications' do