card 1.104.2 → 1.105.1

data/mod/core/spec/set/all/name_events_spec.rb

@@ -1,19 +1,6 @@
 RSpec.describe Card::Set::All::NameEvents do
   include CardExpectations
 
-  def name_invariant_attributes card
-    descendant_ids = []
-    card.each_descendant { |d| descendant_ids << d.id }
-    {
-      content: card.db_content,
-      # updater_id:  card.updater_id,
-      # revisions:   card.actions.count,
-      referers: card.referers.map(&:name).sort,
-      referees: card.referees.map(&:name).sort,
-      descendants: descendant_ids.sort
-    }
-  end
-
   def assert_rename card, new_name
     card = card_to_rename card
     attrs_before = name_invariant_attributes(card)
@@ -21,28 +8,36 @@ RSpec.describe Card::Set::All::NameEvents do
     old_name = card.name
 
     update! card.name, name: new_name
-    expect_action_added card, actions_count_before
-    expect_old_name_cleared old_name
-    expect_successful_rename card, attrs_before
-  end
 
-  def expect_action_added card, actions_count_before
-    expect(card.actions.count).to eq(actions_count_before + 1)
+    expect(name_invariant_attributes(card)).to eq(attrs_before)
+    expect_successful_rename old_name, card, (actions_count_before + 1)
   end
 
-  def expect_old_name_cleared old_name
+  private
+
+  def expect_successful_rename old_name, card, num_actions
+    expect(card.actions.count).to eq(num_actions)
     expect(Card.cache.read(old_name)).to eq(nil)
+    expect(card.name.card).to eq(card)
   end
 
-  def expect_successful_rename card, attrs_before
-    expect(name_invariant_attributes(card)).to eq(attrs_before)
-    expect(Card[card.name]).to eq(card)
+  def name_invariant_attributes card
+    descendant_ids = []
+    card.each_descendant { |d| descendant_ids << d.id }
+    {
+      content: card.db_content,
+      # updater_id:  card.updater_id,
+      # revisions:   card.actions.count,
+      referers: card.referers.map(&:name).sort,
+      referees: card.referees.map(&:name).sort,
+      descendants: descendant_ids.sort
+    }
   end
 
   def card_to_rename card
     return card unless card.is_a? String
 
-    Card[card].refresh || raise("Couldn't find card named #{card}")
+    Card[card]&.refresh || raise("Couldn't find card named #{card}")
   end
 
   it "renames simple card to its own child" do
@@ -107,8 +102,7 @@ RSpec.describe Card::Set::All::NameEvents do
   end
 
   it "fails if name is invalid" do
-    expect { update "T", name: "" }
-      .to raise_error(/Name can't be blank/)
+    expect { update "T", name: "" }.to raise_error(/Name can't be blank/)
   end
 
   example "simple to simple" do
@@ -154,7 +148,7 @@ RSpec.describe Card::Set::All::NameEvents do
   end
 
   context "with self references" do
-    example "renaming card with self link should nothang" do
+    example "renaming card with self link should not hang" do
       pre_content = Card["self_aware"].content
       update "self aware", name: "buttah"
       expect_card("Buttah").to have_content(pre_content)
@@ -232,45 +226,35 @@ RSpec.describe Card::Set::All::NameEvents do
   end
 
   describe "event: prepare_left_and_right" do
-    context "when creating junctions" do
-      before do
-        Card.create! name: "Peach+Pear", content: "juicy"
-      end
-
-      it "creates left card" do
-        expect(Card["Peach"]).to be_a(Card)
-      end
+    it "creates left card, right card, and compound card for 2-part names" do
+      Card.create! name: "Peach+Pear", content: "juicy"
+      expect("Peach".card).to be_a(Card)
+      expect("Pear".card).to be_a(Card)
+      expect("Peach+Pear".card).to be_a(Card)
+    end
 
-      it "creates right card" do
-        expect(Card["Pear"]).to be_a(Card)
-      end
+    it "creates all cards for three-part names" do
+      sugar_milk_flour = Card.create! name: "Sugar+Milk+Flour", content: "tasty"
+      sugar_milk = "Sugar+Milk".card
+      expect(sugar_milk_flour.left_id).to eq(sugar_milk.id)
+      expect(sugar_milk_flour.right_id).to eq("Flour".card_id)
+      expect(sugar_milk.left_id).to eq("Sugar".card_id)
+      expect(sugar_milk.right_id).to eq("Milk".card_id)
     end
   end
 
-  describe "event: autoname" do
-    before do
-      Card::Auth.as_bot do
-        @b1 = Card.create! name: "Book+*type+*autoname", content: "b1"
-      end
-    end
+  specify "event: rename_in_trash", as_bot: true do
+    a = "a".card
+    a.delete!
 
-    it "handles cards without names" do
-      c = Card.create! type: "Book"
-      expect(c.name).to eq("b1")
-    end
+    b = "b".card
+    b.update! name: "A"
 
-    it "increments again if name already exists" do
-      _b1 = Card.create! type: "Book"
-      b2 = Card.create! type: "Book"
-      expect(b2.name).to eq("b2")
-    end
+    trashed_a = Card.find a.id
 
-    it "handles trashed names" do
-      b1 = Card.create! type: "Book"
-      Card::Auth.as_bot { b1.delete }
-      b1 = Card.create! type: "Book"
-      expect(b1.name).to eq("b1")
-    end
+    expect(b.name).to eq("A")
+    expect(trashed_a.name).to eq("A*trash")
+    expect(trashed_a.key).to eq("a*trash")
   end
 
   describe "event: escape_name" do
@@ -291,11 +275,4 @@ RSpec.describe Card::Set::All::NameEvents do
         .to raise_error(/wrong key/)
     end
   end
-
-  describe "reset_codename_cache" do
-    it "resets codename cache when codename is updated" do
-      card = Card.create! name: "Codename Haver", codename: :codename_haver
-      expect(Card::Codename.id(:codename_haver)).to eq(card.id)
-    end
-  end
 end

data/mod/core/spec/set/all/trash_spec.rb

@@ -1,81 +1,18 @@
 # -*- encoding : utf-8 -*-
 
 RSpec.describe Card::Set::All::Trash do
-  describe "deletion basics" do
-    before do
-      Card::Auth.as_bot do
-        @c = Card["A"]
-        @c.delete!
-      end
-    end
-
-    it "is in the trash" do
-      expect(@c.trash).to be_truthy
+  describe "#delete " do
+    it "puts card in trash", as_bot: true do
+      subj = card_subject
+      subj.delete!
+      expect(subj.trash).to be_truthy
     end
-
-    it "comes out of the trash when a plus card is created" do
-      Card::Auth.as_bot do
-        Card.create(name: "A+*acct")
-        c = Card["A"]
-        expect(c.trash).to be_falsey
-      end
-    end
-  end
-
-  it "descendant removal" do
-    create! "born to die"
-    create! "born to die+slowly"
-    create! "slowly+born to die"
-    create! "born to die+slowly+without regrets"
-
-    Card["born to die"].delete!
-
-    expect(Card["born to die"]).to be_nil
-    expect(Card["born to die+slowly"]).to be_nil
-    expect(Card["slowly+born to die"]).to be_nil
-    expect(Card["born to die+slowly+without regrets"]).to be_nil
-    expect(Card["slowly"]).to be_a Card
-    expect(Card["without regrets"]).to be_a Card
-
-    trashed_dependant = Card.find Card::Lexicon.id("born to die+slowly+without regrets")
-    expect(trashed_dependant.trash).to be_truthy
-  end
-
-  it "deletes children under a set", as_bot: true do
-    create_set "Book+value+*type plus right",
-               book1 = "Richard Mills+Annual Sales+CA+2014"
-    book2 = "Richard Mills+Annual Profits+CA+2014"
-    create_book book1
-    create_book book2
-    create! "#{book1}+value"
-    create! "#{book2}+value"
-
-    expect(Card["CA"]).to be
-
-    Card["CA"].delete!
-
-    expect(Card["CA"]).not_to be
-    expect(Card[book1]).not_to be
-    expect(Card["#{book1}+value"]).not_to be
-    expect(Card[book2]).not_to be
-    expect(Card["#{book2}+value"]).not_to be
   end
 
   it "deletes account of user", as_bot: true do
     expect(Card["Sample User", :account]).to be_a Card
     Card["Sample User"].delete!
     expect(Card["Sample User", :account]).not_to be
-    # @signup =
-    #   create_signup "born to die",
-    #                 "+*account" => { "+*email" => "wolf@decko.org", "+*password" => "wolf" }
-    # @signup.update!({})
-    # Card::Cache.reset_all
-    #
-    # Card::Auth.as_bot do
-    #   expect(Card.search(right: "*account")).not_to be_empty
-    #   Card["born to die"].delete!
-    # end
-    # expect(Card["born to die+*account"]).not_to be
   end
 
   describe "event: validate_delete" do
@@ -87,6 +24,16 @@ RSpec.describe Card::Set::All::Trash do
       expect(Card[rule]).to be_a Card
     end
 
+    it "prevents deletion without permission" do
+      a = "a".card
+      Card::Auth.as :anonymous do
+        expect(a.ok?(:delete)).to eq(false)
+        expect(a.delete).to eq(false)
+        expect(a.errors[:permission_denied]).not_to be_empty
+        expect("a".card.trash).to eq(false)
+      end
+    end
+
     context "card with account" do
       context "with edits" do
         it "is not removable" do
@@ -103,6 +50,140 @@ RSpec.describe Card::Set::All::Trash do
           end
         end
       end
+
+      context "with undeletable child" do
+        # NOTE: +*status restricts deletion to Help Desk role
+        it "cannot be deleted" do
+          Card::Auth.as_bot { Card.create! name: ["A", :status] }
+          expect { card_subject.delete! }.to raise_error(/don't have permission/)
+        end
+
+        it "cannot be created and deleted in consecutive acts" do
+          schmatus = Card::Auth.as_bot do
+            Card.create! name: "schmatus", fields: { status: "open" }
+          end
+          expect { schmatus.delete! }.to raise_error(/don't have permission/)
+        end
+      end
+    end
+  end
+
+  describe "event: delete_children" do
+    it "removes descendants" do
+      create! "born to die"
+      create! "born to die+slowly"
+      create! "slowly+born to die"
+      create! "born to die+slowly+without regrets"
+
+      Card["born to die"].delete!
+
+      expect(Card["born to die"]).to be_nil
+      expect(Card["born to die+slowly"]).to be_nil
+      expect(Card["slowly+born to die"]).to be_nil
+      expect(Card["born to die+slowly+without regrets"]).to be_nil
+      expect(Card["slowly"]).to be_a Card
+      expect(Card["without regrets"]).to be_a Card
+
+      trashed_dependant = Card.find Card::Lexicon.id("born to die+slowly+without regrets")
+      expect(trashed_dependant.trash).to be_truthy
+    end
+
+    # TODO: explain what this adds to testing above or remove test.
+    it "deletes children under a set", as_bot: true do
+      create_set "Book+value+*type plus right"
+      book1 = "Richard Mills+Annual Sales+CA+2014"
+      book2 = "Richard Mills+Annual Profits+CA+2014"
+      create_book book1
+      create_book book2
+      create! "#{book1}+value"
+      create! "#{book2}+value"
+
+      expect(Card["CA"]).to be
+
+      Card["CA"].delete!
+
+      expect(Card["CA"]).not_to be
+      expect(Card[book1]).not_to be
+      expect(Card["#{book1}+value"]).not_to be
+      expect(Card[book2]).not_to be
+      expect(Card["#{book2}+value"]).not_to be
+    end
+
+    it "handles compound cards", as_bot: true do
+      c = Card.create! name: "zz+top"
+      "zz".card.delete!
+      expect(Card.find(c.id).trash).to be_truthy
+      expect("zz".card).to be_nil
+    end
+  end
+
+  describe "event: manage_trash" do
+    it "pulls deleted card from trash when recreating" do
+      b_id = "basicname".card_id
+      "basicname".card.delete!
+      c = Card.create! name: "basicname", content: "revived content"
+      expect(c.trash).to eq(false)
+      expect(c.actions.count).to eq(3)
+      expect(c.nth_action(1).value(:db_content)).to eq("basiccontent")
+      expect(c.content).to eq("revived content")
+      expect(c.id).to eq(b_id)
+    end
+
+    it "pulls parts out of trash when creating compound", as_bot: true do
+      card_subject.delete!
+      Card.create name: "A+*acct"
+      expect(card_subject.trash).to be_falsey
+    end
+
+    it "pulls compound card out of trash", as_bot: true do
+      %w[a b].card.delete!
+      card = Card.create name: "A+B", content: "revived"
+      expect(card.trash).to eq(false)
+      expect(card.actions.count).to eq(3)
+      expect(card.nth_action(1).value(:db_content)).to eq("AlphaBeta")
+      expect(card.db_content).to eq("revived")
+    end
+  end
+
+  specify "card in trash" do
+    b = "basicname".card
+    b.delete!
+
+    expect(b.trash).to eq(true)
+    expect(Card["basicname"]).to eq(nil)
+    expect(b.actions.count).to eq(2)
+    expect(b.last_change_on(:db_content).value).to eq("basiccontent")
+  end
+
+  example "recreate plus card name variant" do
+    Card.create(name: "rta+rtb").delete
+    Card["rta"].update name: "rta!"
+    Card.create! name: "rta!+rtb"
+    expect(Card["rta!+rtb"]).to be_a Card
+    expect(Card["rta!+rtb"].trash).to be_falsey
+    expect(Card.find_by_key("rtb*trash")).to be_nil
+  end
+
+  example "multiple trash collision" do
+    Card.create(name: "alpha").delete
+    3.times do
+      b = Card.create(name: "beta")
+      b.name = "alpha"
+      assert b.save!
+      b.delete
     end
   end
 end
+
+# NOT WORKING, BUT IT SHOULD
+# describe Card, "a part of an unremovable card" do
+#  before do
+#     Card::Auth.as(Card::WagnBotID)
+#     # this ugly setup makes it so A+Admin is the actual user with edits..
+#     Card["Wagn Bot"].update! name: "A+Wagn Bot"
+#  end
+#  it "does not be removable" do
+#    @a = Card['A']
+#    @a.delete.should_not be_true
+#  end
+# end

data/mod/{admin → core}/spec/set/self/admin_spec.rb

@@ -1,11 +1,8 @@
 # -*- encoding : utf-8 -*-
 
-describe Card::Set::Self::Admin do
-  it "renders a table" do
-    Card::Auth.as_bot do
-      @core = render_card :core, name: :admin
-    end
-    assert_view_select @core, "table"
+RSpec.describe Card::Set::Self::Admin do
+  it "renders a table", as_bot: true do
+    assert_view_select render_card(:core, name: :admin), "table"
   end
 
   describe "#update" do
@@ -20,15 +17,15 @@ describe Card::Set::Self::Admin do
 
     it "clearing trash is denied" do
       expect { run_admin_task :empty_trash }
-        .to raise_error Card::Error::PermissionDenied, /The admin task 'empty trash'/
+        .to raise_error Card::Error::PermissionDenied, /The admin task 'Empty Trash'/
     end
 
-    it "clearing history is denied" do
-      expect { run_admin_task :clear_history }
-        .to raise_error Card::Error::PermissionDenied, /The admin task 'clear history'/
-    end
+    # it "clearing history is denied" do
+    #   expect { run_admin_task :clear_history }
+    #     .to raise_error Card::Error::PermissionDenied, /The admin task 'clear history'/
+    # end
 
-    context "irreversible tasks allowed" do
+    context "when irreversible tasks allowed" do
       around do |example|
         Cardio.config.allow_irreversible_admin_tasks = true
         example.run
@@ -43,16 +40,16 @@ describe Card::Set::Self::Admin do
         expect(Card.where(trash: true)).to be_empty
       end
 
-      it "triggers deleting old revisions (with right params)" do
-        Card::Auth.as_bot do
-          a = Card["A"]
-          a.update! content: "a new day"
-          a.update! content: "another day"
-          expect(a.actions.count).to eq(3)
-          run_admin_task :clear_history
-          expect(a.actions.count).to eq(1)
-        end
-      end
+      # it "triggers deleting old revisions (with right params)" do
+      #   Card::Auth.as_bot do
+      #     a = Card["A"]
+      #     a.update! content: "a new day"
+      #     a.update! content: "another day"
+      #     expect(a.actions.count).to eq(3)
+      #     run_admin_task :clear_history
+      #     expect(a.actions.count).to eq(1)
+      #   end
+      # end
     end
 
     # it 'is trigger reference repair' do
@@ -67,4 +64,10 @@ describe Card::Set::Self::Admin do
     #   end
     # end
   end
+
+  specify "view warning" do
+    expect_view(:warning).to have_tag("div.alert.alert-warning.alert-dismissible") do
+      with_tag "button.btn-close"
+    end
+  end
 end

data/mod/core/spec/set/self/trash_spec.rb

@@ -1,6 +1,11 @@
 # -*- encoding : utf-8 -*-
 
 RSpec.describe Card::Set::Self::Trash do
+  # FIXME: there is no :trash card.  Either add it or get rid of this set.
+  def card_subject
+    "A".card.with_set described_class
+  end
+
   specify "view core" do
     expect_view(:core).to have_tag("table")
   end