card 1.101.4 → 1.101.5

data/db/migrate/20170908114452_increase_text_size_for_delayed_jobs.rb

@@ -1,6 +1,6 @@
 class IncreaseTextSizeForDelayedJobs < ActiveRecord::Migration[5.1]
   def self.up
-    change_column :delayed_jobs, :handler, :text, :limit => 16777215
+    change_column :delayed_jobs, :handler, :text, limit: 16_777_215
   end
 
   def self.down

data/db/migrate/20180514152037_add_card_virtuals_table.rb

@@ -6,7 +6,7 @@ class AddCardVirtualsTable < ActiveRecord::Migration[4.2]
     create_table :card_virtuals do |t|
       t.integer :left_id
       t.integer :right_id
-      t.text :content, limit: 16777215
+      t.text :content, limit: 16_777_215
     end
 
     add_index :card_virtuals, :right_id, name: "left_id_index"

data/db/migrate_core_cards/20120611203506_rails_inflection_updates.rb

@@ -37,7 +37,7 @@ class RailsInflectionUpdates < Cardio::Migration::Core
       # plural,     wrong singular,  correct singular
       word(['(\w+)lice',  '(\w+)louse',    '\1lice']),
       word(['(\w+)mice',  '(\w+)mouse',    '\1mice']),
-      word_end(%w(kine cow kine)),
+      word_end(%w[kine cow kine]),
       word(keep_the_s("analysi")),
       word(keep_the_s("axi"))
     ]
@@ -51,6 +51,7 @@ class RailsInflectionUpdates < Cardio::Migration::Core
 
       card_names.reject! do |name|  # change a name only once
         next unless name =~ plural
+
         # can't use fetch, because it uses the wrong key
         # find_by_name is case-insensitve and finds the wrong cards for camel case names
         card = Card.where(name: name).find { |card| card.name == name }

data/db/migrate_core_cards/20130411191151_renaming_for_menu.rb

@@ -3,15 +3,15 @@
 class RenamingForMenu < Cardio::Migration::Core
   def up
     renames = {
-      "*content"    => "*structure",
-      "*edit help"  => "*help",
-      "*links"      => "*links to",
+      "*content" => "*structure",
+      "*edit help" => "*help",
+      "*links" => "*links to",
       "*inclusions" => "*includes",
-      "*linkers"    => "*linked to by",
-      "*includers"  => "*included by",
+      "*linkers" => "*linked to by",
+      "*includers" => "*included by",
       "*plus cards" => "*children",
       "*plus parts" => "*mates",
-      "*editing"    => "*edited"
+      "*editing" => "*edited"
     }
     renames.each do |oldname, newname|
       puts "updating: #{oldname}"
@@ -21,7 +21,7 @@ class RenamingForMenu < Cardio::Migration::Core
       c.save!
     end
 
-    codenames = %w(
+    codenames = %w[
       by_name
       by_update
       by_create
@@ -37,9 +37,9 @@ class RenamingForMenu < Cardio::Migration::Core
       discussion
       created
       edited
-    )
+    ]
     codenames.each do |codename|
-      name = codename =~ /^by|disc/ ? codename : "*" + codename
+      name = codename =~ /^by|disc/ ? codename : "*#{codename}"
       c = Card[name]
       c.codename = codename
       c.save!

data/db/migrate_core_cards/20130419215612_import_help_text.rb

@@ -3,10 +3,11 @@
 class ImportHelpText < Cardio::Migration::Core
   def up
     dir = data_path "1.11_help_text.json"
-    data = JSON.parse(File.read dir)
+    data = JSON.parse(File.read(dir))
     data.each do |atom|
       c = atom["card"]
-      Card.merge c["name"], { type: c["type"], content: atom["views"][0]["parts"] }, pristine: true
+      Card.merge c["name"], { type: c["type"], content: atom["views"][0]["parts"] },
+                 pristine: true
     end
   end
 end

data/db/migrate_core_cards/20130823192433_add_style_cards.rb

@@ -26,8 +26,8 @@ class AddStyleCards < Cardio::Migration::Core
 
     # PERMISSIONS FOR CSS AND SCSS TYPES
 
-    %w(CSS SCSS Skin).each do |type|
-      [:create, :update, :delete].each do |action|
+    %w[CSS SCSS Skin].each do |type|
+      %i[create update delete].each do |action|
         Card.create! name: "#{type}+#{Card[:type].name}+#{Card[action].name}",
                      content: "[[#{Card[:administrator].name}]]"
       end
@@ -53,10 +53,10 @@ class AddStyleCards < Cardio::Migration::Core
 
     simple_styles = []
     classic_styles = []
-    %w(
+    %w[
       jquery-ui-smoothness.css functional.scss standard.scss right_sidebar.scss
       common.scss classic_cards.scss traditional.scss
-    ).each_with_index do |sheet, index|
+    ].each_with_index do |sheet, index|
       name, type = sheet.split "."
       name.tr! "_", " "
       index < 5 ? simple_styles << name : classic_styles << name
@@ -90,7 +90,7 @@ class AddStyleCards < Cardio::Migration::Core
     begin
       Card.create! name: "#{Card[:all].name}+*style",
                    content: "[[#{default_skin}]]"
-    rescue
+    rescue StandardError
       if default_skin =~ /customized/
         all_style = Card["#{Card[:all].name}+*style"]
         all_style.update content: "[[classic skin]]"

data/db/migrate_core_cards/20130910183318_move_styles_to_content.rb

@@ -3,8 +3,9 @@
 class MoveStylesToContent < Cardio::Migration::Core
   def up
     dir = File.join data_path, "1.12_stylesheets"
-    %w(right_sidebar common classic_cards traditional).each do |sheetname|
-      Card["style: #{sheetname}"].update! codename: nil, content: File.read("#{dir}/#{sheetname}.scss")
+    %w[right_sidebar common classic_cards traditional].each do |sheetname|
+      Card["style: #{sheetname}"].update! codename: nil,
+                                          content: File.read("#{dir}/#{sheetname}.scss")
     end
   end
 end

data/db/migrate_core_cards/20130920291703_update_stylesheets.rb

@@ -3,11 +3,9 @@
 class UpdateStylesheets < Cardio::Migration::Core
   def up
     dir = File.join data_path, "1.12_stylesheets"
-    %w(common traditional).each do |sheetname|
+    %w[common traditional].each do |sheetname|
       card = Card["style: #{sheetname}"]
-      if card && card.pristine?
-        card.update! content: File.read("#{dir}/#{sheetname}.scss")
-      end
+      card.update! content: File.read("#{dir}/#{sheetname}.scss") if card&.pristine?
     end
 
     if (c = Card["*all+*style+file"])

data/db/migrate_core_cards/20131016172445_common_css_patch.rb

@@ -4,8 +4,6 @@ class CommonCssPatch < Cardio::Migration::Core
   def up
     dir = File.join data_path, "1.12_stylesheets"
     card = Card["style: common"]
-    if card && card.pristine?
-      card.update! content: File.read("#{dir}/common.scss")
-    end
+    card.update! content: File.read("#{dir}/common.scss") if card&.pristine?
   end
 end

data/db/migrate_core_cards/20140110193325_reset_account_request_type.rb

@@ -3,8 +3,6 @@
 class ResetAccountRequestType < Cardio::Migration::Core
   def up
     arcard = Card[:signup]
-    if arcard.type_code != :cardtype
-      arcard.update type_id: Card::CardtypeID
-    end
+    arcard.update type_id: Card::CardtypeID if arcard.type_code != :cardtype
   end
 end

data/db/migrate_core_cards/20140307231621_user_data_to_cards.rb

@@ -6,12 +6,12 @@ end
 class UserDataToCards < Cardio::Migration::Core
   def up
     puts "adding new codename cards"
-    [:password, :token, :salt, :status, :signin, :stats].each do |codename|
+    %i[password token salt status signin stats].each do |codename|
       Card.create! name: "*#{codename}", codename: codename
     end
 
     puts "setting read permissions for account cards (Administrator)"
-    [:password, :token, :salt, :status, :email, :account].each do |codename|
+    %i[password token salt status email account].each do |codename|
       rule_name = [codename, :right, :read].map { |code| Card[code].name } * "+"
       rule_card = Card.fetch rule_name, new: {}
       rule_card.content = "[[Administrator]]"
@@ -19,20 +19,22 @@ class UserDataToCards < Cardio::Migration::Core
     end
 
     puts "making email and password fields default to Phrase cards"
-    [:email, :password].each do |field|
+    %i[email password].each do |field|
       rulename = [field, :right, :default].map { |code| Card[code].name } * "+"
       Card.create! name: rulename, type_id: Card::PhraseID
     end
 
     puts "signin permissions"
-    [:read, :update].each do |setting|
+    %i[read update].each do |setting|
       rulename = [:signin, :self, setting].map { |code| Card[code].name } * "+"
       Card.create! name: rulename, content: "[[#{Card[:anyone].name}]]"
     end
 
     puts "supporting legacy handling of +*email on User cards"
-    oldname = [:email,           :right, :structure].map { |code| Card[code].name } * "+"
-    newname = [:user, :email, :type_plus_right, :structure].map { |code| Card[code].name } * "+"
+    oldname = %i[email right structure].map { |code| Card[code].name } * "+"
+    newname = %i[user email type_plus_right structure].map do |code|
+      Card[code].name
+    end * "+"
     Card[oldname].update! name: newname
 
     puts "importing all user details (for those not in trash) into +*account attributes"
@@ -40,15 +42,17 @@ class UserDataToCards < Cardio::Migration::Core
     User.all.each do |user|
       base = Card[user.card_id]
       next unless base && !base.trash
+
       puts "~ importing details for #{base.name}"
       date_args = { created_at: user.created_at, updated_at: user.updated_at }
-      [:email, :salt, :password, :status].each do |field|
+      %i[email salt password status].each do |field|
         cardname = "#{base.name}+#{Card[:account].name}+#{Card[field].name}"
         user_field = (field == :password ? :crypted_password : field)
         next unless (content = user.send(user_field))
+
         begin
           Card.create! date_args.merge(name: cardname, content: content)
-        rescue => e
+        rescue StandardError => e
           puts "error importing #{cardname}: #{e.message}"
         end
       end

data/db/migrate_core_cards/20140317035504_account_requests_to_signups.rb

@@ -27,12 +27,10 @@ class AccountRequestsToSignups < Cardio::Migration::Core
     end
 
     # get rid of old signup card unless there is other data there (most likely +*subject and +*message)
-    unless Card.search(return: :id, left_id: old_signup.id).first
-      old_signup.delete!
-    end
+    old_signup.delete! unless Card.search(return: :id, left_id: old_signup.id).first
 
     # turn captcha off by default on signup
-    rulename = [:signup, :type, :captcha].map { |code| Card[code].name } * "+"
+    rulename = %i[signup type captcha].map { |code| Card[code].name } * "+"
     captcha_rule = Card.fetch rulename, new: {}
     captcha_rule.content = "0"
     captcha_rule.save!

data/db/migrate_core_cards/20140512155840_add_script_cards.rb

@@ -37,8 +37,8 @@ class AddScriptCards < Cardio::Migration::Core
 
     # Permissions for JavaScript and CoffeeScript types
     # ( the same as for CSS and SCSS)
-    %w(JavaScript CoffeeScript).each do |type|
-      [:create, :update, :delete].each do |action|
+    %w[JavaScript CoffeeScript].each do |type|
+      %i[create update delete].each do |action|
         Card.gimme!("#{type}+#{Card[:type].name}+#{Card[action].name}",
                     content: "[[#{Card[:administrator].name}]]")
       end
@@ -48,8 +48,10 @@ class AddScriptCards < Cardio::Migration::Core
     Card.create! name: "*script", codename: :script, type_id: Card::SettingID
     script_set = "*script+#{Card[:right].name}"
     Card.create! name: "#{script_set}+#{Card[:default].name}", type_id: Card::PointerID
-    Card.create! name: "#{script_set}+#{Card[:read].name}",    content: "[[#{Card[:anyone].name}]]"
-    Card.create! name: "#{script_set}+#{Card[:options].name}", content: %( {"type":["in", "JavaScript", "CoffeeScript"] }), type: Card::SearchTypeID
+    Card.create! name: "#{script_set}+#{Card[:read].name}",
+                 content: "[[#{Card[:anyone].name}]]"
+    Card.create! name: "#{script_set}+#{Card[:options].name}",
+                 content: %( {"type":["in", "JavaScript", "CoffeeScript"] }), type: Card::SearchTypeID
     Card.create! name: "#{script_set}+#{Card[:input].name}",   content: "list"
     Card.create! name: "#{script_set}+#{Card[:help].name}",    content:       %{ JavaScript (or CoffeeScript) for card's page. }  # TODO: help link?
 
@@ -57,23 +59,28 @@ class AddScriptCards < Cardio::Migration::Core
     default_rule_ending = "#{Card[:right].name}+#{Card[:default].name}"
     Card.create! name: "*machine output", codename: :machine_output
     Card.create! name: "*machine output+#{default_rule_ending}", type_id: Card::FileID
-    Card.create! name: "*machine output+#{Card[:right].name}+#{Card[:read].name}", content: "_left"
+    Card.create! name: "*machine output+#{Card[:right].name}+#{Card[:read].name}",
+                 content: "_left"
     Card.create! name: "*machine input", codename: :machine_input
     Card.create! name: "*machine input+#{default_rule_ending}", type_id: Card::PointerID
 
     # create default script rule
     card_type = { "js" => "java_script", "coffee" => "coffee_script" }
-    scripts        = %w(jquery tinymce slot     card_menu jquery_helper html5shiv_printshiv)
-    types          = %w(js     js      coffee   js        js            js)
+    scripts = %w[jquery tinymce slot card_menu jquery_helper
+                 html5shiv_printshiv]
+    types = %w[js js coffee js js js]
     # jquery.mobile  (in jquery_helper) must be after card to avoid mobileinit nastiness
     cardnames = scripts.map { |name| "script: #{name.tr('_', ' ')}" }
 
     scripts.each_with_index do |name, index|
-      Card.create! name: cardnames[index], type: card_type[types[index]], codename: "script_#{name}"
+      Card.create! name: cardnames[index], type: card_type[types[index]],
+                   codename: "script_#{name}"
     end
 
     cardnames.pop # html5shiv_printshiv not in default list, only used for IE9 (handled in head.rb)
     Card::Cache.reset_all
-    Card.create! name: "#{Card[:all].name}+*script", content: cardnames.map { |name| "[[#{name}]]" }.join("\n")
+    Card.create! name: "#{Card[:all].name}+*script", content: cardnames.map { |name|
+                                                                "[[#{name}]]"
+                                                              }.join("\n")
   end
 end

data/db/migrate_core_cards/20140629222005_add_email_cards.rb

@@ -3,14 +3,15 @@
 class AddEmailCards < Cardio::Migration::Core
   def up
     # change notification rules
-    %w(create update delete).each do |action|
+    %w[create update delete].each do |action|
       Card.create! name: "*on #{action}", type_code: :setting, codename: "on_#{action}"
-      Card.create! name: "*on #{action}+*right+*help", content: "Configures email to be sent when card is #{action}d."
+      Card.create! name: "*on #{action}+*right+*help",
+                   content: "Configures email to be sent when card is #{action}d."
       Card.create! name: "*on #{action}+*right+*default", type_code: :pointer
     end
 
     # change email address list fields to pointers
-    [:to, :from, :cc, :bcc].each do |field|
+    %i[to from cc bcc].each do |field|
       set = Card[field].fetch(:right, new: {})
       default_rule = set.fetch(:default, new: {})
       default_rule.type_id = Card::PointerID
@@ -27,7 +28,8 @@ class AddEmailCards < Cardio::Migration::Core
     end
 
     # create new cardtype for email templates
-    Card.create! name: "Email template", codename: :email_template, type_id: Card::CardtypeID
+    Card.create! name: "Email template", codename: :email_template,
+                 type_id: Card::CardtypeID
     Card.create! name: "Email template+*type+*structure", content: %(
 {{+#{Card[:from].name} | labeled | link}}
 {{+#{Card[:to].name} | labeled | link}}
@@ -55,21 +57,25 @@ class AddEmailCards < Cardio::Migration::Core
     data = JSON.parse(json)
     data.each do |mail|
       mail = mail.symbolize_keys!
-      Card.create! name: mail[:name], codename: mail[:codename], type_id: Card::EmailTemplateID
-      Card.create! name: "#{mail[:name]}+*html message", content: File.read(File.join(dir, "#{mail[:codename]}.html"))
-      Card.create! name: "#{mail[:name]}+*text message", content: File.read(File.join(dir, "#{mail[:codename]}.txt"))
+      Card.create! name: mail[:name], codename: mail[:codename],
+                   type_id: Card::EmailTemplateID
+      Card.create! name: "#{mail[:name]}+*html message",
+                   content: File.read(File.join(dir, "#{mail[:codename]}.html"))
+      Card.create! name: "#{mail[:name]}+*text message",
+                   content: File.read(File.join(dir, "#{mail[:codename]}.txt"))
       Card.create! name: "#{mail[:name]}+*subject", content: mail[:subject]
     end
 
     # move old hard-coded signup alert email handling to new card-based on_create handling
     Card.create!(
-      name: ([:signup, :type, :on_create].map { |code| Card[code].name } * "+"),
+      name: (%i[signup type on_create].map { |code| Card[code].name } * "+"),
       type_id: Card::PointerID, content: "[[signup alert email]]"
     )
     if request_card = Card[:request]
-      [:to, :from].each do |field|
+      %i[to from].each do |field|
         if old_card = request_card.fetch(field) && !old_card.db_content.blank?
-          Card.create! name: "signup alert email+#{Card[field].name}", content: old_card.db_content
+          Card.create! name: "signup alert email+#{Card[field].name}",
+                       content: old_card.db_content
         end
       end
       request_card.codename = nil
@@ -87,7 +93,8 @@ class AddEmailCards < Cardio::Migration::Core
     wagn_bot = Card[:wagn_bot].account.email.present? ? Card[:wagn_bot].name : nil
     token_emails_from = Card::Rule.global_setting("*invite+*from") || wagn_bot || "_user"
     ["verification email", "password reset email"].each do |token_email_template_name|
-      Card.create! name: "#{token_email_template_name}+#{Card[:from].name}", content: token_emails_from
+      Card.create! name: "#{token_email_template_name}+#{Card[:from].name}",
+                   content: token_emails_from
     end
 
     if invite_card = Card[:invite]
@@ -118,6 +125,7 @@ class AddEmailCards < Cardio::Migration::Core
 
     send = Card[:send]
     return unless send
+
     send.update codename: nil
     send.delete!
   end

data/db/migrate_core_cards/20140725180118_config_card_updates.rb

@@ -2,7 +2,7 @@
 
 class ConfigCardUpdates < Cardio::Migration::Core
   def up
-    raw_json = File.read(data_path "1.13_config_text.json")
+    raw_json = File.read(data_path("1.13_config_text.json"))
     json = JSON.parse raw_json
     Card.merge_list json["card"]["value"], output_file: "tmp/unmerged_config_text.json"
   end

data/db/migrate_core_cards/20141115034214_config_descriptions_etc.rb

@@ -2,7 +2,7 @@
 
 class ConfigDescriptionsEtc < Cardio::Migration::Core
   def up
-    raw_json = File.read(data_path "1.14_config_descriptions_etc.json")
+    raw_json = File.read(data_path("1.14_config_descriptions_etc.json"))
     json = JSON.parse raw_json
     Card.merge_list json["card"]["value"], output_file: "tmp/unmerged_config_text.json"
 

data/db/migrate_core_cards/20141119001955_make_symlinks_relative.rb

@@ -3,7 +3,7 @@
 class MakeSymlinksRelative < Cardio::Migration
   def up
     Card.paths["files"].each do |file_path|
-      files = Dir.glob(File.join file_path, "**", "*")
+      files = Dir.glob(File.join(file_path, "**", "*"))
       symlinks = files.select { |f| File.symlink? f }
       symlinks.each do |symlink|
         base = File.basename(File.readlink(symlink))

data/db/migrate_core_cards/20141204061304_watchers_to_following.rb

@@ -13,6 +13,7 @@ class WatchersToFollowing < Cardio::Migration::Core
         card.include_set_modules
 
         next unless watched = card.left
+
         card.item_names.each do |user_name|
           follower_hash[user_name] << watched.name
         end
@@ -20,6 +21,7 @@ class WatchersToFollowing < Cardio::Migration::Core
 
       follower_hash.each do |user, items|
         next unless (card = Card.fetch(user)) && card.account
+
         following = card.fetch "following",  new: { type_code: :pointer }
         items.each { |item| following.add_item item }
         following.save!

data/db/migrate_core_cards/20141216155251_add_more_following_cards.rb

@@ -5,7 +5,8 @@ class AddMoreFollowingCards < Cardio::Migration::Core
     Card.create! name: "*follow", codename: "follow", type_code: :setting
     Card.create! name: "*follow+*right+*default", type_code: :pointer
     Card.create! name: "*follow+*right+*input", type_code: :pointer, content: "[[radio]]"
-    Card.create! name: "*follow+*right+*help", content: "Get notified about changes", type_code: :phrase
+    Card.create! name: "*follow+*right+*help", content: "Get notified about changes",
+                 type_code: :phrase
 
     Card.create! name: "*followers", codename: "followers"
     Card.create! name: "*follow fields", codename: "follow_fields", type_code: :setting
@@ -18,7 +19,8 @@ class AddMoreFollowingCards < Cardio::Migration::Core
     Card.create! name: "*never", codename: "never"
 
     # default follow rule
-    Card.create! name: "*follow defaults", codename: "follow_defaults", type_code: :pointer
+    Card.create! name: "*follow defaults", codename: "follow_defaults",
+                 type_code: :pointer
     Card.create! name: "*all+*all+*follow", type_code: :pointer, content: "[[*never]]"
   end
 end