card 1.101.1 → 1.101.6

data/db/migrate/20110511221913_require_earlier_migrations.rb

@@ -1,4 +1,5 @@
 # -*- encoding : utf-8 -*-
+
 class RequireEarlierMigrations < ActiveRecord::Migration[4.2]
   def self.up
     raise %(

data/db/migrate/20121111025347_require_1_10_migrations.rb

@@ -1,4 +1,5 @@
 # -*- encoding : utf-8 -*-
+
 class Require110Migrations < ActiveRecord::Migration[4.2]
   def self.up
     raise %(

data/db/migrate/20121118114000_split_link_type.rb

@@ -1,4 +1,5 @@
 # -*- encoding : utf-8 -*-
+
 class SplitLinkType < ActiveRecord::Migration[4.2]
   def up
     add_column :card_references, :present, :integer

data/db/migrate/20121118115000_update_link_type.rb

@@ -1,4 +1,5 @@
 # -*- encoding : utf-8 -*-
+
 class UpdateLinkType < ActiveRecord::Migration[4.2]
   class TmpReference < ApplicationRecord
     self.table_name = "card_references"

data/db/migrate/20130106052640_table_cleanup.rb

@@ -1,4 +1,5 @@
 # -*- encoding : utf-8 -*-
+
 class TableCleanup < ActiveRecord::Migration[4.2]
   def up
     drop_table :cardtypes
@@ -20,6 +21,5 @@ class TableCleanup < ActiveRecord::Migration[4.2]
     remove_column :card_references, :updated_at
   end
 
-  def down
-  end
+  def down; end
 end

data/db/migrate/20130109015336_trunk_left.rb

@@ -1,4 +1,5 @@
 # -*- encoding : utf-8 -*-
+
 class TrunkLeft < ActiveRecord::Migration[4.2]
   def up
     rename_column :card_references, :link_type, :ref_type

data/db/migrate/20130411210957_update_codenames.rb

@@ -1,4 +1,5 @@
 # -*- encoding : utf-8 -*-
+
 class UpdateCodenames < ActiveRecord::Migration[4.2]
   def up
     { content: :structure, edit_help: :help }.each do |oldname, newname|

data/db/migrate/20140822073704_create_new_revision_tables.rb

@@ -1,4 +1,5 @@
 # -*- encoding : utf-8 -*-
+
 class CreateNewRevisionTables < ActiveRecord::Migration[4.2]
   def up
     add_column :cards, :db_content, :text

data/db/migrate/20141001105348_move_revisions_to_actions.rb

@@ -8,15 +8,19 @@ class MoveRevisionsToActions < ActiveRecord::Migration[4.2]
       TmpRevision.joins(left_join).where("cards.id IS NULL").delete_all
     end
   end
+
   class TmpAct < ApplicationRecord
     self.table_name = "card_acts"
   end
+
   class TmpAction < ApplicationRecord
     self.table_name = "card_actions"
   end
+
   class TmpChange < ApplicationRecord
     self.table_name = "card_changes"
   end
+
   class TmpCard < ApplicationRecord
     belongs_to :tmp_revision, foreign_key: :current_revision_id
     has_many :tmp_actions, foreign_key: :card_id
@@ -30,7 +34,10 @@ class MoveRevisionsToActions < ActiveRecord::Migration[4.2]
     created = ::Set.new
 
     TmpRevision.find_each do |rev|
-      TmpAct.create({ id: rev.id, card_id: rev.card_id, actor_id: rev.creator_id, acted_at: rev.created_at }, without_protection: true)
+      TmpAct.create(
+        { id: rev.id, card_id: rev.card_id, actor_id: rev.creator_id,
+          acted_at: rev.created_at }, without_protection: true
+      )
       if created.include? rev.card_id
         TmpAction.connection.execute "INSERT INTO card_actions (id, card_id, card_act_id, action_type) VALUES
                                                                ('#{rev.id}', '#{rev.card_id}', '#{rev.id}', 1)"
@@ -59,6 +66,5 @@ class MoveRevisionsToActions < ActiveRecord::Migration[4.2]
     # remove_column :cards, :current_revision
   end
 
-  def down
-  end
+  def down; end
 end

data/db/migrate/20141216053032_better_index_names.rb

@@ -6,11 +6,15 @@ class BetterIndexNames < ActiveRecord::Migration[4.2]
     rename_index :card_actions, "card_act_id_index", "card_actions_card_act_id_index"
     rename_index :card_actions, "card_id_index",     "card_actions_card_id_index"
 
-    rename_index :card_changes, "card_action_id_index", "card_changes_card_action_id_index"
+    rename_index :card_changes, "card_action_id_index",
+                 "card_changes_card_action_id_index"
 
-    rename_index :card_references, "wiki_references_referenced_card_id", "card_references_referee_id_index"
-    rename_index :card_references, "wiki_references_referenced_name",    "card_references_referee_key_index"
-    rename_index :card_references, "wiki_references_card_id",            "card_references_referer_id_index"
+    rename_index :card_references, "wiki_references_referenced_card_id",
+                 "card_references_referee_id_index"
+    rename_index :card_references, "wiki_references_referenced_name",
+                 "card_references_referee_key_index"
+    rename_index :card_references, "wiki_references_card_id",
+                 "card_references_referer_id_index"
 
     rename_index :cards, "cards_key_uniq",              "cards_key_index"
     rename_index :cards, "card_type_index",             "cards_type_id_index"
@@ -19,6 +23,5 @@ class BetterIndexNames < ActiveRecord::Migration[4.2]
     rename_index :cards, "index_cards_on_read_rule_id", "cards_read_rule_id_index"
   end
 
-  def down
-  end
+  def down; end
 end

data/db/migrate/20170908114442_create_delayed_jobs.rb

@@ -13,7 +13,7 @@ class CreateDelayedJobs < ActiveRecord::Migration[5.1]
       table.timestamps null: true
     end
 
-    add_index :delayed_jobs, [:priority, :run_at], name: "delayed_jobs_priority"
+    add_index :delayed_jobs, %i[priority run_at], name: "delayed_jobs_priority"
   end
 
   def self.down

data/db/migrate/20170908114452_increase_text_size_for_delayed_jobs.rb

@@ -1,6 +1,6 @@
 class IncreaseTextSizeForDelayedJobs < ActiveRecord::Migration[5.1]
   def self.up
-    change_column :delayed_jobs, :handler, :text, :limit => 16777215
+    change_column :delayed_jobs, :handler, :text, limit: 16_777_215
   end
 
   def self.down

data/db/migrate/20180514152037_add_card_virtuals_table.rb

@@ -6,7 +6,7 @@ class AddCardVirtualsTable < ActiveRecord::Migration[4.2]
     create_table :card_virtuals do |t|
       t.integer :left_id
       t.integer :right_id
-      t.text :content, limit: 16777215
+      t.text :content, limit: 16_777_215
     end
 
     add_index :card_virtuals, :right_id, name: "left_id_index"

data/db/migrate/20200805200729_add_unique_pair_indeces.rb

@@ -1,9 +1,43 @@
 class AddUniquePairIndeces < ActiveRecord::Migration[6.0]
   def change
-    # TODO: uncomment following
+    stash_duplicate_cards
+    delete_duplicate_virtuals
     add_index :cards, %i[left_id right_id], unique: true
     add_index :card_virtuals, %i[left_id right_id], unique: true
 
     drop_table :users
   end
+
+  private
+
+  def stash_duplicate_cards
+    fake_id = -9000
+    duplicates :cards do |id|
+      stash_card id, fake_id
+      fake_id = fake_id - 1
+    end
+  end
+
+  def delete_duplicate_virtuals
+    duplicates :card_virtuals do |id|
+      connection.execute "delete from card_virtuals where id = #{id}"
+    end
+  end
+
+  def stash_card id, fake_id
+    connection.execute(
+      "UPDATE cards set left_id = #{fake_id}, trash = true where id = #{id}"
+    )
+  end
+
+  def duplicates table
+    sql = "SELECT distinct a.id from #{table} a join #{table} b " \
+          "ON a.left_id = b.left_id AND a.right_id = b.right_id " \
+          "AND a.id < b.id"
+    connection.select_all(sql).each { |row| yield row["id"].to_i }
+  end
+
+  def connection
+    ActiveRecord::Base.connection
+  end
 end

data/db/migrate_core_cards/20120611203506_rails_inflection_updates.rb

@@ -37,7 +37,7 @@ class RailsInflectionUpdates < Cardio::Migration::Core
       # plural,     wrong singular,  correct singular
       word(['(\w+)lice',  '(\w+)louse',    '\1lice']),
       word(['(\w+)mice',  '(\w+)mouse',    '\1mice']),
-      word_end(%w(kine cow kine)),
+      word_end(%w[kine cow kine]),
       word(keep_the_s("analysi")),
       word(keep_the_s("axi"))
     ]
@@ -51,6 +51,7 @@ class RailsInflectionUpdates < Cardio::Migration::Core
 
       card_names.reject! do |name|  # change a name only once
         next unless name =~ plural
+
         # can't use fetch, because it uses the wrong key
         # find_by_name is case-insensitve and finds the wrong cards for camel case names
         card = Card.where(name: name).find { |card| card.name == name }
@@ -69,7 +70,7 @@ class RailsInflectionUpdates < Cardio::Migration::Core
       end
     end
 
-    cards_with_css = Card.search type: %w(in html css scss)
+    cards_with_css = Card.search type: %w[in html css scss]
     cards_with_css.each do |card|
       new_content = card.db_content
       content_changed = false

data/db/migrate_core_cards/20130411191151_renaming_for_menu.rb

@@ -3,15 +3,15 @@
 class RenamingForMenu < Cardio::Migration::Core
   def up
     renames = {
-      "*content"    => "*structure",
-      "*edit help"  => "*help",
-      "*links"      => "*links to",
+      "*content" => "*structure",
+      "*edit help" => "*help",
+      "*links" => "*links to",
       "*inclusions" => "*includes",
-      "*linkers"    => "*linked to by",
-      "*includers"  => "*included by",
+      "*linkers" => "*linked to by",
+      "*includers" => "*included by",
       "*plus cards" => "*children",
       "*plus parts" => "*mates",
-      "*editing"    => "*edited"
+      "*editing" => "*edited"
     }
     renames.each do |oldname, newname|
       puts "updating: #{oldname}"
@@ -21,7 +21,7 @@ class RenamingForMenu < Cardio::Migration::Core
       c.save!
     end
 
-    codenames = %w(
+    codenames = %w[
       by_name
       by_update
       by_create
@@ -37,9 +37,9 @@ class RenamingForMenu < Cardio::Migration::Core
       discussion
       created
       edited
-    )
+    ]
     codenames.each do |codename|
-      name = codename =~ /^by|disc/ ? codename : "*" + codename
+      name = codename =~ /^by|disc/ ? codename : "*#{codename}"
       c = Card[name]
       c.codename = codename
       c.save!

data/db/migrate_core_cards/20130419215612_import_help_text.rb

@@ -3,10 +3,11 @@
 class ImportHelpText < Cardio::Migration::Core
   def up
     dir = data_path "1.11_help_text.json"
-    data = JSON.parse(File.read dir)
+    data = JSON.parse(File.read(dir))
     data.each do |atom|
       c = atom["card"]
-      Card.merge c["name"], { type: c["type"], content: atom["views"][0]["parts"] }, pristine: true
+      Card.merge c["name"], { type: c["type"], content: atom["views"][0]["parts"] },
+                 pristine: true
     end
   end
 end

data/db/migrate_core_cards/20130823192433_add_style_cards.rb

@@ -26,8 +26,8 @@ class AddStyleCards < Cardio::Migration::Core
 
     # PERMISSIONS FOR CSS AND SCSS TYPES
 
-    %w(CSS SCSS Skin).each do |type|
-      [:create, :update, :delete].each do |action|
+    %w[CSS SCSS Skin].each do |type|
+      %i[create update delete].each do |action|
         Card.create! name: "#{type}+#{Card[:type].name}+#{Card[action].name}",
                      content: "[[#{Card[:administrator].name}]]"
       end
@@ -53,10 +53,10 @@ class AddStyleCards < Cardio::Migration::Core
 
     simple_styles = []
     classic_styles = []
-    %w(
+    %w[
       jquery-ui-smoothness.css functional.scss standard.scss right_sidebar.scss
       common.scss classic_cards.scss traditional.scss
-    ).each_with_index do |sheet, index|
+    ].each_with_index do |sheet, index|
       name, type = sheet.split "."
       name.tr! "_", " "
       index < 5 ? simple_styles << name : classic_styles << name
@@ -90,7 +90,7 @@ class AddStyleCards < Cardio::Migration::Core
     begin
       Card.create! name: "#{Card[:all].name}+*style",
                    content: "[[#{default_skin}]]"
-    rescue
+    rescue StandardError
       if default_skin =~ /customized/
         all_style = Card["#{Card[:all].name}+*style"]
         all_style.update content: "[[classic skin]]"

data/db/migrate_core_cards/20130910183318_move_styles_to_content.rb

@@ -3,8 +3,9 @@
 class MoveStylesToContent < Cardio::Migration::Core
   def up
     dir = File.join data_path, "1.12_stylesheets"
-    %w(right_sidebar common classic_cards traditional).each do |sheetname|
-      Card["style: #{sheetname}"].update! codename: nil, content: File.read("#{dir}/#{sheetname}.scss")
+    %w[right_sidebar common classic_cards traditional].each do |sheetname|
+      Card["style: #{sheetname}"].update! codename: nil,
+                                          content: File.read("#{dir}/#{sheetname}.scss")
     end
   end
 end

data/db/migrate_core_cards/20130920291703_update_stylesheets.rb

@@ -3,11 +3,9 @@
 class UpdateStylesheets < Cardio::Migration::Core
   def up
     dir = File.join data_path, "1.12_stylesheets"
-    %w(common traditional).each do |sheetname|
+    %w[common traditional].each do |sheetname|
       card = Card["style: #{sheetname}"]
-      if card && card.pristine?
-        card.update! content: File.read("#{dir}/#{sheetname}.scss")
-      end
+      card.update! content: File.read("#{dir}/#{sheetname}.scss") if card&.pristine?
     end
 
     if (c = Card["*all+*style+file"])

data/db/migrate_core_cards/20131016172445_common_css_patch.rb

@@ -4,8 +4,6 @@ class CommonCssPatch < Cardio::Migration::Core
   def up
     dir = File.join data_path, "1.12_stylesheets"
     card = Card["style: common"]
-    if card && card.pristine?
-      card.update! content: File.read("#{dir}/common.scss")
-    end
+    card.update! content: File.read("#{dir}/common.scss") if card&.pristine?
   end
 end

data/db/migrate_core_cards/20140110193325_reset_account_request_type.rb

@@ -3,8 +3,6 @@
 class ResetAccountRequestType < Cardio::Migration::Core
   def up
     arcard = Card[:signup]
-    if arcard.type_code != :cardtype
-      arcard.update type_id: Card::CardtypeID
-    end
+    arcard.update type_id: Card::CardtypeID if arcard.type_code != :cardtype
   end
 end

data/db/migrate_core_cards/20140307231621_user_data_to_cards.rb

@@ -6,12 +6,12 @@ end
 class UserDataToCards < Cardio::Migration::Core
   def up
     puts "adding new codename cards"
-    [:password, :token, :salt, :status, :signin, :stats].each do |codename|
+    %i[password token salt status signin stats].each do |codename|
       Card.create! name: "*#{codename}", codename: codename
     end
 
     puts "setting read permissions for account cards (Administrator)"
-    [:password, :token, :salt, :status, :email, :account].each do |codename|
+    %i[password token salt status email account].each do |codename|
       rule_name = [codename, :right, :read].map { |code| Card[code].name } * "+"
       rule_card = Card.fetch rule_name, new: {}
       rule_card.content = "[[Administrator]]"
@@ -19,20 +19,22 @@ class UserDataToCards < Cardio::Migration::Core
     end
 
     puts "making email and password fields default to Phrase cards"
-    [:email, :password].each do |field|
+    %i[email password].each do |field|
       rulename = [field, :right, :default].map { |code| Card[code].name } * "+"
       Card.create! name: rulename, type_id: Card::PhraseID
     end
 
     puts "signin permissions"
-    [:read, :update].each do |setting|
+    %i[read update].each do |setting|
       rulename = [:signin, :self, setting].map { |code| Card[code].name } * "+"
       Card.create! name: rulename, content: "[[#{Card[:anyone].name}]]"
     end
 
     puts "supporting legacy handling of +*email on User cards"
-    oldname = [:email,           :right, :structure].map { |code| Card[code].name } * "+"
-    newname = [:user, :email, :type_plus_right, :structure].map { |code| Card[code].name } * "+"
+    oldname = %i[email right structure].map { |code| Card[code].name } * "+"
+    newname = %i[user email type_plus_right structure].map do |code|
+      Card[code].name
+    end * "+"
     Card[oldname].update! name: newname
 
     puts "importing all user details (for those not in trash) into +*account attributes"
@@ -40,15 +42,17 @@ class UserDataToCards < Cardio::Migration::Core
     User.all.each do |user|
       base = Card[user.card_id]
       next unless base && !base.trash
+
       puts "~ importing details for #{base.name}"
       date_args = { created_at: user.created_at, updated_at: user.updated_at }
-      [:email, :salt, :password, :status].each do |field|
+      %i[email salt password status].each do |field|
         cardname = "#{base.name}+#{Card[:account].name}+#{Card[field].name}"
         user_field = (field == :password ? :crypted_password : field)
         next unless (content = user.send(user_field))
+
         begin
           Card.create! date_args.merge(name: cardname, content: content)
-        rescue => e
+        rescue StandardError => e
           puts "error importing #{cardname}: #{e.message}"
         end
       end

data/db/migrate_core_cards/20140317035504_account_requests_to_signups.rb

@@ -27,12 +27,10 @@ class AccountRequestsToSignups < Cardio::Migration::Core
     end
 
     # get rid of old signup card unless there is other data there (most likely +*subject and +*message)
-    unless Card.search(return: :id, left_id: old_signup.id).first
-      old_signup.delete!
-    end
+    old_signup.delete! unless Card.search(return: :id, left_id: old_signup.id).first
 
     # turn captcha off by default on signup
-    rulename = [:signup, :type, :captcha].map { |code| Card[code].name } * "+"
+    rulename = %i[signup type captcha].map { |code| Card[code].name } * "+"
     captcha_rule = Card.fetch rulename, new: {}
     captcha_rule.content = "0"
     captcha_rule.save!