card-mod-permissions 0.17.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 443a944aa0813b46f7f712e8d309dcf1cf65fb621f2a16a2a3931788dc13013b
-  data.tar.gz: 86ef98147edad0eed532e3a4c4307bf15368b763b83b41da39fdfff19981f47a
+  metadata.gz: 0f6078e690d49effad8b5e8dcc2c17b5c25360612b183c9958eb3403e7ee468c
+  data.tar.gz: 7bb9710db77010d387df7d73f7fed189c9ed25e3370aeb560d03e4646f6eb98e
 SHA512:
-  metadata.gz: efdb829467f04d220efecbc5cee7cd5133c778616e9c5fb7ac60b0de68ba9b8f4081ae68cf89bf7782e3915c129f436893d1c799f73bfd46dc5c826cb39704f3
-  data.tar.gz: 531fb7979d8696002843ae28999a49ea9c8eb4427f75b6ee0379b04b29a518b2289043848f5bcb546f763f105d14522a15f2bee71d88a205cd3b652c2faf8b4f
+  metadata.gz: 738ab74454596e1bfcdeafdf4c6047c2f1b5e8c135a8bcf830e2baa3825d6b467606b7d05d923d22cfbaf762198c027fdb793fe379b5ddd66a457316309ce4db
+  data.tar.gz: 2629efb0acb72b37e51235f917dc38a60cab7b489254b516de311426b4214307746d00e16a159cf5553793f662523f26ba426713a82671af8516fcb0ecdf79d4

data/set/all/permissions.rb

@@ -1,16 +1,28 @@
-module ClassMethods
-  def repair_all_permissions
-    Card.where("(read_rule_class is null or read_rule_id is null) and trash is false")
-        .each do |broken_card|
-      broken_card.include_set_modules
-      broken_card.repair_permissions!
-    end
+event :set_read_rule, :store, on: :save, changed: %i[type_id name] do
+  read_rule_id, read_rule_class = permission_rule_id_and_class(:read)
+  self.read_rule_id = read_rule_id
+  self.read_rule_class = read_rule_class
+end
+
+event :set_field_read_rules, after: :set_read_rule, on: :update, changed: :type_id do
+  each_field_as_bot(&:update_read_rule)
+end
+
+event :update_read_rule do
+  without_timestamps do
+    reset_patterns # why is this needed?
+    set_read_rule
+    Card.where(id: id).update_all read_rule_id: read_rule_id,
+                                  read_rule_class: read_rule_class
+    expire :shared
+    update_field_read_rules
   end
 end
 
-def repair_permissions!
-  rule_id, rule_class = permission_rule_id_and_class :read
-  update_columns read_rule_id: rule_id, read_rule_class: rule_class
+event :check_permissions, :validate do
+  track_permission_errors do
+    ok? action_for_permission_check
+  end
 end
 
 # ok? and ok! are public facing methods to approve one action at a time
@@ -21,8 +33,6 @@ end
 #      trait: :account      would fetch this card plus a tag codenamed :account
 #      trait: :roles, new: {} would initialize a new card with default ({})
 # options.
-#
-#
 
 def ok? action
   @ok ||= {}
@@ -42,12 +52,6 @@ def anyone_can? action
   who_can(action).include? AnyoneID
 end
 
-def direct_rule_card action
-  direct_rule_id = rule_card_id action
-  require_permission_rule! direct_rule_id, action
-  Card.quick_fetch direct_rule_id
-end
-
 def permission_rule_id action
   if compound? && rule(action).match?(/^\[?\[?_left\]?\]?$/)
     left_permission_rule_id action
@@ -159,16 +163,6 @@ end
 #   self.read_rule_id = self.read_rule_class = nil
 # end
 
-event :set_read_rule, :store, on: :save, changed: %i[type_id name] do
-  read_rule_id, read_rule_class = permission_rule_id_and_class(:read)
-  self.read_rule_id = read_rule_id
-  self.read_rule_class = read_rule_class
-end
-
-event :set_field_read_rules, after: :set_read_rule, on: :update, changed: :type_id do
-  each_field_as_bot(&:update_read_rule)
-end
-
 def update_field_read_rules
   return unless type_id_changed? || read_rule_id_changed?
 
@@ -186,6 +180,13 @@ def each_field_as_bot &block
   end
 end
 
+def repair_permissions!
+  rule_id, rule_class = permission_rule_id_and_class :read
+  update_columns read_rule_id: rule_id, read_rule_class: rule_class
+end
+
+private
+
 def without_timestamps
   Card.record_timestamps = false
   yield
@@ -193,30 +194,6 @@ ensure
   Card.record_timestamps = true
 end
 
-event :update_read_rule do
-  without_timestamps do
-    reset_patterns # why is this needed?
-    rcard_id, rclass = permission_rule_id_and_class :read
-    # these two are just to make sure vals are correct on current object
-    self.read_rule_id = rcard_id
-    self.read_rule_class = rclass
-    Card.where(id: id).update_all read_rule_id: rcard_id, read_rule_class: rclass
-    expire :hard
-    # binding.pry if field_cards.include? nil
-    update_field_read_rules
-  end
-end
-
-def add_to_read_rule_update_queue updates
-  @read_rule_update_queue = Array.wrap(@read_rule_update_queue).concat updates
-end
-
-event :check_permissions, :validate do
-  track_permission_errors do
-    ok? action_for_permission_check
-  end
-end
-
 def action_for_permission_check
   commenting? ? :update : action
 end
@@ -228,3 +205,19 @@ def track_permission_errors
   @permission_errors = nil
   result
 end
+
+def direct_rule_card action
+  direct_rule_id = rule_card_id action
+  require_permission_rule! direct_rule_id, action
+  Card.quick_fetch direct_rule_id
+end
+
+module ClassMethods
+  def repair_all_permissions
+    Card.where("(read_rule_class is null or read_rule_id is null) and trash is false")
+        .each do |broken_card|
+      broken_card.include_set_modules
+      broken_card.repair_permissions!
+    end
+  end
+end

data/set/right/read.rb

@@ -5,11 +5,24 @@ assign_type :list
 format :html do include Abstract::Permission::HtmlFormat end
 
 event :cascade_read_rule, :finalize, after: :update_rule_cache, when: :rule? do
+  # left&.update_lexicon
   return unless name_is_changing? || trash_is_changing?
 
   update_read_ruled_cards
 end
 
+def rule_pattern_index
+  return if trash
+
+  @rule_pattern_index ||= pattern_index rule_set&.tag&.id
+end
+
+def pattern_index pattern_id
+  Pattern.ids.index(pattern_id) || invalid_pattern_id(pattern_id)
+end
+
+private
+
 def update_read_ruled_cards
   Card::Rule.clear_read_rule_cache
   Card.cache.reset # maybe be more surgical, just Auth.user related
@@ -57,20 +70,6 @@ def all_members
   rule_set.item_cards limit: 0
 end
 
-def rule_pattern_index
-  return if trash
-
-  @rule_pattern_index ||= pattern_index rule_set&.tag&.id
-end
-
-def pattern_index pattern_id
-  Pattern.ids.index(pattern_id) || invalid_pattern_id(pattern_id)
-end
-
 def invalid_pattern_id pattern_id
   Rails.logger.info "invalid pattern id for read rule: #{pattern_id}"
 end
-
-event :process_read_rule_update_queue, :finalize do
-  left&.update_read_rule
-end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: card-mod-permissions
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.0
 platform: ruby
 authors:
 - Ethan McCutchen
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-12 00:00:00.000000000 Z
+date: 2024-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: card
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.107.0
+        version: 1.108.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.107.0
+        version: 1.108.0
 description: ''
 email:
 - info@decko.org
@@ -55,7 +55,7 @@ files:
 - set/self/update.rb
 homepage: https://decko.org
 licenses:
-- GPL-3.0
+- GPL-3.0-or-later
 metadata:
   source_code_uri: https://github.com/decko-commons/decko
   homepage_uri: https://decko.org
@@ -79,7 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.10
+rubygems_version: 3.5.7
 signing_key:
 specification_version: 4
 summary: decko permissions