card-mod-permissions 0.11.1 → 0.11.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2dac11c74b7e4df1557fcfd767a943dd2e36366df677bc0826cdcbe067758762
-  data.tar.gz: 9b242bead9cfc1fed892dd700da46e4cc8da967099b08ee9236942f89afd41b8
+  metadata.gz: 702205228e1f4682a4dcafe6b52fc815308a85fea6129f33c6c7dbcba4d954a1
+  data.tar.gz: a68d350ddd383e303e49279c5a965a3ecfb025707bf2e99111074e924a4e645d
 SHA512:
-  metadata.gz: 20409bbdef65cf47461c2f60aa4c1ce8e86250c6f3594f3a44e4c500f8e7797f75e9d8d8c75262a813eec8c84087fc05a0784d926c8123277dca4195254afeff
-  data.tar.gz: d673d1f20b51815dc3b1f7d7dbdc0a49de29d074fa8ee32cb912b0a7165bf6b412ff2de18a8da6c9286aff8b0d36f0ef041c2c55dd7b1e1ab7ea2c17c881b4ec
+  metadata.gz: 3e836f80cd26bf0d1ec99aae1dd233c4d5f78b98fbbcbf18e58f6af76658a4ed1f9507bcd4022d9bbb346e75d7c08c8d1bdd9da0d5af96b045aa5c47dda70e44
+  data.tar.gz: fcc0937ac9a48d4fd89ad3c1d29b822e72f362106b936d84ab8fe325316b4ff7c83f4f9394ff6ca1e1a31f32b75999a1e060ee67545add00d8cc61ab40e25627

data/set/abstract/permission.rb

@@ -1,4 +1,3 @@
-
 def standardize_items
   super unless content == "_left"
 end
@@ -84,6 +83,7 @@ format :html do
 
   def inheritance_checkbox
     return unless inheritable?
+
     <<-HTML
       <div class="perm-inheritance perm-section">
         #{check_box_tag 'inherit', 'inherit', inheriting?}
@@ -106,6 +106,7 @@ format :html do
 
   def in_context_of_self_set?
     return false unless @set_context
+
     @set_context.to_name.tag_name.key == Card[:self].key
   end
 
@@ -116,7 +117,7 @@ format :html do
       link_to_card card_id, nil, target: args[:target]
     end * ", "
     "Inherit ( #{links} )"
-  rescue
+  rescue StandardError
     "Inherit"
   end
 end

data/set/all/permissions.rb

@@ -51,7 +51,7 @@ def direct_rule_card action
 end
 
 def permission_rule_id action
-  if junction? && rule(action).match?(/^\[?\[?_left\]?\]?$/)
+  if compound? && rule(action).match?(/^\[?\[?_left\]?\]?$/)
     left_permission_rule_id action
   else
     rule_card_id(action)
@@ -64,9 +64,7 @@ end
 
 def left_permission_rule_id action
   lcard = left_or_new(skip_virtual: true, skip_modules: true)
-  if action == :create && lcard.real? && lcard.action != :create
-    action = :update
-  end
+  action = :update if action == :create && lcard.real? && lcard.action != :create
   lcard.permission_rule_id action
 end
 
@@ -76,9 +74,11 @@ end
 
 def require_permission_rule! rule_id, action
   return if rule_id
+
   # RULE missing.  should not be possible.
   # generalize this to handling of all required rules
-  errors.add :permission_denied, tr(:error_no_action_rule, action: action, name: name)
+  errors.add :permission_denied,
+             t(:permission_error_no_action_rule, action: action, name: name)
   raise Card::Error::PermissionDenied, self
 end
 
@@ -110,6 +110,7 @@ def permit action, verb=nil
   end
 
   return true if permitted? action
+
   verb ||= action.to_s
   deny_because you_cant("#{verb} #{name.present? ? name : 'this'}")
 end
@@ -124,6 +125,7 @@ end
 def ok_to_create_side side
   # left is supercard; create permissions will get checked there.
   return true if side == :left && superleft
+
   part_card = send side, new: {}
   # if no card, there must be other errors
   return true unless part_card&.new_card? && !part_card.ok?(:create)
@@ -144,6 +146,7 @@ end
 def ok_to_update
   return false unless permit(:update)
   return true unless type_id_changed? && !permitted?(:create)
+
   deny_because you_cant("change to this type (need create permission)")
 end
 
@@ -170,17 +173,18 @@ end
 
 def update_field_read_rules
   return unless type_id_changed? || read_rule_id_changed?
+
   each_field_as_bot do |field|
     field.update_read_rule if field.rule(:read) == "_left"
   end
 end
 
-def each_field_as_bot
+def each_field_as_bot &block
   # find all cards with me as trunk and update their read_rule
   # (because of *type plus right)
   # skip if name is updated because will already be resaved
   Auth.as_bot do
-    fields.each { |field| yield field }
+    fields.each(&block)
   end
 end
 

data/set/all/update_read_rules.rb

@@ -1,8 +1,7 @@
-
 # FIXME: the following don't really belong here, but they have to come after
 # the reference stuff.  we need to organize a bit!
 
-event :update_rule_cache, :finalize, when: :is_rule? do
+event :update_rule_cache, :finalize, when: :rule? do
   Card::Rule.clear_rule_cache
 end
 

data/set/right/read.rb

@@ -2,7 +2,7 @@ include Abstract::Permission
 
 format :html do include Abstract::Permission::HtmlFormat end
 
-event :cascade_read_rule, :finalize, after: :update_rule_cache, when: :is_rule? do
+event :cascade_read_rule, :finalize, after: :update_rule_cache, when: :rule? do
   return unless name_is_changing? || trash_is_changing?
 
   update_read_ruled_cards
@@ -44,11 +44,9 @@ def update_cards_with_read_rule_id processed
   end
 end
 
-def each_member
+def each_member &block
   Auth.as_bot do
-    all_members.each_with_object(::Set.new) do |member, processed|
-      yield member, processed
-    end
+    all_members.each_with_object(::Set.new, &block)
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: card-mod-permissions
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.11.6
 platform: ruby
 authors:
 - Ethan McCutchen
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-02 00:00:00.000000000 Z
+date: 2021-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: card
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.101.1
+        version: 1.101.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.101.1
+        version: 1.101.6
 description: ''
 email:
 - info@decko.org
@@ -44,10 +44,15 @@ files:
 - set/self/delete.rb
 - set/self/read.rb
 - set/self/update.rb
-homepage: http://decko.org
+homepage: https://decko.org
 licenses:
 - GPL-3.0
 metadata:
+  source_code_uri: https://github.com/decko-commons/decko
+  homepage_uri: https://decko.org
+  bug_tracker_uri: https://github.com/decko-commons/decko/issues
+  wiki_uri: https://decko.org
+  documentation_url: http://docs.decko.org/
   card-mod: permissions
 post_install_message:
 rdoc_options: []
@@ -64,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: decko permissions