card-mod-lookup 0.3 → 0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c77c10ee00c6b928424df37db61a768e58a610f35d6db668e2a3d02a58a46ee
-  data.tar.gz: 78cc69b638d553606d18f558f0702aadf2c42100ec0af3a0e2ba38a57c12c7f9
+  metadata.gz: a98f8a016a2cab0a120e24080a6a9412c78df74364ffc335eeebcaed237d381e
+  data.tar.gz: ea21cc3f70eae3eabb38fcacd5bd69e6780c7fd9b365230536cb97c7ae211155
 SHA512:
-  metadata.gz: c3650ecfd40809a93ce97167062ad4df2ff40970554565267370d192491230d8e29b27b2e68b0d28ec518e0f81791b5af03e302108c5beb05334dad3c8daf9fe
-  data.tar.gz: 1844dddf1146c2575cf4fab268de1a9e5369e1b1ef3d168c4f0b05fe532e058b5409f2f62aa1a5b6234247ef9d523fa00772e70304be3a916d2d71d05d8e17c7
+  metadata.gz: 3ea4e3b72a7ff53aedb4045386d9d901c7b9b594f6faa44d534ef7add330c693a1e011ca942b3efa80997d903f5ab03a258d2461c569e61328bee40debff2da5
+  data.tar.gz: d10d164d42714b2db57d77101d69af7c74244402ec597018efc59ee06599edfd7b4cd2767fc11ebd1609590d6cf2bcd7bd9fb512d80ea82886502f8ccf6ef1a9

data/README.md

@@ -18,10 +18,10 @@ and when a database grows large, it can become quite expensive to execute all
 the implied self joins.
 
 For example, consider the use case that first inspired this code: _answers_ on
-Wikirate.org. WikiRate is a site that collects answers to questions about 
+wikirate.org. Wikirate is a site that collects answers to questions about 
 companies. A given answer is a response to a given metric for a given year
 for a given company. When you consider all the kinds of companies and metrics
-and metric designers that WikiRate supports, you can imagine the queries 
+and metric designers that Wikirate supports, you can imagine the queries 
 becoming quite complex if we have to re-join the cards table to itself every
 time we want to consider a different variable.
 

data/lib/card/{lookup_filter_query → lookup_query}/active_record_extension.rb

@@ -1,5 +1,5 @@
 class Card
-  class LookupFilterQuery
+  class LookupQuery
     # support methods for sort and page
     module ActiveRecordExtension
       # @params hash [Hash] key1: dir1, key2: dir2

data/lib/card/{lookup_filter_query → lookup_query}/filtering.rb

@@ -1,6 +1,6 @@
 class Card
-  class LookupFilterQuery
-    # shared filtering methods for FilterQuery classes built on lookup tables
+  class LookupQuery
+    # shared filtering methods for query classes built on lookup tables
     module Filtering
       def process_filters
         normalize_filter_args
@@ -17,7 +17,7 @@ class Card
         if (method = filter_method key)
           send method, key, value
         else
-          try "#{key}_query", value
+          try "filter_by_#{key}", value
         end
       end
 
@@ -40,10 +40,13 @@ class Card
         filter card_id_map[key], card_id
       end
 
-      def not_ids_query value
-        add_condition "#{lookup_class.card_column} not in (?)", value.split(",")
+      def filter_by_not_ids value
+        add_condition "#{lookup_class.card_column} not in (?)",
+                      not_ids_value(value)
       end
 
+      private
+
       def to_card_id value
         if value.is_a? Array
           value.map(&:card_id)
@@ -106,6 +109,11 @@ class Card
       def db_value value
         value.is_a?(Array) ? "(?)" : "?"
       end
+
+      def not_ids_value value
+        return value if value.is_a? Array
+        value.to_s.split ","
+      end
     end
   end
 end

data/lib/card/{lookup_filter_query.rb → lookup_query.rb}

@@ -1,6 +1,6 @@
 class Card
-  # base class for FilterQuery classes built on lookup tables
-  class LookupFilterQuery
+  # base class for query classes built on lookup tables
+  class LookupQuery
     include Filtering
 
     attr_accessor :filter_args, :sort_args, :paging_args

data/set/abstract/lookup_search.rb

@@ -12,12 +12,12 @@ def run_query_returning query, return_type
   end
 end
 
-def filter_class
-  raise Error::ServerError, "filter_class required!"
+def query_class
+  raise Error::ServerError, "query_class required!"
 end
 
 def query paging={}
-  filter_class.new query_hash, {}, paging
+  query_class.new query_hash, {}, paging
 end
 
 def query_hash
@@ -29,7 +29,7 @@ def count
 end
 
 format do
-  delegate :filter_class, to: :card
+  delegate :query_class, to: :card
 
   def search_with_params
     @search_with_params ||= card.search query: query
@@ -40,11 +40,11 @@ format do
   end
 
   def query
-    filter_class.new query_hash, sort_hash, paging_params
+    query_class.new query_hash, sort_hash, paging_params
   end
 
   def count_query
-    filter_class.new query_hash
+    query_class.new query_hash
   end
 
   def query_hash
@@ -89,10 +89,6 @@ format do
     safe_sql_param(:sort_by)&.to_sym || safe_sql_param(:sort)&.to_sym
   end
 
-  def default_limit
-    Auth.signed_in? ? 5000 : 500
-  end
-
   # not a CQL search
   def filter_cql
     {}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: card-mod-lookup
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: '0.4'
 platform: ruby
 authors:
 - Philipp Kühl
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-02 00:00:00.000000000 Z
+date: 2023-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: card
@@ -47,9 +47,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - README.md
-- lib/card/lookup_filter_query.rb
-- lib/card/lookup_filter_query/active_record_extension.rb
-- lib/card/lookup_filter_query/filtering.rb
+- lib/card/lookup_query.rb
+- lib/card/lookup_query/active_record_extension.rb
+- lib/card/lookup_query/filtering.rb
 - lib/lookup_table.rb
 - lib/lookup_table/class_methods.rb
 - set/abstract/lookup.rb
@@ -76,7 +76,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: lookup