card-mod-history 0.18.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a20f2d9eec3fe3db61fd2812e78f4bb8565cda58e0b1fc7a0688c8cb5765109
-  data.tar.gz: 7be6fe76ba77beee613bc340de7177403c98caf3e818d15f8b58a70b4d67fa37
+  metadata.gz: aad29d5ab8235acbae498c0237bebfb3e28f2821d73575a57572a7e40efb10b9
+  data.tar.gz: aa516afaa78b852815f601fdd2acb989a428ad5a14311c057d4c212619cf2984
 SHA512:
-  metadata.gz: cb259274b48f051e5e793142d26efe926eb1fcb66d0204586f8d459c99b0d1307538683ff8936a84969ccbdef56daa8ddf3cc0a9f22e3754de0ded3328878c48
-  data.tar.gz: d1c77b5e3e5db4f7788d1e985986d0fcf4d1caf0005201e66a0ac949b560e059834aac159b71ea6e9806e275121595b696441bbb14d0fab2b0cfe677b36005b6
+  metadata.gz: 752b0801833b06a47a75e7ca99760392b4bdbe1ccdf7235166865024fab8f8ffff42f8b2fbcc1792f4aec2c5510ce3bf6d9275c7e78c9a183541052371217069
+  data.tar.gz: c1ff8ee19037ce71b323e69ba7054fc7d97f0f9ce9108def8745285a24e390ce2fc9b629c247bd57c3ac0e690b396105cb4066df736d78bd9216ef0303ea90d6

data/lib/card/act/act_renderer/relative_act_renderer.rb

@@ -38,7 +38,7 @@ class Card
         end
 
         def current_act?
-          return unless @format.card.last_act && @act
+          return false unless @format.card.last_act && @act
 
           @act.id == @format.card.last_act.id
         end

data/lib/card/act/act_renderer.rb

@@ -1,5 +1,6 @@
 class Card
   class Act
+    # supports rendering act details within ui
     class ActRenderer
       def initialize format, act, args
         @format = format

data/lib/card/action/action_renderer.rb

@@ -1,5 +1,6 @@
 class Card
   class Action
+    # supports rendering action details within ui
     class ActionRenderer
       attr_reader :action, :header
 
@@ -59,6 +60,7 @@ class Card
 
       def name_diff
         return relative_name if @action.card.name.compound?
+
         # TODO: handle compound names better
 
         # if @action.card == @format.card

data/lib/card/action/differ.rb

@@ -76,7 +76,7 @@ class Card
       end
 
       def content_diff_object opts=nil
-        @diff ||= begin
+        @content_diff_object ||= begin
           diff_args = opts || card.include_set_modules.diff_args
           previous_value = previous_value(:content)
           previous = previous_value ? raw_view(previous_value) : ""

data/lib/card/change.rb

@@ -29,7 +29,7 @@ class Card
       # (janitorial)
       def delete_actionless
         joins(
-          "LEFT JOIN card_actions "\
+          "LEFT JOIN card_actions " \
           "ON card_changes.card_action_id = card_actions.id "
         ).where(
           "card_actions.id is null"

data/set/all/history/act_listing.rb

@@ -1,10 +1,15 @@
+ACTION_ICONS = {
+  create: :create_action,
+  update: :update_action,
+  delete: :delete_action,
+  draft: :draft
+}.freeze
+
 format :html do
   def act_from_context
-    if (act_id = params["act_id"])
-      Act.find(act_id) || raise(Card::NotFound, "act not found")
-    else
-      card.last_action.act
-    end
+    return card.last_action.act unless (act_id = params["act_id"])
+
+    Act.find(act_id) || raise(Card::NotFound, "act not found")
   end
 
   # used (by history and recent)for rendering act lists with legend and paging
@@ -30,7 +35,7 @@ format :html do
   # TODO: consider putting all these under one top-level param, eg:
   # act: { seq: X, diff: [show/hide], action_view: Y }
   def act_listing_opts_from_params seq
-    { act_seq: (seq || params["act_seq"]),
+    { act_seq: seq || params["act_seq"],
       action_view: (params["action_view"] || "summary").to_sym,
       hide_diff: params["hide_diff"].to_s.strip == "true" }
   end
@@ -62,7 +67,7 @@ format :html do
   end
 
   def act_list_starting_seq acts
-    acts.size - (acts_page_from_params - 1) * acts_per_page
+    acts.size - ((acts_page_from_params - 1) * acts_per_page)
   end
 
   def acts_per_page
@@ -74,12 +79,7 @@ format :html do
   end
 
   def action_icon action_type, extra_class=nil
-    icon = case action_type
-           when :create then :create_action
-           when :update then :update_action
-           when :delete then :delete_action
-           when :draft then :draft
-           end
+    icon = ACTION_ICONS[action_type]
     icon_tag icon, extra_class
   end
 

data/set/all/history/selected.rb

@@ -66,7 +66,7 @@ private
 def new_content_action_id
   return unless @current_action && current_action_changes_content?
 
-  @current_action.id
+  @current_action.id || (@current_action.save! && @current_action.id)
 end
 
 def current_action_changes_content?
@@ -75,6 +75,7 @@ end
 
 def action_from_id action_id
   return unless action_id.is_a?(Integer) || action_id =~ /^\d+$/
+
   # if not an integer, action_id is probably a mod (e.g. if you request
   # files/:logo/standard.png)
 

data/set/all/history_board.rb

@@ -3,8 +3,8 @@ format :html do
        wrap: { div: { class: "text-muted creator-credit" } }, cache: :never do
     return "" unless card.real?
 
-    "Created by #{nest card.creator, view: :link} "\
-    "#{time_ago_in_words(card.created_at)} ago"
+    "Created by #{nest card.creator, view: :link} " \
+      "#{time_ago_in_words(card.created_at)} ago"
   end
 
   view :updated_by, wrap: { div: { class: "text-muted" } } do

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: card-mod-history
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Ethan McCutchen
 - Philipp Kühl
 - Gerry Gleason
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-31 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: card
@@ -18,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.108.0
+        version: 1.109.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.108.0
+        version: 1.109.0
 description: ''
 email:
 - info@decko.org
@@ -74,7 +73,6 @@ metadata:
   documentation_url: http://docs.decko.org/
   card-mod: history
   card-mod-group: gem-defaults
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -82,15 +80,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.7
-signing_key:
+rubygems_version: 3.6.8
 specification_version: 4
 summary: Revision histories in acts, actions, and changes
 test_files: []