card-mod-follow 0.18.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eebdd4311fc697ea25598f38762c106619a212ce5d5fc58748d0a71ef14374c7
-  data.tar.gz: e56f9ae407213118bc436c86b43af1a04ed5d7e61230d2929292206d3e324810
+  metadata.gz: c907940506e593ebd411755b26203d96a7ba9c40e56970cafa7abdd55abe6cdf
+  data.tar.gz: 54cdb4b39907d2076507bf31d420eae1c3a8af449c515213fe26ae267cca328e
 SHA512:
-  metadata.gz: 4ce8168f22c1210c16e86d5a1335c3cd0b1f95577c11d6845ff119737d23fa0aec3cf480f24f34d41365e7eaccfa97c0995d5a154513e9279dbae7cabfaff76c
-  data.tar.gz: 4a99f5ecdba02e2d5105b92baf68565127784eb1a02654413a377878cafa85514fdd32a0d502af4fe4a364d5471ef57a22603215de0033f8f5e6a4dabbea873a
+  metadata.gz: fbd1e847b0b5ed2f7b23b083a5cc9175f3d41d72d6a0ac7e22b03c6256448f61c4a033fe08a2f2ef1d8152accbd4f6fc2226489a585b6f645b839481f8dc62dd
+  data.tar.gz: a35da2f16c934a4ed2cedf7a31c3a1d5ce96eb6b66bf18a419629487e1fb6bd2f3227c0ccfa43783debe8215d2675e4c54d5c4d3c57a809309746c907ae5e4e8

data/lib/card/follower_stash.rb

@@ -52,7 +52,7 @@ class Card
     end
 
     def nested? card, field
-      return unless field.to_name.key == includes_card_key
+      return false unless field.to_name.key == includes_card_key
 
       @checked.intersection(nestee_set(card)).any?
     end

data/set/all/follow/follow_link.rb

@@ -1,4 +1,6 @@
 #! no set module
+
+# handles links to follow card sets (base class)
 class FollowLink
   attr_reader :format, :rule_content, :link_text, :action, :css_class, :hover_text
 

data/set/all/follow/followed_by.rb

@@ -16,7 +16,7 @@ end
 # returns true if according to the follow_field_rule followers of self also
 # follow changes of field_card
 def followed_field? field_card
-  return unless (follow_field_rule = rule_card(:follow_fields))
+  return false unless (follow_field_rule = rule_card(:follow_fields))
 
   follow_field_rule.item_names(context: self).find do |item|
     case item.to_name.key

data/set/all/follow/start_follow_link.rb

@@ -1,5 +1,6 @@
 #! no set module
 
+# links to begin following card sets
 class StartFollowLink < FollowLink
   def initialize format
     @rule_content = "*always"

data/set/all/follow/stop_follow_link.rb

@@ -1,5 +1,6 @@
 #! no set module
 
+# links to stop following card sets
 class StopFollowLink < FollowLink
   def initialize format
     @rule_content = "*never"

data/set/all/notify/base_views.rb

@@ -1,7 +1,11 @@
+RELEVANT_FIELDS_BY_ACTION = { create: %i[cardtype content],
+                              update: %i[name cardtype content],
+                              delete: %i[content] }.freeze
+
 format do
   view :list_of_changes, denial: :blank, cache: :never do
     action = notification_action voo.action_id
-    relevant_fields(action).map do |type|
+    RELEVANT_FIELDS_BY_ACTION[action.action_type].map do |type|
       edit_info_for(type, action)
     end.compact.join
   end
@@ -50,14 +54,6 @@ format do
                   card: { subcards: { rule_name => :never.cardname } })
   end
 
-  def relevant_fields action
-    case action.action_type
-    when :create then %i[cardtype content]
-    when :update then %i[name cardtype content]
-    when :delete then %i[content]
-    end
-  end
-
   def name_before_action action
     (action.value(:name) && action.previous_value(:name)) || card.name
   end

data/set/right/account.rb

@@ -6,6 +6,12 @@ def send_change_notice act, followed_set, follow_option
   end
 end
 
+def changes_visible? act
+  act.actions_affecting(act.card).any? { |action| action.card.ok? :read }
+end
+
+private
+
 def notify_of_act act
   Auth.as(left.id) do
     Card[:follower_notification_email].deliver(

data/set/right/follow.rb

@@ -44,13 +44,13 @@ def permit action, verb=nil
   if action.in?(%i[create delete update]) && allowed_to_change_follow_status?
     true
   else
-    super action, verb
+    super
   end
 end
 
 def allowed_to_change_follow_status?
-  Auth.signed_in? &&
-    ((user = rule_user) && Auth.current_id == user.id) || Auth.always_ok?
+  (Auth.signed_in? &&
+    ((user = rule_user) && Auth.current_id == user.id)) || Auth.always_ok?
 end
 
 format :html do

data/set/type_plus_right/user/follow/follow_editor_helper.rb

@@ -8,7 +8,7 @@ format :html do
     rule_opt_array = following_rule_options_hash.map do |key, val|
       [(Card.fetch key, new: {}), val]
     end
-    rules_and_options_by_set_pattern Hash[rule_opt_array], &block
+    rules_and_options_by_set_pattern rule_opt_array.to_h, &block
   end
 
   # constructs hash of rules/options for "Ignore" tab
@@ -25,7 +25,7 @@ format :html do
   def ignore_rules
     never = :never.cardname.key
     card.item_cards.select do |follow_rule|
-      follow_rule.item_names.select { |n| n.key == never }.any?
+      follow_rule.item_names.any? { |n| n.key == never }
     end
   end
 

data/set/type_plus_right/user/follow.rb

@@ -56,7 +56,7 @@ format :html do
 
   def pointer_items args
     voo.items[:view] ||= :link
-    super(args)
+    super
   end
 
   # TODO: research and generalize

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: card-mod-follow
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Ethan McCutchen
 - Philipp Kühl
 - Gerry Gleason
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-31 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: card
@@ -18,28 +17,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.108.0
+        version: 1.109.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.108.0
+        version: 1.109.0
 - !ruby/object:Gem::Dependency
   name: card-mod-carrierwave
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.18.0
+        version: 0.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.18.0
+        version: 0.19.0
 description: ''
 email:
 - info@decko.org
@@ -52,7 +51,7 @@ files:
 - assets/script/follow.js.coffee
 - assets/style/follow.scss
 - config/admin.yml
-- data/files/mod_follow_script_asset_output/file.js
+- data/files/mod_follow/script/asset_output/file.js
 - data/real.yml
 - data/test.yml
 - data/test/rules.yml
@@ -105,7 +104,6 @@ metadata:
   documentation_url: http://docs.decko.org/
   card-mod: follow
   card-mod-group: gem-defaults
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -113,15 +111,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.7
-signing_key:
+rubygems_version: 3.6.8
 specification_version: 4
 summary: follower notifications
 test_files: []