card-mod-edit 0.11.0 → 0.11.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7c1aadcdae71b37abafb105dd2d635ba8d06ca6b2f20793707744041d2fec7d
-  data.tar.gz: '01279e5c1dabf13847d565f9d2a41f20fc904d312b3a335b7ce2faff9455a7cc'
+  metadata.gz: 4a54a9e3aa482aa83ddee3fbca1e2a2ffbbb733124cf681aab56a159e6a943e2
+  data.tar.gz: 7a719d423cb25de68e1974e4d73c87c6719398d0b7e1bb1d787256f93330d6a9
 SHA512:
-  metadata.gz: '098b0b886b4dab71ac825eac10506eba393452b8f63855f14b9d05a36fb992d1ea93aba9aba5ffa246e80036d4a9a9ba6c615218b74ccb1ac6781fac4870e0e0'
-  data.tar.gz: 59f19e636b580403d624a2510b072c5a7e6951c240b77e644f33de46051ead1119eb31d135ef6c62e9a47e76e9f312619e5727e2724203b2f53b63f1bef020f7
+  metadata.gz: 9c879f60df6bce6723ba0d1d05f2dc423594a5ca02d661640d3d708ab8f66f00dc2b4ca05768166c1fcee10fdb304023ceb4cd6c3f1000159990f290fa7dacc8
+  data.tar.gz: 691b4cff469c27bc9d5e0d64e61074a7b709a00701ff9fce21c0705454407b3ae606b3fefe673991a0c9e564640fd524bdca85087d68e1f7155cd1614b2eef39

data/set/all/bridge.rb

@@ -1,9 +1,9 @@
 BRIDGE_TABS = { "Account" => :account_tab,
-                "Guide"   => :guide_tab,
-                "Engage"  => :engage_tab,
+                "Guide" => :guide_tab,
+                "Engage" => :engage_tab,
                 "History" => :history_tab,
                 "Related" => :related_tab,
-                "Rules"   => :rules_tab }.freeze
+                "Rules" => :rules_tab }.freeze
 
 format :html do
   wrapper :bridge do

data/set/all/bridge/related_section.rb

@@ -17,7 +17,7 @@ format :html do
 
   def related_by_name_items
     pills = []
-    if card.name.junction?
+    if card.name.compound?
       pills += card.name.ancestors.map { |a| [a, a, { mark: :absolute }] }
     end
     pills += RELATED_ITEMS["by name"]
@@ -29,6 +29,6 @@ format :html do
   end
 
   def related_by_type_items
-    [["#{card.type} cards", [card.type, :type, :by_name], mark: :absolute]]
+    [["#{card.type} cards", [card.type, :type, :by_name], { mark: :absolute }]]
   end
 end

data/set/all/bridge/tab_visibility.rb

@@ -34,15 +34,13 @@ format :html do
   end
 
   def show_discussion?
-    d_card = discussion_card
-    return unless d_card
+    return unless (d_card = discussion_card)
 
-    permission_task = d_card.new_card? ? :update : :read
-    d_card.ok? permission_task
+    d_card.ok? discussion_permission_task(d_card)
   end
 
   def discussion_card?
-    card.junction? && card.name.tag_name.key == :discussion.cardname.key
+    card.compound? && card.name.tag_name.key == :discussion.cardname.key
   end
 
   def discussion_card
@@ -50,4 +48,11 @@ format :html do
 
     card.fetch :discussion, skip_modules: true, new: {}
   end
+
+  private
+
+  def discussion_permission_task d_card=nil
+    d_card ||= discussion_card
+    d_card.new_card? ? :update : :read
+  end
 end

data/set/all/edit_name.rb

@@ -1,58 +1,56 @@
 format :html do
-  # note: depends on js with selector ".edit_name-view .card-form"
   view :edit_name, perms: :update do
     frame { name_form }
   end
 
-  # note: depends on js with selector ".name_form-view .card-form"
   view :name_form, perms: :update, wrap: :slot, cache: :never do
     name_form :edit_name_row
   end
 
   def name_form success_view=nil
     card_form({ action: :update, id: card.id },
-              # "main-success" => "REDIRECT",
+              "data-main-success": JSON(redirect: true, view: ""),
               "data-update-origin": "true",
+              class: "_rename-form",
               success: edit_name_success(success_view)) do
-      [hidden_edit_name_fields,
+      [edit_name_hidden_fields,
        _render_name_formgroup,
-       rename_confirmation_alert,
+       edit_name_confirmation,
        edit_name_buttons]
     end
   end
 
   def edit_name_success view=nil
-    success = { id: "_self" }
+    success = { name: "_self", redirect: "" }
     success[:view] = view if view
     success
   end
 
-  def hidden_edit_name_fields
+  def edit_name_hidden_fields
     hidden_tags old_name: card.name, card: { update_referers: false }
   end
 
   def edit_name_buttons
+    class_up "button-form-group", "rename-button-form-group"
     button_formgroup do
       [rename_and_update_button, rename_button, standard_cancel_button]
     end
   end
 
-  # LOCALIZE
-  def rename_and_update_button
-    submit_button text: "Rename and Update", disable_with: "Renaming",
-                  class: "renamer-updater"
+  def edit_name_confirmation
+    alert "warning", false, false, class: "hidden-alert" do
+      haml :edit_name_confirmation, referer_count: card.references_in.count
+    end
   end
 
-  def rename_button
-    button_tag "Rename", data: { disable_with: "Renaming" }, class: "renamer"
+  def rename_and_update_button
+    submit_button text: t(:core_rename_and_update),
+                  disable_with: t(:core_renaming),
+                  class: "_renamer-updater"
   end
 
-  # LOCALIZE
-  def rename_confirmation_alert
-    msg = "<h5>Are you sure you want to rename <em>#{safe_name}</em>?</h5>"
-    msg << %(<h6>This may change names referred to by other cards.</h6>)
-    msg << %(<p>You may choose to <em>update or ignore</em> the referers.</p>)
-    msg << hidden_field_tag(:referers, 1)
-    alert("warning", false, false, class: "hidden-alert") { msg }
+  def rename_button
+    button_tag t(:core_rename),
+               class: "renamer", data: { disable_with: t(:core_renaming) }
   end
 end

data/set/all/edit_name_confirmation.haml

@@ -0,0 +1,7 @@
+%h5
+  = t :core_rename_confirm
+  %em
+    = safe_name
+  ?
+%p._rename-reference-confirm{ data: { referer_count: referer_count } }
+  = t :core_rename_reference_confirm, count: referer_count

data/set/all/edit_type.rb

@@ -42,60 +42,79 @@ format :html do
     end
   end
 
+  def type_field args={}
+    @no_current_type = args.delete :no_current_type # just a test artifact?
+    action_view.select_tag "card[type]", type_field_options,
+                           args.merge("data-select2-id": "#{unique_id}-#{Time.now.to_i}")
+  end
+
+  private
+
+  def raw_type_options
+    return @raw_type_options if @raw_type_options
+
+    options = Auth.createable_types
+    if !@no_current_type && card.real? && !options.include?(card.type_name)
+      # current type should be an option on existing cards,
+      # regardless of create perms
+      options.push(card.type_name).sort!
+    end
+    @raw_type_options = ::Set.new options
+  end
+
   def wrap_type_formgroup
     formgroup "Type", input: "type", class: "type-formgroup", help: false do
       output [yield, hidden_field_tag(:assign, true)]
     end
   end
 
-  def type_field args={}
-    typelist = Auth.createable_types
-    current_type = type_field_current_value args, typelist
-    action_view.select_tag "card[type]", type_field_options(current_type),
-                           args.merge("data-select2-id": "#{unique_id}-#{Time.now.to_i}")
+  def type_field_options
+    if grouped_types.size == 1
+      simple_type_field_options
+    else
+      multi_type_field_options
+    end
   end
 
-  def type_field_options current_type
-    types = grouped_types(current_type)
+  def simple_type_field_options
+    options_for_select grouped_types.flatten[1], current_type_value
+  end
 
-    if types.size == 1
-      options_for_select types.flatten[1], current_type
-    else
-      grouped_options_for_select types, current_type
-    end
+  def multi_type_field_options
+    grouped_options_for_select grouped_types, current_type_value
+  end
+
+  def current_type_value
+    return if @no_current_type
+
+    @current_type_value ||= card.type_name_or_default
   end
 
-  def grouped_types current_type
+  def grouped_types
     groups = Hash.new { |h, k| h[k] = [] }
-    allowed = ::Set.new Auth.createable_types
-    allowed << current_type if current_type
 
-    visible_cardtype_groups.each_pair do |name, items|
+    visible_cardtype_groups.each_pair.with_object(groups) do |(name, items), grps|
       if name == "Custom"
-        Auth.createable_types.each do |type|
-          groups["Custom"] << type unless ::Card::Set::Self::Cardtype::GROUP_MAP[type]
-        end
+        custom_grouped_types grps
       else
-        items.each do |i|
-          groups[name] << i if allowed.include?(i)
-        end
+        standard_grouped_types grps, name, items
       end
     end
-    groups
   end
 
-  def visible_cardtype_groups
-    ::Card::Set::Self::Cardtype::GROUP
+  def custom_grouped_types groups
+    Auth.createable_types.each do |type|
+      groups["Custom"] << type unless ::Card::Set::Self::Cardtype::GROUP_MAP[type]
+    end
   end
 
-  def type_field_current_value args, typelist
-    return if args.delete :no_current_type
-
-    if !card.new_card? && !typelist.include?(card.type_name)
-      # current type should be an option on existing cards,
-      # regardless of create perms
-      typelist.push(card.type_name).sort!
+  def standard_grouped_types groups, name, items
+    items.each do |i|
+      groups[name] << i if raw_type_options.include?(i)
     end
-    card.type_name_or_default
+  end
+
+  def visible_cardtype_groups
+    ::Card::Set::Self::Cardtype::GROUP
   end
 end

data/set/all/editor.rb

@@ -1,4 +1,3 @@
-
 Self::InputOptions.add_to_basket :options, "text area"
 Self::InputOptions.add_to_basket :options, "text field"
 
@@ -24,9 +23,8 @@ format :html do
 
   # move somewhere more accessible?
   def with_card mark
-    return nil unless (card = Card[mark])
-
-    yield card
+    card = Card[mark]
+    yield card if card
   rescue Card::Error::CodenameNotFound
     nil
   end
@@ -47,7 +45,7 @@ format :html do
 
   def text_area_input
     text_area :content, rows: 5, class: "d0-card-content",
-                        "data-card-type-code" => card.type_code
+                        "data-card-type-code": card.type_code
   end
 
   def text_field_input

data/set/all/form.rb

@@ -30,15 +30,13 @@ format :html do
     hidden_field :last_action_id_before_edit, class: "current_revision_id"
   end
 
-  def wrap_content_formgroup
+  def wrap_content_formgroup &block
     formgroup("Content", input: :content, help: false,
-                         class: classy("card-editor")) { yield }
+                         class: classy("card-editor"), &block)
   end
 
-  def button_formgroup
-    wrap_with :div, class: classy("form-group") do
-      wrap_with :div, yield
-    end
+  def button_formgroup &block
+    wrap_with :div, class: "form-group #{classy 'button-form-group'}", &block
   end
 
   def name_field
@@ -214,9 +212,16 @@ format :html do
     add_class opts, "card-form"
     add_class opts, "slotter" unless opts[:redirect] || opts[:no_slotter]
     add_class opts, "autosave" if action == :update
+    interpret_main_success_opts opts
     opts
   end
 
+  def interpret_main_success_opts opts
+    return unless (hash = opts.delete :main_success)
+
+    opts["data-main-success"] = JSON hash
+  end
+
   def card_form_url_and_action action
     case action
     when Symbol then [path(action: action), action]
@@ -227,18 +232,16 @@ format :html do
     end
   end
 
-  def editor_wrap type=nil
+  def editor_wrap type=nil, &block
     html_class = "editor"
     html_class << " #{type}-editor" if type
-    wrap_with :div, class: html_class do
-      yield
-    end
+    wrap_with :div, class: html_class, &block
   end
 
   # FIELD VIEWS
 
   def add_junction_class
-    return unless card.name.junction?
+    return unless card.name.compound?
 
     class_up "card-editor", "RIGHT-#{card.name.tag_name.safe_key}"
   end

data/set/all/form_buttons.rb

@@ -5,6 +5,7 @@ format :html do
 
   def standard_save_button opts={}
     return if voo&.hide?(:save_button)
+
     add_class opts, "submit-button btn-sm mr-3 _update-history-pills"
     opts[:text] ||= "Save"
     opts["data-cy"] = "save"
@@ -42,6 +43,8 @@ format :html do
   end
 
   def delete_button opts={}
+    return unless card.real?
+
     link_to "Delete", delete_button_opts(opts)
   end
 
@@ -49,7 +52,7 @@ format :html do
     add_class opts,  "slotter btn btn-outline-danger ml-auto btn-sm"
     opts["data-confirm"] = delete_confirm opts
     opts[:path] = { action: :delete }
-    opts[:path][:success] = delete_success(opts) unless opts.delete(:no_success)
+    opts[:path][:success] = delete_success(opts)
     opts[:remote] = true
     opts
   end
@@ -59,6 +62,12 @@ format :html do
   end
 
   def delete_success opts
-    opts.delete(:success) || (main? ? "REDIRECT: *previous" : { view: :just_deleted })
+    if opts[:success]
+      opts.delete :success
+    elsif main?
+      { redirect: true, mark: "*previous" }
+    else
+      { view: :just_deleted }
+    end
   end
 end

data/set/all/form_elements.rb

@@ -52,6 +52,7 @@ format :html do
   # redirect to *previous if no :href is given
   def cancel_button args={}
     return unless voo.show? :cancel_button
+
     text = args.delete(:text) || "Cancel"
     add_class args, "btn btn-#{args.delete(:situation) || 'secondary'}"
     add_class args, cancel_strategy(args[:redirect], args[:href])

data/set/all/new.rb

@@ -75,7 +75,7 @@ format :html do
   end
 
   def new_form_opts
-    { "main-success" => "REDIRECT" }
+    { "data-main-success": JSON(redirect: true) }
   end
 
   def new_view_title
@@ -90,7 +90,7 @@ format :html do
   end
 
   def new_success
-    card.rule(:thanks) || "_self"
+    { mark: (card.rule(:thanks) || "_self") }
   end
 
   def new_in_modal_success; end

data/set/all/template_nest.rb

@@ -39,4 +39,4 @@ format do
 
     tmpl_set_name.left_name
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: card-mod-edit
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.5
 platform: ruby
 authors:
 - Ethan McCutchen
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-24 00:00:00.000000000 Z
+date: 2021-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: card
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.101.0
+        version: 1.101.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.101.0
+        version: 1.101.5
 description: ''
 email:
 - info@decko.org
@@ -43,6 +43,7 @@ files:
 - set/all/edit_content.rb
 - set/all/edit_inline.rb
 - set/all/edit_name.rb
+- set/all/edit_name_confirmation.haml
 - set/all/edit_type.rb
 - set/all/editing.rb
 - set/all/editor.rb
@@ -59,10 +60,15 @@ files:
 - set/type/list.rb
 - set/type/plain_text.rb
 - set/type/pointer.rb
-homepage: http://decko.org
+homepage: https://decko.org
 licenses:
 - GPL-3.0
 metadata:
+  source_code_uri: https://github.com/decko-commons/decko
+  homepage_uri: https://decko.org
+  bug_tracker_uri: https://github.com/decko-commons/decko/issues
+  wiki_uri: https://decko.org
+  documentation_url: http://docs.decko.org/
   card-mod: edit
 post_install_message:
 rdoc_options: []
@@ -79,7 +85,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Edit handling