capybara_error_intel 1.0.2 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ebab2dc2cf570ed1a3c8a6e578cd2eaa309f21f5
-  data.tar.gz: 5732238ef77ad3b3a90c9a5386425549fc8b2ac2
+SHA256:
+  metadata.gz: 90940dfb41a47dfa93a86282cefe1c87189c9ea73053e1db884575597bcc4751
+  data.tar.gz: bec5f80170054c4bf50e34db6c86b3da7dff102f21f19fac442b7d099fea32bc
 SHA512:
-  metadata.gz: e0b827c5919d385a41de269a980ac11b5f2f331751ceb26cf179f2d672648221c462f9482cbb9b9a699d280c30f1b760779fdd6c4397c2d945c63bfcfa772d95
-  data.tar.gz: 5c10884e7d213d895b2c4573e35812502ae5c2014fe9108e869d7ba5a50c987963aa17d731b1fa3dfeeb09a2fca52915f78e2a020d5831810ac753c64c9e1d79
+  metadata.gz: 4ca83fca2fab6a4c9b0ac762dbb3033d6c56526f3ec5d4f62f57cce747dd5911f063fc3e01e66b1256aa87cf5523ee862cd079a1148943d9e8c27a322690b2b1
+  data.tar.gz: b820708110e40f20c9c52ba1730b8ddb5d5d0537d97e9eca8d03c7d48203eb63d85ce561134859adbe9b5b043fccd5d138961f4d4464cd19957caa7773fc28e9

data/.rubocop.yml

@@ -6,4 +6,6 @@ AllCops:
   Exclude:
     - '*.gemspec'
     - 'vendor/**/*'
-
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/**'

data/.travis.yml

@@ -1,10 +1,10 @@
 sudo: false
 language: ruby
 rvm:
+  - 3.0.0
+  - 2.6.3
   - 2.3.1
-  - 2.2.0
-  - 2.1.0
-before_install: gem install bundler -v 1.12.5
+before_install: gem install bundler
 addons:
     code_climate:
         repo_token: d11a38ad79ee8bc4d2972305aeaf999e0de48508813f76ba0ec991842dafc45f

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+# v2.0.0
+
+- Ruby 3.x support (thanks @hasghari)
+
+# v1.1.1
+
+- Support capybara 3.14 module rename (thanks @tmock12) [Read More](https://github.com/dkarter/capybara_error_intel/pull/6)
+
+# v1.1.0
+
+- Allow Capybara 3.x, update spec for proper error text (thanks @geoffharcourt)

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in CapybaraErrorIntel.gemspec

data/README.md

@@ -1,6 +1,6 @@
 ![CapybaraErrorIntel](img/CapybaraErrorIntel.png)
 
-[![Build Status](https://travis-ci.org/dkarter/capybara_error_intel.svg?branch=master)](https://travis-ci.org/dkarter/capybara_error_intel) [![Code Climate](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/gpa.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel) [![Test Coverage](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/coverage.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel/coverage) [![Issue Count](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/issue_count.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel)
+[![Build Status](https://travis-ci.org/dkarter/capybara_error_intel.svg?branch=master)](https://travis-ci.org/dkarter/capybara_error_intel) [![Code Climate](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/gpa.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel) [![Test Coverage](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/coverage.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel/coverage) [![Issue Count](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/issue_count.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel) [![Gem Version](https://badge.fury.io/rb/capybara_error_intel.svg)](https://badge.fury.io/rb/capybara_error_intel) ![downloads counter](http://ruby-gem-downloads-badge.herokuapp.com/capybara_error_intel)
 
 Capybara provides excellent error messages for its built in predicate methods: `has_selector?`, `has_text?`, `has_title?` etc., but when those are used from Page Objects while exposing predicate methods from the PageObjects themselves the error messages are lost and all we get is `expected true, got false`.  Including this module into your PageObject by adding `include CapybaraErrorIntel::DSL` after `include Capybara::DSL` will return the heuristic error messages.
 
@@ -79,6 +79,38 @@ end
   It should be rather trivial to add more of them. Please open an issue or submit a pull request if something you need is missing.
 
 
+### Accessing original predicate methods from your Page Object
+
+If you ever need to access the overwritten Capybara predicate methods you can do
+so by using Capybara's `page` for example:
+
+
+```ruby
+module Pages
+  class PostIndex
+    include Capybara::DSL
+    include CapybaraErrorIntel::DSL
+
+    def has_header?(header_text)
+      page.has_selector?('h1', text: header_text)
+    end
+  end
+end
+
+```
+
+This will allow you to have negative assertions. That being said I strongly
+discourage the use of negative assertions, especially with waiting Capybara
+methods such as `has_selector?` since they can make your test suite really slow.
+
+```ruby
+expect(post_index_page).to_not have_header('POSTS')
+```
+
+> Note: I'm considering changing CapybaraErrorIntel for v2 to expose the
+> predicate methods as bang methods, both positive and negative e.g.
+> `has_selector!` and `has_no_selector!`. Please share your thoughts in the
+> issues section.
 
 ## Development
 
@@ -86,6 +118,13 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+## Releasing a New Version
+0. Add a version header to the top of CHANGELOG.md and list all changes as
+   bullets below the new version number
+1. Change the version number in `lib/capybara_error_intel/version.rb`
+2. In the project's directory run `gem build capybara_error_intel.gemspec`
+3. Push the gem to RubyGems `gem push capybara_error_intel-##VERSION##.gem`
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at
@@ -94,8 +133,6 @@ https://github.com/dkarter/capybara_error_intel
 Please make sure the test suite passes and that you added tests for any new
 method implemented.
 
-
-
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'
@@ -5,4 +7,4 @@ require 'rubocop/rake_task'
 RuboCop::RakeTask.new
 RSpec::Core::RakeTask.new(:spec)
 
-task default: [:spec, :rubocop]
+task default: %i[spec rubocop]

data/bin/console

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+# frozen_string_literal: true
+
 require 'bundler/setup'
 require 'capybara_error_intel'
 

data/capybara_error_intel.gemspec

@@ -26,19 +26,19 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.12'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'sinatra', '~> 1.4', '>= 1.4.7'
   spec.add_development_dependency 'launchy', '~> 0'
   spec.add_development_dependency 'rack', '~> 1.6', '>= 1.6.4'
   spec.add_development_dependency 'rack-test', '~> 0.5', '>= 0.5.4'
+  spec.add_development_dependency 'codeclimate-test-reporter', '~> 1.0.0'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'pry-byebug'
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'cadre'
   spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'codeclimate-test-reporter'
 
   spec.add_runtime_dependency 'rspec', '>= 2.1', '< 4.x'
-  spec.add_runtime_dependency 'capybara', '~> 2'
+  spec.add_runtime_dependency 'capybara', '>= 2.0', '< 4.x'
 end

data/lib/capybara_error_intel/dsl.rb

@@ -1,66 +1,76 @@
+# frozen_string_literal: true
+
 module CapybaraErrorIntel
   # Wraps Capybara::DSL
   module DSL
-    def has_selector?(*args)
-      matcher = has_selector(*args)
+    def has_selector?(*args, **kwargs)
+      matcher = has_selector(*args, **kwargs)
       match_or_error(matcher)
     end
 
-    def has_css?(css, options = {})
-      has_selector?(:css, css, options)
+    def has_css?(css, **options)
+      has_selector?(:css, css, **options)
     end
 
-    def has_button?(locator, options = {})
-      has_selector?(:button, locator, options)
+    def has_button?(locator, **options)
+      has_selector?(:button, locator, **options)
     end
 
-    def has_field?(locator, options = {})
-      has_selector?(:field, locator, options)
+    def has_field?(locator, **options)
+      has_selector?(:field, locator, **options)
     end
 
-    def has_xpath?(_xpath, options = {})
-      has_selector?(:xpath, locator, options)
+    def has_xpath?(_xpath, **options)
+      has_selector?(:xpath, locator, **options)
     end
 
-    def has_checked_field?(locator, options = {})
-      has_selector?(:field, locator, options.merge(checked: true))
+    def has_checked_field?(locator, **options)
+      has_selector?(:field, locator, **options.merge(checked: true))
     end
 
-    def has_unchecked_field?(locator, options = {})
-      has_selector?(:field, locator, options.merge(unchecked: true))
+    def has_unchecked_field?(locator, **options)
+      has_selector?(:field, locator, **options.merge(unchecked: true))
     end
 
-    def has_select?(locator, options = {})
-      has_selector?(:select, locator, options)
+    def has_select?(locator, **options)
+      has_selector?(:select, locator, **options)
     end
 
-    def has_table?(locator, options = {})
-      has_selector?(:table, locator, options)
+    def has_table?(locator, **options)
+      has_selector?(:table, locator, **options)
     end
 
-    def has_text?(*args)
-      matcher = has_text(*args)
+    def has_text?(*args, **kwargs)
+      matcher = has_text(*args, **kwargs)
       match_or_error(matcher)
     end
     alias has_content? has_text?
 
-    def has_title?(title, options = {})
-      matcher = has_title(title, options)
+    def has_title?(title, **options)
+      matcher = has_title(title, **options)
       match_or_error(matcher)
     end
 
     private
 
-    def has_selector(*args)
-      Capybara::RSpecMatchers::HaveSelector.new(*args)
+    def has_selector(*args, **kwargs)
+      capybara_matcher_module::HaveSelector.new(*args, **kwargs)
+    end
+
+    def has_text(*args, **kwargs)
+      capybara_matcher_module::HaveText.new(*args, **kwargs)
     end
 
-    def has_text(*args)
-      Capybara::RSpecMatchers::HaveText.new(*args)
+    def has_title(title, **options)
+      capybara_matcher_module::HaveTitle.new(title, **options)
     end
 
-    def has_title(title, options)
-      Capybara::RSpecMatchers::HaveTitle.new(title, options)
+    def capybara_matcher_module
+      if Capybara::VERSION.to_f >= 3.14
+        Capybara::RSpecMatchers::Matchers
+      else
+        Capybara::RSpecMatchers
+      end
     end
 
     def match_or_error(matcher)

data/lib/capybara_error_intel/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CapybaraErrorIntel
-  VERSION = '1.0.2'.freeze
+  VERSION = '2.0.0'
 end

data/lib/capybara_error_intel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'capybara_error_intel/version'
 require 'capybara_error_intel/dsl'
 require 'capybara'

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: capybara_error_intel
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 2.0.0
 platform: ruby
 authors:
 - Dorian Karter
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-10-28 00:00:00.000000000 Z
+date: 2022-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -113,21 +113,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.5.4
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -141,7 +141,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -155,7 +155,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: cadre
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -169,7 +169,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: cadre
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -183,7 +183,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -220,16 +220,22 @@ dependencies:
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 4.x
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: 4.x
 description: |-
   Capybara provides excellent error messages for its
                             built in predicate methods: has_selector?, has_text?,
@@ -252,6 +258,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -269,7 +276,7 @@ homepage: https://github.com/dkarter/capybara_error_intel
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -284,9 +291,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Provides Capybara's heuristic error messages for Page Objects
 test_files: []