capybara_error_intel 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5862341b63629cf16f8b3339b62789c905b61170
-  data.tar.gz: b9472f2a9161625dbea7f8596fa49dc074ba8108
+  metadata.gz: 81b194d9c5e7129751a873fa127b42a9bdc0a4a7
+  data.tar.gz: aa716d7326530d1bb0e7ba5ff46b2f20ec1e6543
 SHA512:
-  metadata.gz: 33d204d510b83490e5fff56da2b4018c79fb6f031ff8eedfe6195ec60b995b5a6672f6009a480df95d3497e063795fbe66e2fdfffd0cdc66f7e2a87597f833e8
-  data.tar.gz: 332f5782bf6eac411f4b6a01ff76159d8e97e0b89ef930809053113a5728a6b8c6a4170bb15a573658c2eb5f6f450b2cfc1a6796f51778a8ce6d5a8eb4aeb715
+  metadata.gz: 47c67c1c8c075df865c9f74a74f781240bd3d6a490dac915361210f55a0c4448d043c5699164d298a5d9504d12903054098003549b7274a5ca77d4d9aad279a7
+  data.tar.gz: 56645910801df9e620c9fd926fba6d26065fbedc8f426c7385204c4e5db8a7d5b6f45f652110fb5c698195e0ffef2ed922b8c3b20da466ba92bab55767fb875e

data/.codeclimate.yml

@@ -0,0 +1,16 @@
+---
+engines:
+  duplication:
+    enabled: true
+    config:
+      languages:
+      - ruby
+  fixme:
+    enabled: true
+  rubocop:
+    enabled: true
+ratings:
+  paths:
+  - "**.rb"
+exclude_paths:
+- spec/

data/.gitignore

@@ -9,3 +9,4 @@
 /tmp/
 /vendor/bundle
 *.gem
+.cadre

data/.rubocop.yml

@@ -0,0 +1,9 @@
+Metrics/LineLength:
+  Max: 999
+Style/PredicateName:
+  Enabled: false
+AllCops:
+  Exclude:
+    - '*.gemspec'
+    - 'vendor/**/*'
+

data/.travis.yml

@@ -3,4 +3,8 @@ language: ruby
 rvm:
   - 2.3.1
   - 2.2.0
+  - 2.1.0
 before_install: gem install bundler -v 1.12.5
+addons:
+    code_climate:
+        repo_token: d11a38ad79ee8bc4d2972305aeaf999e0de48508813f76ba0ec991842dafc45f

data/README.md

@@ -1,8 +1,8 @@
 ![CapybaraErrorIntel](img/CapybaraErrorIntel.png)
 
-[![Build Status](https://travis-ci.org/dkarter/capybara_error_intel.svg?branch=master)](https://travis-ci.org/dkarter/capybara_error_intel)
+[![Build Status](https://travis-ci.org/dkarter/capybara_error_intel.svg?branch=master)](https://travis-ci.org/dkarter/capybara_error_intel) [![Code Climate](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/gpa.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel) [![Test Coverage](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/coverage.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel/coverage) [![Issue Count](https://codeclimate.com/github/dkarter/capybara_error_intel/badges/issue_count.svg)](https://codeclimate.com/github/dkarter/capybara_error_intel)
 
-Capybara provides excellent error messages for its built in predicate methods: `has_selector?`, `has_text?`, and `has_title?` but when those are used from Page Objects while exposing predicate methods from the PageObjects themselves the error messages are lost and all we get is `expected true, got false`.  Including this module into your PageObject by adding `include CapybaraErrorIntel::DSL` after `include Capybara::DSL` will return the heuristic error messages.
+Capybara provides excellent error messages for its built in predicate methods: `has_selector?`, `has_text?`, `has_title?` etc., but when those are used from Page Objects while exposing predicate methods from the PageObjects themselves the error messages are lost and all we get is `expected true, got false`.  Including this module into your PageObject by adding `include CapybaraErrorIntel::DSL` after `include Capybara::DSL` will return the heuristic error messages.
 
 ## Example
 
@@ -76,9 +76,7 @@ end
   - `has_table?(locator, options={})`
 
 
-  It should be rather trivial to add more of them like `has_css` etc. I will try
-  to implement the rest in the near future but feel free to submit a pull
-  request.
+  It should be rather trivial to add more of them. Please open an issue or submit a pull request if something you need is missing.
 
 
 

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
+RuboCop::RakeTask.new
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: [:spec, :rubocop]

data/bin/console

@@ -1,12 +1,11 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "capybara_error_intel"
+require 'bundler/setup'
+require 'capybara_error_intel'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
 # (If you use this, don't forget to add pry to your Gemfile!)
-require "pry"
+require 'pry'
 Pry.start
-

data/capybara_error_intel.gemspec

@@ -9,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Dorian Karter']
   spec.email         = ['jobs@doriankarter.com']
 
-  spec.summary       = %q{Provides Capybara's heuristic error messages for Page Objects}
-  spec.description   = %q{Capybara provides excellent error messages for its
+  spec.summary       = 'Provides Capybara\'s heuristic error messages for Page Objects'
+  spec.description   = 'Capybara provides excellent error messages for its
                           built in predicate methods: has_selector?, has_text?,
                           has_title? etc.. but when those are used from Page
                           Objects while exposing predicate methods from the
@@ -19,12 +19,12 @@ Gem::Specification.new do |spec|
                           Including this module into your PageObject by adding
                           "include CapybaraErrorIntel::DSL" after
                           "include Capybara::DSL" will return the heuristic
-                          error messages.}
+                          error messages.'
   spec.homepage      = 'https://github.com/dkarter/capybara_error_intel'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.12'
   spec.add_development_dependency 'rake', '~> 10.0'
@@ -32,9 +32,13 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'launchy', '~> 0'
   spec.add_development_dependency 'rack', '~> 1.6', '>= 1.6.4'
   spec.add_development_dependency 'rack-test', '~> 0.5', '>= 0.5.4'
-  spec.add_development_dependency 'pry', '~> 0.10'
-  spec.add_development_dependency 'pry-byebug', '~> 3.4'
+  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'pry-byebug'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'cadre'
+  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'codeclimate-test-reporter'
 
-  spec.add_runtime_dependency 'rspec', '~> 2.1'
+  spec.add_runtime_dependency 'rspec', '~> 2'
   spec.add_runtime_dependency 'capybara', '~> 2'
 end

data/lib/capybara_error_intel.rb

@@ -5,6 +5,9 @@ require 'capybara/dsl'
 require 'capybara/rspec/matchers'
 require 'rspec'
 
+# Provides Capybara::DSL predicate method wrappers that fail the test with heuristic
+# Capybara errors when the result is `false`. Particularly useful when used
+# inside page objects, allowing the user to expose predicate methods of their
+# own.
 module CapybaraErrorIntel
-
 end

data/lib/capybara_error_intel/dsl.rb

@@ -1,39 +1,40 @@
 module CapybaraErrorIntel
+  # Wraps Capybara::DSL
   module DSL
     def has_selector?(*args)
       matcher = has_selector(*args)
       match_or_error(matcher)
     end
 
-    def has_css?(css, options={})
+    def has_css?(css, options = {})
       has_selector?(:css, css, options)
     end
 
-    def has_button?(locator, options={})
+    def has_button?(locator, options = {})
       has_selector?(:button, locator, options)
     end
 
-    def has_field?(locator, options={})
+    def has_field?(locator, options = {})
       has_selector?(:field, locator, options)
     end
 
-    def has_xpath?(xpath, options={})
+    def has_xpath?(_xpath, options = {})
       has_selector?(:xpath, locator, options)
     end
 
-    def has_checked_field?(locator, options={})
-      has_selector?(:field, locator, options.merge(:checked => true))
+    def has_checked_field?(locator, options = {})
+      has_selector?(:field, locator, options.merge(checked: true))
     end
 
-    def has_unchecked_field?(locator, options={})
-      has_selector?(:field, locator, options.merge(:unchecked => true))
+    def has_unchecked_field?(locator, options = {})
+      has_selector?(:field, locator, options.merge(unchecked: true))
     end
 
-    def has_select?(locator, options={})
+    def has_select?(locator, options = {})
       has_selector?(:select, locator, options)
     end
 
-    def has_table?(locator, options={})
+    def has_table?(locator, options = {})
       has_selector?(:table, locator, options)
     end
 
@@ -41,7 +42,7 @@ module CapybaraErrorIntel
       matcher = has_text(*args)
       match_or_error(matcher)
     end
-    alias_method :has_content?, :has_text?
+    alias has_content? has_text?
 
     def has_title?(title, options = {})
       matcher = has_title(title, options)
@@ -50,30 +51,30 @@ module CapybaraErrorIntel
 
     private
 
-      def has_selector(*args)
-        Capybara::RSpecMatchers::HaveSelector.new(*args)
-      end
+    def has_selector(*args)
+      Capybara::RSpecMatchers::HaveSelector.new(*args)
+    end
 
-      def has_text(*args)
-        Capybara::RSpecMatchers::HaveText.new(*args)
-      end
+    def has_text(*args)
+      Capybara::RSpecMatchers::HaveText.new(*args)
+    end
 
-      def has_title(title, options)
-        Capybara::RSpecMatchers::HaveTitle.new(title, options)
-      end
+    def has_title(title, options)
+      Capybara::RSpecMatchers::HaveTitle.new(title, options)
+    end
 
-      def match_or_error(matcher)
-        matcher.matches?(Capybara.current_session) || handle_failure(matcher)
-      end
+    def match_or_error(matcher)
+      matcher.matches?(Capybara.current_session) || handle_failure(matcher)
+    end
 
-      def handle_failure(matcher)
-        message = matcher.failure_message
+    def handle_failure(matcher)
+      message = matcher.failure_message
 
-        if matcher.respond_to?(:diffable?) && matcher.diffable?
-          RSpec::Expectations.fail_with message, matcher.expected, matcher.actual
-        else
-          RSpec::Expectations.fail_with message
-        end
+      if matcher.respond_to?(:diffable?) && matcher.diffable?
+        RSpec::Expectations.fail_with message, matcher.expected, matcher.actual
+      else
+        RSpec::Expectations.fail_with message
       end
+    end
   end
 end

data/lib/capybara_error_intel/version.rb

@@ -1,3 +1,3 @@
 module CapybaraErrorIntel
-  VERSION = "1.0.0"
+  VERSION = '1.0.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara_error_intel
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Dorian Karter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-19 00:00:00.000000000 Z
+date: 2016-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -116,44 +116,100 @@ dependencies:
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cadre
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -185,8 +241,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt