capybara 3.8.1 → 3.33.0

data/lib/capybara/spec/session/window/window_spec.rb

@@ -1,89 +1,91 @@
 # frozen_string_literal: true
 
+# Note: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
+  let!(:orig_window) { @session.current_window }
   before do
-    @window = @session.current_window
     @session.visit('/with_windows')
   end
 
   after do
-    (@session.windows - [@window]).each do |w|
+    (@session.windows - [orig_window]).each do |w|
       @session.switch_to_window w
       w.close
     end
-    @session.switch_to_window(@window)
+    @session.switch_to_window(orig_window)
   end
 
   describe '#exists?' do
-    before do
-      @other_window = @session.window_opened_by do
+    it 'should become false after window was closed' do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-    end
 
-    it 'should become false after window was closed' do
       expect do
-        @session.switch_to_window @other_window
-        @other_window.close
-      end.to change { @other_window.exists? }.from(true).to(false)
+        @session.switch_to_window other_window
+        other_window.close
+      end.to change(other_window, :exists?).from(true).to(false)
     end
   end
 
   describe '#closed?' do
     it 'should become true after window was closed' do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
       expect do
-        @session.switch_to_window @other_window
-        @other_window.close
-      end.to change { @other_window.closed? }.from(false).to(true)
+        @session.switch_to_window other_window
+        other_window.close
+      end.to change { other_window.closed? }.from(false).to(true)
     end
   end
 
   describe '#current?' do
-    before do
-      @other_window = @session.window_opened_by do
+    let(:other_window) do
+      @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
     end
 
     it 'should become true after switching to window' do
       expect do
-        @session.switch_to_window(@other_window)
-      end.to change { @other_window.current? }.from(false).to(true)
+        @session.switch_to_window(other_window)
+      end.to change(other_window, :current?).from(false).to(true)
     end
 
     it 'should return false if window is closed' do
-      @session.switch_to_window(@other_window)
-      @other_window.close
-      expect(@other_window.current?).to eq(false)
+      @session.switch_to_window(other_window)
+      other_window.close
+      expect(other_window.current?).to eq(false)
     end
   end
 
   describe '#close' do
-    before do
-      @other_window = @session.window_opened_by do
+    let!(:other_window) do
+      @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
     end
 
     it 'should switch to original window if invoked not for current window' do
       expect(@session.windows.size).to eq(2)
-      expect(@session.current_window).to eq(@window)
-      @other_window.close
+      expect(@session.current_window).to eq(orig_window)
+      other_window.close
       expect(@session.windows.size).to eq(1)
-      expect(@session.current_window).to eq(@window)
+      expect(@session.current_window).to eq(orig_window)
     end
 
     it 'should make subsequent invocations of other methods raise no_such_window_error if invoked for current window' do
-      @session.switch_to_window(@other_window)
-      expect(@session.current_window).to eq(@other_window)
-      @other_window.close
+      @session.switch_to_window(other_window)
+      expect(@session.current_window).to eq(other_window)
+      other_window.close
       expect do
         @session.find(:css, '#some_id')
       end.to raise_error(@session.driver.no_such_window_error)
-      @session.switch_to_window(@window)
+      @session.switch_to_window(orig_window)
     end
   end
 
@@ -97,55 +99,54 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     end
 
     it 'should switch to original window if invoked not for current window' do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
       sleep 1
-      size = @session.within_window(@other_window) do
+      size = @session.within_window(other_window) do
         win_size
       end
-      expect(@other_window.size).to eq(size)
-      expect(@session.current_window).to eq(@window)
+      expect(other_window.size).to eq(size)
+      expect(@session.current_window).to eq(orig_window)
     end
   end
 
   describe '#resize_to' do
-    before do
-      @initial_size = @session.current_window.size
-    end
+    let!(:initial_size) { @session.current_window.size }
 
     after do
-      @session.current_window.resize_to(*@initial_size)
-      sleep 0.5
+      @session.current_window.resize_to(*initial_size)
+      sleep 1
     end
 
     it 'should be able to resize window', requires: %i[windows js] do
-      width, height = @initial_size
+      width, height = initial_size
       @session.current_window.resize_to(width - 100, height - 100)
       sleep 1
       expect(@session.current_window.size).to eq([width - 100, height - 100])
     end
 
     it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      @other_window.resize_to(600, 300)
-      expect(@session.current_window).to eq(@window)
 
-      @session.within_window(@other_window) do
-        expect(@session.current_window.size).to eq([600, 300])
+      other_window.resize_to(600, 400)
+      expect(@session.current_window).to eq(orig_window)
+
+      @session.within_window(other_window) do
+        expect(@session.current_window.size).to eq([600, 400])
       end
     end
   end
 
   describe '#maximize' do
-    before do
-      @initial_size = @session.current_window.size
+    let! :initial_size do
+      @session.current_window.size
     end
 
     after do
-      @session.current_window.resize_to(*@initial_size)
+      @session.current_window.resize_to(*initial_size)
       sleep 0.5
     end
 
@@ -165,32 +166,32 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     end
 
     it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      @other_window.resize_to(400, 300)
+      other_window.resize_to(400, 300)
       sleep 0.5
-      @other_window.maximize
+      other_window.maximize
       sleep 0.5 # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
 
-      expect(@session.current_window).to eq(@window)
+      expect(@session.current_window).to eq(orig_window)
       # Maximizing the browser affects all tabs so this may not be valid in real browsers
-      # expect(@session.current_window.size).to eq(@initial_size)
+      # expect(@session.current_window.size).to eq(initial_size)
 
-      ow_width, ow_height = @other_window.size
+      ow_width, ow_height = other_window.size
       expect(ow_width).to be > 400
       expect(ow_height).to be > 300
     end
   end
 
   describe '#fullscreen' do
-    before do
-      @initial_size = @session.current_window.size
+    let! :initial_size do
+      @session.current_window.size
     end
 
     after do
-      @session.current_window.resize_to(*@initial_size)
-      sleep 0.5
+      @session.current_window.resize_to(*initial_size)
+      sleep 1
     end
 
     it 'should be able to fullscreen the window' do

data/lib/capybara/spec/session/window/windows_spec.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
+# Note: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#windows', requires: [:windows] do
   before do
     @window = @session.current_window

data/lib/capybara/spec/session/within_spec.rb

@@ -26,6 +26,29 @@ Capybara::SpecHelper.spec '#within' do
       end
       expect(@session).to have_content('Bar')
     end
+
+    it 'should reload the node if the page is changed' do
+      @session.within(:css, '#for_foo') do
+        @session.visit('/with_scope_other')
+        expect(@session).to have_content('Different text')
+      end
+    end
+
+    it 'should reload multiple nodes if the page is changed' do
+      @session.within(:css, '#for_bar') do
+        @session.within(:css, 'form[action="/redirect"]') do
+          @session.refresh
+          expect(@session).to have_content('First Name')
+        end
+      end
+    end
+
+    it 'should error if the page is changed and a matching node no longer exists' do
+      @session.within(:css, '#for_foo') do
+        @session.visit('/')
+        expect { @session.text }.to raise_error(StandardError)
+      end
+    end
   end
 
   context 'with XPath selector' do

data/lib/capybara/spec/spec_helper.rb

@@ -16,8 +16,7 @@ module Capybara
         config.filter_run_excluding requires: method(:filter).to_proc
         config.before { Capybara::SpecHelper.reset! }
         config.after { Capybara::SpecHelper.reset! }
-        # Test in 3.5+ where metadata doesn't autotrigger shared context inclusion - will be only behavior in RSpec 4
-        config.shared_context_metadata_behavior = :apply_to_host_groups if config.respond_to?(:shared_context_metadata_behavior=)
+        config.shared_context_metadata_behavior = :apply_to_host_groups
       end
 
       def reset!
@@ -31,11 +30,14 @@ module Capybara
         Capybara.visible_text_only = false
         Capybara.match = :smart
         Capybara.enable_aria_label = false
+        Capybara.enable_aria_role = false
         Capybara.default_set_options = {}
         Capybara.disable_animation = false
         Capybara.test_id = nil
         Capybara.predicates_wait = true
         Capybara.default_normalize_ws = false
+        Capybara.allow_gumbo = true
+        Capybara.w3c_click_offset = false
         reset_threadsafe
       end
 
@@ -59,7 +61,7 @@ module Capybara
         RSpec.describe Capybara::Session, name, options do # rubocop:disable RSpec/EmptyExampleGroup
           include Capybara::SpecHelper
           include Capybara::RSpecMatchers
-          # rubocop:disable RSpec/ScatteredSetup
+
           before do |example|
             @session = session
             instance_exec(example, &filter_block) if filter_block
@@ -80,7 +82,6 @@ module Capybara
           before :each, :exact_false do
             Capybara.exact = false
           end
-          # rubocop:enable RSpec/ScatteredSetup
 
           specs.each do |spec_name, spec_options, block|
             describe spec_name, *spec_options do # rubocop:disable RSpec/EmptyExampleGroup
@@ -100,7 +101,7 @@ module Capybara
 
     def silence_stream(stream)
       old_stream = stream.dup
-      stream.reopen(RbConfig::CONFIG['host_os'] =~ /rmswin|mingw/ ? 'NUL:' : '/dev/null')
+      stream.reopen(RbConfig::CONFIG['host_os'].match?(/rmswin|mingw/) ? 'NUL:' : '/dev/null')
       stream.sync = true
       yield
     ensure
@@ -117,7 +118,16 @@ module Capybara
 
     def extract_results(session)
       expect(session).to have_xpath("//pre[@id='results']")
-      YAML.load Nokogiri::HTML(session.body).xpath("//pre[@id='results']").first.inner_html.lstrip
+      # YAML.load Nokogiri::HTML(session.body).xpath("//pre[@id='results']").first.inner_html.lstrip
+      YAML.load Capybara::HTML(session.body).xpath("//pre[@id='results']").first.inner_html.lstrip
+    end
+
+    def be_an_invalid_element_error(session)
+      satisfy { |error| session.driver.invalid_element_errors.any? { |e| error.is_a? e } }
+    end
+
+    def with_os_path_separators(path)
+      Gem.win_platform? ? path.to_s.tr('/', '\\') : path.to_s
     end
   end
 end

data/lib/capybara/spec/test_app.rb

@@ -6,8 +6,8 @@ require 'rack'
 require 'yaml'
 
 class TestApp < Sinatra::Base
-  class TestAppError < StandardError; end
-  class TestAppOtherError < StandardError
+  class TestAppError < Exception; end # rubocop:disable Lint/InheritException
+  class TestAppOtherError < Exception # rubocop:disable Lint/InheritException
     def initialize(string1, msg)
       @something = string1
       @message = msg
@@ -18,7 +18,6 @@ class TestApp < Sinatra::Base
   set :raise_errors, true
   set :show_exceptions, false
 
-  @@form_post_count = 0
   # Also check lib/capybara/spec/views/*.erb for pages not listed here
 
   get '/' do
@@ -176,8 +175,8 @@ class TestApp < Sinatra::Base
   end
 
   post '/form' do
-    @@form_post_count += 1
-    '<pre id="results">' + params[:form].merge('post_count' => @@form_post_count).to_yaml + '</pre>'
+    self.class.form_post_count += 1
+    '<pre id="results">' + params[:form].merge('post_count' => self.class.form_post_count).to_yaml + '</pre>'
   end
 
   post '/upload_empty' do
@@ -189,29 +188,35 @@ class TestApp < Sinatra::Base
   end
 
   post '/upload' do
-    begin
-      buffer = []
-      buffer << "Content-type: #{params.dig(:form, :document, :type)}"
-      buffer << "File content: #{params.dig(:form, :document, :tempfile).read}"
-      buffer.join(' | ')
-    rescue StandardError
-      'No file uploaded'
-    end
+    buffer = []
+    buffer << "Content-type: #{params.dig(:form, :document, :type)}"
+    buffer << "File content: #{params.dig(:form, :document, :tempfile).read}"
+    buffer.join(' | ')
+  rescue StandardError
+    'No file uploaded'
   end
 
   post '/upload_multiple' do
-    begin
-      docs = params.dig(:form, :multiple_documents)
-      buffer = [docs.size.to_s]
-      docs.each do |doc|
-        buffer << "Content-type: #{doc[:type]}"
-        buffer << "File content: #{doc[:tempfile].read}"
-      end
-      buffer.join(' | ')
-    rescue StandardError
-      'No files uploaded'
+    docs = params.dig(:form, :multiple_documents)
+    buffer = [docs.size.to_s]
+    docs.each do |doc|
+      buffer << "Content-type: #{doc[:type]}"
+      buffer << "File content: #{doc[:tempfile].read}"
     end
+    buffer.join(' | ')
+  rescue StandardError
+    'No files uploaded'
+  end
+
+  get '/apple-touch-icon-precomposed.png' do
+    halt(404)
   end
+
+  class << self
+    attr_accessor :form_post_count
+  end
+
+  @form_post_count = 0
 end
 
 Rack::Handler::Puma.run TestApp, Port: 8070 if $PROGRAM_NAME == __FILE__

data/lib/capybara/spec/views/animated.erb

@@ -0,0 +1,49 @@
+<html>
+  <head>
+    <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
+    <title>with_animation</title>
+    <script src="/jquery.js" type="text/javascript" charset="utf-8"></script>
+    <script>
+      $(document).on('contextmenu', function(e){ e.preventDefault(); });
+    </script>
+    <style>
+      div {
+        width: 400px;
+        height: 400px;
+        position: absolute;
+      }
+      #obscured {
+        z-index: 1;
+        background-color: red;
+      }
+      #cover {
+        z-index: 2;
+        background-color: blue;
+      }
+      #offscreen {
+        top: 2000px;
+        left: 2000px;
+        background-color: green;
+      }
+      #offscreen_wrapper {
+        top: 2000px;
+        left: 2000px;
+        overflow-x: scroll;
+        background-color: yellow;
+      }
+    </style>
+  </head>
+
+  <body id="with_animation">
+    <div id="obscured">
+      <input id="obscured_input"/>
+    </div>
+    <div id="cover"></div>
+    <div id="offscreen_wrapper">
+      <div id="offscreen"></div>
+    </div>
+  </body>
+
+  <iframe id="frameOne" src="/frame_one"></iframe>
+</html>
+

data/lib/capybara/spec/views/form.erb

@@ -1,7 +1,7 @@
 
 <h1>Form</h1>
 
-<form action="/form" method="post">
+<form action="/form" method="post" novalidate>
 
   <p>
     <label for="form_title">Title</label>
@@ -11,7 +11,7 @@
       <option>Miss</option>
       <option disabled="disabled">Other</option>
     </select>
-    </p>
+  </p>
 
   <p>
     <label for="customer_name">Customer Name
@@ -25,6 +25,12 @@
     </label>
   </p>
 
+  <p>
+    <label for="customer_other_email">Customer Other Email
+      <input type="text" name="form[customer_other_email]" value="notben@notben.com" id="customer_other_email"/>
+    </label>
+  </p>
+
   <p>
     <label for="form_other_title">Other title</label>
     <select name="form[other_title]" id="form_other_title">
@@ -56,6 +62,11 @@
     <input type="text" name="form[name]" value="John Smith" id="form_name"/>
   </p>
 
+  <p>
+    <label for="form_age">Age</label>
+    <input type="range" name="form[age]" value="18" min="13" max="100" step="0.5" id="form_age"/>
+  </p>
+
   <p>
     <label for="form_schmooo">Schmooo</label>
     <input type="schmooo" name="form[schmooo]" value="This is Schmooo!" id="form_schmooo"/>
@@ -88,6 +99,11 @@
     <input type="file" name="form[image]" id="form_image"/>
   </p>
 
+  <p>
+    <label for="form_hidden_image">Hidden Image</label>
+    <input type="file" name="form[hidden_image]" id="form_hidden_image" style="display: none"/>
+  </p>
+
   <p>
     <input type="hidden" name="form[token]" value="12345" id="form_token"/>
   </p>
@@ -97,7 +113,7 @@
     <select name="form[locale]" id="form_locale">
       <option value="sv">Swedish</option>
       <option selected="selected" value="en">English</option>
-      <option value="fi">Finish</option>
+      <option value="fi">Finnish</option>
       <option value="no">Norwegian</option>
       <option value="jo">John's made-up language</option>
       <option value="jbo"> Lojban </option>
@@ -124,7 +140,11 @@
 
   <p>
     <label for="form_zipcode">Zipcode</label>
-    <input type="text" maxlength="5" name="form[zipcode]" id="form_zipcode" />
+    <input type="text" maxlength="5" name="form[zipcode]" id="form_zipcode" pattern="[0-9]{5,9}" />
+  </p>
+
+  <p>
+    <input maxlength="35" id="long_length" />
   </p>
 
   <p>
@@ -428,7 +448,7 @@ New line after and before textarea tag
   </p>
 
   <p>
-    <input type="button" name="form[fresh]" id="fresh_btn" value="i am fresh"/>
+    <input type="button" aria-label="Aria button" name="form[fresh]" id="fresh_btn" value="i am fresh"/>
     <input type="submit" name="form[awesome]" id="awe123" title="What an Awesome Button" value="awesome"/>
     <input type="submit" name="form[crappy]" id="crap321" value="crappy"/>
     <input type="image" name="form[okay]" id="okay556" title="Okay 556 Image" value="okay" alt="oh hai thar"/>
@@ -437,6 +457,7 @@ New line after and before textarea tag
     <button id="no_type">No Type!</button>
     <button><img alt="A horse eating hay"/></button>
     <input type="button" disabled="disabled" value="Disabled button"/>
+    <span role="button">ARIA button</span>
   </p>
 
   <p>
@@ -449,6 +470,11 @@ New line after and before textarea tag
     <input id="readonly" name="form[readonly_test]" readonly/>
     <input id="not_readonly" name="form[readonly_test]" />
   </p>
+
+  <p>
+    <input id="required" name="form[required]" required />
+    <input id="length" name="form[length]" minlength="4" maxlength="4" />
+  </p>
 </form>
 
 <input type="text" name="form[outside_input]" value="outside_input" form="form1"/>
@@ -458,12 +484,19 @@ New line after and before textarea tag
   <input type="text" name="nested_label" id="nested_label"/>
 </label>
 
+<label id="wrapper_label">
+  Wrapper Label
+  <input type="checkbox"/>
+</label>
+
 <form id="form1" action="/form" method="post">
   <input type="text" name="form[which_form]" value="form1" id="form_which_form"/>
   <input type="text" name="form[for_form2]" value="for_form2" form="form2"/>
   <input type="submit" name="form[submit_form1]" value="submit_form1" id="submit_form1"/>
 </form>
 
+<button type="submit" name="form[outside_button]" value="outside_button" form="form2">Outside!</button>
+
 <form id="form2" action="/form" method="post">
   <input type="text" name="form[which_form]" value="form2" id="form_which_form2"/>
   <input type="submit" name="form[unused]" value="unused"/>
@@ -480,8 +513,6 @@ New line after and before textarea tag
 </select>
 
 <input type="submit" name="form[outside_submit]" value="outside_submit" form="form1"/>
-<button type="submit" name="form[outside_button]" value="outside_button" form="form2">Outside!</button>
-
 
 <form id="get-form" action="/form/get?foo=bar" method="get">
   <p>
@@ -491,6 +522,7 @@ New line after and before textarea tag
 
   <p>
     <input type="submit" name="form[mediocre]" id="mediocre" value="med" aria-label="Mediocre Button"/>
+    <input type="submit" formaction="/form/get?bar=foo" id="mediocre2" value="med2"/>
   <p>
 </form>
 
@@ -547,6 +579,11 @@ New line after and before textarea tag
     <input type="file" name="form[multiple_documents][]" id="form_multiple_documents" multiple="multiple" />
   </p>
 
+  <p>
+    <label for="form_directory_upload">Directory Upload</label>
+    <input type="file" name="form[multiple_documents][]" id="form_directory_upload" multiple="multiple" webkitdirectory="webkitdirectory" mozdirectory="mozdirectory" />
+  </p>
+
   <p>
     <input type="submit" value="Upload Multiple"/>
   <p>
@@ -643,3 +680,7 @@ New line after and before textarea tag
   <label for="asterisk_input">With Asterisk<abbr title="required">*</abbr></label>
   <input id="asterisk_input" type="number"value="2016"/>
 </p>
+
+<p>
+  <input id="special" {custom}="abcdef" value="custom attribute"/>
+</p>

data/lib/capybara/spec/views/frame_child.erb

@@ -4,13 +4,14 @@
         <title>This is the child frame title</title>
         <script>
         function closeWin() {
-          var iframe = window.parent.document.getElementById('childFrame')
+          var iframe = window.parent.document.getElementById('childFrame');
           iframe.parentNode.removeChild(iframe)
         }
         </script>
     </head>
     <body id="childBody">
-      <a href="javascript:void(0)" onClick="closeWin()">Close Window</a>
+      <a href="javascript:void(0)" onClick="closeWin()">Close Window Now</a>
+      <a href="javascript:void(0)" onClick="setTimeout(function(){closeWin()}, 10)">Close Window Soon</a>
       <iframe src="/frame_one" id="grandchildFrame1"></iframe>
       <iframe src="/frame_two" id="grandchildFrame2"></iframe>
     </body>

data/lib/capybara/spec/views/frame_one.erb

@@ -5,5 +5,6 @@
     </head>
     <body>
         <div id="divInFrameOne">This is the text of divInFrameOne</div>
+        <div id="otherDivInFrameOne">Some other text</div>
     </body>
 </html>